Skip to content

ASoC: Add TI TAC5XX2 SoundWire codec driver support

Niranjan H Y linux-sound lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v16 Latest4 patches 3 repliesIn review
  2. v154 patches 6 repliesSuperseded
  3. v144 patches 2 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v131 of 4 patches2 repliesSuperseded
v124 patches2 repliesSuperseded
v114 patches7 repliesSuperseded
v94 patches8 repliesSuperseded

Changes in v16 from the cover letter

- use EXPORT_SYMBOL_NS instead of EXPORT_SYMBOL_GPL for asoc_sdw_ti_tac5xx2_spk_rtd_init (patch 3/4)
- remove unwanted dynamic memory allocation for local variable. (patch 3/4)
- reorder to read the uaj status after the regcache sync is done in the resume callback. (patch 2/4)
- rebase and use updated sdca_parse_function (patch 2/4)

Patches in v16 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: SDCA: Add PDE verification reusable helperinclude/sound/sdca_asoc.h sound/soc/sdca/sdca_asoc.c+82 -300 replies
2/4ASoC: tac5xx2-sdw: add soundwire based codec driversound/soc/codecs/Kconfig sound/soc/codecs/Makefile sound/soc/codecs/tac5xx2-sdw.c +1 more+2319 -01 reply
3/4ASoC: sdw_utils: TI amp utility for tac5xx2 familyinclude/sound/soc_sdw_utils.h sound/soc/sdw_utils/soc_sdw_ti_amp.c sound/soc/sdw_utils/soc_sdw_utils.c+294 -10 replies
4/4ASoC: tac5xx2-sdw: ACPI match for intel mtl platformsound/soc/intel/common/soc-acpi-intel-mtl-match.c+132 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchCharles KeepaxPierre-Louis BossartBard Liao
1/4R-b R-b
2/4R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v16 thread

Cover letter [PATCH v16 0/4] ASoC: Add TI TAC5XX2 SoundWire codec driver support

This patch series adds support for Texas Instruments TAC5XX2 family of SoundWire smart amplifiers, including TAC5572, TAC5672, TAC5682, and TAS2883 devices.

The series includes:
- SDCA power state management helper for PDE verification
- New codec driver for TAC5XX2 family with SmartAmp, SmartMic, UAJ, and HID support
- Machine driver integration for Intel SoundWire platforms
- ACPI match entries for Intel MTL platform

Changes in V16:
- use EXPORT_SYMBOL_NS instead of EXPORT_SYMBOL_GPL for asoc_sdw_ti_tac5xx2_spk_rtd_init (patch 3/4)
- remove unwanted dynamic memory allocation for local variable. (patch 3/4)
- reorder to read the uaj status after the regcache sync is done in the resume callback. (patch 2/4)
- rebase and use updated sdca_parse_function (patch 2/4)

Changes in v15: (Patch 2/4)
- call pm_runtime_resume instead of waiting for device to get initialised similar to other drivers
- skip reading the uaj and hid registers in the interrupt handler if the uaj is not supported
- remove had_unattached in the dev_resume callback
- detect headset in the dev_resume callback only if the uaj is supported
- indentation fixes to use reverse-xmas tree

Changes in v14:
- Resending complete series (v13 1/4 was accidentally sent alone)
- rename the first_hw_init to first_hw_init_done for readability.
- Removed dummy tac5xx2_sdw_clk_stop function (Patch 2/4)
- Added pm_runtime calls in .set_jack callback (Patch 2/4)
- Improved error handling for early .set_jack calls (Patch 2/4)
- drop uaj_lock to make it simiar to other drivers (Patch 2/4)
- move the pm_runtime_enable to probe and keep only pm_runtime_set_active for first attach case. (Patch 2/4)
- remove tac5xx2_sdw_clk_stop as currently it is dummy (Patch 2/4)
- Used xmas tree style in .hw_free (Patch 2/4)

Changes in v13:
- no code changes (v13 1/4 was sent alone accidentally)

Changes in v12:
- Used correct namespace while exporting variables (Patch 1/4)
- Fixed missing entity information in logging (Patch 1/4)
- Removed hw_init check in .set_jack (Patch 2/4)
- Added missing pm_runtime_disable in .remove callback (Patch 2/4)
- Improved error logging in .hw_params and .hw_free (Patch 2/4)
- Included part_id in firmware binary name (Patch 2/4)
- Updated firmware header parsing (Patch 2/4)

Niranjan H Y (4):
ASoC: SDCA: Add PDE verification reusable helper
ASoC: tac5xx2-sdw: add soundwire based codec driver
ASoC: sdw_utils: TI amp utility for tac5xx2 family
ASoC: tac5xx2-sdw: ACPI match for intel mtl platform

 include/sound/sdca_asoc.h                     |    6 +
 include/sound/soc_sdw_utils.h                 |    4 +
 sound/soc/codecs/Kconfig                      |   11 +
 sound/soc/codecs/Makefile                     |    2 +
 sound/soc/codecs/tac5xx2-sdw.c                | 2047 +++++++++++++++++
 sound/soc/codecs/tac5xx2.h                    |  259 +++
 .../intel/common/soc-acpi-intel-mtl-match.c   |  132 ++
 sound/soc/sdca/sdca_asoc.c                    |  106 +-
 sound/soc/sdw_utils/soc_sdw_ti_amp.c          |  140 +-
 sound/soc/sdw_utils/soc_sdw_utils.c           |  151 ++
 10 files changed, 2827 insertions(+), 31 deletions(-)
 create mode 100644 sound/soc/codecs/tac5xx2-sdw.c
 create mode 100644 sound/soc/codecs/tac5xx2.h
Signature · 1 line
2.34.1