Skip to content

pcal6524 extensions and fixes for pca953x driver

H. Nikolaus Schaller linux-devicetree linux-gpio lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 9 repliesIn review
  2. v63 patches 3 repliesSuperseded
  3. v57 patches 19 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v47 patches1 replySuperseded
v34 patches9 repliesSuperseded
v25 patches10 repliesSuperseded

Changes in v7 from the cover letter

* replace PCAL register masks by hex constants

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gpio: pca953x: set the PCA_PCAL flag also when matching by DTdrivers/gpio/gpio-pca953x.c+3 -21 reply
2/3gpio: pca953x: define masks for addressing common and extended registersdrivers/gpio/gpio-pca953x.c+4 -01 reply
3/3gpio: pca953x: fix address calculation for pcal6524drivers/gpio/gpio-pca953x.c+6 -26 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy Shevchenko
SeriesR-b
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] pcal6524 extensions and fixes for pca953x driver

V7:
* replace PCAL register masks by hex constants

2018-05-16 19:01:29: V6:

* added proper attribution to the formula used for fixing the pcal6524 register address (changes commit message only)
* add back missing first patch from V2 that defines the PCA_LATCH_INT constant
* removed patches already merged

2018-04-28 18:33:42: V5:

* fix wrong split up between patches 1/7 and 2/7.

2018-04-26 19:35:07: V4:

* introduced PCA_LATCH_INT constant to make of_table more readable (suggested by Andy Shevchenko)
* converted all register constants to hex in a separate patch (suggested by Andy Shevchenko)
* separated additional pcal953x and pcal6524 register definitions into separate patches (suggested by Andy Shevchenko)
* made special pcal6524 address adjustment more readable (suggested by Andy Shevchenko)
* moved gpio-controller and interrupt-controller to the "required" section (reviewed by Rob Herring)

2018-04-10 18:07:07: V3:

* add Reported-by: and Reviewed-by:
* fix wording for bindings description and example
* convert all register offsets to hex
* omit the LEVEL-IRQ RFC/hack commit

2018-04-04 21:00:27: V2:

* added PCA_PCAL flags if matched through of-table
* fix address calculation for extended PCAL6524 registers
* hack to map LEVEL_LOW to EDGE_FALLING to be able to test in combination with ts3a227e driver
* improve description of bindings for optional vcc-supply and interrupt-controller;

2018-03-10 09:32:53: no initial description

H. Nikolaus Schaller (3):
gpio: pca953x: set the PCA_PCAL flag also when matching by DT
gpio: pca953x: define masks for addressing common and extended
registers
gpio: pca953x: fix address calculation for pcal6524

 drivers/gpio/gpio-pca953x.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
Signature · 1 line
2.12.2