Skip to content

MIPS: JZ4780 and CI20 HDMI

H. Nikolaus Schaller dri-devel linux-mips lkml 17 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v18 Latest3 patches 5 repliesIn review
  2. v176 patches 6 repliesSuperseded
  3. v164 patches 30 repliesSuperseded
Earlier versions · 14
VersionPostedPatchesRepliesStatus
v157 patches12 repliesSuperseded
v149 patches7 repliesSuperseded
v138 of 9 patches9 repliesApplied
v128 of 9 patches17 repliesSuperseded
v118 patches5 repliesApplied
v108 patches9 repliesSuperseded
v98 patches3 repliesSuperseded
v88 patches20 repliesSuperseded
v78 patches2 repliesSuperseded
v68 patches5 repliesSuperseded
v57 patches33 repliesSuperseded
v410 patches21 repliesSuperseded
v39 patches1 replySuperseded
v28 patches11 repliesSuperseded

Patches in v18 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/bridge: display-connector: add ddc-en gpio supportdrivers/gpu/drm/bridge/display-connector.c+15 -01 reply
2/3drm/ingenic: Implement proper .atomic_get_input_bus_fmtsdrivers/gpu/drm/ingenic/ingenic-drm-drv.c+27 -11 reply
3/3drm/ingenic: Add dw-hdmi driver specialization for jz4780drivers/gpu/drm/ingenic/Kconfig drivers/gpu/drm/ingenic/Makefile drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c+113 -02 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartNeil Armstrong
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v18 thread

Cover letter [PATCH v18 0/3] MIPS: JZ4780 and CI20 HDMI

PATCH V18 2022-04-07 13:16:10:
* removed CSC filter patches (3-5/6) by Neil Armstrong <[email protected]> as they no longer seem to be required
* added "Reviewed-by: Laurent Pinchart <[email protected]>" to ddc-en patch (6/6)

PATCH V17 2022-04-06 18:26:08:
* removed our local attempts to enable HPD because "drm/bridge_connector: enable HPD by default if supported"
became available and solves the issue globally (by [email protected])
* add new mechanism to disable Color Space Conversion (by [email protected])
* rebased to v5.18-rc1 based drm-misc/drm-misc-next

PATCH V16 2022-02-26 18:13:02:
* fixed and renamed dw-hdmi bus negotiation patch (by [email protected])
* reordered and merged HPD fix (suggested by [email protected])
* fixed MODULE_ALIAS for dw-hdmi-ingenic (reported by [email protected])
* dropped some already merged commits from the series

PATCH V15 2022-02-12 16:50:54:
* remove already (elsewhere) merged commits (suggested by [email protected])
* clarify commit message for (now) 1/7 ((suggested by [email protected]))

PATCH V14 2022-02-12 15:19:25:
* make compatible to c03d0b52ff71d5 ("drm/connector: Fix typo in output format")
* move "dw-hdmi/ingenic-dw-hdmi: repair interworking with hdmi-connector" before drm/ingenic: Add dw-hdmi driver specialization for jz4780 (by [email protected])
* split introduction of dw_hdmi_enable_poll() into separate patch
* explicitly mark plane f0 as not working in jz4780 (suggested by [email protected])
* drop 1/9 since it is now in drm-misc/drm-misc-next

PATCH V13 2022-02-02 17:31:22:
* 7/9: remove call to gpiod_set_value() because of GPIOD_OUT_HIGH (by [email protected])
* 4/9: replace ".." by "." (by [email protected])
* 3/9: remove old hdmi-5v-power in the example (by [email protected])
* 2/9: disable handling of plane f0 only for jz4780 (by [email protected])

PATCH V12 2022-01-31 13:26:54:
This version reworks how hdmi ddc power is controlled by connector and not by ddc/hdmi bridge driver.

Also some patches of the previous version of this series have been removed since they are already applied to mips-next/linux/next/v5.17-rc1.

Fixes and changes:

- repair interworking of dw-hdmi with connector-hdmi (by [email protected])
- fix JZ_REG_LCD_OSDC setup for jz4780 (by [email protected] and [email protected])
- adjustments for ci20.dts to use connector gpio for +5v (suggested by several)
- to add control of "ddc-en-gpios" to hdmi-connector driver (by [email protected])
- regulator code removed because we now use the "ddc-en-gpios" of the connector driver (suggested by [email protected])
- bindings: addition of "ddc-i2c-bus" and "hdmi-5v-supply" removed (suggested by [email protected])
- rebase on v5.17-rc2

PATCH V11 2021-12-02 19:39:52:
- patch 4/8: change devm_regulator_get_optional to devm_regulator_get and remove NULL check (requested by [email protected])
- patch 3/8: make hdmi-5v-supply required (requested by [email protected])

PATCH V10 2021-11-30 22:26:41:
- patch 3/8: fix $id and $ref paths (found by [email protected])

PATCH V9 2021-11-24 22:29:14:
- patch 6/8: remove optional <0> for assigned-clocks and unintentionally included "unwedge" setup (found by [email protected])
- patch 4/8: some cosmetics
make regulator enable/disable only if not NULL (found by [email protected])
simplify/fix error handling and driver cleanup on remove (proposed by [email protected])
- patch 3/8: fix #include path in example (found by [email protected])
fix missing "i" in unevaluatedProperties (found by [email protected])
fix 4 spaces indentation for required: property (found by [email protected])

PATCH V8 2021-11-23 19:14:00:
- fix a bad editing result from patch 2/8 (found by [email protected])

PATCH V7 2021-11-23 18:46:23:
- changed gpio polarity of hdmi_power to 0 (suggested by [email protected])
- fixed LCD1 irq number (bug found by [email protected])
- removed "- 4" for calculating max_register (suggested by [email protected])
- use unevaluatedPropertes instead of additionalProperties (suggested by [email protected])
- moved and renamed ingenic,jz4780-hdmi.yaml (suggested by [email protected])
- adjusted assigned-clocks changes to upstream which added some for SSI (by [email protected])
- rebased and tested with v5.16-rc2 + patch set drm/ingenic by [email protected] (by [email protected])

PATCH V6 2021-11-10 20:43:33:
- changed CONFIG_DRM_INGENIC_DW_HDMI to "m" (by [email protected])
- made ingenic-dw-hdmi an independent platform driver which can be compiled as module and removed error patch fixes for IPU (suggested by [email protected])
- moved assigned-clocks from jz4780.dtsi to ci20.dts (suggested by [email protected])
- fixed reg property in jz4780.dtsi to cover all registers incl. gamma and vee (by [email protected])
- added a base patch to calculate regmap size from DTS reg property (requested by [email protected])
- restored resetting all bits except one in LCDOSDC (requested by [email protected])
- clarified setting of cpos (suggested by [email protected])
- moved bindings definition for ddc-i2c-bus (suggested by [email protected])
- simplified mask definitions for JZ_LCD_DESSIZE (requested by [email protected])
- removed setting alpha premultiplication (suggested by [email protected])
- removed some comments (suggested by [email protected])

PATCH V5 2021-10-05 14:28:44:
- dropped mode_fixup and timings support in dw-hdmi as it is no longer needed in this V5 (by [email protected])
- dropped "drm/ingenic: add some jz4780 specific features" (stimulated by [email protected])
- fixed typo in commit subject: "synopsis" -> "synopsys" (by [email protected])
- swapped clocks in jz4780.dtsi to match synopsys,dw-hdmi.yaml (by [email protected])
- improved, simplified, fixed, dtbschecked ingenic-jz4780-hdmi.yaml and made dependent of bridge/synopsys,dw-hdmi.yaml (based on suggestions by [email protected])
- fixed binding vs. driver&DTS use of hdmi-5v regulator (suggested by [email protected])
- dropped "drm/bridge: synopsis: Fix to properly handle HPD" - was a no longer needed workaround for a previous version
(suggested by [email protected])

PATCH V4 2021-09-27 18:44:38:
- fix setting output_port = 1 (issue found by [email protected])
- ci20.dts: convert to use hdmi-connector (by [email protected])
- add a hdmi-regulator to control +5V power (by [email protected])
- added a fix to dw-hdmi to call drm_kms_helper_hotplug_event on plugin event detection (by [email protected])
- always allocate extended descriptor but initialize only for jz4780 (by [email protected])
- updated to work on top of "[PATCH v3 0/6] drm/ingenic: Various improvements v3" (by [email protected])
- rebased to v5.13-rc3

PATCH V3 2021-08-08 07:10:50:
This series adds HDMI support for JZ4780 and CI20 board (and fixes one IPU related issue in registration error path)
- [patch 1/8] switched from mode_fixup to atomic_check (suggested by [email protected])
- the call to the dw-hdmi specialization is still called mode_fixup
- [patch 3/8] diverse fixes for ingenic-drm-drv (suggested by [email protected])
- factor out some non-HDMI features of the jz4780 into a separate patch
- multiple fixes around max height
- do not change regmap config but a copy on stack
- define some constants
- factor out fixing of drm_init error path for IPU into separate patch
- use FIELD_PREP()
- [patch 8/8] conversion to component framework dropped (suggested by [email protected] and [email protected])

PATCH V2 2021-08-05 16:08:05:
- code and commit messages revisited for checkpatch warnings
- rebased on v5.14-rc4
- include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested by Paul Cercueil <[email protected]> a while ago)

This series adds HDMI support for JZ4780 and CI20 board

H. Nikolaus Schaller (1):
drm/bridge: display-connector: add ddc-en gpio support

Paul Boddie (1):
drm/ingenic: Add dw-hdmi driver specialization for jz4780

Paul Cercueil (1):
drm/ingenic: Implement proper .atomic_get_input_bus_fmts

 drivers/gpu/drm/bridge/display-connector.c |  15 +++
 drivers/gpu/drm/ingenic/Kconfig            |   9 ++
 drivers/gpu/drm/ingenic/Makefile           |   1 +
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c  |  28 +++++-
 drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c  | 103 +++++++++++++++++++++
 5 files changed, 155 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c
Signature · 1 line
2.33.0