MIPS: JZ4780 and CI20 HDMI

From: Paul Boddie <[email protected]>

We have to make sure that
- JZ_LCD_OSDC_ALPHAEN is set
- plane f0 is disabled and not seen from user-space

Tested on MIPS Creator CI20 board.

Signed-off-by Paul Boddie <[email protected]>

Signed-off-by Ezequiel Garcia <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

---
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

drivers/gpu/drm/ingenic/ingenic-drm-drv.c +3 -1

index 7f10d6eed549d..dcf44cb00821f 100644
@@ -65,8 +65,10 @@ struct ingenic_dma_hwdescs {
 struct jz_soc_info {
 	bool needs_dev_clk;
 	bool has_osd;
+	bool has_alpha;
 	bool map_noncoherent;
 	bool use_extended_hwdesc;
+	bool plane_f0_not_working;
 	unsigned int max_width, max_height;
 	const u32 *formats_f0, *formats_f1;
 	unsigned int num_formats_f0, num_formats_f1;

@@ -453,7 +455,7 @@ static int ingenic_drm_plane_atomic_check(struct 
 drm_plane *plane,
 	if (!crtc)
 		return 0;
 
-	if (plane == &priv->f0)
+	if (priv->soc_info->plane_f0_not_working && plane == &priv->f0)
 		return -EINVAL;
 

drivers/gpu/drm/ingenic/ingenic-drm-drv.c +1 -0

 	crtc_state = drm_atomic_get_existing_crtc_state(state,

@@ -1055,6 +1057,7 @@ static int ingenic_drm_bind(struct device *dev, 
 bool has_components)
 	long parent_rate;
 	unsigned int i, clone_mask = 0;
 	int ret, irq;
+	u32 osdc = 0;
 
 	soc_info = of_device_get_match_data(dev);

drivers/gpu/drm/ingenic/ingenic-drm-drv.c +4 -1

 	if (!soc_info) {

@@ -1312,7 +1315,10 @@ static int ingenic_drm_bind(struct device 
 *dev, bool has_components)
 
 	/* Enable OSD if available */
 	if (soc_info->has_osd)
-		regmap_write(priv->map, JZ_REG_LCD_OSDC, JZ_LCD_OSDC_OSDEN);
+		osdc |= JZ_LCD_OSDC_OSDEN;
+	if (soc_info->has_alpha)
+		osdc |= JZ_LCD_OSDC_ALPHAEN;
+	regmap_write(priv->map, JZ_REG_LCD_OSDC, osdc);
 
 	mutex_init(&priv->clk_mutex);

drivers/gpu/drm/ingenic/ingenic-drm-drv.c +2 -0

 	priv->clock_nb.notifier_call = ingenic_drm_update_pixclk;

@@ -1511,7 +1517,9 @@ static const struct jz_soc_info jz4770_soc_info 
 = {
 static const struct jz_soc_info jz4780_soc_info = {
 	.needs_dev_clk = true,
 	.has_osd = true,
+	.has_alpha = true,
 	.use_extended_hwdesc = true,
+	.plane_f0_not_working = true,	/* REVISIT */
 	.max_width = 4096,
 	.max_height = 2048,

.formats_f1 = jz4770_formats_f1,
--
2.33.0

Am 14.02.2022 um 11:13 schrieb Paul Cercueil <[email protected]>:

Hi,

Quoted 4 lines · H. Nikolaus Schaller

From: Paul Boddie <[email protected]>
We have to make sure that
- JZ_LCD_OSDC_ALPHAEN is set
- plane f0 is disabled and not seen from user-space

Actually it will still be seen from user-space, but it won't be possible to use it. So before applying I'll change this to:
"plane f0 is disabled as it's not working yet"

If that's OK with you.

Hi Paul,

Quoted 11 lines

Am 14.02.2022 um 11:13 schrieb Paul Cercueil <[email protected]>:

Hi,

Quoted 4 lines · H. Nikolaus Schaller

From: Paul Boddie <[email protected]>
We have to make sure that
- JZ_LCD_OSDC_ALPHAEN is set
- plane f0 is disabled and not seen from user-space

Quoted 5 lines

Actually it will still be seen from user-space, but it won't be
possible to use it. So before applying I'll change this to:
"plane f0 is disabled as it's not working yet"

If that's OK with you.

Yes. You understand much better than me the implications...

Am 14.02.2022 um 13:29 schrieb Paul Cercueil <[email protected]>:

Hi,

Quoted 8 lines · H. Nikolaus Schaller

Hi Paul,

Quoted 7 lines

Am 14.02.2022 um 11:13 schrieb Paul Cercueil <[email protected]>:
Hi,

Quoted 4 lines · H. Nikolaus Schaller

From: Paul Boddie <[email protected]>
We have to make sure that
- JZ_LCD_OSDC_ALPHAEN is set
- plane f0 is disabled and not seen from user-space

Quoted 4 lines

Quoted 3 lines

Actually it will still be seen from user-space, but it won't be possible to use it. So before applying I'll change this to:
"plane f0 is disabled as it's not working yet"
If that's OK with you.

Yes. You understand much better than me the implications...

I reworded it to "plane f0 is disabled as it's not working yet", added a Fixes: tag, and pushed this patch to drm-misc-next.

Hi Paul,

Quoted 20 lines

Am 14.02.2022 um 13:29 schrieb Paul Cercueil <[email protected]>:

Hi,

Quoted 14 lines · H. Nikolaus Schaller

Hi Paul,

Quoted 13 lines

Am 14.02.2022 um 11:13 schrieb Paul Cercueil
<[email protected]>:
Hi,

Quoted 4 lines · H. Nikolaus Schaller

From: Paul Boddie <[email protected]>
We have to make sure that
- JZ_LCD_OSDC_ALPHAEN is set
- plane f0 is disabled and not seen from user-space

Actually it will still be seen from user-space, but it won't be
possible to use it. So before applying I'll change this to:
"plane f0 is disabled as it's not working yet"
If that's OK with you.

Quoted 4 lines

Quoted 1 line

Yes. You understand much better than me the implications...

I reworded it to "plane f0 is disabled as it's not working yet",
added a Fixes: tag, and pushed this patch to drm-misc-next.

great and thanks.
So I drop it from v16.

Am 14.02.2022 um 13:36 schrieb Paul Cercueil <[email protected]>:

Hi,

Quoted 15 lines · H. Nikolaus Schaller

Hi Paul,

Quoted 14 lines

Am 14.02.2022 um 13:29 schrieb Paul Cercueil <[email protected]>:
Hi,

Quoted 11 lines · H. Nikolaus Schaller

Hi Paul,

Quoted 10 lines

Am 14.02.2022 um 11:13 schrieb Paul Cercueil <[email protected]>:
Hi,

Quoted 4 lines · H. Nikolaus Schaller

From: Paul Boddie <[email protected]>
We have to make sure that
- JZ_LCD_OSDC_ALPHAEN is set
- plane f0 is disabled and not seen from user-space

Actually it will still be seen from user-space, but it won't be possible to use it. So before applying I'll change this to:
"plane f0 is disabled as it's not working yet"
If that's OK with you.

Quoted 4 lines

Quoted 2 lines

Quoted 1 line

Yes. You understand much better than me the implications...

I reworded it to "plane f0 is disabled as it's not working yet", added a Fixes: tag, and pushed this patch to drm-misc-next.

great and thanks.
So I drop it from v16.

Neil told me he'd review patch [4/7] this week so maybe hold off v16 for a few days.

From: Paul Boddie <[email protected]>

A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications.

Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code.

Signed-off-by Paul Boddie <[email protected]>

Signed-off-by Ezequiel Garcia <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

---
 drivers/gpu/drm/ingenic/Kconfig           |   9 ++
 drivers/gpu/drm/ingenic/Makefile          |   1 +
 drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 104 
++++++++++++++++++++++
 3 files changed, 114 insertions(+)
 create mode 100644 drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c

drivers/gpu/drm/ingenic/Kconfig +0 -0

index 001f59fb06d56..090830bcbde7f 100644
@@ -24,4 +24,13 @@ config DRM_INGENIC_IPU
 
 	  The Image Processing Unit (IPU) will appear as a second primary 

plane.

drivers/gpu/drm/ingenic/Kconfig +6 -0

+config DRM_INGENIC_DW_HDMI
+	tristate "Ingenic specific support for Synopsys DW HDMI"
+	depends on MACH_JZ4780
+	select DRM_DW_HDMI
+	help
+	  Choose this option to enable Synopsys DesignWare HDMI based 

driver.

drivers/gpu/drm/ingenic/Kconfig +3 -0

+	  If you want to enable HDMI on Ingenic JZ4780 based SoC, you should
+	  select this option.
+
 endif

drivers/gpu/drm/ingenic/Makefile +1 -0

index d313326bdddbb..f10cc1c5a5f22 100644
@@ -1,3 +1,4 @@
 obj-$(CONFIG_DRM_INGENIC) += ingenic-drm.o
 ingenic-drm-y = ingenic-drm-drv.o
 ingenic-drm-$(CONFIG_DRM_INGENIC_IPU) += ingenic-ipu.o
+obj-$(CONFIG_DRM_INGENIC_DW_HDMI) += ingenic-dw-hdmi.o

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +18 -0

new file mode 100644
index 0000000000000..34e986dd606cf
@@ -0,0 +1,104 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2011-2013 Freescale Semiconductor, Inc.
+ * Copyright (C) 2019, 2020 Paul Boddie <[email protected]>
+ *
+ * Derived from dw_hdmi-imx.c with i.MX portions removed.
+ * Probe and remove operations derived from rcar_dw_hdmi.c.
+ */
+
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+
+#include <drm/bridge/dw_hdmi.h>
+#include <drm/drm_of.h>
+#include <drm/drm_print.h>
+
+static const struct dw_hdmi_mpll_config ingenic_mpll_cfg[] = {
+	{ 45250000,  { { 0x01e0, 0x0000 }, { 0x21e1, 0x0000 }, { 0x41e2, 

0x0000 } } },

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +1 -0

+	{ 92500000,  { { 0x0140, 0x0005 }, { 0x2141, 0x0005 }, { 0x4142, 

0x0005 } } },

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +1 -0

+	{ 148500000, { { 0x00a0, 0x000a }, { 0x20a1, 0x000a }, { 0x40a2, 

0x000a } } },

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +1 -0

+	{ 216000000, { { 0x00a0, 0x000a }, { 0x2001, 0x000f }, { 0x4002, 

0x000f } } },

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +1 -0

+	{ ~0UL,      { { 0x0000, 0x0000 }, { 0x0000, 0x0000 }, { 0x0000, 

0x0000 } } }

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +32 -0

+};
+
+static const struct dw_hdmi_curr_ctrl ingenic_cur_ctr[] = {
+	/*pixelclk     bpp8    bpp10   bpp12 */
+	{ 54000000,  { 0x091c, 0x091c, 0x06dc } },
+	{ 58400000,  { 0x091c, 0x06dc, 0x06dc } },
+	{ 72000000,  { 0x06dc, 0x06dc, 0x091c } },
+	{ 74250000,  { 0x06dc, 0x0b5c, 0x091c } },
+	{ 118800000, { 0x091c, 0x091c, 0x06dc } },
+	{ 216000000, { 0x06dc, 0x0b5c, 0x091c } },
+	{ ~0UL,      { 0x0000, 0x0000, 0x0000 } },
+};
+
+/*
+ * Resistance term 133Ohm Cfg
+ * PREEMP config 0.00
+ * TX/CK level 10
+ */
+static const struct dw_hdmi_phy_config ingenic_phy_config[] = {
+	/*pixelclk   symbol   term   vlev */
+	{ 216000000, 0x800d, 0x0005, 0x01ad},
+	{ ~0UL,      0x0000, 0x0000, 0x0000}
+};
+
+static enum drm_mode_status
+ingenic_dw_hdmi_mode_valid(struct dw_hdmi *hdmi, void *data,
+			   const struct drm_display_info *info,
+			   const struct drm_display_mode *mode)
+{
+	if (mode->clock < 13500)
+		return MODE_CLOCK_LOW;
+	/* FIXME: Hardware is capable of 270MHz, but setup data is missing. 

*/

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +36 -0

+	if (mode->clock > 216000)
+		return MODE_CLOCK_HIGH;
+
+	return MODE_OK;
+}
+
+static struct dw_hdmi_plat_data ingenic_dw_hdmi_plat_data = {
+	.mpll_cfg   = ingenic_mpll_cfg,
+	.cur_ctr    = ingenic_cur_ctr,
+	.phy_config = ingenic_phy_config,
+	.mode_valid = ingenic_dw_hdmi_mode_valid,
+	.output_port	= 1,
+};
+
+static const struct of_device_id ingenic_dw_hdmi_dt_ids[] = {
+	{ .compatible = "ingenic,jz4780-dw-hdmi" },
+	{ /* Sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, ingenic_dw_hdmi_dt_ids);
+
+static void ingenic_dw_hdmi_cleanup(void *data)
+{
+	struct dw_hdmi *hdmi = (struct dw_hdmi *)data;
+
+	dw_hdmi_remove(hdmi);
+}
+
+static int ingenic_dw_hdmi_probe(struct platform_device *pdev)
+{
+	struct dw_hdmi *hdmi;
+
+	hdmi = dw_hdmi_probe(pdev, &ingenic_dw_hdmi_plat_data);
+	if (IS_ERR(hdmi))
+		return PTR_ERR(hdmi);
+
+	return devm_add_action_or_reset(&pdev->dev, 

ingenic_dw_hdmi_cleanup, hdmi);

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +4 -0

+}
+
+static struct platform_driver ingenic_dw_hdmi_driver = {
+	.probe  = ingenic_dw_hdmi_probe,

Am 14.02.2022 um 11:24 schrieb Paul Cercueil <[email protected]>:

Hi,

Quoted 10 lines · H. Nikolaus Schaller

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +10 -0

+static void ingenic_dw_hdmi_cleanup(void *data)
+{
+	struct dw_hdmi *hdmi = (struct dw_hdmi *)data;
+
+	dw_hdmi_remove(hdmi);
+}
+
+static int ingenic_dw_hdmi_probe(struct platform_device *pdev)
+{
+	struct dw_hdmi *hdmi;

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c line 90

Quoted 6 lines

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +6 -0

+
+	hdmi = dw_hdmi_probe(pdev, &ingenic_dw_hdmi_plat_data);
+	if (IS_ERR(hdmi))
+		return PTR_ERR(hdmi);
+
+	return devm_add_action_or_reset(&pdev->dev, ingenic_dw_hdmi_cleanup, hdmi);

I think I said it already, but in this driver you could use a .remove callback, there's not much point in using devm cleanups in such a simple setup.

In your probe you could just:
return PTR_ERR_OR_ZERO(hdmi);

Quoted 5 lines

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +4 -0

+}
+
+static struct platform_driver ingenic_dw_hdmi_driver = {
+	.probe  = ingenic_dw_hdmi_probe,

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c line 104

Quoted 10 lines

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c new file +10 -0

+	.driver = {
+		.name = "dw-hdmi-ingenic",
+		.of_match_table = ingenic_dw_hdmi_dt_ids,
+	},
+};
+module_platform_driver(ingenic_dw_hdmi_driver);
+
+MODULE_DESCRIPTION("JZ4780 Specific DW-HDMI Driver Extension");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:dwhdmi-ingenic");

Should probably be "platform:dw-hdmi-ingenic"?

Hi Paul,

Quoted 25 lines

Am 14.02.2022 um 11:24 schrieb Paul Cercueil <[email protected]>:

Hi,

Quoted 17 lines · H. Nikolaus Schaller

+static void ingenic_dw_hdmi_cleanup(void *data)
+{
+ struct dw_hdmi *hdmi = (struct dw_hdmi *)data;
+
+ dw_hdmi_remove(hdmi);
+}
+
+static int ingenic_dw_hdmi_probe(struct platform_device *pdev) +{
+ struct dw_hdmi *hdmi;
+
+ hdmi = dw_hdmi_probe(pdev, &ingenic_dw_hdmi_plat_data);
+ if (IS_ERR(hdmi))
+ return PTR_ERR(hdmi);
+
+ return devm_add_action_or_reset(&pdev->dev,
ingenic_dw_hdmi_cleanup, hdmi);

Quoted 2 lines

I think I said it already, but in this driver you could use a
.remove callback, there's not much point in using devm cleanups in such a simple setup.

Well it was your suggestion after v8:

https://lore.kernel.org/all/[email protected]/

So we now almost go back to RFC v1 almost 2 years ago:

https://patchwork.kernel.org/project/linux-mips/patch/2c131e1fb19e19f958a612f7186bc83f4afb0b0a.1582744379.git.hns@goldelico.com/

Of course there was a good reason to better handle the regulator AND the dw_hdmi_remove() by a single mechanism.

Now the regulator has gone and been replaced by the hdmi connector and we can go back.

Quoted 1 line

Quoted 2 lines

In your probe you could just:
return PTR_ERR_OR_ZERO(hdmi);

No, this does not work since we need to platform_set_drvdata(). to be able to access the private struct in the remove callback. And checking errors after platform_set_drvdata() can be done but looks strange to me.

It is up to you what you prefer.

Quoted 16 lines

Quoted 15 lines

+}
+
+static struct platform_driver ingenic_dw_hdmi_driver = {
+ .probe = ingenic_dw_hdmi_probe,
+ .driver = {
+ .name = "dw-hdmi-ingenic",
+ .of_match_table = ingenic_dw_hdmi_dt_ids,
+ },
+};
+module_platform_driver(ingenic_dw_hdmi_driver);
+
+MODULE_DESCRIPTION("JZ4780 Specific DW-HDMI Driver Extension"); +MODULE_LICENSE("GPL v2"); +MODULE_ALIAS("platform:dwhdmi-ingenic");

Quoted 1 line

Should probably be "platform:dw-hdmi-ingenic"?

Yes, indeed. Thanks for spotting!

Was also good in v1. Probably someone deleted the hyphen unnoticed during editing of "jz4780" to "ingenic"...

Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks")

introduced a new mechanism to negotiate bus formats between hdmi connector and the synopsys hdmi driver inside the jz4780.

By this, the dw-hdmi is no longer the only bridge and sets up a list of formats in dw_hdmi_bridge_atomic_get_output_bus_fmts().

This includes MEDIA_BUS_FMT_UYVY8_1X16 which is chosen for the jz4780 but only produces a black screen.

This fix is based on the observation that max_bpc = 0 when running this function while info->bpc = 8. Since the formats checks before this always test for max_bpc >= info->pbc indirectly my assumption is that we must check it here as well.

Adding the proposed patch makes the CI20/jz4780 panel work again in MEDIA_BUS_FMT_RGB888_1X24 mode.

Fixes 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks")

Signed-off-by H. Nikolaus Schaller <[email protected]>

---
  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +0 -0

index b0d8110dd412c..826a055a7a273 100644
@@ -2620,10 +2620,10 @@ static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge,
  		output_fmts[i++] = MEDIA_BUS_FMT_RGB101010_1X30;
  	}

Am 21.02.2022 um 09:11 schrieb Neil Armstrong <[email protected]>:

Hi,

Quoted 27 lines · H. Nikolaus Schaller

Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connector and the synopsys hdmi driver inside the jz4780.
By this, the dw-hdmi is no longer the only bridge and sets up a list
of formats in dw_hdmi_bridge_atomic_get_output_bus_fmts().
This includes MEDIA_BUS_FMT_UYVY8_1X16 which is chosen for the jz4780 but only produces a black screen.
This fix is based on the observation that max_bpc = 0 when running this function while info->bpc = 8. Since the formats checks before this always test for max_bpc >= info->pbc indirectly my assumption is that we must check it here as well.
Adding the proposed patch makes the CI20/jz4780 panel work again in MEDIA_BUS_FMT_RGB888_1X24 mode.

Fixes 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks")

Signed-off-by H. Nikolaus Schaller <[email protected]>

---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -0

index b0d8110dd412c..826a055a7a273 100644
@@ -2620,10 +2620,10 @@ static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge,
 		output_fmts[i++] = MEDIA_BUS_FMT_RGB101010_1X30;
 	}
 -	if (info->color_formats & DRM_COLOR_FORMAT_YCBCR422)
+	if (max_bpc >= info->bpc && info->color_formats & DRM_COLOR_FORMAT_YCBCR422)

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, · line 2629

Quoted 5 lines

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -0

 		output_fmts[i++] = MEDIA_BUS_FMT_UYVY8_1X16;
 -	if (info->color_formats & DRM_COLOR_FORMAT_YCBCR444)
+	if (max_bpc >= info->bpc && info->color_formats & DRM_COLOR_FORMAT_YCBCR444)
 		output_fmts[i++] = MEDIA_BUS_FMT_YUV8_1X24;
   	/* Default 8bit RGB fallback */

Please do the same for all other cases and change the patch subject to something more accurate like:
"drm/bridge: dw-hdmi: take display info bpc in account for bus formats negociation"

There is no hpd-gpio installed on the CI20 board HDMI connector. Hence there is no hpd detection by the connector driver and we have to enable polling by the dw-hdmi driver.

We need to set .poll_enabled but that struct component can only be accessed in the core code. Hence we use the public setter function drm_kms_helper_hotplug_event().

Signed-off-by H. Nikolaus Schaller <[email protected]>

---
 drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c +2 -1

index 34e986dd606cf..90547a28dc5c7 100644
@@ -55,6 +55,8 @@ ingenic_dw_hdmi_mode_valid(struct dw_hdmi *hdmi, 
 void *data,
 	if (mode->clock > 216000)
 		return MODE_CLOCK_HIGH;
 
+	dw_hdmi_enable_poll(hdmi, true);
+
 	return MODE_OK;
 }
 
--

2.33.0