ppc4xx: Add GDsys PowerPC 440 ETX board support.
PATCH v5 1/1 ppc4xx: Add GDsys PowerPC 440 ETX board support.
Board support for the Guntermann & Drunck PowerPC 440 ETX module. Based on the AMCC Yosemite board support by Stefan Roese.
---
Depends on [PATCH v3] ppc4xx: Improve DDR autodetect
More whitespace rework.
MAINTAINERS | 1 + MAKEALL | 1 + Makefile | 3 + board/gdsys/gdppc440etx/Makefile | 51 +++++ board/gdsys/gdppc440etx/config.mk | 44 +++++ board/gdsys/gdppc440etx/gdppc440etx.c | 325 +++++++++++++++++++++++++++++++++ board/gdsys/gdppc440etx/init.S | 75 ++++++++ board/gdsys/gdppc440etx/u-boot.lds | 144 +++++++++++++++ include/configs/gdppc440etx.h | 194 ++++++++++++++++++++ 9 files changed, 838 insertions(+), 0 deletions(-) create mode 100644 board/gdsys/gdppc440etx/Makefile create mode 100644 board/gdsys/gdppc440etx/config.mk create mode 100644 board/gdsys/gdppc440etx/gdppc440etx.c create mode 100644 board/gdsys/gdppc440etx/init.S create mode 100644 board/gdsys/gdppc440etx/u-boot.lds create mode 100644 include/configs/gdppc440etx.h
MAINTAINERS +1 -0
@@ -132,6 +132,7 @@ Jon Diekema <[email protected]> Dirk Eibach <[email protected]> + gdppc440etx PPC440EP/GR neo PPC405EP Dave Ellis <[email protected]>
MAKEALL +1 -0
@@ -188,6 +188,7 @@ LIST_4xx=" \ EXBITGEN \ fx12mm \ G2000 \ + gdppc440etx \ glacier \ haleakala \ haleakala_nand \
Makefile +3 -0
@@ -1315,6 +1315,9 @@ fx12mm_config: unconfig G2000_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx g2000 +gdppc440etx_config: unconfig + @$(MKCONFIG) $(@:_config=) ppc ppc4xx gdppc440etx gdsys + hcu4_config: unconfig @mkdir -p $(obj)board/netstal/common @$(MKCONFIG) $(@:_config=) ppc ppc4xx hcu4 netstal
board/gdsys/gdppc440etx/Makefile new file +51 -0
51 lines not on this page · raw message
board/gdsys/gdppc440etx/config.mk new file +44 -0
44 lines not on this page · raw message
board/gdsys/gdppc440etx/gdppc440etx.c new file +325 -0
325 lines not on this page · raw message
board/gdsys/gdppc440etx/init.S new file +75 -0
75 lines not on this page · raw message
board/gdsys/gdppc440etx/u-boot.lds new file +144 -0
144 lines not on this page · raw message
include/configs/gdppc440etx.h new file +194 -0
194 lines not on this page · raw message
Signature · 1 line
1.5.6.5
PATCH v5 1/1 ppc4xx: Add GDsys PowerPC 440 ETX board support.
Hi Dirk,
Quoted 9 lines · Dirk Eibach
Board support for the Guntermann & Drunck PowerPC 440 ETX module. Based on the AMCC Yosemite board support by Stefan Roese.
Signed-off-by Dirk Eibach <[email protected]>---
Depends on [PATCH v3] ppc4xx: Improve DDR autodetect
More whitespace rework.
It's really not a big deal, but since I addressed these issues in my last mail again, I noticed them in this version as well.
<snip>
include/configs/gdppc440etx.h line 131
Quoted 2 lines
include/configs/gdppc440etx.h new file +2
-0+#define CONFIG_SYS_SDRAM0_TR0 0x410a4012 +#define CONFIG_SYS_SDRAM0_WDDCTR 0x40000000
Tab after #define! You seem to have missed this one. Did you ever try running checkpatch on your patch? This should spot such problems.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
Eibach
PATCH v5 1/1 ppc4xx: Add GDsys PowerPC 440 ETX board support.
Hi Stefan,
Quoted 7 lines
It's really not a big deal, but since I addressed these issues in my last mail again, I noticed them in this version as well.
<snip>
include/configs/gdppc440etx.h line 131
Quoted 2 lines
include/configs/gdppc440etx.h new file +2
-0+#define CONFIG_SYS_SDRAM0_TR0 0x410a4012 +#define CONFIG_SYS_SDRAM0_WDDCTR 0x40000000
Oops. Sorry. I thought I had eliminated all of those nasty buggers. If I ever get to talk to the person I copied that stuff from... :)
Quoted 3 lines
Tab after #define! You seem to have missed this one. Did you ever try running checkpatch on your patch? This should spot such problems.
In fact my version of checkpatch (linux 2.6.27) does not :( That is why the last one slipped through.
Which version of checkpatch are you using?
Cheers
Dirk
PATCH v5 1/1 ppc4xx: Add GDsys PowerPC 440 ETX board support.
Quoted 10 lines · Dirk
Quoted 7 lines
It's really not a big deal, but since I addressed these issues in my last mail again, I noticed them in this version as well.
<snip>
include/configs/gdppc440etx.h line 131
Quoted 2 lines
include/configs/gdppc440etx.h new file +2
-0+#define CONFIG_SYS_SDRAM0_TR0 0x410a4012 +#define CONFIG_SYS_SDRAM0_WDDCTR 0x40000000Oops. Sorry. I thought I had eliminated all of those nasty buggers. If I ever get to talk to the person I copied that stuff from... :)
Heh. OK, got me. I most likely copied this stuff from another config as well. Only the review process was much more superficially at that time, so it must have slipped though. Please feel free to submit another patch to clean up other config headers as well. :)
Quoted 7 lines
Quoted 3 lines
Tab after #define! You seem to have missed this one. Did you ever try running checkpatch on your patch? This should spot such problems.
In fact my version of checkpatch (linux 2.6.27) does not :( That is why the last one slipped through.
Which version of checkpatch are you using?
I didn't really check if checkpatch complains about this. I only thought it does. Must have been mistaken though.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================