Add support for Eukrea CPUAT91 SBC

CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode.

Signed-off-by Eric Benard <[email protected]>

---
 MAINTAINERS                     |    6 +-
 MAKEALL                         |    3 +-
 Makefile                        |   16 +++
 board/eukrea/cpuat91/Makefile   |   50 ++++++++
 board/eukrea/cpuat91/config.mk  |    1 +
 board/eukrea/cpuat91/cpuat91.c  |   85 ++++++++++++++
 cpu/arm920t/at91rm9200/Makefile |    5 +-
 cpu/arm920t/at91rm9200/ks8721.c |  244 +++++++++++++++++++++++++++++++++++++++
 include/configs/cpuat91.h       |  231 ++++++++++++++++++++++++++++++++++++
 include/ks8721.h                |   78 +++++++++++++
 10 files changed, 715 insertions(+), 4 deletions(-)
 create mode 100644 board/eukrea/cpuat91/Makefile
 create mode 100644 board/eukrea/cpuat91/config.mk
 create mode 100644 board/eukrea/cpuat91/cpuat91.c
 create mode 100644 cpu/arm920t/at91rm9200/ks8721.c
 create mode 100644 include/configs/cpuat91.h
 create mode 100644 include/ks8721.h

MAINTAINERS +5 -1

index 575a7ec..da64571 100644
@@ -1,4 +1,4 @@
-#########################################################################
+9#########################################################################
 #									#
 # Regular Maintainers for U-Boot board support:				#
 #									#

@@ -515,6 +515,10 @@ Dirk Behme <[email protected]>
 
 	omap3_beagle	ARM CORTEX-A8 (OMAP3530 SoC)
 
+Eric Benard <[email protected]>
+
+	cpcuat91	ARM920T
+
 Rishi Bhattacharya <[email protected]>
 
 	omap5912osk	ARM926EJS

MAKEALL +2 -1

index 020ff73..0e0b657 100755
@@ -587,11 +587,12 @@ LIST_at91="			\
 	at91sam9260ek		\
 	at91sam9261ek		\
 	at91sam9263ek		\
-	at91sam9g10ek	\
+	at91sam9g10ek		\
 	at91sam9g20ek		\
 	at91sam9m10g45ek	\
 	at91sam9rlek		\
 	cmc_pu2			\
+	cpuat91			\
 	csb637			\
 	kb9202			\
 	meesc			\

Makefile +0 -0

index 090e645..02efe1b 100644

Makefile +8 -0

+	@if [ "$(findstring _ram_,$@)" ] ; then \
+		echo "#define CONFIG_CPUAT91_RAM 1" >> ./include/config.h ; \
+		echo "... CPUAT91 configured for RAM !" ; \
+	else \
+		echo "#define CONFIG_BOOTDELAY 1" >> ./include/config.h ;\
+		echo "... CPUAT91 configure for Flash !" ;\
+	fi;
+
 csb637_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t csb637 NULL at91rm9200
 

cpu/arm920t/at91rm9200/Makefile +3 -2

index 73aeeac..114d8ad 100644
@@ -31,14 +31,15 @@ COBJS	+= bcm5221.o
 COBJS	+= dm9161.o
 COBJS	+= ether.o
 COBJS	+= i2c.o
+COBJS-$(CONFIG_KS8721_PHY)	+= ks8721.o
 COBJS	+= lxt972.o
 COBJS	+= reset.o
 COBJS	+= spi.o
 COBJS	+= timer.o
 COBJS	+= usb.o
 
-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
 
 all:	$(obj).depend $(LIB)
 

cpu/arm920t/at91rm9200/ks8721.c new file +0 -0

new file mode 100644
index 0000000..703e58c

cpu/arm920t/at91rm9200/ks8721.c new file +9 -0

+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *

Makefile at91rm9200ek_config : unconfig · line 2691

Quoted 5 lines

Makefile +5 -0

+
+cpuat91_ram_config \
+cpuat91_config    :    unconfig
+    @if [ "$(findstring _ram_,$@)" ] ; then \
+        echo "#define CONFIG_CPUAT91_RAM 1" >> ./include/config.h ; \

what is this ram config?

what is its goal?

Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD

Makefile at91rm9200ek_config : unconfig · line 2691

Quoted 5 lines

Makefile +5 -0

+
+cpuat91_ram_config \
+cpuat91_config    :    unconfig
+    @if [ "$(findstring _ram_,$@)" ] ; then \
+        echo "#define CONFIG_CPUAT91_RAM 1" >> ./include/config.h ; \

what is this ram config?

the ram config allows to generate a u-boot without low level init and relocation without having to modify the .h config file.

Quoted 1 line

what is its goal?

to generate a u-boot.bin which can be used to bootstrap the AT91RM9200 through it's serial port (using Atmel's loader).

CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode.

Signed-off-by Eric Benard <[email protected]>

---

board/eukrea/cpuat91/cpuat91.c new file +38 -0

+	/* arch number of CPUAT91-Board */
+	gd->bd->bi_arch_number = MACH_TYPE_CPUAT91;
+	/* adress of boot parameters */
+	gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
+
+	return 0;
+}
+
+int dram_init(void)
+{
+	gd->bd->bi_dram[0].start = PHYS_SDRAM;
+	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
+	return 0;
+}
+
+#if defined(CONFIG_DRIVER_ETHER)
+#if defined(CONFIG_CMD_NET)
+
+/*
+ * Name:
+ *	at91rm9200_GetPhyInterface
+ * Description:
+ *	Initialise the interface functions to the PHY
+ * Arguments:
+ *	None
+ * Return value:
+ *	None
+ */
+void at91rm9200_GetPhyInterface(AT91PS_PhyOps p_phyops)
+{
+	p_phyops->Init = ks8721_InitPhy;
+	p_phyops->IsPhyConnected = ks8721_IsPhyConnected;
+	p_phyops->GetLinkSpeed = ks8721_GetLinkSpeed;
+	p_phyops->AutoNegotiate = ks8721_AutoNegotiate;
+}
+
+#endif	/* CONFIG_CMD_NET */
+#endif	/* CONFIG_DRIVER_ETHER */

cpu/arm920t/at91rm9200/Makefile +3 -2

index 73aeeac..114d8ad 100644
@@ -31,14 +31,15 @@ COBJS	+= bcm5221.o
 COBJS	+= dm9161.o
 COBJS	+= ether.o
 COBJS	+= i2c.o
+COBJS-$(CONFIG_KS8721_PHY)	+= ks8721.o
 COBJS	+= lxt972.o
 COBJS	+= reset.o
 COBJS	+= spi.o
 COBJS	+= timer.o
 COBJS	+= usb.o
 
-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
 
 all:	$(obj).depend $(LIB)
 

cpu/arm920t/at91rm9200/ks8721.c new file +0 -0

new file mode 100644
index 0000000..703e58c

+ * Return value:
+ * TRUE - if id read successfully
+ * FALSE- if error
+ */

cpu/arm920t/at91rm9200/ks8721.c new file +5 -0

+/*
+ * Name:
+ *	ks8721_InitPhy
+ * Description:
+ *	MAC starts checking its link by using parallel detection and

MAKEALL +1 -0

 	at91sam9g20ek		\
 	at91sam9m10g45ek	\
 	at91sam9rlek		\
 	cmc_pu2			\
+	cpuat91			\
 	csb637			\
 	kb9202			\
 	meesc			\

Makefile +0 -0

index 090e645..3b348d9 100644

Makefile +7 -0

+		$(XECHO) "... CPUAT91 configured for RAM" ; \
+	else \
+		echo "#define CONFIG_BOOTDELAY 1" >>$(obj)include/config.h ;\
+		$(XECHO) "... CPUAT91 configured for Flash" ;\
+	fi;
+	@$(MKCONFIG) -a cpuat91 arm arm920t cpuat91 eukrea at91rm9200
+
 csb637_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t csb637 NULL at91rm9200
 

board/eukrea/cpuat91/Makefile new file +18 -0

new file mode 100644
index 0000000..08a90dc
@@ -0,0 +1,50 @@
+#
+# (C) Copyright 2003-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License

board/eukrea/cpuat91/Makefile new file +21 -0

+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak .depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+

board/eukrea/cpuat91/Makefile new file +3 -0

+
+#endif	/* CONFIG_CMD_NET */
+#endif	/* CONFIG_DRIVER_ETHER */

cpu/arm920t/at91rm9200/Makefile +1 -0

index 73aeeac..114d8ad 100644
@@ -31,14 +31,15 @@ COBJS	+= bcm5221.o
 COBJS	+= dm9161.o
 COBJS	+= ether.o
 COBJS	+= i2c.o
+COBJS-$(CONFIG_KS8721_PHY)	+= ks8721.o

Quoted 7 lines

Makefile +0 -0

@@ -2683,6 +2683,18 @@ at91rm9200ek_config	:	unconfig
 cmc_pu2_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 

Makefile at91rm9200ek_config : unconfig · line 2690

Quoted 5 lines

Makefile +5 -0

+cpuat91_ram_config \
+cpuat91_config	:	unconfig
+	@mkdir -p $(obj)include
+	@if [ "$(findstring _ram_,$@)" ] ; then \
+		echo "#define CONFIG_CPUAT91_RAM 1" >>$(obj)include/config.h ; \

same as other patch
no need please define the
#define CONFIG_SKIP_LOWLEVEL_INIT
#define CONFIG_SKIP_RELOCATE_UBOOT
here

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 7 lines · In message <[email protected]> you wrote:

Quoted 7 lines

Makefile +0 -0

@@ -2683,6 +2683,18 @@ at91rm9200ek_config	:	unconfig
 cmc_pu2_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 

Quoted 10 lines

Makefile at91rm9200ek_config : unconfig · line 2690

Quoted 5 lines

Makefile +5 -0

+cpuat91_ram_config \
+cpuat91_config	:	unconfig
+	@mkdir -p $(obj)include
+	@if [ "$(findstring _ram_,$@)" ] ; then \
+		echo "#define CONFIG_CPUAT91_RAM 1" >>$(obj)include/config.h ; \

same as other patch
no need please define the
#define CONFIG_SKIP_LOWLEVEL_INIT
#define CONFIG_SKIP_RELOCATE_UBOOT
here

No. Not here, i. e. not in the Makefile. We don't want tens of lines of scripts per board in the top level Makefile.

Quoted 14 lines

cpu/arm920t/at91rm9200/Makefile +2 -2

-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
 
 all:	$(obj).depend $(LIB)

cpu/arm920t/at91rm9200/ks8721.c new file +0 -0

new file mode 100644
index 0000000..703e58c

cpu/arm920t/at91rm9200/ks8721.c line 6

Quoted 6 lines

cpu/arm920t/at91rm9200/ks8721.c new file +6 -0

@@ -0,0 +1,244 @@
+/*
+ * (C) Copyright 2006
+ * Author : Eric Benard (Eukrea Electromatique)
+ * based on dm9161.c which is :
+ * (C) Copyright 2003
+ * Author : Hamid Ikdoumi (Atmel)

I'm not a fan of this implementation at all

but as I've not yet finish the rm9200 cleanup
I'll ack this ben what do you think?
ben please note that the rm9200 cleanup will introduce a phylib support

Quoted 23 lines

Quoted 15 lines

cpu/arm920t/at91rm9200/Makefile +2 -2

-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
 
 all:	$(obj).depend $(LIB)

cpu/arm920t/at91rm9200/ks8721.c new file +0 -0

new file mode 100644
index 0000000..703e58c

cpu/arm920t/at91rm9200/ks8721.c line 6

Quoted 6 lines

cpu/arm920t/at91rm9200/ks8721.c new file +6 -0

@@ -0,0 +1,244 @@
+/*
+ * (C) Copyright 2006
+ * Author : Eric Benard (Eukrea Electromatique)
+ * based on dm9161.c which is :
+ * (C) Copyright 2003
+ * Author : Hamid Ikdoumi (Atmel)

I'm not a fan of this implementation at all

Quoted 4 lines

but as I've not yet finish the rm9200 cleanup
I'll ack this ben what do you think?
ben please note that the rm9200 cleanup will introduce a phylib support

Ben ping

Best Regards,
J.

This patch has many coding style violations that haven't been addressed, so it can't go in. I"m not a fan of the piece-meal PHY implementation

Quoted 3 lines · Ben Warren

This patch has many coding style violations that haven't been addressed, so it can't go in. I"m not a fan of the piece-meal PHY implementation

coding style violations should be fixed in v3 /
http://www.mail-archive.com/u-boot at lists.denx.de/msg18068.html

Eric

MAKEALL +1 -0

 	at91sam9g20ek		\
 	at91sam9m10g45ek	\
 	at91sam9rlek		\
 	cmc_pu2			\
+	cpuat91			\
 	csb637			\
 	kb9202			\
 	meesc			\

Makefile +0 -0

index ac844a7..655cb03 100644

Makefile +7 -0

+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#if defined(CONFIG_CPUAT91_RAM)
+#define CONFIG_SKIP_LOWLEVEL_INIT	1
+#define CONFIG_SKIP_RELOCATE_UBOOT	1

Makefile +41 -0

+#define CONFIG_CPUAT91			1
+
+#undef CONFIG_USE_IRQ
+#define USE_920T_MMU			1
+
+#define CONFIG_CMDLINE_TAG		1
+#define CONFIG_SETUP_MEMORY_TAGS	1
+#define CONFIG_INITRD_TAG		1
+
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+#define CONFIG_SYS_USE_MAIN_OSCILLATOR	1
+/* flash */
+#define CONFIG_SYS_MC_PUIA_VAL	0x00000000
+#define CONFIG_SYS_MC_PUP_VAL	0x00000000
+#define CONFIG_SYS_MC_PUER_VAL	0x00000000
+#define CONFIG_SYS_MC_ASR_VAL	0x00000000
+#define CONFIG_SYS_MC_AASR_VAL	0x00000000
+#define CONFIG_SYS_EBI_CFGR_VAL	0x00000000
+#define CONFIG_SYS_SMC_CSR0_VAL	0x00003284 /* 16bit, 2 TDF, 4 WS */
+
+/* clocks */
+#define CONFIG_SYS_PLLAR_VAL	0x20263E04 /* 179.712000 MHz for PCK */
+#define CONFIG_SYS_PLLBR_VAL	0x10483E0E /* 48.054857 MHz for USB */
+#define CONFIG_SYS_MCKR_VAL	0x00000202 /* PCK/3 = MCK Master Clock */
+
+/* sdram */
+#define CONFIG_SYS_PIOC_ASR_VAL	0xFFFF0000 /* Configure PIOC as D16/D31 */
+#define CONFIG_SYS_PIOC_BSR_VAL	0x00000000
+#define CONFIG_SYS_PIOC_PDR_VAL	0xFFFF0000
+#define CONFIG_SYS_EBI_CSA_VAL	0x00000002 /* CS1=SDRAM */
+#define CONFIG_SYS_SDRC_CR_VAL	0x2188C155 /* set up the SDRAM */
+#define CONFIG_SYS_SDRAM	0x20000000 /* address of the SDRAM */
+#define CONFIG_SYS_SDRAM1	0x20000080 /* address of the SDRAM */
+#define CONFIG_SYS_SDRAM_VAL	0x00000000 /* value written to SDRAM */
+#define CONFIG_SYS_SDRC_MR_VAL	0x00000002 /* Precharge All */
+#define CONFIG_SYS_SDRC_MR_VAL1	0x00000004 /* refresh */
+#define CONFIG_SYS_SDRC_MR_VAL2	0x00000003 /* Load Mode Register */
+#define CONFIG_SYS_SDRC_MR_VAL3	0x00000000 /* Normal Mode */
+#define CONFIG_SYS_SDRC_TR_VAL	0x000002E0 /* Write refresh rate */
+#endif	/* CONFIG_SKIP_LOWLEVEL_INIT */
+

Makefile +19 -0

+
+#define CONFIG_HARD_I2C			1
+
+#if defined(CONFIG_HARD_I2C)
+#define	CONFIG_SYS_I2C_SPEED			50000
+#define CONFIG_SYS_I2C_SLAVE			0
+#define CONFIG_SYS_I2C_EEPROM_ADDR		0x54
+#define CONFIG_SYS_I2C_EEPROM_ADDR_LEN		1
+#define CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW	1
+#define	CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	10
+#endif
+
+#define CONFIG_BOOTP_BOOTFILESIZE	1
+#define CONFIG_BOOTP_BOOTPATH		1
+#define CONFIG_BOOTP_GATEWAY		1
+#define CONFIG_BOOTP_HOSTNAME		1
+
+#include <config_cmd_default.h>
+

Makefile at91rm9200ek_config : unconfig · line 2680

Quoted 5 lines

Makefile +5 -0

+cpuat91_ram_config \
+cpuat91_config	:	unconfig
+	@mkdir -p $(obj)include
+	@if [ "$(findstring _ram_,$@)" ] ; then \
+		echo "#define CONFIG_CPUAT91_RAM 1" >>$(obj)include/config.h ; \

NACK
no new config for this you must use the current one

Makefile at91rm9200ek_config : unconfig · line 2687

Quoted 7 lines

Makefile +7 -0

+		$(XECHO) "... CPUAT91 configured for RAM" ; \
+	else \
+		echo "#define CONFIG_BOOTDELAY 1" >>$(obj)include/config.h ;\
+		$(XECHO) "... CPUAT91 configured for Flash" ;\
+	fi;
+	@$(MKCONFIG) -a cpuat91 arm arm920t cpuat91 eukrea at91rm9200
+

CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode.

v3 : fix coding style issues
v4 : fix coding style in ks8721
v5 : fix following Jean Christophe's review

Signed-off-by Eric Benard <[email protected]>

---

 MAINTAINERS                     |    4 +
 MAKEALL                         |    1 +
 Makefile                        |   13 ++
 board/eukrea/cpuat91/Makefile   |   50 ++++++++
 board/eukrea/cpuat91/config.mk  |    1 +
 board/eukrea/cpuat91/cpuat91.c  |   86 ++++++++++++++
 cpu/arm920t/at91rm9200/Makefile |    5 +-
 cpu/arm920t/at91rm9200/ks8721.c |  242 +++++++++++++++++++++++++++++++++++++++
 include/configs/cpuat91.h       |  226 ++++++++++++++++++++++++++++++++++++

 include/ks8721.h                |   78 +++++++++++++
 10 files changed, 704 insertions(+), 2 deletions(-)
 create mode 100644 board/eukrea/cpuat91/Makefile
 create mode 100644 board/eukrea/cpuat91/config.mk
 create mode 100644 board/eukrea/cpuat91/cpuat91.c
 create mode 100644 cpu/arm920t/at91rm9200/ks8721.c
 create mode 100644 include/configs/cpuat91.h
 create mode 100644 include/ks8721.h

CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode.

Makefile +5 -0

+cpuat91_ram_config \
+cpuat91_config	:	unconfig
+	@mkdir -p $(obj)include
+	@if [ "$(findstring _ram_,$@)" ] ; then \
+		echo "#define CONFIG_SKIP_LOWLEVEL_INIT" >> $(obj)include/config.h; \

cpu/arm920t/at91rm9200/ks8721.c new file +2 -0

+unsigned char ks8721_autonegotiate(AT91PS_EMAC p_mac, int *status)
+{

CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode.

(quoted diff) +0 -0

 	meesc			\

Makefile +5 -0

index 54c0b67..2386cdc 100644
@@ -2674,6 +2674,19 @@ at91rm9200ek_config	:	unconfig
 cmc_pu2_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 
+cpuat91_ram_config \
+cpuat91_config	:	unconfig
+	@mkdir -p $(obj)include
+	@if [ "$(findstring _ram_,$@)" ] ; then \
+		echo "#define CONFIG_SKIP_LOWLEVEL_INIT" >> $(obj)include/config.h; \

Dear Eric Benard,

Quoted 3 lines · In message <[email protected]> you wrote:

CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode.

...

Quoted 19 lines

(quoted diff) +0 -0

 	meesc			\

Makefile +10 -0

index 54c0b67..2386cdc 100644
@@ -2674,6 +2674,19 @@ at91rm9200ek_config	:	unconfig
 cmc_pu2_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 
+cpuat91_ram_config \
+cpuat91_config	:	unconfig
+	@mkdir -p $(obj)include
+	@if [ "$(findstring _ram_,$@)" ] ; then \
+		echo "#define CONFIG_SKIP_LOWLEVEL_INIT" >> $(obj)include/config.h; \
+		echo "#define CONFIG_SKIP_RELOCATE_UBOOT" >> $(obj)include/config.h; \
+		$(XECHO) "... CPUAT91 configured for RAM" ; \
+	else \
+		echo "#define CONFIG_BOOTDELAY 1" >>$(obj)include/config.h ; \
+		$(XECHO) "... CPUAT91 configured for Flash" ;\

Makefile at91rm9200ek_config : unconfig · line 2691

Quoted 5 lines

Makefile +3 -0

+	fi;
+	@$(MKCONFIG) -a cpuat91 arm arm920t cpuat91 eukrea at91rm9200
+
 csb637_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t csb637 NULL at91rm9200

Please do not add such scripting to the top level Makefile. Perform it in your board config file instead.

Quoted 3 lines

Please do not add such scripting to the top level Makefile. Perform it in your board config file instead.

Not sure if this is 'standard' for at91, but I saw something similar in

http://git.denx.de/?p=u-boot/u-boot-arm.git;a=blobdiff;f=Makefile;h=c9d315ae98f2272659b88405cd2b94265f3bbfc3;hp=54c0b67499510f83fa642b9684ad95ce832de1b9;hb=f8ea12cf9be98508096dc4102a6ef40cb484fdd3;hpb=c6b5600aee06a13e556837c3065f7f8721d56ec9

Signed-off-by Eric Benard <[email protected]>

---
 MAKEALL |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Quoted 24 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 19 lines

Quoted 11 lines

cpu/arm920t/at91rm9200/Makefile +2 -2

-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))

all: $(obj).depend $(LIB)

cpu/arm920t/at91rm9200/ks8721.c new file +0 -0

new file mode 100644
index 0000000..703e58c

cpu/arm920t/at91rm9200/ks8721.c line 6

Quoted 6 lines

cpu/arm920t/at91rm9200/ks8721.c new file +6 -0

@@ -0,0 +1,244 @@
+/*
+ * (C) Copyright 2006
+ * Author : Eric Benard (Eukrea Electromatique)
+ * based on dm9161.c which is :
+ * (C) Copyright 2003
+ * Author : Hamid Ikdoumi (Atmel)

I'm not a fan of this implementation at all

Quoted 3 lines

but as I've not yet finish the rm9200 cleanup
I'll ack this ben what do you think?
ben please note that the rm9200 cleanup will introduce a phylib support

Ben ping

Quoted 2 lines

Best Regards,
J.

This patch has many coding style violations that haven't been addressed, so it can't go in. I"m not a fan of the piece-meal PHY implementation either, but realize that a real PHY lib isn't imminent, unless your rm2000 implementation is useful across architectures.

Quoted 28 lines · Ben Warren

Quoted 26 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 20 lines

Quoted 12 lines

cpu/arm920t/at91rm9200/Makefile +2 -2

-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))

all: $(obj).depend $(LIB)

cpu/arm920t/at91rm9200/ks8721.c new file +0 -0

new file mode 100644
index 0000000..703e58c

cpu/arm920t/at91rm9200/ks8721.c line 6

Quoted 6 lines

cpu/arm920t/at91rm9200/ks8721.c new file +6 -0

@@ -0,0 +1,244 @@
+/*
+ * (C) Copyright 2006
+ * Author : Eric Benard (Eukrea Electromatique)
+ * based on dm9161.c which is :
+ * (C) Copyright 2003
+ * Author : Hamid Ikdoumi (Atmel)

I'm not a fan of this implementation at all

Quoted 4 lines

but as I've not yet finish the rm9200 cleanup
I'll ack this ben what do you think?
ben please note that the rm9200 cleanup will introduce a phylib support

Ben ping

Quoted 9 lines

Quoted 3 lines

Best Regards,
J.

This patch has many coding style violations that haven't been addressed, so it can't go in. I"m not a fan of the piece-meal PHY implementation either, but realize that a real PHY lib isn't imminent, unless your rm2000 implementation is useful across architectures.

it will be a generic implementation
as we need it also for other soc and arch for our boards.

Best Regards,
J.