Skip to contentSkip to conversation

drm/i915: Probe SDVO LVDS information

PATCH In review Adam Jackson 2 participants 3 messages Nov 28, 2011 – Jan 23, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Probe SDVO LVDS information

No effect besides printing the result in dmesg if debugging is enabled.

---
 drivers/gpu/drm/i915/intel_sdvo.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +11 -0
index 3003fb2..c3810d2 100644
@@ -2113,6 +2113,15 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device)
 	return true;
 }
 
+static void
+intel_sdvo_lvds_probe_panel_information(struct intel_sdvo *intel_sdvo)
+{
+	u8 info;
+	intel_sdvo_get_value(intel_sdvo,
+			     SDVO_CMD_GET_LVDS_PANEL_INFORMATION,
+			     &info, sizeof(info));
+}
+
 static bool
 intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
 {
@@ -2145,6 +2154,8 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
 	if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
 		goto err;
 
+	intel_sdvo_lvds_probe_panel_information(intel_sdvo);
+
 	return true;
 
 err:
Signature · 1 line
1.7.6.4
#1 lore raw
Quoted 3 lines · Adam Jackson

No effect besides printing the result in dmesg if debugging is enabled.

This looks strange without dmesg output nor a comment added. Quick survey on irc with Jesse and Chris showed that we want interesting stuff decoded into dmesg or debugfs ... hint ;-)
-Daniel

Quoted 40 lines
---
 drivers/gpu/drm/i915/intel_sdvo.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +11 -0
index 3003fb2..c3810d2 100644
@@ -2113,6 +2113,15 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device)
 	return true;
 }
 
+static void
+intel_sdvo_lvds_probe_panel_information(struct intel_sdvo *intel_sdvo)
+{
+	u8 info;
+	intel_sdvo_get_value(intel_sdvo,
+			     SDVO_CMD_GET_LVDS_PANEL_INFORMATION,
+			     &info, sizeof(info));
+}
+
 static bool
 intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
 {
@@ -2145,6 +2154,8 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
 	if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
 		goto err;
 
+	intel_sdvo_lvds_probe_panel_information(intel_sdvo);
+
 	return true;
 
 err:
Signature · 6 lines
1.7.6.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48
#2 lore raw
Quoted 9 lines · Daniel Vetter
Quoted 3 lines · Adam Jackson

No effect besides printing the result in dmesg if debugging is enabled.

This looks strange without dmesg output nor a comment added. Quick survey on irc with Jesse and Chris showed that we want interesting stuff decoded into dmesg or debugfs ... hint ;-)
-Daniel

Well:

Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_sdvo.c +4 -0
+static void
+intel_sdvo_lvds_probe_panel_information(struct intel_sdvo *intel_sdvo)
+{
+	u8 info;
Quoted 8 lines

drivers/gpu/drm/i915/intel_sdvo.c intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device) · line 2127

Quoted 8 lines
drivers/gpu/drm/i915/intel_sdvo.c +5 -0
+	intel_sdvo_get_value(intel_sdvo,
+			     SDVO_CMD_GET_LVDS_PANEL_INFORMATION,
+			     &info, sizeof(info));
+}
+
 static bool
 intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
 {

intel_sdvo_get_value -> intel_sdvo_write_cmd / intel_sdvo_read_response, both of which call DRM_{DEBUG,LOG}_KMS.

Which is a little non-obvious without an explicit "yes i'm doing this in void context, don't panic" comment in the code I guess. Want a better version?

- ajax

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx