Skip to contentSkip to conversation

ASoC: tas2552: Describe the possible I2C addresses

PATCH In review Fabio Estevam 2 participants 4 messages Apr 11, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ASoC: tas2552: Describe the possible I2C addresses

According to the TAS2552 datasheet the possible I2C addresses are:

0x40 - when ADDR pin is 0
0x41 - when ADDR pin is 1

List the possible values for better clarification.

---
 Documentation/devicetree/bindings/sound/tas2552.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/tas2552.txt +2 -1
index 54c1c87..ea8abf0 100644
@@ -5,7 +5,8 @@ The tas2552 serial control bus communicates through I2C protocols
 Required properties:
 	- compatible - One of:
 		"ti,tas2552" - TAS2552
-	- reg -  I2C slave address
+	- reg -  I2C slave address: it can be 0x40 if ADDR pin is 0
+				    or 0x41 if ADDR pin is 1.
 	- supply-*: Required supply regulators are:
 		"vbat"		battery voltage
 		"iovdd"		I/O Voltage
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 ASoC: tas2552: Fix typos in the binding doc

Fix the following typos:

"receive its reference clock" and "selected".

---
 Documentation/devicetree/bindings/sound/tas2552.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/tas2552.txt +2 -2
index ea8abf0..2d71eb0 100644
@@ -15,11 +15,11 @@ Required properties:
 Optional properties:
 	- enable-gpio - gpio pin to enable/disable the device
 
-tas2552 can receive it's reference clock via MCLK, BCLK, IVCLKIN pin or use the
+tas2552 can receive its reference clock via MCLK, BCLK, IVCLKIN pin or use the
 internal 1.8MHz. This CLKIN is used by the PLL. In addition to PLL, the PDM
 reference clock is also selectable: PLL, IVCLKIN, BCLK or MCLK.
 For system integration the dt-bindings/sound/tas2552.h header file provides
-defined values to selct and configure the PLL and PDM reference clocks.
+defined values to select and configure the PLL and PDM reference clocks.
 
 Example:
 
Signature · 1 line
2.7.4
maintainer
#2 lore raw

Applied "ASoC: tas2552: Fix typos in the binding doc" to the asoc tree

The patch

ASoC: tas2552: Fix typos in the binding doc

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 7d8d2c9482474804a5c2b33ea9218d33dbcb48ba Mon Sep 17 00:00:00 2001

From: Fabio Estevam <[email protected]>
Date: Tue, 11 Apr 2017 15:49:35 -0300
Subject: [PATCH] ASoC: tas2552: Fix typos in the binding doc

Fix the following typos:

"receive its reference clock" and "selected".

---
 Documentation/devicetree/bindings/sound/tas2552.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/tas2552.txt +2 -2
index ea8abf08b094..2d71eb05c1d3 100644
@@ -15,11 +15,11 @@ Required properties:
 Optional properties:
 	- enable-gpio - gpio pin to enable/disable the device
 
-tas2552 can receive it's reference clock via MCLK, BCLK, IVCLKIN pin or use the
+tas2552 can receive its reference clock via MCLK, BCLK, IVCLKIN pin or use the
 internal 1.8MHz. This CLKIN is used by the PLL. In addition to PLL, the PDM
 reference clock is also selectable: PLL, IVCLKIN, BCLK or MCLK.
 For system integration the dt-bindings/sound/tas2552.h header file provides
-defined values to selct and configure the PLL and PDM reference clocks.
+defined values to select and configure the PLL and PDM reference clocks.
 
 Example:
 
Signature · 1 line
2.11.0
maintainer
#3 lore raw

Applied "ASoC: tas2552: Describe the possible I2C addresses" to the asoc tree

In reply to Fabio Estevam

The patch

ASoC: tas2552: Describe the possible I2C addresses

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From ddea87ea79927ba0b94e697a505f90fe06c29f84 Mon Sep 17 00:00:00 2001

From: Fabio Estevam <[email protected]>
Date: Tue, 11 Apr 2017 15:49:34 -0300
Subject: [PATCH] ASoC: tas2552: Describe the possible I2C addresses

According to the TAS2552 datasheet the possible I2C addresses are:

0x40 - when ADDR pin is 0
0x41 - when ADDR pin is 1

List the possible values for better clarification.

---
 Documentation/devicetree/bindings/sound/tas2552.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/tas2552.txt +2 -1
index 54c1c87c4ad8..ea8abf08b094 100644
@@ -5,7 +5,8 @@ The tas2552 serial control bus communicates through I2C protocols
 Required properties:
 	- compatible - One of:
 		"ti,tas2552" - TAS2552
-	- reg -  I2C slave address
+	- reg -  I2C slave address: it can be 0x40 if ADDR pin is 0
+				    or 0x41 if ADDR pin is 1.
 	- supply-*: Required supply regulators are:
 		"vbat"		battery voltage
 		"iovdd"		I/O Voltage
Signature · 1 line
2.11.0