Staging: ethernet: Fixes checkpatch blank lines warnings

PATCH Superseded Ronald Rojas 2 participants 4 messages Sep 14, 2016 Staging

lore

Share & tools

lore

Ronald Rojas

author

2016-09-14 14:34 UTC #0 lore raw

PATCH 1/1 Staging: ethernet: Fixes checkpatch blank lines warnings

This patch fixes several of the checkpatch.pl warnings in the driver/staging/octeon/ethernet.c file:

CHECK: Please don't use multiple blank lines
89: FILE: drivers/staging/octeon/ethernet.c:89:

CHECK: Please don't use multiple blank lines
668: FILE: drivers/staging/octeon/ethernet.c:668:

CHECK: Please don't use multiple blank lines
881: FILE: drivers/staging/octeon/ethernet.c:881:

Signed-off-by Ronald Rojas <[email protected]>

---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/staging/octeon/ethernet.c +0 -3

index e9cd5f2..79571d6 100644
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *

@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();

@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();

Signature · 1 line

2.7.4

Julia Lawall

2016-09-14 14:36 UTC #1 lore raw

I guess there are some maintainers who should also receive this? Look for the information about the get_maintainer command in the Submit a patch section of the tutorial.

Quoted 11 lines · Ronald Rojas

This patch fixes several of the checkpatch.pl warnings in the driver/staging/octeon/ethernet.c file:
CHECK: Please don't use multiple blank lines
89: FILE: drivers/staging/octeon/ethernet.c:89:
CHECK: Please don't use multiple blank lines
668: FILE: drivers/staging/octeon/ethernet.c:668:
CHECK: Please don't use multiple blank lines
881: FILE: drivers/staging/octeon/ethernet.c:881:

You don't need to list all of the errors explicitly. The important part is just that checkpatch suggested removing the blank lines.

thanks,
julia

Quoted 43 lines

Signed-off-by Ronald Rojas <[email protected]>
---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/octeon/ethernet.c +0 -4
index e9cd5f2..79571d6 100644
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914143430.GA22511%40fedora.
For more options, visit https://groups.google.com/d/optout.

Ronald Rojas

author

2016-09-14 16:55 UTC #2 lore raw

Sorry for the mistake. When I resubmit the patch with the appropriate maintainers CC'd should I append a v2 to the subject? Or use the same name?

Ronald
Ronald Rojas

Quoted 67 lines · Julia Lawall

I guess there are some maintainers who should also receive this? Look for the information about the get_maintainer command in the Submit a patch section of the tutorial.
Quoted 11 lines · Ronald Rojas
This patch fixes several of the checkpatch.pl warnings in the driver/staging/octeon/ethernet.c file:
CHECK: Please don't use multiple blank lines
89: FILE: drivers/staging/octeon/ethernet.c:89:
CHECK: Please don't use multiple blank lines
668: FILE: drivers/staging/octeon/ethernet.c:668:
CHECK: Please don't use multiple blank lines
881: FILE: drivers/staging/octeon/ethernet.c:881:
You don't need to list all of the errors explicitly. The important part is just that checkpatch suggested removing the blank lines.
thanks,
julia
Quoted 43 lines
Signed-off-by Ronald Rojas <[email protected]>
---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/octeon/ethernet.c +0 -4
index e9cd5f2..79571d6 100644
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
              return -EINVAL;
      }
 
-
      cvm_oct_configure_common_hw();
 
      cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
              }
      }
 
-
      cvmx_pko_shutdown();
 
      cvmx_ipd_free_ptr();
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914143430.GA22511%40fedora.
For more options, visit https://groups.google.com/d/optout.

Julia Lawall

2016-09-14 19:10 UTC #3 lore raw

Quoted 3 lines · Ronald Rojas

Sorry for the mistake. When I resubmit the patch with the appropriate maintainers CC'd should I append a v2 to the subject? Or use the same name?

[PATCH v2]

It is always safe to up the version. Greg will only apply the highest version number.

julia

Quoted 81 lines

Ronald
Ronald Rojas
Quoted 60 lines · Julia Lawall
I guess there are some maintainers who should also receive this? Look for the information about the get_maintainer command in the Submit a patch section of the tutorial.
Quoted 11 lines · Ronald Rojas
This patch fixes several of the checkpatch.pl warnings in the driver/staging/octeon/ethernet.c file:
CHECK: Please don't use multiple blank lines
89: FILE: drivers/staging/octeon/ethernet.c:89:
CHECK: Please don't use multiple blank lines
668: FILE: drivers/staging/octeon/ethernet.c:668:
CHECK: Please don't use multiple blank lines
881: FILE: drivers/staging/octeon/ethernet.c:881:
You don't need to list all of the errors explicitly. The important part is just that checkpatch suggested removing the blank lines.
thanks,
julia
Quoted 36 lines
Signed-off-by Ronald Rojas <[email protected]>
---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/octeon/ethernet.c +0 -4
index e9cd5f2..79571d6 100644
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
              return -EINVAL;
      }
 
-
      cvm_oct_configure_common_hw();
 
      cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
              }
      }
 
-
      cvmx_pko_shutdown();
 
      cvmx_ipd_free_ptr();
--
2.7.4
Quoted 7 lines
Quoted 7 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914143430.GA22511%40fedora.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAM_P2LKQuGM0D52ezJQdTovMFbWSzuJVnaFYmgQ7-jQ1HMf%2BCw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.