Staging: ethernet: Fixes checkpatch blank lines warnings
PATCH v2 1/1 Staging: ethernet: Fixes checkpatch blank lines warnings
This patch fixes several of the checkpatch.pl warnings in the driver/staging/octeon/ethernet.c file.
All of the errors were "Please don't use multiple blank lines" and the appropriate lines were deleted at lines 89, 668, and 881. 89.
--- drivers/staging/octeon/ethernet.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/octeon/ethernet.c +0 -3
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;module_param (rx_napi_weight, int,0444 );MODULE_PARM_DESC (rx_napi_weight,"The NAPI WEIGHT parameter." ); -/* * cvm_oct_poll_queue_stopping - flag to indicate polling should stop. *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)return -EINVAL ; } -cvm_oct_configure_common_hw ();cvmx_helper_initialize_packet_io_global ();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev) } } -cvmx_pko_shutdown ();cvmx_ipd_free_ptr ();
Signature · 1 line
2.7.4
Quoted 5 lines · Ronald Rojas
This patch fixes several of the checkpatch.pl warnings in the
driver/staging/octeon/ethernet.cfile.
All of the errors were "Please don't use multiple blank lines" and the appropriate lines were deleted at lines 89, 668, and 881. 89.
It's better, but it's still too much. You don't need the file name - that is clear from the diffstat just below the ---. And you don't need the line numbers. The commit log could be "Remove the second of a pair of blank lines. Problem detected by checkpatch."
Quoted 2 lines
Signed-off-by Ronald Rojas <[email protected]>---
Here you should put
v2: changed commit log
julia
Quoted 41 lines
drivers/staging/octeon/ethernet.c | 3 --- 1 file changed, 3 deletions(-)drivers/staging/octeon/ethernet.c +0
-4@@ -86,7 +86,6 @@ int rx_napi_weight = 32;module_param (rx_napi_weight, int,0444 );MODULE_PARM_DESC (rx_napi_weight,"The NAPI WEIGHT parameter." ); -/* * cvm_oct_poll_queue_stopping - flag to indicate polling should stop. * @@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)return -EINVAL ; } -cvm_oct_configure_common_hw ();cvmx_helper_initialize_packet_io_global ();@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev) } } -cvmx_pko_shutdown ();cvmx_ipd_free_ptr (); --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914180614.GA4299%40fedora.
For more options, visit https://groups.google.com/d/optout.