RISC-V S-mode support
v4 cover RISC-V S-mode support
This patchset allows us runing u-boot in S-mode which is useful on platforms where M-mode runtime firmware is an independent firmware and u-boot is used as last stage OS bootloader.
The patchset based upon git://git.denx.de/u-boot-riscv.git
and is tested on QEMU in both M-mode and S-mode.
For S-mode testing, we have used u-boot.bin as payload of latest BBL (at commit 6ebd0f2a46255d0c76dad3c05b16c1d154795d26) applied with following changes:
machine/emulation.c +6 -0
@@ -162,6 +162,12 @@ static inline int emulate_read_csr(int num, uintptr_t mstatus, uintptr_t* resultswitch (num) { +case CSR_MISA : + *result =read_csr (misa); +return 0 ; +case CSR_MHARTID : + *result =read_csr (mhartid); +return 0 ;case CSR_CYCLE :if (!((counteren >> (CSR_CYCLE -CSR_CYCLE )) &1 ))return -1 ;
Changes since v3:
- Replaced 'u-boot' with 'U-Boot' in commit message
- Dropped 'an' in RISCV_SMODE kconfig option help message
- Added appropriate #ifdef in arch/riscv/lib/interrupts.c
Changes since v2:
- Dropped 'default n" from RISCV_SMODE kconfig option
- Replaced '-smode_' in defconfig names with '_smode_'
Changes since v1:
- Rebased upon latest git://git.denx.de/u-boot-riscv.git
- Add details in cover letter for running u-boot in S-mode using BBL
Anup Patel (3):
riscv: Add kconfig option to run U-Boot in S-mode
riscv: qemu: Use different SYS_TEXT_BASE for S-mode
riscv: Add S-mode defconfigs for QEMU virt machine
arch/riscv/Kconfig | 5 ++++ arch/riscv/cpu/start.S | 33 +++++++++++++++++++++++ arch/riscv/include/asm/encoding.h | 2 ++ arch/riscv/lib/interrupts.c | 36 +++++++++++++++++++------- board/emulation/qemu-riscv/Kconfig | 3 ++- board/emulation/qemu-riscv/MAINTAINERS | 2 ++ configs/qemu-riscv32_smode_defconfig | 10 +++++++ configs/qemu-riscv64_smode_defconfig | 11 ++++++++ 8 files changed, 92 insertions(+), 10 deletions(-) create mode 100644 configs/qemu-riscv32_smode_defconfig create mode 100644 configs/qemu-riscv64_smode_defconfig
Signature · 1 line
2.17.1
PATCH v4 1/3 riscv: Add kconfig option to run U-Boot in S-mode
This patch adds kconfig option RISCV_SMODE to run U-Boot in S-mode. When this opition is enabled we use s<xyz> CSRs instead of m<xyz> CSRs.
It is important to note that there is no equivalent S-mode CSR for misa and mhartid CSRs so we expect M-mode runtime firmware (BBL or equivalent) to emulate misa and mhartid CSR read.
In-future, we will have more patches to avoid accessing misa and mhartid CSRs from S-mode.
--- arch/riscv/Kconfig | 5 +++++ arch/riscv/cpu/start.S | 33 ++++++++++++++++++++++++++++ arch/riscv/include/asm/encoding.h | 2 ++ arch/riscv/lib/interrupts.c | 36 +++++++++++++++++++++++-------- 4 files changed, 67 insertions(+), 9 deletions(-)
arch/riscv/Kconfig +5 -0
@@ -55,6 +55,11 @@ config RISCV_ISA_C config RISCV_ISA_A def_bool y +config RISCV_SMODE + bool "Run in S-Mode" + help + Enable this option to build U-Boot for RISC-V S-Mode + config 32BIT bool
arch/riscv/cpu/start.S +33 -0
@@ -39,10 +39,18 @@ _start: mv s1, a1 la t0, trap_entry +#ifdef CONFIG_RISCV_SMODE + csrw stvec, t0 +#else csrw mtvec, t0 +#endif /* mask all interrupts */ +#ifdef CONFIG_RISCV_SMODE + csrw sie, zero +#else csrw mie, zero +#endif /* Enable cache */ jal icache_enable
@@ -164,7 +172,11 @@ fix_rela_dyn: */ la t0, trap_entry add t0, t0, t6 +#ifdef CONFIG_RISCV_SMODE + csrw stvec, t0 +#else csrw mtvec, t0 +#endif clear_bss: la t0, __bss_start /* t0 <- rel __bss_start in FLASH */
@@ -236,17 +248,34 @@ trap_entry: SREG x29, 29*REGBYTES(sp) SREG x30, 30*REGBYTES(sp) SREG x31, 31*REGBYTES(sp) +#ifdef CONFIG_RISCV_SMODE + csrr a0, scause + csrr a1, sepc +#else csrr a0, mcause csrr a1, mepc +#endif mv a2, sp jal handle_trap +#ifdef CONFIG_RISCV_SMODE + csrw sepc, a0 +#else csrw mepc, a0 +#endif +#ifdef CONFIG_RISCV_SMODE +/* + * Remain in S-mode after sret + */ + li t0, SSTATUS_SPP + csrs sstatus, t0 +#else /* * Remain in M-mode after mret */ li t0, MSTATUS_MPP csrs mstatus, t0 +#endif LREG x1, 1*REGBYTES(sp) LREG x2, 2*REGBYTES(sp) LREG x3, 3*REGBYTES(sp)
@@ -279,4 +308,8 @@ trap_entry: LREG x30, 30*REGBYTES(sp) LREG x31, 31*REGBYTES(sp) addi sp, sp, 32*REGBYTES +#ifdef CONFIG_RISCV_SMODE + sret +#else mret +#endif
arch/riscv/include/asm/encoding.h +2 -0
@@ -143,6 +143,8 @@# define MCAUSE_CAUSE MCAUSE32_CAUSE#endif +#define SCAUSE_INT MCAUSE_INT +#define RISCV_PGSHIFT 12#define RISCV_PGSIZE BIT(RISCV_PGSHIFT)
arch/riscv/lib/interrupts.c +27 -9
@@ -34,17 +34,35 @@ int disable_interrupts(void)return 0 ; } -ulong handle_trap (ulong mcause,ulong epc,struct pt_regs *regs) +ulong handle_trap (ulong cause,ulong epc,struct pt_regs *regs) { -ulong is_int; +ulong is_irq, irq; - is_int = (mcause &MCAUSE_INT ); -if ((is_int) && ((mcause &MCAUSE_CAUSE ) ==IRQ_M_EXT )) -external_interrupt (0 );/* handle_m_ext_interrupt */ -else if ((is_int) && ((mcause &MCAUSE_CAUSE ) ==IRQ_M_TIMER )) -timer_interrupt (0 );/* handle_m_timer_interrupt */ -else -_exit_trap (mcause, epc, regs); +#ifdef CONFIG_RISCV_SMODE + is_irq = (cause &SCAUSE_INT ); + irq = (cause & ~SCAUSE_INT ); +#else + is_irq = (cause &MCAUSE_INT ); + irq = (cause & ~MCAUSE_INT ); +#endif + +if (is_irq) { +switch (irq) { +case IRQ_M_EXT : +case IRQ_S_EXT : +external_interrupt (0 );/* handle external interrupt */ +break ; +case IRQ_M_TIMER : +case IRQ_S_TIMER : +timer_interrupt (0 );/* handle timer interrupt */ +break ; +default : +_exit_trap (cause, epc, regs); +break ; + }; + }else { +_exit_trap (cause, epc, regs); + }return epc; }
Signature · 1 line
2.17.1
PATCH v4 2/3 riscv: qemu: Use different SYS_TEXT_BASE for S-mode
In reply to Anup PatelWhen u-boot runs in S-mode, the M-mode runtime firmware (BBL or equivalent) uses memory range in 0x80000000 to 0x80200000. Due to this, we cannot use 0x80000000 as SYS_TEXT_BASE when running in S-mode. Instead for S-mode, we use 0x80200000 as SYS_TEXT_BASE.
Even Linux RISC-V kernel ignores/reserves memory range 0x80000000 to 0x80200000 because it runs in S-mode.
--- board/emulation/qemu-riscv/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
board/emulation/qemu-riscv/Kconfig +2 -1
@@ -13,7 +13,8 @@ config SYS_CONFIG_NAME default "qemu-riscv" config SYS_TEXT_BASE - default 0x80000000 + default 0x80000000 if !RISCV_SMODE + default 0x80200000 if RISCV_SMODE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y
Signature · 1 line
2.17.1
PATCH v4 3/3 riscv: Add S-mode defconfigs for QEMU virt machine
In reply to Anup PatelThis patch adds S-mode defconfigs for QEMU virt machine so that we can run u-boot in S-mode on QEMU using M-mode runtime firmware (BBL or equivalent).
--- board/emulation/qemu-riscv/MAINTAINERS | 2 ++ configs/qemu-riscv32_smode_defconfig | 10 ++++++++++ configs/qemu-riscv64_smode_defconfig | 11 +++++++++++ 3 files changed, 23 insertions(+) create mode 100644 configs/qemu-riscv32_smode_defconfig create mode 100644 configs/qemu-riscv64_smode_defconfig
board/emulation/qemu-riscv/MAINTAINERS +2 -0
@@ -4,4 +4,6 @@ S: Maintained F: board/emulation/qemu-riscv/ F: include/configs/qemu-riscv.h F: configs/qemu-riscv32_defconfig +F: configs/qemu-riscv32_smode_defconfig F: configs/qemu-riscv64_defconfig +F: configs/qemu-riscv64_smode_defconfig
configs/qemu-riscv32_smode_defconfig new file +10 -0
@@ -0,0 +1,10 @@ +CONFIG_RISCV=y +CONFIG_TARGET_QEMU_VIRT=y +CONFIG_RISCV_SMODE=y +CONFIG_DISTRO_DEFAULTS=y +CONFIG_NR_DRAM_BANKS=1 +CONFIG_FIT=y +CONFIG_DISPLAY_CPUINFO=y +CONFIG_DISPLAY_BOARDINFO=y +# CONFIG_CMD_MII is not set +CONFIG_OF_PRIOR_STAGE=y
configs/qemu-riscv64_smode_defconfig new file +11 -0
@@ -0,0 +1,11 @@ +CONFIG_RISCV=y +CONFIG_TARGET_QEMU_VIRT=y +CONFIG_ARCH_RV64I=y +CONFIG_RISCV_SMODE=y +CONFIG_DISTRO_DEFAULTS=y +CONFIG_NR_DRAM_BANKS=1 +CONFIG_FIT=y +CONFIG_DISPLAY_CPUINFO=y +CONFIG_DISPLAY_BOARDINFO=y +# CONFIG_CMD_MII is not set +CONFIG_OF_PRIOR_STAGE=y
Signature · 1 line
2.17.1
v4 cover RISC-V S-mode support
In reply to Anup PatelHi All,
Is it possible to include this series for next U-Boot release?
Regards,
Anup
A message that is not in the archive (sent off-list or not yet received): [email protected]
v4 cover RISC-V S-mode support
Quoted 5 lines
Hi All,
Is it possible to include this series for next U-Boot release?
Hi Anup
Yes.
I will do some verification.
And prepare the PR ASAP.
Can you prepare a version which will be rebase on the latest u-boot-riscv.git
Thanks
Rick
Quoted 7 lines
Regards,
Anup
v4 cover RISC-V S-mode support
Quoted 7 lines · Rick Chen
Quoted 6 lines
Hi All,
Is it possible to include this series for next U-Boot release?
Quoted 8 lines
Hi Anup
Yes.
I will do some verification.
And prepare the PR ASAP.Can you prepare a version which will be rebase on the latest u-boot-riscv.git
Sure, give me few minutes.
I will send v5 based on:
commit 52923c6db7f00e0197ec894c8c1bb8a7681974bb
riscv: cache: Implement i/dcache [status, enable, disable]
Regards,
Anup
A message that is not in the archive (sent off-list or not yet received): [email protected]
v4 cover RISC-V S-mode support
Quoted 7 lines
Quoted 7 lines
Subject: [PATCH v4 0/3] RISC-V S-mode support
This patchset allows us runing u-boot in S-mode which is useful on platforms where M-mode runtime firmware is an independent firmware and u-boot is used as last stage OS bootloader.
The patchset based upon
git://git.denx.de/u-boot-riscv.git
Hi Anup
I apply your patch-sets fail on u-boot-riscv.git
Can you tell me which commit id I shall base on ?
Rick
Quoted 59 lines
Quoted 58 lines
and is tested on QEMU in both M-mode and S-mode.
For S-mode testing, we have used u-boot.bin as payload of latest BBL (at commit
6ebd0f2a46255d0c76dad3c05b16c1d154795d26)
applied with following changes:machine/emulation.c index 132e977..def75e1 renamed from machine/emulation.c +0
-0100644
machine/emulation.c +0
-0@@ -162,6 +162,12 @@ static inline int emulate_read_csr(int num, uintptr_tmstatus, uintptr_t* result
switch (num) {machine/emulation.c +6
-0+case CSR_MISA : + *result =read_csr (misa); +return 0 ; +case CSR_MHARTID : + *result =read_csr (mhartid); +return 0 ;case CSR_CYCLE :if (!((counteren >> (CSR_CYCLE -CSR_CYCLE )) &1 ))return -1 ;Changes since v3:
- Replaced 'u-boot' with 'U-Boot' in commit message
- Dropped 'an' inRISCV_SMODEkconfig option help message
- Added appropriate #ifdef inarch/riscv/lib/interrupts.cChanges since v2:
- Dropped 'default n" fromRISCV_SMODEkconfig option
- Replaced '-smode_' in defconfig names with '_smode_'Changes since v1:
- Rebased upon latestgit://git.denx.de/u-boot-riscv.git
- Add details in cover letter for running u-boot in S-mode using BBLAnup Patel (3):
riscv: Add kconfig option to run U-Boot in S-mode
riscv: qemu: Use differentSYS_TEXT_BASEfor S-mode
riscv: Add S-mode defconfigs for QEMU virt machinearch/riscv/Kconfig | 5 ++++ arch/riscv/cpu/start.S | 33 +++++++++++++++++++++++ arch/riscv/include/asm/encoding.h | 2 ++ arch/riscv/lib/interrupts.c | 36 +++++++++++++++++++------- board/emulation/qemu-riscv/Kconfig | 3 ++- board/emulation/qemu-riscv/MAINTAINERS | 2 ++ configs/qemu-riscv32_smode_defconfig | 10 +++++++ configs/qemu-riscv64_smode_defconfig | 11 ++++++++ 8 files changed, 92 insertions(+), 10 deletions(-) create mode 100644 configs/qemu-riscv32_smode_defconfig create mode 100644 configs/qemu-riscv64_smode_defconfig--
2.17.1