Skip to contentSkip to conversation

arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)

PATCH Superseded Sunil Mohan Adapa 2 participants 5 messages Aug 22, 2019 – Sep 10, 2019

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)

This is a follow up a patch that didn't create a separate dts:
https://lists.denx.de/pipermail/u-boot/2019-July/379109.html

A64 OLinuXino board from Olimex has three variants with onboard eMMC:
A64-OLinuXino-1Ge16GW, A64-OLinuXino-1Ge4GW and A64-OLinuXino-2Ge8G-IND. In addition, there are two variants without eMMC. One without eMMC and one with SPI flash. This suggests the need for separate device tree for the three eMMC variants.

The Linux kernel upstream has chosen to create and use a separate device tree for the eMMC variants instead of adding eMMC support existing device tree. These changes to Linux kernel are queued for Linux 5.4.

https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?h=sunxi/dt-for-5.4&id=02bb66b347ff8115f53948f86b884e008ba385b9

This patch has been tested on A64-OLinuXino-1Ge16GW and is based on Linux device-tree.

Changes:

v2: Separate device tree for emmc models.

Sunil Mohan Adapa (2):
arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)
configs: sun50i: Add support for Olimex A64-Olinuxino-eMMC

 arch/arm/dts/Makefile                      |  1 +
 arch/arm/dts/sun50i-a64-olinuxino-emmc.dts | 23 ++++++++++++++++++++++
 board/sunxi/MAINTAINERS                    |  5 +++++
 configs/a64-olinuxino-emmc_defconfig       | 17 ++++++++++++++++
 4 files changed, 46 insertions(+)
 create mode 100644 arch/arm/dts/sun50i-a64-olinuxino-emmc.dts
 create mode 100644 configs/a64-olinuxino-emmc_defconfig
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/2 arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)

A64 OLinuXino board from Olimex has three variants with onboard eMMC:
A64-OLinuXino-1Ge16GW, A64-OLinuXino-1Ge4GW and A64-OLinuXino-2Ge8G-IND. In addition, there are two variants without eMMC. One without eMMC and one with SPI flash. This suggests the need for separate device tree for the three eMMC variants.

The Linux kernel upstream has chosen to create and use a separate device tree for the eMMC variants instead of adding eMMC support existing device tree. These changes to Linux kernel are queued for Linux 5.4.

https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?h=sunxi/dt-for-5.4&id=02bb66b347ff8115f53948f86b884e008ba385b9

This patch has been tested on A64-OLinuXino-1Ge16GW and is based on Linux device-tree.

---
 arch/arm/dts/Makefile                      |  1 +
 arch/arm/dts/sun50i-a64-olinuxino-emmc.dts | 23 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 arch/arm/dts/sun50i-a64-olinuxino-emmc.dts
arch/arm/dts/Makefile +1 -0
index 05ff624c07..d28906a63b 100644
@@ -530,6 +530,7 @@ dtb-$(CONFIG_MACH_SUN50I) += \
 	sun50i-a64-nanopi-a64.dtb \
 	sun50i-a64-oceanic-5205-5inmfd.dtb \
 	sun50i-a64-olinuxino.dtb \
+	sun50i-a64-olinuxino-emmc.dtb \
 	sun50i-a64-orangepi-win.dtb \
 	sun50i-a64-pine64-lts.dtb \
 	sun50i-a64-pine64-plus.dtb \
arch/arm/dts/sun50i-a64-olinuxino-emmc.dts new file +23 -0
new file mode 100644
index 0000000000..96ab0227e8
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2018 Martin Ayotte <[email protected]>
+ * Copyright (C) 2019 Sunil Mohan Adapa <[email protected]>
+ */
+
+#include "sun50i-a64-olinuxino.dts"
+
+/ {
+	model = "Olimex A64-Olinuxino-eMMC";
+	compatible = "olimex,a64-olinuxino-emmc", "allwinner,sun50i-a64";
+};
+
+&mmc2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc2_pins>;
+	vmmc-supply = <&reg_dcdc1>;
+	vqmmc-supply = <&reg_dcdc1>;
+	bus-width = <8>;
+	non-removable;
+	cap-mmc-hw-reset;
+	status = "okay";
+};
Signature · 1 line
2.20.1
#2 lore raw

PATCH v2 2/2 configs: sun50i: Add support for Olimex A64-Olinuxino-eMMC

In reply to Sunil Mohan Adapa

A64 OLinuXino board from Olimex has three variants with onboard eMMC:
A64-OLinuXino-1Ge16GW, A64-OLinuXino-1Ge4GW and A64-OLinuXino-2Ge8G-IND. In addition, there are two variants without eMMC. One without eMMC and one with SPI flash. This suggests the need for separate device tree for the three eMMC variants.

The Linux kernel upstream has chosen to create and use a separate device tree for the eMMC variants instead of adding eMMC support existing device tree. These changes to Linux kernel are queued for Linux 5.4.

https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?h=sunxi/dt-for-5.4&id=02bb66b347ff8115f53948f86b884e008ba385b9

Based on a64-olinuxino_defconfig.

This patch has been tested on A64-OLinuXino-1Ge16GW.

---
 board/sunxi/MAINTAINERS              |  5 +++++
 configs/a64-olinuxino-emmc_defconfig | 17 +++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 configs/a64-olinuxino-emmc_defconfig
board/sunxi/MAINTAINERS +5 -0
index c7e9d3eda0..442ff3d9cd 100644
@@ -106,6 +106,11 @@ M:	Jagan Teki <[email protected]>
 S:	Maintained
 F:	configs/a64-olinuxino_defconfig
 
+A64-OLINUXINO-EMMC BOARD
+M:	Sunil Mohan Adapa <[email protected]>
+S:	Maintained
+F:	configs/a64-olinuxino-emmc_defconfig
+
 A80 OPTIMUS BOARD
 M:	Chen-Yu Tsai <[email protected]>
 S:	Maintained
configs/a64-olinuxino-emmc_defconfig new file +17 -0
new file mode 100644
index 0000000000..56153e38a7
@@ -0,0 +1,17 @@
+CONFIG_ARM=y
+CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_SPL=y
+CONFIG_MACH_SUN50I=y
+CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
+CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_USE_PREBOOT=y
+# CONFIG_CMD_FLASH is not set
+# CONFIG_SPL_DOS_PARTITION is not set
+# CONFIG_SPL_EFI_PARTITION is not set
+CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino-emmc"
+CONFIG_SUN8I_EMAC=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
Signature · 1 line
2.20.1
#3 lore raw

v2 cover arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)

In reply to Sunil Mohan Adapa
Quoted 19 lines · Sunil Mohan Adapa

This is a follow up a patch that didn't create a separate dts:
https://lists.denx.de/pipermail/u-boot/2019-July/379109.html

A64 OLinuXino board from Olimex has three variants with onboard eMMC:
A64-OLinuXino-1Ge16GW, A64-OLinuXino-1Ge4GW and A64-OLinuXino-2Ge8G-IND. In addition, there are two variants without eMMC. One without eMMC and one with SPI flash. This suggests the need for separate device tree for the three eMMC variants.

The Linux kernel upstream has chosen to create and use a separate device tree for the eMMC variants instead of adding eMMC support existing device tree. These changes to Linux kernel are queued for Linux 5.4.

https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?h=sunxi/dt-for-5.4&id=02bb66b347ff8115f53948f86b884e008ba385b9

This patch has been tested on A64-OLinuXino-1Ge16GW and is based on Linux device-tree.

Quoted 7 lines

Changes:

v2: Separate device tree for emmc models.

Sunil Mohan Adapa (2):
arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)
configs: sun50i: Add support for Olimex A64-Olinuxino-eMMC

Please squash and send it as single patch, all look fine to me.

#4 lore raw

v2 cover arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)

Quoted 24 lines · Jagan Teki
Quoted 23 lines · Sunil Mohan Adapa

This is a follow up a patch that didn't create a separate dts:
https://lists.denx.de/pipermail/u-boot/2019-July/379109.html

A64 OLinuXino board from Olimex has three variants with onboard eMMC:
A64-OLinuXino-1Ge16GW, A64-OLinuXino-1Ge4GW and A64-OLinuXino-2Ge8G-IND. In addition, there are two variants without eMMC. One without eMMC and one with SPI flash. This suggests the need for separate device tree for the three eMMC variants.

The Linux kernel upstream has chosen to create and use a separate device tree for the eMMC variants instead of adding eMMC support existing device tree. These changes to Linux kernel are queued for Linux 5.4.

https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?h=sunxi/dt-for-5.4&id=02bb66b347ff8115f53948f86b884e008ba385b9

This patch has been tested on A64-OLinuXino-1Ge16GW and is based on Linux device-tree.

Changes:

v2: Separate device tree for emmc models.

Quoted 8 lines
Quoted 3 lines

Sunil Mohan Adapa (2):
arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)
configs: sun50i: Add support for Olimex A64-Olinuxino-eMMC

Please squash and send it as single patch, all look fine to me.

Thank you for reviewing the patch. I have posted v3 with the two patches squashed.

Signature · 9 lines
Sunil

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190910/1dc2b681/attachment.sig>