arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings
Subsystems (2)
PATCH 1/3 arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings
The RockPro64 schematic [1] page 18 states a min voltage of 0.8V and a max voltage of 1.4V for the VDD_LOG pwm regulator. However, there is an additional note that the pwm parameter needs to be modified. From the schematics a voltage range of 0.8V to 1.7V can be calculated. Additional voltage measurements on the board show that this fix indeed leads to the correct voltage, while without this fix the voltage was set too high.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
---
Cc: Heiko Stuebner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +1 -1
@@ -173,7 +173,7 @@ regulator-always-on; regulator-boot-on; regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1400000>; + regulator-max-microvolt = <1700000>; vin-supply = <&vcc5v0_sys>; }; };
--
2.17.1
PATCH 2/3 arm64: dts: rockchip: fix RockPro64 sdhci settings
The RockPro64 schematics [1], [2] show that the rk3399 EMMC_STRB pin is connected to the RESET pin instead of the DATA_STROBE pin of the eMMC module. So the data strobe cannot be used for its intended purpose on this board, and so the HS400 eMMC mode is not functional. Limit the controller to HS200.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
[2] http://files.pine64.org/doc/rock64/PINE64_eMMC_Module_20170719.pdf
---
Cc: Heiko Stuebner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +1 -2
@@ -636,8 +636,7 @@ &sdhci { bus-width = <8>; - mmc-hs400-1_8v; - mmc-hs400-enhanced-strobe; + mmc-hs200-1_8v; non-removable; status = "okay"; };
--
2.17.1
PATCH 3/3 arm64: dts: rockchip: fix RockPro64 sdmmc settings
In reply to Soeren MochAccording to the RockPro64 schematic [1] the rk3399 sdmmc controller is connected to a microSD (TF card) slot, which cannot be switched to 1.8V. So also configure the vcc_sdio regulator, which drives the i/o voltage of the sdmmc controller, accordingly.
While at it, also remove the cap-mmc-highspeed property of the sdmmc controller, since no mmc card can be connected here.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
---
Cc: Heiko Stuebner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +1 -2
@@ -353,7 +353,7 @@ regulator-name = "vcc_sdio"; regulator-always-on; regulator-boot-on; - regulator-min-microvolt = <1800000>; + regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; regulator-state-mem { regulator-on-in-suspend;
@@ -624,7 +624,6 @@ &sdmmc { bus-width = <4>; - cap-mmc-highspeed; cap-sd-highspeed; cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>; disable-wp;
--
2.17.1
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings
Quoted 2 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is connected to a microSD (TF card) slot, which cannot be switched to 1.8V.
Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I know that board can happily drive a UHS-I microSD card with 1.8v I/Os, because mine's doing so right now.
Robin.
Quoted 49 lines
So also configure the
vcc_sdioregulator, which drives the i/o voltage of the sdmmc controller, accordingly.While at it, also remove the cap-mmc-highspeed property of the sdmmc controller, since no mmc card can be connected here.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
Fixes e4f3fb490967 ("arm64: dts: rockchip: add initial dts support for Rockpro64")Signed-off-by Soeren Moch <[email protected]>---
Cc: Heiko Stuebner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +1
-3@@ -353,7 +353,7 @@ regulator-name = "vcc_sdio"; regulator-always-on; regulator-boot-on; - regulator-min-microvolt = <1800000>; + regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; regulator-state-mem { regulator-on-in-suspend;@@ -624,7 +624,6 @@ &sdmmc { bus-width = <4>; - cap-mmc-highspeed; cap-sd-highspeed; cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>; disable-wp; --2.17.1
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings
Quoted 10 lines · Robin Murphy
Quoted 2 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is connected to a microSD (TF card) slot, which cannot be switched to 1.8V.
Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I know that board can happily drive a UHS-I microSD card with 1.8v I/Os, because mine's doing so right now.
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since VCC3V0_SD is directly connected to VCC3V3_SYS (via R89555), the SDMMC0_PWH_H signal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.
Regards,
Soeren
Quoted 47 lines
Quoted 47 lines
So also configure the
vcc_sdioregulator, which drives the i/o voltage of the sdmmc controller, accordingly.While at it, also remove the cap-mmc-highspeed property of the sdmmc controller, since no mmc card can be connected here.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
Fixes e4f3fb490967 ("arm64: dts: rockchip: add initial dts supportfor Rockpro64")
Signed-off-by Soeren Moch <[email protected]>---
Cc: Heiko Stuebner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +1
-2@@ -353,7 +353,7 @@ regulator-name = "vcc_sdio"; regulator-always-on; regulator-boot-on; - regulator-min-microvolt = <1800000>; + regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; regulator-state-mem { regulator-on-in-suspend;@@ -624,7 +624,6 @@ &sdmmc { bus-width = <4>; - cap-mmc-highspeed; cap-sd-highspeed; cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>; disable-wp;Signature · 1 line
2.17.1
Quoted 5 lines
Quoted 5 lines
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
Quoted 12 lines · Soeren Moch
Quoted 9 lines · Robin Murphy
Quoted 2 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is connected to a microSD (TF card) slot, which cannot be switched to 1.8V.
Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I know that board can happily drive a UHS-I microSD card with 1.8v I/Os, because mine's doing so right now.
Quoted 6 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.
I believe we addressed this issue long time ago, please check:
Quoted 60 lines
Regards,
SoerenQuoted 47 lines
Quoted 47 lines
So also configure the
vcc_sdioregulator, which drives the i/o voltage of the sdmmc controller, accordingly.While at it, also remove the cap-mmc-highspeed property of the sdmmc controller, since no mmc card can be connected here.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
Fixes e4f3fb490967 ("arm64: dts: rockchip: add initial dts supportfor Rockpro64")
Signed-off-by Soeren Moch <[email protected]>---
Cc: Heiko Stuebner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +1
-2@@ -353,7 +353,7 @@ regulator-name = "vcc_sdio"; regulator-always-on; regulator-boot-on; - regulator-min-microvolt = <1800000>; + regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; regulator-state-mem { regulator-on-in-suspend;@@ -624,7 +624,6 @@ &sdmmc { bus-width = <4>; - cap-mmc-highspeed; cap-sd-highspeed; cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>; disable-wp;Signature · 1 line
2.17.1Quoted 5 lines
Quoted 5 lines
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Signature · 9 lines
Best Regards Shawn Lin _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
Quoted 22 lines · Shawn Lin
Quoted 14 lines · Soeren Moch
Quoted 11 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I know that board can happily drive a UHS-I microSD card with 1.8v I/Os, because mine's doing so right now.
Quoted 6 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.
Quoted 4 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:
rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +0 -0
@@ -619,6 +619,8 @@
max-frequency = <150000000>;
pinctrl-names = "default";
pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
+ sd-uhs-sdr104;
+ vqmmc-supply = <&vcc_sdio>;
status = "okay";
};
When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId = 0x0
ChipType = 0x10, 286Spi_ChipId = c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1
So I guess I should use a different miniloader for this reboot to work!? Or what else could be wrong here?
Thanks,
Soeren
Quoted 49 lines
Quoted 49 lines
Regards,
SoerenQuoted 47 lines
Quoted 47 lines
So also configure the
vcc_sdioregulator, which drives the i/o voltage of the sdmmc controller, accordingly.While at it, also remove the cap-mmc-highspeed property of the sdmmc controller, since no mmc card can be connected here.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
Fixes e4f3fb490967 ("arm64: dts: rockchip: add initial dts supportfor Rockpro64")
Signed-off-by Soeren Moch <[email protected]>---
Cc: Heiko Stuebner <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +1
-2@@ -353,7 +353,7 @@ regulator-name = "vcc_sdio"; regulator-always-on; regulator-boot-on; - regulator-min-microvolt = <1800000>; + regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; regulator-state-mem { regulator-on-in-suspend;@@ -624,7 +624,6 @@ &sdmmc { bus-width = <4>; - cap-mmc-highspeed; cap-sd-highspeed; cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>; disable-wp;--
2.17.1
Quoted 13 lines
Quoted 11 lines
Quoted 5 lines
Quoted 5 lines
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
Quoted 18 lines · Soeren Moch
Quoted 15 lines · Shawn Lin
Quoted 14 lines · Soeren Moch
Quoted 11 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I know that board can happily drive a UHS-I microSD card with 1.8v I/Os, because mine's doing so right now.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.
Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 44 lines
Quoted 5 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1
Quoted 2 lines
So I guess I should use a different miniloader for this reboot to work!? Or what else could be wrong here?
Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the offending card is itself the boot medium. There was a proposal here:
https://patchwork.kernel.org/patch/10817217/
although I'm not sure what if any progress has been made since then.
Robin.
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
Quoted 75 lines · Robin Murphy
Quoted 15 lines · Soeren Moch
Quoted 13 lines · Shawn Lin
Quoted 12 lines · Soeren Moch
Quoted 10 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I know that board can happily drive a UHS-I microSD card with 1.8v I/Os, because mine's doing so right now.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 43 lines
Quoted 4 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 2 lines
So I guess I should use a different miniloader for this reboot to work!? Or what else could be wrong here?
Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the offending card is itself the boot medium. There was a proposal here:
Quoted 3 lines
https://patchwork.kernel.org/patch/10817217/
although I'm not sure what if any progress has been made since then.
Correct, I never got around to complete testing on other devices.
Maybe someone more familiar with mmc subsystem can pick that up if it now turns out other devices show the same/similar issue?
fwiw the "mmc: core: set initial signal voltage on power off" rfc/patch have been used in LibreELEC rockchip builds for well over a year now.
Regards,
Jonas
Quoted 3 lines
Robin.
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
In reply to Robin MurphyQuoted 71 lines · Robin Murphy
Quoted 18 lines · Soeren Moch
Quoted 15 lines · Shawn Lin
Quoted 14 lines · Soeren Moch
Quoted 11 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I know that board can happily drive a UHS-I microSD card with 1.8v I/Os, because mine's doing so right now.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 44 lines
Quoted 6 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1
Quoted 4 lines
Quoted 2 lines
So I guess I should use a different miniloader for this reboot to work!? Or what else could be wrong here?
Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0
My initial plan was to patching upstream kernel by adding ->shutdown,but never finish it.
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Quoted 7 lines
although I'm not sure what if any progress has been made since then.
Robin.
Signature · 9 lines
Best Regards Shawn Lin _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
In reply to Robin MurphyQuoted 27 lines · Robin Murphy
Quoted 20 lines · Soeren Moch
Quoted 17 lines · Shawn Lin
Quoted 16 lines · Soeren Moch
Quoted 13 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.
Quoted 4 lines
Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Agreed. I should have been more precise about this in the commit message.
Soeren
Quoted 57 lines
Quoted 45 lines
Quoted 7 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 2 lines
So I guess I should use a different miniloader for this reboot to work!? Or what else could be wrong here?
Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the offending card is itself the boot medium. There was a proposal here:
https://patchwork.kernel.org/patch/10817217/
although I'm not sure what if any progress has been made since then.
Robin.
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
In reply to Shawn LinQuoted 93 lines · Shawn Lin
Quoted 76 lines · Robin Murphy
Quoted 20 lines · Soeren Moch
Quoted 17 lines · Shawn Lin
Quoted 16 lines · Soeren Moch
Quoted 13 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 44 lines
Quoted 6 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 7 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0My initial plan was to patching upstream kernel by adding ->shutdown,but never finish it.
Quoted 6 lines
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally against the specification, can lead to all kinds of strange behaviour and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses the i/o voltage from the card configuration and switches the controller accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with good luck. Even if the kernel driver would switch the regulator back to 1.8V in this case, the voltage mismatch remains in the bootloader when this card contains the boot image.
The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader and u-boot SPL since both bootloader chains are supported for this board).
Or maybe I miss something?
Soeren
Quoted 10 lines
Quoted 8 lines
although I'm not sure what if any progress has been made since then.
Robin.
Am Donnerstag, 3. Oktober 2019, 23:50:34 CEST schrieb Soeren Moch:
Quoted 8 lines
The RockPro64 schematic [1] page 18 states a min voltage of 0.8V and a max voltage of 1.4V for the
VDD_LOGpwm regulator. However, there is an additional note that the pwm parameter needs to be modified. From the schematics a voltage range of 0.8V to 1.7V can be calculated. Additional voltage measurements on the board show that this fix indeed leads to the correct voltage, while without this fix the voltage was set too high.
Quoted 4 lines
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
Fixes e4f3fb490967 ("arm64: dts: rockchip: add initial dts support for Rockpro64")Signed-off-by Soeren Moch <[email protected]>
applied as fix for 5.4
Thanks for going that extra mile with all the calculations and measurements Heiko
Re: [PATCH 2/3] arm64: dts: rockchip: fix RockPro64 sdhci settings
In reply to Soeren MochAm Donnerstag, 3. Oktober 2019, 23:50:35 CEST schrieb Soeren Moch:
Quoted 10 lines
The RockPro64 schematics [1], [2] show that the rk3399
EMMC_STRBpin is connected to the RESET pin instead of theDATA_STROBEpin of the eMMC module. So the data strobe cannot be used for its intended purpose on this board, and so the HS400 eMMC mode is not functional. Limit the controller to HS200.[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
[2] http://files.pine64.org/doc/rock64/PINE64_eMMC_Module_20170719.pdfFixes e4f3fb490967 ("arm64: dts: rockchip: add initial dts support for Rockpro64")Signed-off-by Soeren Moch <[email protected]>
applied as fix for 5.4
Thanks
Heiko
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
In reply to Sören MochHeiko,
since you started to apply the first 2 Patches of this series (thanks for that!), now after all the discussions here (and the heads-up for the implemented mode detection) I think we should leave the vcc_sdio regulator settings unmodified.
It still could make sense to remove the cap-mmc-highspeed property. Are you OK with a V2 patch for that?
Thanks,
Soeren
Quoted 107 lines · Sören Moch
Quoted 83 lines · Shawn Lin
Quoted 71 lines · Robin Murphy
Quoted 17 lines · Soeren Moch
Quoted 15 lines · Shawn Lin
Quoted 14 lines · Soeren Moch
Quoted 12 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 43 lines
Quoted 5 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 6 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0Quoted 8 lines
My initial plan was to patching upstream kernel by adding ->shutdown,but never finish it.
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally against the specification, can lead to all kinds of strange behaviour and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses the i/o voltage from the card configuration and switches the controller accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with good luck. Even if the kernel driver would switch the regulator back to 1.8V in this case, the voltage mismatch remains in the bootloader when this card contains the boot image.
Quoted 17 lines
The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader and u-boot SPL since both bootloader chains are supported for this board).
Or maybe I miss something?
Soeren
Quoted 7 lines
Quoted 6 lines
although I'm not sure what if any progress has been made since then.
Robin.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Heiko Stuebner
maintainerRe: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
Hi Sören,
Am Freitag, 4. Oktober 2019, 22:15:45 CEST schrieb Soeren Moch:
Quoted 6 lines
Heiko,
since you started to apply the first 2 Patches of this series (thanks for that!), now after all the discussions here (and the heads-up for the implemented mode detection) I think we should leave the
vcc_sdioregulator settings unmodified.
I was composing a mail about me holding off on this patch due to the ongoing discussion when your mail came ;-)
Quoted 2 lines
It still could make sense to remove the cap-mmc-highspeed property. Are you OK with a V2 patch for that?
Sure, go ahead.
Heiko
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
Quoted 9 lines · Heiko Stuebner
Hi Sören,
Am Freitag, 4. Oktober 2019, 22:15:45 CEST schrieb Soeren Moch:
Quoted 6 lines
Heiko,
since you started to apply the first 2 Patches of this series (thanks for that!), now after all the discussions here (and the heads-up for the implemented mode detection) I think we should leave the
vcc_sdioregulator settings unmodified.
Quoted 7 lines
I was composing a mail about me holding off on this patch due to the ongoing discussion when your mail came ;-)
Quoted 2 lines
It still could make sense to remove the cap-mmc-highspeed property. Are you OK with a V2 patch for that?
Sure, go ahead.
OK, I sent a V2 patch for that.
Maybe someone can come up with a real solution for the 1.8V/3.3V problem, which would allow to enable the uhs-sdr104 mode by default. For now I think we have to live with sd-highspeed to be able to (re-)boot from SD.
Thanks,
Soeren
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】
In reply to Sören MochQuoted 107 lines · Sören Moch
Quoted 83 lines · Shawn Lin
Quoted 71 lines · Robin Murphy
Quoted 17 lines · Soeren Moch
Quoted 15 lines · Shawn Lin
Quoted 14 lines · Soeren Moch
Quoted 12 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 43 lines
Quoted 5 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 6 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0Quoted 8 lines
My initial plan was to patching upstream kernel by adding ->shutdown,but never finish it.
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally against the specification, can lead to all kinds of strange behaviour and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses the i/o voltage from the card configuration and switches the controller accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with good luck. Even if the kernel driver would switch the regulator back to 1.8V in this case, the voltage mismatch remains in the bootloader when this card contains the boot image.
Quoted 5 lines
The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader and u-boot SPL since both bootloader chains are supported for this board).
Or maybe I miss something?
Thanks for your input, I have made a new series [1] with a similar approach but is limited to dw_mmc-rockchip
and only changes the regulator at power_off after the regulator has been disabled (the vqmmc regulator in affected devices is always-on).
To my knowledge the problem is not with the rockchip miniloader or u-boot SPL, it is the initial boot rom that tries to load the miniloader/SPL from a SD-card, so nothing that can be updated.
I have observed this issue on the following devices, and the patches at [1] makes it possible to reboot from SD-card after UHS has been enabled.
- Asus Tinker Board (RK3288)
- Rockchip Sapphire Board (RK3399)
- Radxa Rock Pi 4 (RK3399)
- Pine64 RockPro64 (RK3399)
All of the above seem to use the RK808 regulator for sd io voltage.
The ROC-RK3328-CC did not have this issue and seem to automatically reset to 3.3v.
[1] https://github.com/Kwiboo/linux-rockchip/compare/next-20191011...next-20191011-mmc
Regards,
Jonas
Quoted 8 lines
Soeren
Quoted 4 lines
Quoted 4 lines
although I'm not sure what if any progress has been made since then.
Robin.
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings
Quoted 105 lines · Jonas Karlman
Quoted 104 lines · Sören Moch
Quoted 81 lines · Shawn Lin
Quoted 69 lines · Robin Murphy
Quoted 15 lines · Soeren Moch
Quoted 14 lines · Shawn Lin
Quoted 13 lines · Soeren Moch
Quoted 12 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 43 lines
Quoted 5 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 6 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0Quoted 8 lines
My initial plan was to patching upstream kernel by adding ->shutdown,but never finish it.
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally against the specification, can lead to all kinds of strange behaviour and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses the i/o voltage from the card configuration and switches the controller accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with good luck. Even if the kernel driver would switch the regulator back to 1.8V in this case, the voltage mismatch remains in the bootloader when this card contains the boot image.
Quoted 7 lines
Quoted 5 lines
The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader and u-boot SPL since both bootloader chains are supported for this board).
Or maybe I miss something?
Thanks for your input, I have made a new series [1] with a similar approach but is limited to dw_mmc-rockchip
and only changes the regulator atpower_offafter the regulator has been disabled (the vqmmc regulator in affected devices is always-on).
Thanks for your work on this. Unfortunately I still think that this is the wrong approach.
I see several problems in your patch series:
- You introduced GPIO0_PA1 as regulator enable for RockPro64. Unfortunately Pine64 decided to disable this regulator on Board Version 2.1 (real product version), see above. I have no idea why they did this.
- You changed the i/o voltage from 3.0V to 3.3V. This is not allowed on RK3399 I/O bank F.
Changing the i/o voltage to 3.0V/3.3V while the sd card is configured for 1.8V is against the specification and dangerous. While experimenting with different images (ayufan, armbian) for my newly bought RockPro64 I killed a SD card (32GB Samsung UHS-I). I cannot reconstruct the exact circumstances, but I'm pretty sure this happened due to the voltage mismatch. Of course I'm not keen to experiment further with this and kill more sd cards. This is not just an theoretical issue.
Quoted 2 lines
To my knowledge the problem is not with the rockchip miniloader or u-boot SPL, it is the initial boot rom that tries to load the miniloader/SPL from a SD-card, so nothing that can be updated.
What I observed on my RockPro64:
The ROM bootloader always was able to load the next stage, maybe due to the low initial clock of 400kHz? Also the ROM bootloader cannot change voltage regulator settings. So if the i/o voltage still is at 1.8V and matching the sd card setting, there is no problem for the ROM bootloader. So I think the normal reboot handling should be:
If the sd card can be switched off (preferred solution), do so and reset the controller i/o voltage to 3.0V/3.3V.
If the sd card can not be switched off, make sure to leave the controller i/o voltage at the current setting. Make sure in later boot stages to not change the controller i/o voltage to 3.0V/3.3V when the card is configured for 1.8V. According to the patch mentioned above this behaviour already is implemented in linux, we also need this for the bootloaders.
Regards,
Soeren
Quoted 8 lines
I have observed this issue on the following devices, and the patches at [1] makes it possible to reboot from SD-card after UHS has been enabled.
- Asus Tinker Board (RK3288)
- Rockchip Sapphire Board (RK3399)
- Radxa Rock Pi 4 (RK3399)
- Pine64 RockPro64 (RK3399)
All of the above seem to use the RK808 regulator for sd io voltage.
Quoted 14 lines
The ROC-RK3328-CC did not have this issue and seem to automatically reset to 3.3v.
[1] https://github.com/Kwiboo/linux-rockchip/compare/next-20191011...next-20191011-mmc
Regards,
JonasQuoted 7 lines
Soeren
Quoted 4 lines
Quoted 4 lines
although I'm not sure what if any progress has been made since then.
Robin.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings
Quoted 131 lines · Soeren Moch
Quoted 105 lines · Jonas Karlman
Quoted 104 lines · Sören Moch
Quoted 81 lines · Shawn Lin
Quoted 69 lines · Robin Murphy
Quoted 15 lines · Soeren Moch
Quoted 14 lines · Shawn Lin
Quoted 13 lines · Soeren Moch
Quoted 12 lines · Robin Murphy
Quoted 4 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to 1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 43 lines
Quoted 5 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 6 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0Quoted 8 lines
My initial plan was to patching upstream kernel by adding ->shutdown,but never finish it.
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally against the specification, can lead to all kinds of strange behaviour and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses the i/o voltage from the card configuration and switches the controller accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with good luck. Even if the kernel driver would switch the regulator back to 1.8V in this case, the voltage mismatch remains in the bootloader when this card contains the boot image.
Quoted 7 lines
Quoted 5 lines
The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader and u-boot SPL since both bootloader chains are supported for this board).
Or maybe I miss something?
Thanks for your input, I have made a new series [1] with a similar approach but is limited to dw_mmc-rockchip
and only changes the regulator atpower_offafter the regulator has been disabled (the vqmmc regulator in affected devices is always-on).Thanks for your work on this. Unfortunately I still think that this is the wrong approach.
I see several problems in your patch series:
- You introducedGPIO0_PA1as regulator enable for RockPro64. Unfortunately Pine64 decided to disable this regulator on Board Version 2.1 (real product version), see above. I have no idea why they did this.
- You changed the i/o voltage from 3.0V to 3.3V. This is not allowed on RK3399 I/O bank F.Changing the i/o voltage to 3.0V/3.3V while the sd card is configured for 1.8V is against the specification and dangerous. While experimenting with different images (ayufan, armbian) for my newly bought RockPro64 I killed a SD card (32GB Samsung UHS-I). I cannot reconstruct the exact circumstances, but I'm pretty sure this happened due to the voltage mismatch. Of course I'm not keen to experiment further with this and kill more sd cards. This is not just an theoretical issue.
Quoted 7 lines
Quoted 2 lines
To my knowledge the problem is not with the rockchip miniloader or u-boot SPL, it is the initial boot rom that tries to load the miniloader/SPL from a SD-card, so nothing that can be updated.
What I observed on my RockPro64:
The ROM bootloader always was able to load the next stage, maybe due to the low initial clock of 400kHz? Also the ROM bootloader cannot change voltage regulator settings. So if the i/o voltage still is at 1.8V and matching the sd card setting, there is no problem for the ROM bootloader.
Hmm, that makes me wonder if the problem might be not so much that the level of SDMMC0_VDD itself stays at 1.8V, but that at some point after the bootrom the GRF_IO_VSEL bit gets reset so the controller just stops being able to read anything as logic-high.
Robin.
Quoted 36 lines
So I think the normal reboot handling should be:
If the sd card can be switched off (preferred solution), do so and reset the controller i/o voltage to 3.0V/3.3V.
If the sd card can not be switched off, make sure to leave the controller i/o voltage at the current setting. Make sure in later boot stages to not change the controller i/o voltage to 3.0V/3.3V when the card is configured for 1.8V. According to the patch mentioned above this behaviour already is implemented in linux, we also need this for the bootloaders.Regards,
SoerenQuoted 22 lines
I have observed this issue on the following devices, and the patches at [1] makes it possible to reboot from SD-card after UHS has been enabled.
- Asus Tinker Board (RK3288)
- Rockchip Sapphire Board (RK3399)
- Radxa Rock Pi 4 (RK3399)
- Pine64 RockPro64 (RK3399)
All of the above seem to use the RK808 regulator for sd io voltage.The ROC-RK3328-CC did not have this issue and seem to automatically reset to 3.3v.
[1] https://github.com/Kwiboo/linux-rockchip/compare/next-20191011...next-20191011-mmc
Regards,
JonasQuoted 7 lines
Soeren
Quoted 4 lines
Quoted 4 lines
although I'm not sure what if any progress has been made since then.
Robin.
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings
Quoted 155 lines · Robin Murphy
Quoted 147 lines · Soeren Moch
Quoted 122 lines · Jonas Karlman
Quoted 121 lines · Sören Moch
Quoted 91 lines · Shawn Lin
Quoted 74 lines · Robin Murphy
Quoted 17 lines · Soeren Moch
Quoted 16 lines · Shawn Lin
Quoted 15 lines · Soeren Moch
Quoted 14 lines · Robin Murphy
Quoted 5 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to
1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the
NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify
itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 45 lines
Quoted 6 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 6 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0My initial plan was to patching upstream kernel by adding ->shutdown,but
never finish it.Quoted 5 lines
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally
against the specification, can lead to all kinds of strange behaviour and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses
the i/o voltage from the card configuration and switches the controller
accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with
good luck. Even if the kernel driver would switch the regulator back to
1.8V in this case, the voltage mismatch remains in the bootloader when this card contains the boot image.The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader and u-boot SPL since both bootloader chains are supported for this board).
Quoted 5 lines
Quoted 1 line
Or maybe I miss something?
Thanks for your input, I have made a new series [1] with a similar approach but is limited to dw_mmc-rockchip
and only changes the regulator atpower_offafter the regulator has been disabled (the vqmmc regulator in affected devices is always-on).Thanks for your work on this. Unfortunately I still think that this is the wrong approach.
I see several problems in your patch series:
- You introducedGPIO0_PA1as regulator enable for RockPro64. Unfortunately Pine64 decided to disable this regulator on Board Version 2.1 (real product version), see above. I have no idea why they did this.
- You changed the i/o voltage from 3.0V to 3.3V. This is not allowed on RK3399 I/O bank F.Changing the i/o voltage to 3.0V/3.3V while the sd card is configured for 1.8V is against the specification and dangerous. While experimenting with different images (ayufan, armbian) for my newly bought RockPro64 I killed a SD card (32GB Samsung UHS-I). I cannot reconstruct the exact circumstances, but I'm pretty sure this happened due to the voltage mismatch. Of course I'm not keen to experiment further with this and kill more sd cards. This is not just an theoretical issue.
Quoted 3 lines
To my knowledge the problem is not with the rockchip miniloader or u-boot SPL, it is the initial boot rom that tries to load the miniloader/SPL from a SD-card, so nothing that can be updated.
Quoted 6 lines
What I observed on my RockPro64:
The ROM bootloader always was able to load the next stage, maybe due to the low initial clock of 400kHz? Also the ROM bootloader cannot change voltage regulator settings. So if the i/o voltage still is at 1.8V and matching the sd card setting, there is no problem for the ROM bootloader.
Quoted 4 lines
Hmm, that makes me wonder if the problem might be not so much that the level of
SDMMC0_VDDitself stays at 1.8V, but that at some point after the bootrom theGRF_IO_VSELbit gets reset so the controller just stops being able to read anything as logic-high.
Would be great if someone from Rockchip could give some insights whether and when during reboot GRF_IO_VSEL is reset (ATF before reboot, some SoC soft-reset, ROM bootloader, rkminiloader, something different), Shawn? Or gets this VSEL changed only when switching the voltage regulator (via io_domains,sdmmc-supply)?
Soeren
Quoted 43 lines
Robin.
Quoted 40 lines
So I think the normal reboot handling should be:
If the sd card can be switched off (preferred solution), do so and reset the controller i/o voltage to 3.0V/3.3V.
If the sd card can not be switched off, make sure to leave the controller i/o voltage at the current setting. Make sure in later boot stages to not change the controller i/o voltage to 3.0V/3.3V when the card is configured for 1.8V. According to the patch mentioned above this behaviour already is implemented in linux, we also need this for the bootloaders.Regards,
SoerenQuoted 26 lines
I have observed this issue on the following devices, and the patches at [1] makes it possible to reboot from SD-card after UHS has been enabled.
- Asus Tinker Board (RK3288)
- Rockchip Sapphire Board (RK3399)
- Radxa Rock Pi 4 (RK3399)
- Pine64 RockPro64 (RK3399)
All of the above seem to use the RK808 regulator for sd io voltage.The ROC-RK3328-CC did not have this issue and seem to automatically reset to 3.3v.
[1]
https://github.com/Kwiboo/linux-rockchip/compare/next-20191011...next-20191011-mmcRegards,
JonasQuoted 7 lines
Soeren
Quoted 4 lines
Quoted 4 lines
although I'm not sure what if any progress has been made since then.
Robin.
Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings
Quoted 156 lines · Soeren Moch
Quoted 155 lines · Robin Murphy
Quoted 153 lines · Soeren Moch
Quoted 122 lines · Jonas Karlman
Quoted 121 lines · Sören Moch
Quoted 91 lines · Shawn Lin
Quoted 74 lines · Robin Murphy
Quoted 17 lines · Soeren Moch
Quoted 16 lines · Shawn Lin
Quoted 15 lines · Soeren Moch
Quoted 14 lines · Robin Murphy
Quoted 5 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc controller is
connected to a microSD (TF card) slot, which cannot be switched to
1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the
NanoPC-T4 schematic (it's the same reference design, after all), and I
know that board can happily drive a UHS-I microSD card with 1.8v I/Os,
because mine's doing so right now.Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify
itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be switched" as "switching can lead to other problems".
Quoted 45 lines
Quoted 6 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 renamed from rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 6 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0My initial plan was to patching upstream kernel by adding ->shutdown,but
never finish it.Quoted 5 lines
Quoted 3 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally
against the specification, can lead to all kinds of strange behaviour and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses
the i/o voltage from the card configuration and switches the controller
accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with
good luck. Even if the kernel driver would switch the regulator back to
1.8V in this case, the voltage mismatch remains in the bootloader when this card contains the boot image.The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader and u-boot SPL since both bootloader chains are supported for this board).
Quoted 5 lines
Quoted 1 line
Or maybe I miss something?
Thanks for your input, I have made a new series [1] with a similar approach but is limited to dw_mmc-rockchip
and only changes the regulator atpower_offafter the regulator has been disabled (the vqmmc regulator in affected devices is always-on).Thanks for your work on this. Unfortunately I still think that this is the wrong approach.
I see several problems in your patch series:
- You introducedGPIO0_PA1as regulator enable for RockPro64. Unfortunately Pine64 decided to disable this regulator on Board Version 2.1 (real product version), see above. I have no idea why they did this.
- You changed the i/o voltage from 3.0V to 3.3V. This is not allowed on RK3399 I/O bank F.Changing the i/o voltage to 3.0V/3.3V while the sd card is configured for 1.8V is against the specification and dangerous. While experimenting with different images (ayufan, armbian) for my newly bought RockPro64 I killed a SD card (32GB Samsung UHS-I). I cannot reconstruct the exact circumstances, but I'm pretty sure this happened due to the voltage mismatch. Of course I'm not keen to experiment further with this and kill more sd cards. This is not just an theoretical issue.
Quoted 3 lines
To my knowledge the problem is not with the rockchip miniloader or u-boot SPL, it is the initial boot rom that tries to load the miniloader/SPL from a SD-card, so nothing that can be updated.
What I observed on my RockPro64:
The ROM bootloader always was able to load the next stage, maybe due to the low initial clock of 400kHz? Also the ROM bootloader cannot change voltage regulator settings. So if the i/o voltage still is at 1.8V and matching the sd card setting, there is no problem for the ROM bootloader.
Quoted 7 lines
Quoted 4 lines
Hmm, that makes me wonder if the problem might be not so much that the level of
SDMMC0_VDDitself stays at 1.8V, but that at some point after the bootrom theGRF_IO_VSELbit gets reset so the controller just stops being able to read anything as logic-high.Would be great if someone from Rockchip could give some insights whether and when during reboot
GRF_IO_VSELis reset (ATF before reboot, some SoC soft-reset, ROM bootloader, rkminiloader, something different), Shawn?
ROM code and miniloader never touch this GRF_IO_VSEL for sdmmc, and only kernel did since now it support UHS mode. After reboot, the value should depends on the (value-in-kernel && does-reboot-level-hold-this-reg?)
Different SoCs+PMICs excute differents reboot level policy.
Quoted 52 lines
Or gets this VSEL changed only when switching the voltage regulator (via io_domains,sdmmc-supply)?
Soeren
Quoted 43 lines
Robin.
Quoted 40 lines
So I think the normal reboot handling should be:
If the sd card can be switched off (preferred solution), do so and reset the controller i/o voltage to 3.0V/3.3V.
If the sd card can not be switched off, make sure to leave the controller i/o voltage at the current setting. Make sure in later boot stages to not change the controller i/o voltage to 3.0V/3.3V when the card is configured for 1.8V. According to the patch mentioned above this behaviour already is implemented in linux, we also need this for the bootloaders.Regards,
SoerenQuoted 26 lines
I have observed this issue on the following devices, and the patches at [1] makes it possible to reboot from SD-card after UHS has been enabled.
- Asus Tinker Board (RK3288)
- Rockchip Sapphire Board (RK3399)
- Radxa Rock Pi 4 (RK3399)
- Pine64 RockPro64 (RK3399)
All of the above seem to use the RK808 regulator for sd io voltage.The ROC-RK3328-CC did not have this issue and seem to automatically reset to 3.3v.
[1]
https://github.com/Kwiboo/linux-rockchip/compare/next-20191011...next-20191011-mmcRegards,
JonasQuoted 7 lines
Soeren
Quoted 4 lines
Quoted 4 lines
although I'm not sure what if any progress has been made since then.
Robin.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 3/3 arm64: dts: rockchip: fix RockPro64 sdmmc settings
Quoted 184 lines · Shawn Lin
Quoted 175 lines · Soeren Moch
Quoted 174 lines · Robin Murphy
Quoted 172 lines · Soeren Moch
Quoted 135 lines · Jonas Karlman
Quoted 134 lines · Sören Moch
Quoted 100 lines · Shawn Lin
Quoted 81 lines · Robin Murphy
Quoted 19 lines · Soeren Moch
Quoted 18 lines · Shawn Lin
Quoted 17 lines · Soeren Moch
Quoted 16 lines · Robin Murphy
Quoted 5 lines · Soeren Moch
According to the RockPro64 schematic [1] the rk3399 sdmmc
controller is
connected to a microSD (TF card) slot, which cannot be
switched to
1.8V.Really? AFAICS the SDMMC0 wiring looks pretty much identical to the
NanoPC-T4 schematic (it's the same reference design, after all),
and I
know that board can happily drive a UHS-I microSD card with 1.8v
I/Os,
because mine's doing so right now.Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Robin.
OK, the RockPro64 does not allow a card reset (power cycle) since
VCC3V0_SDis directly connected toVCC3V3_SYS(via R89555), theSDMMC0_PWH_Hsignal is not connected. So the card fails to identify
itself after suspend or reboot when switched to 1.8V operation.Ah, thanks for clarifying - I did overlook the subtlety that U12 and
friends have "NC" as alternative part numbers, even though they aren't actually marked as DNP. So it's still not so much "cannot be
switched" as "switching can lead to other problems".Quoted 47 lines
Quoted 7 lines
I believe we addressed this issue long time ago, please check:
Thanks for the pointer.
In this case I guess I should use following patch instead:--- rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200
+++ rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200(quoted diff) +2
-0@@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; };When I do so, the sd card is detected as SDR104, but a reboot hangs:
Boot1: 2018-06-26, version: 1.14
CPUId =0x0
ChipType =0x10, 286Spi_ChipId= c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
mmc0:cmd5,32
mmc0:cmd7,32
SdmmcInit=0 1Quoted 6 lines
Quoted 3 lines
So I guess I should use a different miniloader for this reboot to work!?
Or what else could be wrong here?Hmm, I guess this is "the Tinkerboard problem" again - the patch above would be OK if we could get as far as the kernel, but can't help if the
I didn't realize that SD was used as boot medium for RockPro64, but I
did patch the vendor tree to solve the issue for Tinkerboard, see
https://github.com/rockchip-linux/kernel/commit/a4ccde21f5a9f04f996fb02479cb9f16d3dc8dc0My initial plan was to patching upstream kernel by adding ->shutdown,but
never finish it.Quoted 6 lines
Quoted 4 lines
offending card is itself the boot medium. There was a proposal here:
This RFC also looks good to me, but seems it needs volunteers to push it again.
Oh, I think this is a totally wrong way.
While this might work for some cards, setting the controller's i/o voltage to 3.3V while leaving the card at 1.8V configuration is totally
against the specification, can lead to all kinds of strange behaviour
and even cause hardware damage. It also would actively defend the purpose of the above mentioned patch (6a11fc4) where the kernel guesses
the i/o voltage from the card configuration and switches the controller
accordingly. We would end up with a 1.8V card and controller configuration and a regulator voltage of 3.3V. This would only work with
good luck. Even if the kernel driver would switch the regulator back to
1.8V in this case, the voltage mismatch remains in the bootloader when
this card contains the boot image.The only sane way I see to handle this is implementing the same workaround (mode guessing) also in the bootloader (rockchip miniloader
and u-boot SPL since both bootloader chains are supported for this board).Quoted 5 lines
Quoted 1 line
Or maybe I miss something?
Thanks for your input, I have made a new series [1] with a similar approach but is limited to dw_mmc-rockchip
and only changes the regulator atpower_offafter the regulator has been disabled (the vqmmc regulator in affected devices is always-on).Thanks for your work on this. Unfortunately I still think that this is the wrong approach.
I see several problems in your patch series:
- You introducedGPIO0_PA1as regulator enable for RockPro64. Unfortunately Pine64 decided to disable this regulator on Board Version
2.1 (real product version), see above. I have no idea why they did this.
- You changed the i/o voltage from 3.0V to 3.3V. This is not allowed on
RK3399 I/O bank F.Changing the i/o voltage to 3.0V/3.3V while the sd card is configured for 1.8V is against the specification and dangerous. While experimenting
with different images (ayufan, armbian) for my newly bought RockPro64 I
killed a SD card (32GB Samsung UHS-I). I cannot reconstruct the exact circumstances, but I'm pretty sure this happened due to the voltage mismatch. Of course I'm not keen to experiment further with this and kill more sd cards. This is not just an theoretical issue.Quoted 3 lines
To my knowledge the problem is not with the rockchip miniloader or u-boot SPL, it is the initial boot rom that tries to load the miniloader/SPL from a SD-card, so nothing that can be updated.
What I observed on my RockPro64:
The ROM bootloader always was able to load the next stage, maybe due to
the low initial clock of 400kHz? Also the ROM bootloader cannot change voltage regulator settings. So if the i/o voltage still is at 1.8V and matching the sd card setting, there is no problem for the ROM bootloader.Quoted 7 lines
Quoted 4 lines
Hmm, that makes me wonder if the problem might be not so much that the level of
SDMMC0_VDDitself stays at 1.8V, but that at some point after the bootrom theGRF_IO_VSELbit gets reset so the controller just stops being able to read anything as logic-high.Would be great if someone from Rockchip could give some insights whether and when during reboot
GRF_IO_VSELis reset (ATF before reboot, some SoC soft-reset, ROM bootloader, rkminiloader, something different), Shawn?
Quoted 5 lines
ROM code and miniloader never touch this
GRF_IO_VSELfor sdmmc, and only kernel did since now it support UHS mode. After reboot, the value should depends on the (value-in-kernel && does-reboot-level-hold-this-reg?)Different SoCs+PMICs excute differents reboot level policy.
OK, thanks. RockPro64 uses RK3399 and RK808D. Is there such a soft-reset for GRF_IO_VSEL in RK3399?
Let's have another detailed look at the reboot process on my RockPro64 with SD UHS enabled:
[ 84.675548] reboot: Restarting system DDR Version 1.23 20190709
[...]
change freq to 856MHz 1,0
ch 0 ddrconfig = 0x101, ddrsize = 0x2020
ch 1 ddrconfig = 0x101, ddrsize = 0x2020 pmugrf_os_reg[2] = 0x3AA1FAA1, stride = 0xD OUT
Boot1: 2018-06-26, version: 1.14
CPUId = 0x0
ChipType = 0x10, 287Spi_ChipId = c84018
no find rkpartition
SpiBootInit:ffffffff
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! emmc reinit
mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000
mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1
mmc0:cmd5,32
mmc0:cmd16,32
mmc0:cmd5,32
mmc0:cmd16,32
mmc0:cmd5,32
mmc0:cmd16,32
SdmmcInit=0 1
powerOn 489837
Usb re Boot. 6489831
Usb re Boot. 12489837
Usb re Boot. 18489840
SoftReset
DDR Version 1.23 20190709
[boot loop]
What we can see here:
The ROM bootloader is able to access the SD card after reboot, it loads and starts the DDR config firmware without any problem. The DDR firmware runs through and loads and starts the miniloader without any problem. The miniloader then tries to find RKTRUST on SPI (empty on my board), eMMC (not populated) and SD card and fails to access the SD card properly, if this card is configured for UHS mode. (With SD card at HS not UHS configuration the miniloader just loads and starts ATF, TEE and u-boot without any problem.)
So in principle the UHS configured SD card can be accessed after reboot without any problem. At least ROM bootloader and DDR firmware do so. The miniloader seems to do something differently and therefore fails. Shawn, any idea what's going on there?
Soeren
Quoted 48 lines
Quoted 48 lines
Or gets this VSEL changed only when switching the voltage regulator (via io_domains,sdmmc-supply)?
Soeren
Quoted 43 lines
Robin.
Quoted 40 lines
So I think the normal reboot handling should be:
If the sd card can be switched off (preferred solution), do so and reset
the controller i/o voltage to 3.0V/3.3V.
If the sd card can not be switched off, make sure to leave the controller i/o voltage at the current setting. Make sure in later boot stages to not change the controller i/o voltage to 3.0V/3.3V when the card is configured for 1.8V. According to the patch mentioned above this
behaviour already is implemented in linux, we also need this for the bootloaders.Regards,
SoerenQuoted 26 lines
I have observed this issue on the following devices, and the patches at [1] makes it possible to reboot from SD-card after UHS has been enabled.
- Asus Tinker Board (RK3288)
- Rockchip Sapphire Board (RK3399)
- Radxa Rock Pi 4 (RK3399)
- Pine64 RockPro64 (RK3399)
All of the above seem to use the RK808 regulator for sd io voltage.The ROC-RK3328-CC did not have this issue and seem to automatically reset to 3.3v.
[1]
https://github.com/Kwiboo/linux-rockchip/compare/next-20191011...next-20191011-mmcRegards,
JonasQuoted 6 lines
Soeren
Quoted 3 lines
Quoted 3 lines
although I'm not sure what if any progress has been made since then.
Quoted 11 lines
Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Robin.
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip