Add kernel seccomp support for m68k
v8 cover Add kernel seccomp support for m68k
Respin of m68k kernel seccomp support, again.
I have split the (MMU) m68k switch to syscall_trace_enter()/ syscall_trace_leave() patch from the patch adding return code checks for syscall_trace_enter() as suggested by Al Viro.
Patch 1 could now replace Eric's patch 'Stop open coding ptrace_report_syscall'.
Rest of the series remains unchanged.
Cheers,
Michael
PATCH v8 1/3 m68k/kernel - wire up syscall_trace_enter/leave for m68k
m68k (other than Coldfire) uses syscall_trace for both trace entry and trace exit. Seccomp support requires separate entry points for trace entry and exit which are already provided for Coldfire.
Replace syscall_trace by syscall_trace_enter and syscall_trace_leave in preparation for seccomp support.
No regression seen in testing with strace on ARAnyM.
--
Changes from v7:
Al Viro:
- split first patch to separate the switch to syscall_trace_enter/leave() from return code checks
Changes from v6:
Geert Uytterhoeven:
- add syscall_trace_enter() return code check for 68000 and coldfire
Changes from v5:
- add comment to explain optimization
Changes from v4:
Andreas Schwab:
- optimize return code test (addql #1,%d0 for cmpil #-1,%d0)
- spelling fix in commit message
Changes from v3:
- change syscall_trace_enter return code test from !=0 to ==-1
revert syscall trace return code checks
--- arch/m68k/kernel/entry.S | 4 ++-- arch/m68k/kernel/ptrace.c | 17 ----------------- 2 files changed, 2 insertions(+), 19 deletions(-)
arch/m68k/kernel/entry.S +2 -2
@@ -181,7 +181,7 @@ do_trace_entry: movel #-ENOSYS,%sp@(PT_OFF_D0)| needed for strace subql #4,%sp SAVE_SWITCH_STACK - jbsr syscall_trace + jbsr syscall_trace_enter RESTORE_SWITCH_STACK addql #4,%sp movel %sp@(PT_OFF_ORIG_D0),%d0
@@ -194,7 +194,7 @@ badsys: do_trace_exit: subql #4,%sp SAVE_SWITCH_STACK - jbsr syscall_trace + jbsr syscall_trace_leave RESTORE_SWITCH_STACK addql #4,%sp jra .Lret_from_exception
arch/m68k/kernel/ptrace.c +0 -17
@@ -271,22 +271,6 @@ long arch_ptrace(struct task_struct *child, long request,return -EIO ; } -asmlinkage void syscall_trace(void) -{ -ptrace_notify (SIGTRAP | ((current->ptrace &PT_TRACESYSGOOD ) - ?0x80 :0 )); -/* -* this isn't the same as continuing with a signal, but it will do -* for normal use. strace only continues with a signal if the -* stopping signal is not SIGTRAP. -brl -*/ -if (current->exit_code) { -send_sig (current->exit_code, current,1 ); - current->exit_code =0 ; - } -} - -#if defined(CONFIG_COLDFIRE ) || !defined(CONFIG_MMU ) asmlinkage int syscall_trace_enter(void) {int ret =0 ;
@@ -301,4 +285,3 @@ asmlinkage void syscall_trace_leave(void)if (test_thread_flag (TIF_SYSCALL_TRACE ))tracehook_report_syscall_exit (task_pt_regs (current),0 ); } -#endif /* CONFIG_COLDFIRE */
Signature · 1 line
2.17.1
PATCH v8 2/3 m68k/kernel - check syscall_trace_enter() return code on m68k
In reply to Michael SchmitzCheck return code of syscall_trace_enter(), and skip syscall if -1. Return code will be left at what had been set by ptrace or seccomp (in regs->d0).
No regression seen in testing with strace on ARAnyM.
--
Changes from v7:
Al Viro:
- split return code checks from switch to syscall_trace_enter()
Changes from v6:
Geert Uytterhoeven:
- add syscall_trace_enter() return code check for 68000 and coldfire
Changes from v5:
- add comment to explain optimization
Changes from v4:
Andreas Schwab:
- optimize return code test (addql #1,%d0 for cmpil #-1,%d0)
- spelling fix in commit message
Changes from v3:
- change syscall_trace_enter return code test from !=0 to ==-1
--- arch/m68k/68000/entry.S | 2 ++ arch/m68k/coldfire/entry.S | 2 ++ arch/m68k/kernel/entry.S | 2 ++ 3 files changed, 6 insertions(+)
arch/m68k/68000/entry.S +2 -0
@@ -45,6 +45,8 @@ do_trace: jbsr syscall_trace_enter RESTORE_SWITCH_STACK addql #4,%sp + addql #1,%d0 + jeq ret_from_exception movel %sp@(PT_OFF_ORIG_D0),%d1 movel #-ENOSYS,%d0 cmpl #NR_syscalls,%d1
arch/m68k/coldfire/entry.S +2 -0
@@ -90,6 +90,8 @@ ENTRY(system_call) jbsr syscall_trace_enter RESTORE_SWITCH_STACK addql #4,%sp + addql #1,%d0 + jeq ret_from_exception movel %d3,%a0 jbsr %a0@ movel %d0,%sp@(PT_OFF_D0) /* save the return value */
arch/m68k/kernel/entry.S +2 -0
@@ -184,6 +184,8 @@ do_trace_entry: jbsr syscall_trace_enter RESTORE_SWITCH_STACK addql #4,%sp + addql #1,%d0 | optimization for cmpil #-1,%d0 + jeq ret_from_syscall movel %sp@(PT_OFF_ORIG_D0),%d0 cmpl #NR_syscalls,%d0 jcs syscall
Signature · 1 line
2.17.1
PATCH v8 3/3 m68k: add kernel seccomp support
In reply to Michael SchmitzAdd secure_computing() call to syscall_trace_enter to actually filter system calls.
Add necessary arch Kconfig options, define TIF_SECCOMP trace flag and provide basic seccomp filter support in asm/syscall.h
syscall_get_nr currently uses the syscall nr stored in orig_d0 because we change d0 to a default return code before starting a syscall trace. This may be inconsistent with syscall_rollback copying orig_d0 to d0 (which we never check upon return from trace). We use d0 for the return code from syscall_trace_enter in entry.S currently, and could perhaps expand that to store a new syscall number returned by the seccomp filter before executing the syscall. This clearly needs some discussion.
Compiles (for Atari) and boots on ARAnyM, otherwise untested.
--
Changes from v6:
Geert Uytterhoeven:
- add syscall_get_error(), syscall_get_return_value(), and syscall_set_arguments() (not needed to compile!)
Changes from v5:
Geert Uytterhoeven:
- correct wrong offset for d1-d5 register copy
- update Documentation/features/seccomp/seccomp-filter/arch-support.txt
add syscall_get_error(), syscall_get_return_value(), syscall_set_arguments()
--- .../seccomp/seccomp-filter/arch-support.txt | 2 +- arch/m68k/Kconfig | 2 + arch/m68k/include/asm/seccomp.h | 11 ++++ arch/m68k/include/asm/syscall.h | 56 +++++++++++++++++++ arch/m68k/include/asm/thread_info.h | 2 + arch/m68k/kernel/ptrace.c | 5 ++ 6 files changed, 77 insertions(+), 1 deletion(-) create mode 100644 arch/m68k/include/asm/seccomp.h
Documentation/features/seccomp/seccomp-filter/arch-support.txt +1 -1
@@ -14,7 +14,7 @@ | h8300: | TODO | | hexagon: | TODO | | ia64: | TODO | - | m68k: | TODO | + | m68k: | ok | | microblaze: | TODO | | mips: | ok | | nds32: | TODO |
arch/m68k/Kconfig +2 -0
@@ -18,6 +18,8 @@ config M68K select GENERIC_IOMAP select GENERIC_IRQ_SHOW select HAVE_AOUT if MMU + select HAVE_ARCH_SECCOMP + select HAVE_ARCH_SECCOMP_FILTER select HAVE_ASM_MODVERSIONS select HAVE_DEBUG_BUGVERBOSE select HAVE_EFFICIENT_UNALIGNED_ACCESS if !CPU_HAS_NO_UNALIGNED
arch/m68k/include/asm/seccomp.h new file +11 -0
@@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef _ASM_SECCOMP_H +#define _ASM_SECCOMP_H + +#include <asm-generic/seccomp.h> + +#define SECCOMP_ARCH_NATIVE AUDIT_ARCH_M68K +#define SECCOMP_ARCH_NATIVE_NR NR_syscalls +#define SECCOMP_ARCH_NATIVE_NAME "m68k" + +#endif /* _ASM_SECCOMP_H */
arch/m68k/include/asm/syscall.h +56 -0
62 lines not on this page · raw message
arch/m68k/include/asm/thread_info.h +2 -0
@@ -61,6 +61,7 @@ static inline struct thread_info *current_thread_info(void)#define TIF_NOTIFY_RESUME 5/* callback before returning to user */ #define TIF_SIGPENDING 6/* signal pending */ #define TIF_NEED_RESCHED 7/* rescheduling necessary */ +#define TIF_SECCOMP 13/* seccomp syscall filtering active */ #define TIF_DELAYED_TRACE 14/* single step a syscall */ #define TIF_SYSCALL_TRACE 15/* syscall trace active */ #define TIF_MEMDIE 16/* is terminating due to OOM killer */
@@ -69,6 +70,7 @@ static inline struct thread_info *current_thread_info(void)#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED) +#define _TIF_SECCOMP (1 << TIF_SECCOMP)#define _TIF_DELAYED_TRACE (1 << TIF_DELAYED_TRACE)#define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE)#define _TIF_MEMDIE (1 << TIF_MEMDIE)
arch/m68k/kernel/ptrace.c +5 -0
@@ -19,6 +19,7 @@#include <linux/ptrace.h> #include <linux/user.h> #include <linux/signal.h> +#include <linux/seccomp.h> #include <linux/tracehook.h> #include <linux/uaccess.h>
@@ -277,6 +278,10 @@ asmlinkage int syscall_trace_enter(void)if (test_thread_flag (TIF_SYSCALL_TRACE )) ret =tracehook_report_syscall_entry (task_pt_regs (current)); + +if (secure_computing () ==-1 ) +return -1 ; +return ret; }
Signature · 1 line
2.17.1
Hi!
Quoted 10 lines · Michael Schmitz
Respin of m68k kernel seccomp support, again.
I have split the (MMU) m68k switch to syscall_trace_enter()/
syscall_trace_leave()patch from the patch adding return code checks forsyscall_trace_enter()as suggested by Al Viro.Patch 1 could now replace Eric's patch 'Stop open coding
ptrace_report_syscall'.Rest of the series remains unchanged.
I will try to test this series within the next days. I'd like to see this finally getting merged as there is a number of packages in Debian that depend on libsecomp being available and there currently cannot be built on m68k.
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer - [email protected] `. `' Freie Universitaet Berlin - [email protected] `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Quoted 8 lines · Michael Schmitz
Respin of m68k kernel seccomp support, again.
I have split the (MMU) m68k switch to syscall_trace_enter()/
syscall_trace_leave()patch from the patch adding return code checks forsyscall_trace_enter()as suggested by Al Viro.Patch 1 could now replace Eric's patch 'Stop open coding
ptrace_report_syscall'.
That change has merged and should show up in v5.17-rc1, but that should not matter in practice. This series just deletes the function I modified and replaces it with something that is equivalent for my purposes.
Quoted 1 line
Rest of the series remains unchanged.
Eric
Hi Eric,
Am 18.01.2022 um 07:06 schrieb Eric W. Biederman:
Quoted 8 lines
Quoted 6 lines · Michael Schmitz
Respin of m68k kernel seccomp support, again.
I have split the (MMU) m68k switch to syscall_trace_enter()/
syscall_trace_leave()patch from the patch adding return code checks forsyscall_trace_enter()as suggested by Al Viro.
Quoted 7 lines
Quoted 2 lines
Patch 1 could now replace Eric's patch 'Stop open coding
ptrace_report_syscall'.That change has merged and should show up in v5.17-rc1, but that should not matter in practice. This series just deletes the function I modified and replaces it with something that is equivalent for my purposes.
Thanks - I'll watch out for your patch to show up in 5.17-rc1 before respinning again.
Quoted 4 lines
Quoted 2 lines
Rest of the series remains unchanged.
Thanks,
Michael
Quoted 3 lines
Eric
Hi Adrian,
Am 15.01.2022 um 11:51 schrieb John Paul Adrian Glaubitz:
Quoted 12 lines
Hi!
Quoted 9 lines · Michael Schmitz
Respin of m68k kernel seccomp support, again.
I have split the (MMU) m68k switch to syscall_trace_enter()/
syscall_trace_leave()patch from the patch adding return code checks forsyscall_trace_enter()as suggested by Al Viro.Patch 1 could now replace Eric's patch 'Stop open coding
ptrace_report_syscall'.
Quoted 6 lines
Quoted 1 line
Rest of the series remains unchanged.
I will try to test this series within the next days. I'd like to see this finally getting merged as there is a number of packages in Debian that depend on libsecomp being available and there currently cannot be built on m68k.
Thanks - your tests might help convincing Geert (and explain why my selftests never showed much improvement - missing modules perhaps?).
Cheers,
Michael
Quoted 3 lines
Adrian