Skip to contentSkip to conversation

i2c: designware: remove unneeded semicolon

PATCH Superseded Yang Li 2 participants 2 messages Feb 14, 2022

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 i2c: designware: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/i2c/busses/i2c-designware-amdpsp.c:248:2-3: Unneeded semicolon

---
 drivers/i2c/busses/i2c-designware-amdpsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-amdpsp.c +1 -1
index 752e0024db03..f589d3a1a19e 100644
@@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
 	if (psp_i2c_access_count) {
 		psp_i2c_access_count++;
 		goto cleanup;
-	};
+	}
 
 	status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
 	if (status) {
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw

pon., 14 lut 2022 o 02:03 Yang Li <[email protected]> napisał(a):

Quoted 15 lines

Eliminate the following coccicheck warning:
./drivers/i2c/busses/i2c-designware-amdpsp.c:248:2-3: Unneeded semicolon

---
 drivers/i2c/busses/i2c-designware-amdpsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-amdpsp.c +0 -0
index 752e0024db03..f589d3a1a19e 100644

drivers/i2c/busses/i2c-designware-amdpsp.c static int psp_acquire_i2c_bus(void) · line 248

Quoted 5 lines
drivers/i2c/busses/i2c-designware-amdpsp.c +1 -1
@@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
        if (psp_i2c_access_count) {
                psp_i2c_access_count++;
                goto cleanup;
-       };
+       }

Thanks. While fixing this, please do the same for the 'switch' in check_i2c_req_sts() function above. Isn't your tool reporting this?

Best Regards,
Jan