Skip to contentSkip to conversation

imx: imx8qm: cgtqmx8: switch to binman

PATCH Superseded Oliver Graute 4 participants 4 messages Feb 16, 2022 – Feb 21, 2022

Subsystems (3)

v1 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx: imx8qm: cgtqmx8: switch to binman

Switch to use binman to pack images

---
 arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
 arch/arm/mach-imx/imx8/Kconfig      | 1 +
 board/congatec/cgtqmx8/imximage.cfg | 4 ++--
 configs/cgtqmx8_defconfig           | 2 +-
 doc/board/congatec/cgtqmx8.rst      | 3 +--
 5 files changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/imx8qm-cgtqmx8.dts +1 -0
index 555c357f6f..919d00644f 100644
@@ -12,6 +12,7 @@
 /memreserve/ 0x80000000 0x00020000;
 
 #include "fsl-imx8qm.dtsi"
+#include "imx8qm-u-boot.dtsi"
 
 / {
 	model = "Congatec QMX8 Qseven series";
arch/arm/mach-imx/imx8/Kconfig +1 -0
index 6cd321fbb6..6e4b25961f 100644
@@ -75,6 +75,7 @@ config TARGET_IMX8QM_MEK
 
 config TARGET_CONGA_QMX8
 	bool "Support congatec conga-QMX8 board"
+	select BINMAN
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select IMX8QM
board/congatec/cgtqmx8/imximage.cfg +2 -2
index e324c7ca37..58eeef54f6 100644
@@ -5,8 +5,8 @@
 
 #define __ASSEMBLY__
 
-/* Boot from SD, sector size 0x400 */
-BOOT_FROM SD 0x400
+BOOT_FROM	sd
+
 /* SoC type IMX8QM */
 SOC_TYPE IMX8QM
 /* Append seco container image */
configs/cgtqmx8_defconfig +1 -1
index 34aca6ea85..48433bdef9 100644
@@ -18,7 +18,7 @@ CONFIG_SPL_DRIVERS_MISC=y
 CONFIG_SPL=y
 CONFIG_FIT=y
 CONFIG_SPL_LOAD_FIT=y
-CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh"
+# CONFIG_USE_SPL_FIT_GENERATOR is not set
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/congatec/cgtqmx8/imximage.cfg"
 CONFIG_BOOTDELAY=3
 CONFIG_LOG=y
doc/board/congatec/cgtqmx8.rst +1 -2
index bccdef2f16..16711a844d 100644
@@ -57,8 +57,7 @@ Build U-Boot
      $ export ATF_LOAD_ADDR=0x80000000
      $ export BL33_LOAD_ADDR=0x80020000
      $ make cgtqmx8_defconfig
-     $ make u-boot.bin
-     $ make flash.bin
+     $ make
 
 Flash the binary into the SD card
 ---------------------------------
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Oliver Graute

Switch to use binman to pack images

---
 arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
 arch/arm/mach-imx/imx8/Kconfig      | 1 +
 board/congatec/cgtqmx8/imximage.cfg | 4 ++--
 configs/cgtqmx8_defconfig           | 2 +-
 doc/board/congatec/cgtqmx8.rst      | 3 +--
 5 files changed, 6 insertions(+), 5 deletions(-)
#2 lore raw

Hi Oliver,

Quoted 14 lines · Simon Glass
Quoted 11 lines · Oliver Graute

Switch to use binman to pack images

---
  arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
  arch/arm/mach-imx/imx8/Kconfig      | 1 +
  board/congatec/cgtqmx8/imximage.cfg | 4 ++--
  configs/cgtqmx8_defconfig           | 2 +-
  doc/board/congatec/cgtqmx8.rst      | 3 +--
  5 files changed, 6 insertions(+), 5 deletions(-)
Quoted 1 line

Applying this, build fails. Could you take a look, rebase and repost ? Thanks !

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#3 lore raw
Quoted 17 lines · Stefano Babic

Hi Oliver,

Quoted 14 lines · Simon Glass
Quoted 11 lines · Oliver Graute

Switch to use binman to pack images

---
  arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
  arch/arm/mach-imx/imx8/Kconfig      | 1 +
  board/congatec/cgtqmx8/imximage.cfg | 4 ++--
  configs/cgtqmx8_defconfig           | 2 +-
  doc/board/congatec/cgtqmx8.rst      | 3 +--
  5 files changed, 6 insertions(+), 5 deletions(-)
Quoted 4 lines
Quoted 1 line

Applying this, build fails. Could you take a look, rebase and repost ? Thanks !

ok, 'll do.

Best Regards,

Oliver