QEMU RISC-V nested virtualization fixes
v4 cover QEMU RISC-V nested virtualization fixes
This series does fixes and improvements to have nested virtualization on QEMU RISC-V.
These patches can also be found in riscv_nested_fixes_v4 branch at:
https://github.com/avpatel/qemu.git
The RISC-V nested virtualization was tested on QEMU RISC-V using Xvisor RISC-V which has required hypervisor support to run another hypervisor as Guest/VM.
Changes since v3:
- Updated PATCH3 to set special pseudoinstructions in htinst for guest page faults which result due to VS-stage page table walks
- Updated warning message in PATCH4
Changes since v2:
- Dropped the patch which are already in Alistair's next branch
- Set "Addr. Offset" in the transformed instruction for PATCH3
- Print warning in riscv_cpu_realize() if we are disabling an extension due to privilege spec verions mismatch for PATCH4
Changes since v1:
- Set write_gva to env->two_stage_lookup which ensures that for HS-mode to HS-mode trap write_gva is true only for HLV/HSV instructions
- Included "[PATCH 0/3] QEMU RISC-V priv spec version fixes" patches in this series for easy review
- Re-worked PATCH7 to force disable extensions if required priv spec version is not staisfied
- Added new PATCH8 to fix "aia=aplic-imsic" mode of virt machine
Anup Patel (4):
target/riscv: Don't force update priv spec version to latest target/riscv: Add dummy mcountinhibit CSR for priv spec v1.11 or
higher
target/riscv: Update [m|h]tinst CSR in riscv_cpu_do_interrupt() target/riscv: Force disable extensions if priv spec version does not
match
target/riscv/cpu.c | 65 +++++++++-- target/riscv/cpu.h | 3 + target/riscv/cpu_bits.h | 3 + target/riscv/cpu_helper.c | 231 +++++++++++++++++++++++++++++++++++++- target/riscv/csr.c | 2 + target/riscv/instmap.h | 43 +++++++ 6 files changed, 333 insertions(+), 14 deletions(-)
Signature · 1 line
2.34.1
PATCH v4 1/4 target/riscv: Don't force update priv spec version to latest
The riscv_cpu_realize() sets priv spec verion to v1.12 when it is when "env->priv_ver == 0" (i.e. default v1.10) because the enum value of priv spec v1.10 is zero.
Due to above issue, the sifive_u machine will see priv spec v1.12 instead of priv spec v1.10.
To fix this issue, we set latest priv spec version (i.e. v1.12) for base rv64/rv32 cpu and riscv_cpu_realize() will override priv spec version only when "cpu->cfg.priv_spec != NULL".
--- target/riscv/cpu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
target/riscv/cpu.c +6 -4
@@ -169,6 +169,8 @@ static void rv64_base_cpu_init(Object *obj)CPURISCVState *env = &RISCV_CPU (obj)->env;/* We set this in the realise function */ set_misa (env,MXL_RV64 ,0 ); +/* Set latest version of privileged specification */ +set_priv_version (env,PRIV_VERSION_1_12_0 ); }static void rv64_sifive_u_cpu_init (Object *obj)
@@ -204,6 +206,8 @@ static void rv32_base_cpu_init(Object *obj)CPURISCVState *env = &RISCV_CPU (obj)->env;/* We set this in the realise function */ set_misa (env,MXL_RV32 ,0 ); +/* Set latest version of privileged specification */ +set_priv_version (env,PRIV_VERSION_1_12_0 ); }static void rv32_sifive_u_cpu_init (Object *obj)
@@ -509,7 +513,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)CPURISCVState *env = &cpu->env;RISCVCPUClass *mcc =RISCV_CPU_GET_CLASS (dev);CPUClass *cc =CPU_CLASS (mcc); -int priv_version =0 ; +int priv_version =-1 ;Error *local_err =NULL ;cpu_exec_realizefn (cs, &local_err);
@@ -533,10 +537,8 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp) } } -if (priv_version) { +if (priv_version >=PRIV_VERSION_1_10_0 ) {set_priv_version (env, priv_version); - }else if (!env->priv_ver) { -set_priv_version (env,PRIV_VERSION_1_12_0 ); }if (cpu->cfg.mmu) {
Signature · 1 line
2.34.1
PATCH v4 2/4 target/riscv: Add dummy mcountinhibit CSR for priv spec v1.11 or higher
In reply to Anup PatelThe mcountinhibit CSR is mandatory for priv spec v1.11 or higher. For implementation that don't want to implement can simply have a dummy mcountinhibit which always zero.
the CSR ops.")
--- target/riscv/cpu_bits.h | 3 +++ target/riscv/csr.c | 2 ++ 2 files changed, 5 insertions(+)
target/riscv/cpu_bits.h +3 -0
@@ -159,6 +159,9 @@#define CSR_MTVEC 0x305#define CSR_MCOUNTEREN 0x306 +/* Machine Counter Setup */ +#define CSR_MCOUNTINHIBIT 0x320 +/* 32-bit only */ #define CSR_MSTATUSH 0x310
target/riscv/csr.c +2 -0
@@ -3391,6 +3391,8 @@ riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = { [CSR_MIE] = { "mie", any, NULL, NULL, rmw_mie }, [CSR_MTVEC] = { "mtvec", any, read_mtvec, write_mtvec }, [CSR_MCOUNTEREN] = { "mcounteren", any, read_mcounteren, write_mcounteren }, + [CSR_MCOUNTINHIBIT] = { "mcountinhibit", any, read_zero, write_ignore, + .min_priv_ver = PRIV_VERSION_1_11_0 }, [CSR_MSTATUSH] = { "mstatush", any32, read_mstatush, write_mstatush },
Signature · 1 line
2.34.1
PATCH v4 3/4 target/riscv: Update [m|h]tinst CSR in riscv_cpu_do_interrupt()
In reply to Anup PatelWe should write transformed instruction encoding of the trapped instruction in [m|h]tinst CSR at time of taking trap as defined by the RISC-V privileged specification v1.12.
--- target/riscv/cpu.h | 3 + target/riscv/cpu_helper.c | 231 +++++++++++++++++++++++++++++++++++++- target/riscv/instmap.h | 43 +++++++ 3 files changed, 271 insertions(+), 6 deletions(-)
target/riscv/cpu.h +3 -0
@@ -271,6 +271,9 @@ struct CPUArchState {/* Signals whether the current exception occurred with two-stage address translation active. */ bool two_stage_lookup; +/* Signals whether the current exception occurred while doing two-stage +address translation for the VS-stage page table walk. */ +bool two_stage_indirect_lookup;target_ulong scounteren;target_ulong mcounteren;
target/riscv/cpu_helper.c +225 -6
322 lines not on this page · raw message
target/riscv/instmap.h +43 -0
65 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v4 4/4 target/riscv: Force disable extensions if priv spec version does not match
In reply to Anup PatelWe should disable extensions in riscv_cpu_realize() if minimum required priv spec version is not satisfied. This also ensures that machines with priv spec v1.11 (or lower) cannot enable H, V, and various multi-letter extensions.
device tree")
--- target/riscv/cpu.c | 57 ++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 52 insertions(+), 5 deletions(-)
target/riscv/cpu.c +52 -5
@@ -43,9 +43,13 @@ static const char riscv_single_letter_exts[] = "IEMAFDQCPVH";struct isa_ext_data {const char *name; -bool enabled; +int min_version; +bool *enabled; }; +#define ISA_EDATA_ENTRY (name, prop) {#name, PRIV_VERSION_1_10_0, &cpu->cfg.prop} +#define ISA_EDATA_ENTRY2 (name, min_ver, prop) {#name, min_ver, &cpu->cfg.prop} +const char *const riscv_int_regnames[] = {"x0/zero" ,"x1/ra" ,"x2/sp" ,"x3/gp" ,"x4/tp" ,"x5/t0" ,"x6/t1" ,"x7/t2" ,"x8/s0" ,"x9/s1" ,"x10/a0" ,"x11/a1" ,"x12/a2" ,"x13/a3" ,
@@ -513,8 +517,42 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)CPURISCVState *env = &cpu->env;RISCVCPUClass *mcc =RISCV_CPU_GET_CLASS (dev);CPUClass *cc =CPU_CLASS (mcc); -int priv_version =-1 ; +int i, priv_version =-1 ;Error *local_err =NULL ; +struct isa_ext_data isa_edata_arr[] = { +ISA_EDATA_ENTRY2 (h,PRIV_VERSION_1_12_0 , ext_h), +ISA_EDATA_ENTRY2 (v,PRIV_VERSION_1_12_0 , ext_v), +ISA_EDATA_ENTRY2 (zicsr,PRIV_VERSION_1_10_0 , ext_icsr), +ISA_EDATA_ENTRY2 (zifencei,PRIV_VERSION_1_10_0 , ext_ifencei), +ISA_EDATA_ENTRY2 (zfh,PRIV_VERSION_1_12_0 , ext_zfh), +ISA_EDATA_ENTRY2 (zfhmin,PRIV_VERSION_1_12_0 , ext_zfhmin), +ISA_EDATA_ENTRY2 (zfinx,PRIV_VERSION_1_12_0 , ext_zfinx), +ISA_EDATA_ENTRY2 (zdinx,PRIV_VERSION_1_12_0 , ext_zdinx), +ISA_EDATA_ENTRY2 (zba,PRIV_VERSION_1_12_0 , ext_zba), +ISA_EDATA_ENTRY2 (zbb,PRIV_VERSION_1_12_0 , ext_zbb), +ISA_EDATA_ENTRY2 (zbc,PRIV_VERSION_1_12_0 , ext_zbc), +ISA_EDATA_ENTRY2 (zbkb,PRIV_VERSION_1_12_0 , ext_zbkb), +ISA_EDATA_ENTRY2 (zbkc,PRIV_VERSION_1_12_0 , ext_zbkc), +ISA_EDATA_ENTRY2 (zbkx,PRIV_VERSION_1_12_0 , ext_zbkx), +ISA_EDATA_ENTRY2 (zbs,PRIV_VERSION_1_12_0 , ext_zbs), +ISA_EDATA_ENTRY2 (zk,PRIV_VERSION_1_12_0 , ext_zk), +ISA_EDATA_ENTRY2 (zkn,PRIV_VERSION_1_12_0 , ext_zkn), +ISA_EDATA_ENTRY2 (zknd,PRIV_VERSION_1_12_0 , ext_zknd), +ISA_EDATA_ENTRY2 (zkne,PRIV_VERSION_1_12_0 , ext_zkne), +ISA_EDATA_ENTRY2 (zknh,PRIV_VERSION_1_12_0 , ext_zknh), +ISA_EDATA_ENTRY2 (zkr,PRIV_VERSION_1_12_0 , ext_zkr), +ISA_EDATA_ENTRY2 (zks,PRIV_VERSION_1_12_0 , ext_zks), +ISA_EDATA_ENTRY2 (zksed,PRIV_VERSION_1_12_0 , ext_zksed), +ISA_EDATA_ENTRY2 (zksh,PRIV_VERSION_1_12_0 , ext_zksh), +ISA_EDATA_ENTRY2 (zkt,PRIV_VERSION_1_12_0 , ext_zkt), +ISA_EDATA_ENTRY2 (zve32f,PRIV_VERSION_1_12_0 , ext_zve32f), +ISA_EDATA_ENTRY2 (zve64f,PRIV_VERSION_1_12_0 , ext_zve64f), +ISA_EDATA_ENTRY2 (zhinx,PRIV_VERSION_1_12_0 , ext_zhinx), +ISA_EDATA_ENTRY2 (zhinxmin,PRIV_VERSION_1_12_0 , ext_zhinxmin), +ISA_EDATA_ENTRY2 (svinval,PRIV_VERSION_1_12_0 , ext_svinval), +ISA_EDATA_ENTRY2 (svnapot,PRIV_VERSION_1_12_0 , ext_svnapot), +ISA_EDATA_ENTRY2 (svpbmt,PRIV_VERSION_1_12_0 , ext_svpbmt), + };cpu_exec_realizefn (cs, &local_err);if (local_err !=NULL ) {
@@ -541,6 +579,17 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)set_priv_version (env, priv_version); } +/* Force disable extensions if priv spec version does not match */ +for (i =0 ; i <ARRAY_SIZE (isa_edata_arr); i++) { +if (*isa_edata_arr[i].enabled && + (env->priv_ver < isa_edata_arr[i].min_version)) { + *isa_edata_arr[i].enabled = false; +warn_report ("disabling %s extension for hart 0x%lx because " +"privilege spec version does not match" , + isa_edata_arr[i].name, (unsigned long )env->mhartid); + } + } +if (cpu->cfg.mmu) {riscv_set_feature (env,RISCV_FEATURE_MMU ); }
@@ -1011,8 +1060,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)device_class_set_props (dc, riscv_cpu_properties); } -#define ISA_EDATA_ENTRY (name, prop) {#name, cpu->cfg.prop} -static void riscv_isa_string_ext (RISCVCPU *cpu,char **isa_str,int max_str_len) {char *old = *isa_str;
@@ -1071,7 +1118,7 @@ static void riscv_isa_string_ext(RISCVCPU *cpu, char **isa_str, int max_str_len) };for (i =0 ; i <ARRAY_SIZE (isa_edata_arr); i++) { -if (isa_edata_arr[i].enabled) { +if (*isa_edata_arr[i].enabled) { new =g_strconcat (old,"_" , isa_edata_arr[i].name,NULL );g_free (old); old = new;
Signature · 1 line
2.34.1
Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match
Quoted 1 line · Anup Patel
+ struct
isa_ext_dataisa_edata_arr[] = {
static const?
r~
Re: [PATCH v4 1/4] target/riscv: Don't force update priv spec version to latest
In reply to Anup PatelQuoted 2 lines · Anup Patel
The
riscv_cpu_realize()sets priv spec verion to v1.12 when it is
typo: version
Quoted 10 lines
when "
env->priv_ver== 0" (i.e. default v1.10) because the enum value of priv spec v1.10 is zero.Due to above issue, the
sifive_umachine will see priv spec v1.12 instead of priv spec v1.10.To fix this issue, we set latest priv spec version (i.e. v1.12) for base rv64/rv32 cpu and
riscv_cpu_realize()will override priv spec version only when "cpu->cfg.priv_spec!= NULL".
Quoted 9 lines
Fixes 7100fe6c2441 ("target/riscv: Enable privileged spec version 1.12")Signed-off-by Anup Patel <[email protected]>Reviewed-by Frank Chang <[email protected]>Reviewed-by Alistair Francis <[email protected]>Reviewed-by Atish Patra <[email protected]>--- target/riscv/cpu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
Otherwise,
Re: [PATCH v4 2/4] target/riscv: Add dummy mcountinhibit CSR for priv spec v1.11 or higher
In reply to Anup PatelQuoted 4 lines · Anup Patel
The mcountinhibit CSR is mandatory for priv spec v1.11 or higher. For implementation that don't want to implement can simply have a dummy mcountinhibit which always zero.
which is always
Quoted 3 lines
Fixes a4b2fa433125 ("target/riscv: Introduce privilege version field inthe CSR ops.")
The "Fixes" tag should be put in one single line, so that scripts relying on such won't be broken.
Quoted 27 lines
Signed-off-by Anup Patel <[email protected]>Reviewed-by Frank Chang <[email protected]>Reviewed-by Alistair Francis <[email protected]>--- target/riscv/cpu_bits.h | 3 +++ target/riscv/csr.c | 2 ++ 2 files changed, 5 insertions(+)target/riscv/cpu_bits.h +3
-0@@ -159,6 +159,9 @@#define CSR_MTVEC 0x305#define CSR_MCOUNTEREN 0x306 +/* Machine Counter Setup */ +#define CSR_MCOUNTINHIBIT 0x320 +/* 32-bit only */ #define CSR_MSTATUSH 0x310target/riscv/csr.c +0
-0
target/riscv/csr.c riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = {
Quoted 9 lines
target/riscv/csr.c +2
-1@@ -3391,6 +3391,8 @@ riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = { [CSR_MIE] = { "mie", any, NULL, NULL, rmw_mie }, [CSR_MTVEC] = { "mtvec", any, read_mtvec, write_mtvec }, [CSR_MCOUNTEREN] = { "mcounteren", any, read_mcounteren, write_mcounteren }, + [CSR_MCOUNTINHIBIT] = { "mcountinhibit", any, read_zero, write_ignore, + .min_priv_ver = PRIV_VERSION_1_11_0 }, [CSR_MSTATUSH] = { "mstatush", any32, read_mstatush, write_mstatush }, --
Otherwise,
Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match
In reply to Anup PatelQuoted 8 lines · Anup Patel
We should disable extensions in
riscv_cpu_realize()if minimum required priv spec version is not satisfied. This also ensures that machines with priv spec v1.11 (or lower) cannot enable H, V, and various multi-letter extensions.Fixes a775398be2e ("target/riscv: Add isa extenstion strings to thedevice tree")
single line "Fixes" tag. Also the commit id should have at least 12 digits.
Quoted 96 lines
Signed-off-by Anup Patel <[email protected]>--- target/riscv/cpu.c | 57 ++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 52 insertions(+), 5 deletions(-)target/riscv/cpu.c +51
-4@@ -43,9 +43,13 @@ static const char riscv_single_letter_exts[] = "IEMAFDQCPVH";struct isa_ext_data {const char *name; -bool enabled; +int min_version; +bool *enabled; }; +#define ISA_EDATA_ENTRY (name, prop) {#name, PRIV_VERSION_1_10_0, &cpu->cfg.prop} +#define ISA_EDATA_ENTRY2 (name, min_ver, prop) {#name, min_ver, &cpu->cfg.prop} +const char *const riscv_int_regnames[] = {"x0/zero" ,"x1/ra" ,"x2/sp" ,"x3/gp" ,"x4/tp" ,"x5/t0" ,"x6/t1" ,"x7/t2" ,"x8/s0" ,"x9/s1" ,"x10/a0" ,"x11/a1" ,"x12/a2" ,"x13/a3" ,@@ -513,8 +517,42 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)CPURISCVState *env = &cpu->env;RISCVCPUClass *mcc =RISCV_CPU_GET_CLASS (dev);CPUClass *cc =CPU_CLASS (mcc); -int priv_version =-1 ; +int i, priv_version =-1 ;Error *local_err =NULL ; +struct isa_ext_data isa_edata_arr[] = { +ISA_EDATA_ENTRY2 (h,PRIV_VERSION_1_12_0 , ext_h), +ISA_EDATA_ENTRY2 (v,PRIV_VERSION_1_12_0 , ext_v), +ISA_EDATA_ENTRY2 (zicsr,PRIV_VERSION_1_10_0 , ext_icsr), +ISA_EDATA_ENTRY2 (zifencei,PRIV_VERSION_1_10_0 , ext_ifencei), +ISA_EDATA_ENTRY2 (zfh,PRIV_VERSION_1_12_0 , ext_zfh), +ISA_EDATA_ENTRY2 (zfhmin,PRIV_VERSION_1_12_0 , ext_zfhmin), +ISA_EDATA_ENTRY2 (zfinx,PRIV_VERSION_1_12_0 , ext_zfinx), +ISA_EDATA_ENTRY2 (zdinx,PRIV_VERSION_1_12_0 , ext_zdinx), +ISA_EDATA_ENTRY2 (zba,PRIV_VERSION_1_12_0 , ext_zba), +ISA_EDATA_ENTRY2 (zbb,PRIV_VERSION_1_12_0 , ext_zbb), +ISA_EDATA_ENTRY2 (zbc,PRIV_VERSION_1_12_0 , ext_zbc), +ISA_EDATA_ENTRY2 (zbkb,PRIV_VERSION_1_12_0 , ext_zbkb), +ISA_EDATA_ENTRY2 (zbkc,PRIV_VERSION_1_12_0 , ext_zbkc), +ISA_EDATA_ENTRY2 (zbkx,PRIV_VERSION_1_12_0 , ext_zbkx), +ISA_EDATA_ENTRY2 (zbs,PRIV_VERSION_1_12_0 , ext_zbs), +ISA_EDATA_ENTRY2 (zk,PRIV_VERSION_1_12_0 , ext_zk), +ISA_EDATA_ENTRY2 (zkn,PRIV_VERSION_1_12_0 , ext_zkn), +ISA_EDATA_ENTRY2 (zknd,PRIV_VERSION_1_12_0 , ext_zknd), +ISA_EDATA_ENTRY2 (zkne,PRIV_VERSION_1_12_0 , ext_zkne), +ISA_EDATA_ENTRY2 (zknh,PRIV_VERSION_1_12_0 , ext_zknh), +ISA_EDATA_ENTRY2 (zkr,PRIV_VERSION_1_12_0 , ext_zkr), +ISA_EDATA_ENTRY2 (zks,PRIV_VERSION_1_12_0 , ext_zks), +ISA_EDATA_ENTRY2 (zksed,PRIV_VERSION_1_12_0 , ext_zksed), +ISA_EDATA_ENTRY2 (zksh,PRIV_VERSION_1_12_0 , ext_zksh), +ISA_EDATA_ENTRY2 (zkt,PRIV_VERSION_1_12_0 , ext_zkt), +ISA_EDATA_ENTRY2 (zve32f,PRIV_VERSION_1_12_0 , ext_zve32f), +ISA_EDATA_ENTRY2 (zve64f,PRIV_VERSION_1_12_0 , ext_zve64f), +ISA_EDATA_ENTRY2 (zhinx,PRIV_VERSION_1_12_0 , ext_zhinx), +ISA_EDATA_ENTRY2 (zhinxmin,PRIV_VERSION_1_12_0 , ext_zhinxmin), +ISA_EDATA_ENTRY2 (svinval,PRIV_VERSION_1_12_0 , ext_svinval), +ISA_EDATA_ENTRY2 (svnapot,PRIV_VERSION_1_12_0 , ext_svnapot), +ISA_EDATA_ENTRY2 (svpbmt,PRIV_VERSION_1_12_0 , ext_svpbmt), + };cpu_exec_realizefn (cs, &local_err);if (local_err !=NULL ) {@@ -541,6 +579,17 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)set_priv_version (env, priv_version); } +/* Force disable extensions if priv spec version does not match */ +for (i =0 ; i <ARRAY_SIZE (isa_edata_arr); i++) { +if (*isa_edata_arr[i].enabled && + (env->priv_ver < isa_edata_arr[i].min_version)) { + *isa_edata_arr[i].enabled = false; +warn_report ("disabling %s extension for hart 0x%lx because " +"privilege spec version does not match" , + isa_edata_arr[i].name, (unsigned long )env->mhartid); + } + } +if (cpu->cfg.mmu) {riscv_set_feature (env,RISCV_FEATURE_MMU ); }@@ -1011,8 +1060,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)device_class_set_props (dc, riscv_cpu_properties); } -#define ISA_EDATA_ENTRY (name, prop) {#name, cpu->cfg.prop} -static void riscv_isa_string_ext (RISCVCPU *cpu,char **isa_str,int max_str_len) {char *old = *isa_str;
target/riscv/cpu.c static void riscv_isa_string_ext(RISCVCPU *cpu, char **isa_str, int max_str_len)
Quoted 9 lines
target/riscv/cpu.c +1
-2@@ -1071,7 +1118,7 @@ static void riscv_isa_string_ext(RISCVCPU *cpu, char **isa_str, int max_str_len) };for (i =0 ; i <ARRAY_SIZE (isa_edata_arr); i++) { -if (isa_edata_arr[i].enabled) { +if (*isa_edata_arr[i].enabled) { new =g_strconcat (old,"_" , isa_edata_arr[i].name,NULL );g_free (old); old = new; --
Regards,
Bin
Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match
In reply to Richard HendersonQuoted 5 lines · Richard Henderson
Quoted 1 line · Anup Patel
+ struct
isa_ext_dataisa_edata_arr[] = {static const?
Using const is fine but we can't use "static const" because the "struct isa_ext_data" has a pointer to ext_xyz which is different for each CPU.
Regards,
Anup
Quoted 3 lines
r~
Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match
Quoted 11 lines · Anup Patel
Quoted 5 lines · Richard Henderson
Quoted 1 line · Anup Patel
+ struct
isa_ext_dataisa_edata_arr[] = {static const?
Using const is fine but we can't use "static const" because the "struct
isa_ext_data" has a pointer toext_xyzwhich is different for each CPU.
Ah, I see. Perhaps better to use offsetof then -- the data structure is not small...
r~
Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match
Quoted 8 lines · Richard Henderson
Quoted 6 lines · Anup Patel
Quoted 4 lines · Richard Henderson
Quoted 1 line · Anup Patel
+ struct
isa_ext_dataisa_edata_arr[] = {
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
static const?
Using const is fine but we can't use "static const" because the "struct
isa_ext_data" has a pointer toext_xyzwhich is different for each CPU.Ah, I see. Perhaps better to use offsetof then -- the data structure is not small...
I agree. Using offsetof() is a much better approach.
Thanks,
Anup
Quoted 3 lines
r~