dt-bindings: media: i2c: Add IMX519 CMOS sensor binding
Subsystems (2)
PATCH v2 1/2 dt-bindings: media: i2c: Add IMX519 CMOS sensor binding
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant MAINTAINERS entries.
--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +107 -0
@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor + with an active array size of 4656H x 3496V. It is programmable through + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. + Image data is sent through MIPI CSI-2, which is configured as either 2 or + 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device address + maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply: + description: + Digital I/O voltage supply, 1.05 volts + + VANA-supply: + description: + Analog voltage supply, 2.8 volts + + VDDL-supply: + description: + Digital core voltage supply, 1.8 volts + + reset-gpios: + description: |- + Reference to the GPIO connected to the xclr pin, if any. + Must be released (set high) after all supplies and INCK are applied. + +port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver only supports two-lane operation. + items: + - const: 1 + - const: 2 + + clock-noncontinuous: true + link-frequencies: true + + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocks + - VANA-supply + - VDIG-supply + - VDDL-supply + - port + +additionalProperties: false + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + imx519: sensor@1a { + compatible = "sony,imx519"; + reg = <0x1a>; + clocks = <&imx519_clk>; + VANA-supply = <&imx519_vana>; /* 2.8v */ + VDIG-supply = <&imx519_vdig>; /* 1.05v */ + VDDL-supply = <&imx519_vddl>; /* 1.8v */ + + port { + imx519_0: endpoint { + remote-endpoint = <&csi1_ep>; + data-lanes = <1 2>; + clock-noncontinuous; + link-frequencies = /bits/ 64 <493500000>; + }; + }; + }; + }; + +...
MAINTAINERS +9 -0
@@ -19236,6 +19236,15 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml F: drivers/media/i2c/imx412.c +SONY IMX519 SENSOR DRIVER +M: Arducam Kernel Maintenance <[email protected]> +M: Lee Jackson <[email protected]> +L: [email protected] +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml +F: drivers/media/i2c/imx519.c + SONY MEMORYSTICK SUBSYSTEM M: Maxim Levitsky <[email protected]> M: Alex Dubov <[email protected]>
Signature · 1 line
2.25.1
Rob Herring
maintainerQuoted 10 lines · lee
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:./Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml:48:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml: 'port' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx519.example.dtb: sensor@1a: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
Quoted 4 lines · lee
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>
Your From does not match fully SoB.
Quoted 26 lines
--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +14
-0@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor + with an active array size of 4656H x 3496V. It is programmable through
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 24
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +10
-0+ I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. + Image data is sent through MIPI CSI-2, which is configured as either 2 or + 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device address
Skip description.
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 30
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +6
-0+ maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply:
Use lower case names.
Quoted 19 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +19
-0+ description: + Digital I/O voltage supply, 1.05 volts + + VANA-supply: + description: + Analog voltage supply, 2.8 volts + + VDDL-supply: + description: + Digital core voltage supply, 1.8 volts + + reset-gpios: + description: |- + Reference to the GPIO connected to the xclr pin, if any. + Must be released (set high) after all supplies and INCK are applied. + +port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 59
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +10
-0+ + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver only supports two-lane operation.
Please describe the hardware, not driver.
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 65
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +6
-0+ items: + - const: 1 + - const: 2 + + clock-noncontinuous: true + link-frequencies: true
I think these are coming from video-interfaces, so no need for them.
Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +9
-0+ + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocks
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 84
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +10
-0+ - VANA-supply + - VDIG-supply + - VDDL-supply + - port + +additionalProperties: false + +examples: + - | + i2c0 {
i2c
Quoted 30 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +23
-0+ #address-cells = <1>; + #size-cells = <0>; + + imx519: sensor@1a { + compatible = "sony,imx519"; + reg = <0x1a>; + clocks = <&imx519_clk>; + VANA-supply = <&imx519_vana>; /* 2.8v */ + VDIG-supply = <&imx519_vdig>; /* 1.05v */ + VDDL-supply = <&imx519_vddl>; /* 1.8v */ + + port { + imx519_0: endpoint { + remote-endpoint = <&csi1_ep>; + data-lanes = <1 2>; + clock-noncontinuous; + link-frequencies = /bits/ 64 <493500000>; + }; + }; + }; + }; + +...MAINTAINERS +0
-0@@ -19236,6 +19236,15 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
MAINTAINERS T: git git://linuxtv.org/media_tree.git · line 19246
Quoted 10 lines
MAINTAINERS +8
-0F: drivers/media/i2c/imx412.c +SONY IMX519 SENSOR DRIVER +M: Arducam Kernel Maintenance <[email protected]> +M: Lee Jackson <[email protected]> +L: [email protected] +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml +F: drivers/media/i2c/imx519.c
The file does not exist, so path is not correct (yet). Add it in 2/2.
Best regards,
Krzysztof
On Thu, 3 Nov 2022 09:05:05 -0400
Krzysztof Kozlowski <[email protected]> wrote:
Hi,
Thanks a lot for detailed comments and suggestions for revisions,there is one place where I have some doubts.
Quoted 52 lines · lee
Quoted 4 lines
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>Your From does not match fully SoB.
Quoted 33 lines
--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644
Documentation/devicetree/bindings/media/i2c/sony,imx519.yamldiff --git
a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlb/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlnew file mode 100644 index 000000000000..9b6cda96f613 ---/dev/null+++b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +13
-0@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital imagesensor
+ with an active array size of 4656H x 3496V. It is programmable through
+ I2C interface. The I2C address is fixed to0x1Aas per sensor data sheet.
+ Image data is sent through MIPI CSI-2, which is configured as either 2 orDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 24
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +8
-0+ 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device addressSkip description.
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 30
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +6
-0+ maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply:Use lower case names.
Here we refer to other drivers (imx219), they are all uppercase, is lowercase mandatory?
Quoted 109 lines
Quoted 20 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +15
-0+ description: + Digital I/O voltage supply, 1.05 volts + + VANA-supply: + description: + Analog voltage supply, 2.8 volts + + VDDL-supply: + description: + Digital core voltage supply, 1.8 volts + + reset-gpios: + description: |- + Reference to the GPIO connected to the xclr pin, if any. + Must be released (set high) after all supplies and INCK areapplied. +
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +3
-0+port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: falseDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 59
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +10
-0+ + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver only supports two-lane operation.Please describe the hardware, not driver.
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 65
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +6
-0+ items: + - const: 1 + - const: 2 + + clock-noncontinuous: true + link-frequencies: trueI think these are coming from video-interfaces, so no need for them.
Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +9
-0+ + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocksDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 84
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +10
-0+ - VANA-supply + - VDIG-supply + - VDDL-supply + - port + +additionalProperties: false + +examples: + - | + i2c0 {i2c
Quoted 39 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +23
-0+ #address-cells = <1>; + #size-cells = <0>; + + imx519: sensor@1a { + compatible = "sony,imx519"; + reg = <0x1a>; + clocks = <&imx519_clk>; + VANA-supply = <&imx519_vana>; /* 2.8v */ + VDIG-supply = <&imx519_vdig>; /* 1.05v */ + VDDL-supply = <&imx519_vddl>; /* 1.8v */ + + port { + imx519_0: endpoint { + remote-endpoint = <&csi1_ep>; + data-lanes = <1 2>; + clock-noncontinuous; + link-frequencies = /bits/ 64 <493500000>; + }; + }; + }; + }; + +...MAINTAINERS +0
-0@@ -19236,6 +19236,15 @@ T: git
git://linuxtv.org/media_tree.gitF:Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
F:drivers/media/i2c/imx412.cMAINTAINERS +7
-0+SONY IMX519 SENSOR DRIVER +M: Arducam Kernel Maintenance <[email protected]> +M: Lee Jackson <[email protected]> +L: [email protected] +S: Maintained +T: git git://linuxtv.org/media_tree.git +F:Quoted 2 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
+F:drivers/media/i2c/imx519.cThe file does not exist, so path is not correct (yet). Add it in 2/2.
Quoted 3 lines
Best regards,
Krzysztof
Best regards,
lee
Quoted 66 lines · lee
On Thu, 3 Nov 2022 09:05:05 -0400
Krzysztof Kozlowski <[email protected]> wrote:Hi,
Thanks a lot for detailed comments and suggestions for revisions,there is one place where I have some doubts.Quoted 52 lines · lee
Quoted 4 lines
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>Your From does not match fully SoB.
Quoted 33 lines
--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644
Documentation/devicetree/bindings/media/i2c/sony,imx519.yamldiff --git
a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlb/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlnew file mode 100644 index 000000000000..9b6cda96f613 ---/dev/null+++b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +13
-0@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital imagesensor
+ with an active array size of 4656H x 3496V. It is programmable through
+ I2C interface. The I2C address is fixed to0x1Aas per sensor data sheet.
+ Image data is sent through MIPI CSI-2, which is configured as either 2 orDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 24
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +8
-0+ 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device addressSkip description.
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 30
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +6
-0+ maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply:Use lower case names.
Quoted 1 line
Here we refer to other drivers (imx219), they are all uppercase, is lowercase mandatory?
Lowercase is the convention. Just because some other driver used uppercase is not really correct argument. If other driver has bug, you also copy it?
Best regards,
Krzysztof
Quoted 71 lines · On Mon, 7 Nov 2022 09:24:53 +0100 Krzysztof Kozlowski…
Quoted 67 lines · lee
On Thu, 3 Nov 2022 09:05:05 -0400
Krzysztof Kozlowski <[email protected]> wrote:Hi,
Thanks a lot for detailed comments and suggestions for revisions,there is one place where I have some doubts.Quoted 52 lines · lee
Quoted 4 lines
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>Your From does not match fully SoB.
Quoted 33 lines
--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644
Documentation/devicetree/bindings/media/i2c/sony,imx519.yamldiff --git
a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlb/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlnew file mode 100644 index 000000000000..9b6cda96f613 ---/dev/null+++b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +13
-0@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital imagesensor
+ with an active array size of 4656H x 3496V. It is programmable through
+ I2C interface. The I2C address is fixed to0x1Aas per sensor data sheet.
+ Image data is sent through MIPI CSI-2, which is configured as either 2 orDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 24
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +8
-0+ 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device addressSkip description.
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 30
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +6
-0+ maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply:Use lower case names.
Quoted 2 lines
Here we refer to other drivers (imx219), they are all uppercase, is lowercase mandatory?
Quoted 8 lines
Lowercase is the convention. Just because some other driver used uppercase is not really correct argument. If other driver has bug, you also copy it?
Best regards,
Krzysztof
Hi,
Thanks for your quick reply.
I just want to refer to the driver that has passed the review, as a template, is there anything I can refer to? Do you have any good suggestions?