dt-bindings: media: i2c: Add IMX519 CMOS sensor binding
Subsystems (2)
PATCH v2 1/2 dt-bindings: media: i2c: Add IMX519 CMOS sensor binding
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant MAINTAINERS entries.
--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +107 -0
@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor + with an active array size of 4656H x 3496V. It is programmable through + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. + Image data is sent through MIPI CSI-2, which is configured as either 2 or + 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device address + maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply: + description: + Digital I/O voltage supply, 1.05 volts + + VANA-supply: + description: + Analog voltage supply, 2.8 volts + + VDDL-supply: + description: + Digital core voltage supply, 1.8 volts + + reset-gpios: + description: |- + Reference to the GPIO connected to the xclr pin, if any. + Must be released (set high) after all supplies and INCK are applied. + +port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver only supports two-lane operation. + items: + - const: 1 + - const: 2 + + clock-noncontinuous: true + link-frequencies: true + + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocks + - VANA-supply + - VDIG-supply + - VDDL-supply + - port + +additionalProperties: false + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + imx519: sensor@1a { + compatible = "sony,imx519"; + reg = <0x1a>; + clocks = <&imx519_clk>; + VANA-supply = <&imx519_vana>; /* 2.8v */ + VDIG-supply = <&imx519_vdig>; /* 1.05v */ + VDDL-supply = <&imx519_vddl>; /* 1.8v */ + + port { + imx519_0: endpoint { + remote-endpoint = <&csi1_ep>; + data-lanes = <1 2>; + clock-noncontinuous; + link-frequencies = /bits/ 64 <493500000>; + }; + }; + }; + }; + +...
MAINTAINERS +9 -0
@@ -19236,6 +19236,15 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml F: drivers/media/i2c/imx412.c +SONY IMX519 SENSOR DRIVER +M: Arducam Kernel Maintenance <[email protected]> +M: Lee Jackson <[email protected]> +L: [email protected] +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml +F: drivers/media/i2c/imx519.c + SONY MEMORYSTICK SUBSYSTEM M: Maxim Levitsky <[email protected]> M: Alex Dubov <[email protected]>
Signature · 1 line
2.25.1
Rob Herring
maintainerQuoted 10 lines · lee
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:./Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml:48:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml: 'port' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx519.example.dtb: sensor@1a: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
Quoted 30 lines · lee
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +14
-0@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor + with an active array size of 4656H x 3496V. It is programmable through
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 24
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +10
-0+ I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. + Image data is sent through MIPI CSI-2, which is configured as either 2 or + 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device address
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
Quoted 54 lines · On Fri, 4 Nov 2022 09:17:15 -0400 Krzysztof Kozlowski…
Quoted 37 lines · lee
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>--- .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ MAINTAINERS | 9 ++ 2 files changed, 116 insertions(+) create mode 100644
Documentation/devicetree/bindings/media/i2c/sony,imx519.yamldiff --git
a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlb/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlnew file mode 100644 index 000000000000..9b6cda96f613 ---/dev/null+++b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yamlDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +13
-0@@ -0,0 +1,107 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <[email protected]> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital imagesensor
+ with an active array size of 4656H x 3496V. It is programmable through
+ I2C interface. The I2C address is fixed to0x1Aas per sensor data sheet.
+ Image data is sent through MIPI CSI-2, which is configured as either 2 orDocumentation/devicetree/bindings/media/i2c/sony,imx519.yaml line 24
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new file +8
-0+ 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device addressThis is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Quoted 5 lines
Thank you.
Best regards,
Krzysztof
Hi,
Thanks for your friendly reminder. Sorry for my last error commit. I have modified the dts based on your comments and resubmitted new driver. I have checked it using make dt_binding_check command.
You are welcome to submit new comments again.
Have a nice day.
Lee.
Quoted 5 lines · lee
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant
MAINTAINERSentries.Signed-off-by Lee Jackson <[email protected]>---
For the record - seems none of the comments were applied (not just one or two), so you just ignored all of them.
Best regards,
Krzysztof