net: dsa: b53: mmap: Add bcm63268 GPHY power control
cover net: dsa: b53: mmap: Add bcm63268 GPHY power control
The gpio controller on the bcm63268 has a register for controlling the gigabit phy power. These patches disable low power mode when enabling the gphy port.
This is based on an earlier patch series here:
https://lore.kernel.org/netdev/[email protected]/
I have created a new series since many of the changes were included in the ephy control patches:
https://lore.kernel.org/netdev/[email protected]/
Kyle Hendry (2):
net: dsa: b53: mmap: Add gphy port to phy info for bcm63268
net: dsa: b53: mmap: Implement bcm63268 gphy power control
drivers/net/dsa/b53/b53_mmap.c | 35 ++++++++++++++++++++++++++++++---- 1 file changed, 31 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0
PATCH RESEND 1/2 net: dsa: b53: mmap: Add gphy port to phy info for bcm63268
Add gphy mask to bcm63xx phy info struct and add data for bcm63268
--- drivers/net/dsa/b53/b53_mmap.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/dsa/b53/b53_mmap.c +2 -0
@@ -31,6 +31,7 @@#define BCM63XX_EPHY_REG 0x3Cstruct b53_phy_info { +u32 gphy_port_mask;u32 ephy_enable_mask;u32 ephy_port_mask;u32 ephy_bias_bit;
@@ -65,6 +66,7 @@ static const struct b53_phy_info bcm6368_ephy_info = {static const u32 bcm63268_ephy_offsets[] = {4 ,9 ,14 };static const struct b53_phy_info bcm63268_ephy_info = { + .gphy_port_mask =BIT (3 ), .ephy_enable_mask =GENMASK (4 ,0 ), .ephy_port_mask =GENMASK ((ARRAY_SIZE (bcm63268_ephy_offsets) -1 ),0 ), .ephy_bias_bit =24 ,
Signature · 1 line
2.43.0
PATCH RESEND 2/2 net: dsa: b53: mmap: Implement bcm63268 gphy power control
In reply to Kyle HendryAdd check for gphy in enable/disable phy calls and set power bits in gphy control register.
--- drivers/net/dsa/b53/b53_mmap.c | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-)
drivers/net/dsa/b53/b53_mmap.c +29 -4
@@ -29,6 +29,10 @@#include "b53_priv.h" #define BCM63XX_EPHY_REG 0x3C +#define BCM63268_GPHY_REG 0x54 + +#define GPHY_CTRL_LOW_PWR BIT(3) +#define GPHY_CTRL_IDDQ_BIAS BIT(0)struct b53_phy_info {u32 gphy_port_mask;
@@ -292,13 +296,30 @@ static int bcm63xx_ephy_set(struct b53_device *dev, int port, bool enable)return regmap_update_bits (gpio_ctrl,BCM63XX_EPHY_REG , mask, val); } +static int bcm63268_gphy_set (struct b53_device *dev,bool enable) +{ +struct b53_mmap_priv *priv = dev->priv; +struct regmap *gpio_ctrl = priv->gpio_ctrl; +u32 mask =GPHY_CTRL_IDDQ_BIAS |GPHY_CTRL_LOW_PWR ; +u32 val =0 ; + +if (!enable) + val = mask; + +return regmap_update_bits (gpio_ctrl,BCM63268_GPHY_REG , mask, val); +} +static void b53_mmap_phy_enable (struct b53_device *dev,int port) {struct b53_mmap_priv *priv = dev->priv;int ret =0 ; -if (priv->phy_info && (BIT (port) & priv->phy_info->ephy_port_mask)) - ret =bcm63xx_ephy_set (dev, port, true); +if (priv->phy_info) { +if (BIT (port) & priv->phy_info->ephy_port_mask) + ret =bcm63xx_ephy_set (dev, port, true); +else if (BIT (port) & priv->phy_info->gphy_port_mask) + ret =bcm63268_gphy_set (dev, true); + }if (!ret) priv->phys_enabled |=BIT (port);
@@ -309,8 +330,12 @@ static void b53_mmap_phy_disable(struct b53_device *dev, int port)struct b53_mmap_priv *priv = dev->priv;int ret =0 ; -if (priv->phy_info && (BIT (port) & priv->phy_info->ephy_port_mask)) - ret =bcm63xx_ephy_set (dev, port, false); +if (priv->phy_info) { +if (BIT (port) & priv->phy_info->ephy_port_mask) + ret =bcm63xx_ephy_set (dev, port, false); +else if (BIT (port) & priv->phy_info->gphy_port_mask) + ret =bcm63268_gphy_set (dev, false); + }if (!ret) priv->phys_enabled &= ~BIT (port);
Signature · 1 line
2.43.0
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 13 Aug 2025 17:25:26 -0700 you wrote:
The gpio controller on the bcm63268 has a register for controlling the gigabit phy power. These patches disable low power mode when enabling the gphy port.
This is based on an earlier patch series here:
https://lore.kernel.org/netdev/[email protected]/[...]
Here is the summary with links:
- [RESEND,net-next,1/2] net: dsa: b53: mmap: Add gphy port to phy info for bcm63268
https://git.kernel.org/netdev/net-next/c/7f95f04fe190 - [RESEND,net-next,2/2] net: dsa: b53: mmap: Implement bcm63268 gphy power control https://git.kernel.org/netdev/net-next/c/61730ac10ba9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html