Skip to contentSkip to conversation

Incorrect Kconfig dependencies

PATCH New Michal Simek 5 participants 32 messages Aug 19, 2020 – Sep 23, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Incorrect Kconfig dependencies

Hi,

I wanted to take a look at running randconfig and I found that there are a lot of issues in connection to setting up right dependencies. This is visible when you run make randconfig and going through reported issues.
I have created several patches to fix them. I am not quite sure if it is more recommended to use more depends on instead of selecting missing options. Please let me know what's the preferred way.

Thanks,
Michal

Michal Simek (9):
pci: kconfig: Setup proper dependency for PCIE_ROCKCHIP
cmd: Kconfig: Add missing dependency for cmd gpt
cmd: Kconfig: Change dependency for CMD_ADC
nand: Kconfig: Change dependency for NAND_ARASAN
cmd: Kconfig: Change dependency of CMD_USB_SDP
arc: Kconfig: Add missing DM dependency
ARM: zynqmp: Fix SPL_DM_SPI dependencies
cmd: Kconfig: Fix dependencies for CMD_USB_MASS_STORAGE
env: Kconfig: Add missing dependency for ENV_IS_IN_EXT4

 arch/Kconfig                 | 1 +
 arch/arm/Kconfig             | 3 ++-
 cmd/Kconfig                  | 7 ++++---
 drivers/mtd/nand/raw/Kconfig | 2 +-
 drivers/pci/Kconfig          | 1 +
 env/Kconfig                  | 1 +
 6 files changed, 10 insertions(+), 5 deletions(-)
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/9 pci: kconfig: Setup proper dependency for PCIE_ROCKCHIP

There is missing dependency for PCIE_ROCKCHIP which selects PHY_ROCKCHIP_PCIE which directly depends on ARCH_ROCKCHIP.

WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_PCIE
Depends on [n]: ARCH_ROCKCHIP [=n]
Selected by [y]:
- PCIE_ROCKCHIP [=y] && PCI [=y]

---

Got this issue via randconfig

---
 drivers/pci/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/Kconfig +1 -0
index 5e0a39396bb0..cb41c4f55bba 100644
@@ -223,6 +223,7 @@ config PCIE_MEDIATEK
 
 config PCIE_ROCKCHIP
 	bool "Enable Rockchip PCIe driver"
+	depends on ARCH_ROCKCHIP
 	select DM_PCI
 	select PHY_ROCKCHIP_PCIE
 	default y if ROCKCHIP_RK3399
Signature · 1 line
2.28.0
#4 lore raw

PATCH 2/9 cmd: Kconfig: Add missing dependency for cmd gpt

In reply to Michal Simek

Command gpt select PARTITION_UUIDS which depends on PARTITIONS which is doesn't need to be enabled.

Kconfig reports it like this.

WARNING: unmet direct dependencies detected for PARTITION_UUIDS
Depends on [n]: PARTITIONS [=n]
Selected by [y]:
- CMD_GPT [=y]

---

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +1 -0
index 9ad511aa176f..692fae5b8e89 100644
@@ -1012,6 +1012,7 @@ config CMD_GPT
 	bool "GPT (GUID Partition Table) command"
 	select EFI_PARTITION
 	select HAVE_BLOCK_DEVICE
+	select PARTITIONS
 	select PARTITION_UUIDS
 	imply RANDOM_UUID
 	help
Signature · 1 line
2.28.0
#9 lore raw

PATCH 3/9 cmd: Kconfig: Change dependency for CMD_ADC

In reply to Michal Simek

CMD_ADC selected DM_REGULATOR unconditionally without enabling DM. That's why change select to depends on to cover it.

Kconfig is showing this issue as:
WARNING: unmet direct dependencies detected for REGMAP
Depends on [n]: DM [=n]
Selected by [y]:
- DM_REGULATOR_PBIAS [=y] && DM_REGULATOR [=y]

---

 cmd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/Kconfig +1 -1
index 692fae5b8e89..bd3559ae6c12 100644
@@ -854,7 +854,7 @@ config CMD_ARMFLASH
 config CMD_ADC
 	bool "adc - Access Analog to Digital Converters info and data"
 	select ADC
-	select DM_REGULATOR
+	depends on DM_REGULATOR
 	help
 	  Shows ADC device info and permit printing one-shot analog converted
 	  data from a named Analog to Digital Converter.
Signature · 1 line
2.28.0
#12 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

In reply to Michal Simek

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/raw/Kconfig +1 -1
index 06b2ff972cad..df4cbd52cf5c 100644
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
 	bool "Configure Arasan Nand"
 	select SYS_NAND_SELF_INIT
-	select DM_MTD
+	depends on DM_MTD
 	imply CMD_NAND
 	help
 	  This enables Nand driver support for Arasan nand flash
Signature · 1 line
2.28.0
#20 lore raw

PATCH 5/9 cmd: Kconfig: Change dependency of CMD_USB_SDP

In reply to Michal Simek

USB_FUNCTION_SDP depends on USB_GADGET_DOWNLOAD to be enabled which is not reflect in Kconfig. Fix it by changing select to depends on for CMD_USB_SDP command.
Kconfig is reporting it as:
WARNING: unmet direct dependencies detected for USB_FUNCTION_SDP
Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] Selected by [y]:
- CMD_USB_SDP [=y]

---

 cmd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/Kconfig +1 -1
index bd3559ae6c12..f291c8cbf423 100644
@@ -1351,7 +1351,7 @@ config CMD_USB
 
 config CMD_USB_SDP
 	bool "sdp"
-	select USB_FUNCTION_SDP
+	depends on USB_FUNCTION_SDP
 	help
 	  Enables the command "sdp" which is used to have U-Boot emulating the
 	  Serial Download Protocol (SDP) via USB.
Signature · 1 line
2.28.0
#22 lore raw

PATCH 6/9 arc: Kconfig: Add missing DM dependency

In reply to Michal Simek

ARC is selecting TIMER which depends on DM but DM is not selected and doesn't need to be enabled. Fix it by selecting DM for ARC architecture.

Kconfig is showing this missing dependency by:
WARNING: unmet direct dependencies detected for TIMER
Depends on [n]: DM [=n]
Selected by [y]:
- ARC [=y] && <choice>

---

 arch/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/Kconfig +1 -0
index e4a0a0230c1f..683e38431906 100644
@@ -12,6 +12,7 @@ config ARC
 	bool "ARC architecture"
 	select ARC_TIMER
 	select CLK
+	select DM
 	select HAVE_PRIVATE_LIBGCC
 	select SUPPORT_OF_CONTROL
 	select TIMER
Signature · 1 line
2.28.0
#25 lore raw

PATCH 7/9 ARM: zynqmp: Fix SPL_DM_SPI dependencies

In reply to Michal Simek

Add missing dependencies for DM_SPI_FLASH.
Kconfig reports it as:
WARNING: unmet direct dependencies detected for SPL_DM_SPI_FLASH
Depends on [n]: SPL [=n] && SPL_DM [=n]
Selected by [y]:
- ARCH_ZYNQMP [=y] && <choice> && SPL_DM_SPI [=y]

---

 arch/arm/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/Kconfig +2 -1
index bb71b1647650..1d8e6975fe57 100644
@@ -1153,7 +1153,8 @@ config ARCH_ZYNQMP
 	select OF_CONTROL
 	select SPL_BOARD_INIT if SPL
 	select SPL_CLK if SPL
-	select SPL_DM_SPI if SPI
+	select SPL_DM if SPL
+	select SPL_DM_SPI if SPI && SPL_DM
 	select SPL_DM_SPI_FLASH if SPL_DM_SPI
 	select SPL_DM_MAILBOX if SPL
 	select SPL_FIRMWARE if SPL
Signature · 1 line
2.28.0
#27 lore raw

PATCH 8/9 cmd: Kconfig: Fix dependencies for CMD_USB_MASS_STORAGE

In reply to Michal Simek

There are missing dependencies for selecting USB_FUNCTION_MASS_STORAGE. Change select to depends on instead of selecting all required options. Kconfig reports this issue as:
WARNING: unmet direct dependencies detected for USB_FUNCTION_MASS_STORAGE
Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] Selected by [y]:
- CMD_USB_MASS_STORAGE [=y]

---

 cmd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/Kconfig +1 -1
index f291c8cbf423..eebaaa420bf1 100644
@@ -1367,7 +1367,7 @@ config CMD_ROCKUSB
 
 config CMD_USB_MASS_STORAGE
 	bool "UMS usb mass storage"
-	select USB_FUNCTION_MASS_STORAGE
+	depends on USB_FUNCTION_MASS_STORAGE
 	help
 	  USB mass storage support
 
Signature · 1 line
2.28.0
#29 lore raw

PATCH 9/9 env: Kconfig: Add missing dependency for ENV_IS_IN_EXT4

In reply to Michal Simek

ENV_IS_IN_EXT4 also need to enable FS_EXT4 which is not covered in Kconfig. Kconfig reports this as:
WARNING: unmet direct dependencies detected for EXT4_WRITE
Depends on [n]: FS_EXT4 [=n]
Selected by [y]:
- ENV_IS_IN_EXT4 [=y] && !CHAIN_OF_TRUST [=n]

---

 env/Kconfig | 1 +
 1 file changed, 1 insertion(+)
env/Kconfig +1 -0
index af4d9cbaa4d8..b59ba310ec3d 100644
@@ -72,6 +72,7 @@ config ENV_IS_IN_FAT
 config ENV_IS_IN_EXT4
 	bool "Environment is in a EXT4 filesystem"
 	depends on !CHAIN_OF_TRUST
+	select FS_EXT4
 	select EXT4_WRITE
 	help
 	  Define this if you want to use the EXT4 file system for the environment.
Signature · 1 line
2.28.0
#5 lore raw

PATCH 2/9 cmd: Kconfig: Add missing dependency for cmd gpt

In reply to Michal Simek
Quoted 21 lines · Michal Simek

Command gpt select PARTITION_UUIDS which depends on PARTITIONS which is doesn't need to be enabled.

Kconfig reports it like this.

WARNING: unmet direct dependencies detected for PARTITION_UUIDS
Depends on [n]: PARTITIONS [=n]
Selected by [y]:
- CMD_GPT [=y]

---

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +0 -0
index 9ad511aa176f..692fae5b8e89 100644

cmd/Kconfig config CMD_GPT · line 1016

Quoted 5 lines
cmd/Kconfig +1 -0
@@ -1012,6 +1012,7 @@ config CMD_GPT
 	bool "GPT (GUID Partition Table) command"
 	select EFI_PARTITION
 	select HAVE_BLOCK_DEVICE
+	select PARTITIONS
 	select PARTITION_UUIDS

It would be preferable to use "depends" instead of "select".

You don't want anybody to select this command on a device that does not even have block devices.

Best regards

Heinrich

Quoted 3 lines
cmd/Kconfig +0 -0
 	imply RANDOM_UUID
 	help
#6 lore raw

PATCH 2/9 cmd: Kconfig: Add missing dependency for cmd gpt

Quoted 30 lines · Heinrich Schuchardt
Quoted 21 lines · Michal Simek

Command gpt select PARTITION_UUIDS which depends on PARTITIONS which is doesn't need to be enabled.

Kconfig reports it like this.

WARNING: unmet direct dependencies detected for PARTITION_UUIDS
Depends on [n]: PARTITIONS [=n]
Selected by [y]:
- CMD_GPT [=y]

---

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +0 -0
index 9ad511aa176f..692fae5b8e89 100644

cmd/Kconfig config CMD_GPT · line 1016

Quoted 5 lines
cmd/Kconfig +1 -0
@@ -1012,6 +1012,7 @@ config CMD_GPT
 	bool "GPT (GUID Partition Table) command"
 	select EFI_PARTITION
 	select HAVE_BLOCK_DEVICE
+	select PARTITIONS
 	select PARTITION_UUIDS

It would be preferable to use "depends" instead of "select".

Quoted 2 lines

You don't want anybody to select this command on a device that does not even have block devices.

Do we have any doc which is talking about preferred ways?

If you look at all patches I have used mostly depends on instead of select with 2 exception. This patch and then last one 9/9.

In this case I use select because as you use there is already a lot of other selection for EFI, BLOCK_DEVICE and UUIDS.

Thanks,
Michal

#7 lore raw

PATCH 2/9 cmd: Kconfig: Add missing dependency for cmd gpt

Quoted 36 lines · Michal Simek
Quoted 30 lines · Heinrich Schuchardt
Quoted 21 lines · Michal Simek

Command gpt select PARTITION_UUIDS which depends on PARTITIONS which is doesn't need to be enabled.

Kconfig reports it like this.

WARNING: unmet direct dependencies detected for PARTITION_UUIDS
Depends on [n]: PARTITIONS [=n]
Selected by [y]:
- CMD_GPT [=y]

---

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +0 -0
index 9ad511aa176f..692fae5b8e89 100644

cmd/Kconfig config CMD_GPT · line 1016

Quoted 5 lines
cmd/Kconfig +1 -0
@@ -1012,6 +1012,7 @@ config CMD_GPT
 	bool "GPT (GUID Partition Table) command"
 	select EFI_PARTITION
 	select HAVE_BLOCK_DEVICE
+	select PARTITIONS
 	select PARTITION_UUIDS

It would be preferable to use "depends" instead of "select".

Quoted 2 lines

You don't want anybody to select this command on a device that does not even have block devices.

Quoted 7 lines

Do we have any doc which is talking about preferred ways?

If you look at all patches I have used mostly depends on instead of select with 2 exception. This patch and then last one 9/9.

In this case I use select because as you use there is already a lot of other selection for EFI, BLOCK_DEVICE and UUIDS.

Select allows you to set something whose own dependencies are not fulfilled. So depends is preferable.

Best regards

Heinrich

#8 lore raw

PATCH 2/9 cmd: Kconfig: Add missing dependency for cmd gpt

In reply to Michal Simek
Quoted 34 lines · Michal Simek
Quoted 30 lines · Heinrich Schuchardt
Quoted 21 lines · Michal Simek

Command gpt select PARTITION_UUIDS which depends on PARTITIONS which is doesn't need to be enabled.

Kconfig reports it like this.

WARNING: unmet direct dependencies detected for PARTITION_UUIDS
Depends on [n]: PARTITIONS [=n]
Selected by [y]:
- CMD_GPT [=y]

---

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +0 -0
index 9ad511aa176f..692fae5b8e89 100644

cmd/Kconfig config CMD_GPT · line 1016

Quoted 5 lines
cmd/Kconfig +1 -0
@@ -1012,6 +1012,7 @@ config CMD_GPT
 	bool "GPT (GUID Partition Table) command"
 	select EFI_PARTITION
 	select HAVE_BLOCK_DEVICE
+	select PARTITIONS
 	select PARTITION_UUIDS

It would be preferable to use "depends" instead of "select".

Quoted 2 lines

You don't want anybody to select this command on a device that does not even have block devices.

Quoted 7 lines

Do we have any doc which is talking about preferred ways?

If you look at all patches I have used mostly depends on instead of select with 2 exception. This patch and then last one 9/9.

In this case I use select because as you use there is already a lot of other selection for EFI, BLOCK_DEVICE and UUIDS.

We don't have a preferred way to solve these problems because it depends on what the problem even is to start with. Library type functionality should be select'd while configurable functionality should be depend'd on.

In this case, PARTITION_UUIDS enables code in disk/part_dos.c and disk/part_efi.c to get and store UUID information from the existing table (and cmd/gpt.c is setting/etc those UUIDs).

So I suspect audit'ing these symbols down further to see what the code usage of them requires is and going back up to the Kconfig logic is what's needed here.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/a1cd8b2b/attachment.sig>
#2 lore raw

PATCH 1/9 pci: kconfig: Setup proper dependency for PCIE_ROCKCHIP

In reply to Michal Simek
Quoted 21 lines · Michal Simek

There is missing dependency for PCIE_ROCKCHIP which selects PHY_ROCKCHIP_PCIE which directly depends on ARCH_ROCKCHIP.

WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_PCIE
Depends on [n]: ARCH_ROCKCHIP [=n]
Selected by [y]:
- PCIE_ROCKCHIP [=y] && PCI [=y]

---

Got this issue via randconfig

---
 drivers/pci/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/Kconfig +0 -0
index 5e0a39396bb0..cb41c4f55bba 100644

drivers/pci/Kconfig config PCIE_MEDIATEK · line 229

Quoted 7 lines
drivers/pci/Kconfig +1 -0
@@ -223,6 +223,7 @@ config PCIE_MEDIATEK
 
 config PCIE_ROCKCHIP
 	bool "Enable Rockchip PCIe driver"
+	depends on ARCH_ROCKCHIP
 	select DM_PCI
 	select PHY_ROCKCHIP_PCIE
 	default y if ROCKCHIP_RK3399

Since we probably can't enable this on sandbox, this is probably right.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/e4c2b6ed/attachment.sig>
#30 lore raw

PATCH 9/9 env: Kconfig: Add missing dependency for ENV_IS_IN_EXT4

In reply to Michal Simek
Quoted 8 lines · Michal Simek

ENV_IS_IN_EXT4 also need to enable FS_EXT4 which is not covered in Kconfig. Kconfig reports this as:
WARNING: unmet direct dependencies detected for EXT4_WRITE
Depends on [n]: FS_EXT4 [=n]
Selected by [y]:
- ENV_IS_IN_EXT4 [=y] && !CHAIN_OF_TRUST [=n]

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/2f40d293/attachment.sig>
#10 lore raw

PATCH 3/9 cmd: Kconfig: Change dependency for CMD_ADC

In reply to Michal Simek
Quoted 10 lines · Michal Simek

CMD_ADC selected DM_REGULATOR unconditionally without enabling DM. That's why change select to depends on to cover it.

Kconfig is showing this issue as:
WARNING: unmet direct dependencies detected for REGMAP
Depends on [n]: DM [=n]
Selected by [y]:
- DM_REGULATOR_PBIAS [=y] && DM_REGULATOR [=y]

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/467a7401/attachment.sig>
#13 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

In reply to Michal Simek
Quoted 19 lines · Michal Simek

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/raw/Kconfig +0 -0
index 06b2ff972cad..df4cbd52cf5c 100644

drivers/mtd/nand/raw/Kconfig endif · line 239

Quoted 8 lines
drivers/mtd/nand/raw/Kconfig +1 -1
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
 	bool "Configure Arasan Nand"
 	select SYS_NAND_SELF_INIT
-	select DM_MTD
+	depends on DM_MTD
 	imply CMD_NAND
 	help
 	  This enables Nand driver support for Arasan nand flash

If we can use the driver without DM then we can't depend nor select DM_MTD. Is someone using the driver still without DM_MTD?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/0f395505/attachment.sig>
#14 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

Quoted 16 lines · Tom Rini
Quoted 14 lines · Michal Simek

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

drivers/mtd/nand/raw/Kconfig endif · line 239

Quoted 13 lines
drivers/mtd/nand/raw/Kconfig +1 -1
index 06b2ff972cad..df4cbd52cf5c 100644
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
 	bool "Configure Arasan Nand"
 	select SYS_NAND_SELF_INIT
-	select DM_MTD
+	depends on DM_MTD
 	imply CMD_NAND
 	help
 	  This enables Nand driver support for Arasan nand flash

If we can use the driver without DM then we can't depend nor select DM_MTD. Is someone using the driver still without DM_MTD?

Driver has been converted to DM already. It is used by ZynqMP platforms. And it can't be used without DM_MTD.

commit b014b833bd627d27542b50e71df9cf0628f241e7

Author:     Ashok Reddy Soma <[email protected]>
AuthorDate: Thu Dec 19 02:27:42 2019 -0700
Commit:     Michal Simek <[email protected]>
CommitDate: Tue Jan 14 09:05:52 2020 +0100

mtd: nand: Move arasan nand driver to driver model

Make changes to arasan nand driver to move it to driver model. Select DM_MTD if arasan nand driver is selected.

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/f484f607/attachment.sig>

#21 lore raw

PATCH 5/9 cmd: Kconfig: Change dependency of CMD_USB_SDP

In reply to Michal Simek
Quoted 20 lines · Michal Simek

USB_FUNCTION_SDP depends on USB_GADGET_DOWNLOAD to be enabled which is not reflect in Kconfig. Fix it by changing select to depends on for CMD_USB_SDP command.
Kconfig is reporting it as:
WARNING: unmet direct dependencies detected for USB_FUNCTION_SDP
Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] Selected by [y]:
- CMD_USB_SDP [=y]

---

 cmd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/Kconfig +0 -0
index bd3559ae6c12..f291c8cbf423 100644

cmd/Kconfig config CMD_USB · line 1357

Quoted 8 lines
cmd/Kconfig +1 -1
@@ -1351,7 +1351,7 @@ config CMD_USB
 
 config CMD_USB_SDP
 	bool "sdp"
-	select USB_FUNCTION_SDP
+	depends on USB_FUNCTION_SDP
 	help
 	  Enables the command "sdp" which is used to have U-Boot emulating the
 	  Serial Download Protocol (SDP) via USB.

Based on usage, USB_FUNCTION_SDP looks to really be a library type function. Adding some iMX folks as it's used there, and Lokesh since the K2G platforms enable the library side, but I don't think use it?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/f6501d52/attachment.sig>
#28 lore raw

PATCH 8/9 cmd: Kconfig: Fix dependencies for CMD_USB_MASS_STORAGE

In reply to Michal Simek
Quoted 19 lines · Michal Simek

There are missing dependencies for selecting USB_FUNCTION_MASS_STORAGE. Change select to depends on instead of selecting all required options. Kconfig reports this issue as:
WARNING: unmet direct dependencies detected for USB_FUNCTION_MASS_STORAGE
Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] Selected by [y]:
- CMD_USB_MASS_STORAGE [=y]

---

 cmd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/Kconfig +0 -0
index f291c8cbf423..eebaaa420bf1 100644

cmd/Kconfig config CMD_ROCKUSB · line 1372

Quoted 7 lines
cmd/Kconfig +1 -1
@@ -1367,7 +1367,7 @@ config CMD_ROCKUSB
 
 config CMD_USB_MASS_STORAGE
 	bool "UMS usb mass storage"
-	select USB_FUNCTION_MASS_STORAGE
+	depends on USB_FUNCTION_MASS_STORAGE
 	help
 	  USB mass storage support

Similar to the SDP issue, perhaps we have USB symbols that in turn need to be select'ing other library functions they use?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/76f26f20/attachment.sig>
#15 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

In reply to Michal Simek
Quoted 44 lines · Michal Simek
Quoted 16 lines · Tom Rini
Quoted 14 lines · Michal Simek

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

drivers/mtd/nand/raw/Kconfig endif · line 239

Quoted 13 lines
drivers/mtd/nand/raw/Kconfig +1 -1
index 06b2ff972cad..df4cbd52cf5c 100644
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
 	bool "Configure Arasan Nand"
 	select SYS_NAND_SELF_INIT
-	select DM_MTD
+	depends on DM_MTD
 	imply CMD_NAND
 	help
 	  This enables Nand driver support for Arasan nand flash

If we can use the driver without DM then we can't depend nor select DM_MTD. Is someone using the driver still without DM_MTD?

Driver has been converted to DM already. It is used by ZynqMP platforms. And it can't be used without DM_MTD.

commit b014b833bd627d27542b50e71df9cf0628f241e7

Author:     Ashok Reddy Soma <[email protected]>
AuthorDate: Thu Dec 19 02:27:42 2019 -0700
Commit:     Michal Simek <[email protected]>
CommitDate: Tue Jan 14 09:05:52 2020 +0100
Quoted 7 lines

mtd: nand: Move arasan nand driver to driver model

Make changes to arasan nand driver to move it to driver model. Select DM_MTD if arasan nand driver is selected.

Ah, I misunderstood the comment, sorry. Yes, this is right then, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/5364363e/attachment.sig>
#16 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

Quoted 50 lines · Tom Rini
Quoted 49 lines · Michal Simek
Quoted 16 lines · Tom Rini
Quoted 14 lines · Michal Simek

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

drivers/mtd/nand/raw/Kconfig endif · line 239

Quoted 13 lines
drivers/mtd/nand/raw/Kconfig +1 -1
index 06b2ff972cad..df4cbd52cf5c 100644
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
 	bool "Configure Arasan Nand"
 	select SYS_NAND_SELF_INIT
-	select DM_MTD
+	depends on DM_MTD
 	imply CMD_NAND
 	help
 	  This enables Nand driver support for Arasan nand flash

If we can use the driver without DM then we can't depend nor select DM_MTD. Is someone using the driver still without DM_MTD?

Driver has been converted to DM already. It is used by ZynqMP platforms. And it can't be used without DM_MTD.

commit b014b833bd627d27542b50e71df9cf0628f241e7

Author:     Ashok Reddy Soma <[email protected]>
AuthorDate: Thu Dec 19 02:27:42 2019 -0700
Commit:     Michal Simek <[email protected]>
CommitDate: Tue Jan 14 09:05:52 2020 +0100

mtd: nand: Move arasan nand driver to driver model

Make changes to arasan nand driver to move it to driver model. Select DM_MTD if arasan nand driver is selected.

Quoted 8 lines
Quoted 2 lines

Ah, I misunderstood the comment, sorry. Yes, this is right then, thanks.

ok. I just need to enable this symbol for zynqmp platforms.

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/92588579/attachment.sig>

#17 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

Quoted 56 lines · Michal Simek
Quoted 53 lines · Tom Rini
Quoted 51 lines · Michal Simek
Quoted 16 lines · Tom Rini
Quoted 14 lines · Michal Simek

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

drivers/mtd/nand/raw/Kconfig endif · line 239

Quoted 13 lines
drivers/mtd/nand/raw/Kconfig +1 -1
index 06b2ff972cad..df4cbd52cf5c 100644
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
 	bool "Configure Arasan Nand"
 	select SYS_NAND_SELF_INIT
-	select DM_MTD
+	depends on DM_MTD
 	imply CMD_NAND
 	help
 	  This enables Nand driver support for Arasan nand flash

If we can use the driver without DM then we can't depend nor select DM_MTD. Is someone using the driver still without DM_MTD?

Driver has been converted to DM already. It is used by ZynqMP platforms. And it can't be used without DM_MTD.

commit b014b833bd627d27542b50e71df9cf0628f241e7

Author:     Ashok Reddy Soma <[email protected]>
AuthorDate: Thu Dec 19 02:27:42 2019 -0700
Commit:     Michal Simek <[email protected]>
CommitDate: Tue Jan 14 09:05:52 2020 +0100

mtd: nand: Move arasan nand driver to driver model

Make changes to arasan nand driver to move it to driver model. Select DM_MTD if arasan nand driver is selected.

Quoted 7 lines
Quoted 5 lines

Ah, I misunderstood the comment, sorry. Yes, this is right then, thanks.

ok. I just need to enable this symbol for zynqmp platforms.

That is the hard part about all of these patches, when you go from "select X" to "depends on X", you also need to run a script and make sure that every config that enables the main symbol (NAND_ARASAN) also enables the now depended on symbol (DM_MTD) and sync the configs after the change.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/12e856ae/attachment.sig>
#18 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

Quoted 63 lines · Tom Rini
Quoted 62 lines · Michal Simek
Quoted 58 lines · Tom Rini
Quoted 44 lines · Michal Simek
Quoted 16 lines · Tom Rini
Quoted 14 lines · Michal Simek

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

drivers/mtd/nand/raw/Kconfig endif · line 239

Quoted 13 lines
drivers/mtd/nand/raw/Kconfig +1 -1
index 06b2ff972cad..df4cbd52cf5c 100644
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
 	bool "Configure Arasan Nand"
 	select SYS_NAND_SELF_INIT
-	select DM_MTD
+	depends on DM_MTD
 	imply CMD_NAND
 	help
 	  This enables Nand driver support for Arasan nand flash

If we can use the driver without DM then we can't depend nor select DM_MTD. Is someone using the driver still without DM_MTD?

Driver has been converted to DM already. It is used by ZynqMP platforms. And it can't be used without DM_MTD.

commit b014b833bd627d27542b50e71df9cf0628f241e7

Author:     Ashok Reddy Soma <[email protected]>
AuthorDate: Thu Dec 19 02:27:42 2019 -0700
Commit:     Michal Simek <[email protected]>
CommitDate: Tue Jan 14 09:05:52 2020 +0100
Quoted 7 lines

mtd: nand: Move arasan nand driver to driver model

Make changes to arasan nand driver to move it to driver model. Select DM_MTD if arasan nand driver is selected.

Ah, I misunderstood the comment, sorry. Yes, this is right then, thanks.

Quoted 7 lines
Quoted 1 line

ok. I just need to enable this symbol for zynqmp platforms.

That is the hard part about all of these patches, when you go from "select X" to "depends on X", you also need to run a script and make sure that every config that enables the main symbol (NAND_ARASAN) also enables the now depended on symbol (DM_MTD) and sync the configs after the change.

This one is easy but others can be problematic.
But there is serious issue with these symbols. When you run make randconfig you see unfortunately a lot of issues reported.

Do you use any tool/script for defconfig update when Kconfig layout has changed?

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/3b5f1aca/attachment.sig>

#23 lore raw

PATCH 6/9 arc: Kconfig: Add missing DM dependency

In reply to Michal Simek
Quoted 10 lines · Michal Simek

ARC is selecting TIMER which depends on DM but DM is not selected and doesn't need to be enabled. Fix it by selecting DM for ARC architecture.

Kconfig is showing this missing dependency by:
WARNING: unmet direct dependencies detected for TIMER
Depends on [n]: DM [=n]
Selected by [y]:
- ARC [=y] && <choice>

Quoted 5 lines

---

 arch/Kconfig | 1 +
 1 file changed, 1 insertion(+)
#3 lore raw

PATCH 1/9 pci: kconfig: Setup proper dependency for PCIE_ROCKCHIP

In reply to Michal Simek
Quoted 10 lines · Michal Simek

There is missing dependency for PCIE_ROCKCHIP which selects PHY_ROCKCHIP_PCIE which directly depends on ARCH_ROCKCHIP.

WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_PCIE
Depends on [n]: ARCH_ROCKCHIP [=n]
Selected by [y]:
- PCIE_ROCKCHIP [=y] && PCI [=y]

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200828/1c2811d3/attachment.sig>
#11 lore raw

PATCH 3/9 cmd: Kconfig: Change dependency for CMD_ADC

In reply to Michal Simek
Quoted 11 lines · Michal Simek

CMD_ADC selected DM_REGULATOR unconditionally without enabling DM. That's why change select to depends on to cover it.

Kconfig is showing this issue as:
WARNING: unmet direct dependencies detected for REGMAP
Depends on [n]: DM [=n]
Selected by [y]:
- DM_REGULATOR_PBIAS [=y] && DM_REGULATOR [=y]

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200828/e9327ed5/attachment.sig>
#24 lore raw

PATCH 6/9 arc: Kconfig: Add missing DM dependency

In reply to Michal Simek
Quoted 11 lines · Michal Simek

ARC is selecting TIMER which depends on DM but DM is not selected and doesn't need to be enabled. Fix it by selecting DM for ARC architecture.

Kconfig is showing this missing dependency by:
WARNING: unmet direct dependencies detected for TIMER
Depends on [n]: DM [=n]
Selected by [y]:
- ARC [=y] && <choice>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200828/650c9a79/attachment.sig>
#31 lore raw

PATCH 9/9 env: Kconfig: Add missing dependency for ENV_IS_IN_EXT4

In reply to Michal Simek
Quoted 9 lines · Michal Simek

ENV_IS_IN_EXT4 also need to enable FS_EXT4 which is not covered in Kconfig. Kconfig reports this as:
WARNING: unmet direct dependencies detected for EXT4_WRITE
Depends on [n]: FS_EXT4 [=n]
Selected by [y]:
- ENV_IS_IN_EXT4 [=y] && !CHAIN_OF_TRUST [=n]

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200828/c24d4cfe/attachment.sig>
#19 lore raw

PATCH 4/9 nand: Kconfig: Change dependency for NAND_ARASAN

In reply to Michal Simek

st 19. 8. 2020 v 10:44 odes?latel Michal Simek <[email protected]> napsal:

Quoted 29 lines

NAND_ARASAN selecting DM_MTD uunconditionally. Driver can be enabled with !DM that's why Kconfig it showing it as error:

WARNING: unmet direct dependencies detected for DM_MTD
Depends on [n]: DM [=n]
Selected by [y]:
- NAND_ARASAN [=y] && MTD_RAW_NAND [=y]

---

 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/raw/Kconfig +1 -2
index 06b2ff972cad..df4cbd52cf5c 100644
@@ -233,7 +233,7 @@ endif
 config NAND_ARASAN
        bool "Configure Arasan Nand"
        select SYS_NAND_SELF_INIT
-       select DM_MTD
+       depends on DM_MTD
        imply CMD_NAND
        help
          This enables Nand driver support for Arasan nand flash
--
Quoted 2 lines

2.28.0

Applied just this one patch with defconfig sync.
M

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
#26 lore raw

PATCH 7/9 ARM: zynqmp: Fix SPL_DM_SPI dependencies

In reply to Michal Simek

st 19. 8. 2020 v 10:44 odes?latel Michal Simek <[email protected]> napsal:

Quoted 29 lines

Add missing dependencies for DM_SPI_FLASH.
Kconfig reports it as:
WARNING: unmet direct dependencies detected for SPL_DM_SPI_FLASH
Depends on [n]: SPL [=n] && SPL_DM [=n]
Selected by [y]:
- ARCH_ZYNQMP [=y] && <choice> && SPL_DM_SPI [=y]

---

 arch/arm/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/Kconfig +2 -2
index bb71b1647650..1d8e6975fe57 100644
@@ -1153,7 +1153,8 @@ config ARCH_ZYNQMP
        select OF_CONTROL
        select SPL_BOARD_INIT if SPL
        select SPL_CLK if SPL
-       select SPL_DM_SPI if SPI
+       select SPL_DM if SPL
+       select SPL_DM_SPI if SPI && SPL_DM
        select SPL_DM_SPI_FLASH if SPL_DM_SPI
        select SPL_DM_MAILBOX if SPL
        select SPL_FIRMWARE if SPL
--
Quoted 2 lines

2.28.0

Applied just this one.
M

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs