Skip to contentSkip to conversation

Change in openvpn[master]: Fixup: prompting password from management

Openvpn-devel In review selvanair (Code Review) 2 participants 6 messages Apr 23 – Apr 25 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1776903146000.I4d46c3672691b159cbd98a17020c4f30782bc202@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email

to review the following change.

Change subject: Fixup: prompting password from management
......................................................................

Fixup: prompting password from management

Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on response_from_stdin which is always true! Fix by explicitly checking for password_from_stdin.

Change-Id I4d46c3672691b159cbd98a17020c4f30782bc202

---
M src/openvpn/misc.c

1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1638/1

src/openvpn/misc.c +1 -0
index 979293f..10bfc35 100644
@@ -336,6 +336,7 @@
              */
             if (management && (flags & GET_USER_PASS_MANAGEMENT)
                 && management_query_user_pass_enabled(management)
+                && password_from_stdin
                 && !(flags & GET_USER_PASS_USERNAME_ONLY))
             {
                 msg(D_LOW,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202
Gerrit-Change-Number: 1638
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: plaisthos, selvanair.

cron2 has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email )

Change subject: Fixup: prompting password from management
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202
Gerrit-Change-Number: 1638
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: selvanair <[email protected]...>
Gerrit-Comment-Date: Fri, 24 Apr 2026 16:18:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

#3 lore raw

PATCH 1/1 Fixup: prompting password from management

In reply to a message not in the archive

From: Selva Nair <[email protected]...>

Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on response_from_stdin which is always true! Fix by explicitly checking for password_from_stdin.

Change-Id I4d46c3672691b159cbd98a17020c4f30782bc202

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

src/openvpn/misc.c +1 -0
index 979293f..10bfc35 100644
@@ -336,6 +336,7 @@
              */
             if (management && (flags & GET_USER_PASS_MANAGEMENT)
                 && management_query_user_pass_enabled(management)
+                && password_from_stdin
                 && !(flags & GET_USER_PASS_USERNAME_ONLY))
             {
                 msg(D_LOW,
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: Fixup: prompting password from management

I have verified the original problem in GH #1021 (as soon as --management-query-passwords is active, username+password passed in via file or inline is ignored and the mgmt interface is queried instead
- which can actually be tested from t_client.rc, so I have proper regression tests for this now).

I have *also* tested (this time) that with the patch, all the "credentials on file" functionality still works, and also that querying from the management interface *also* still works. We should really stop breaking these...

Your patch has been applied to the master and release/2.7 branch.

commit 9ac9a41b82aecdb5cb17a3746a7fa50878ec7ee0 (master) commit 8d512db3fcfceed73cd302f27c2c7849764c33f6 (release/2.7)

Author: Selva Nair
Date:   Fri Apr 24 18:18:33 2026 +0200
     Fixup: prompting password from management

     Signed-off-by: Selva Nair <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg36739.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: Fixup: prompting password from management
......................................................................

Fixup: prompting password from management

Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on response_from_stdin which is always true! Fix by explicitly checking for password_from_stdin.

Github: fixes OpenVPN/openvpn#1021

Change-Id I4d46c3672691b159cbd98a17020c4f30782bc202

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36739.html

---
M src/openvpn/misc.c

1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1638/2

src/openvpn/misc.c +1 -0
index 979293f..10bfc35 100644
@@ -336,6 +336,7 @@
              */
             if (management && (flags & GET_USER_PASS_MANAGEMENT)
                 && management_query_user_pass_enabled(management)
+                && password_from_stdin
                 && !(flags & GET_USER_PASS_USERNAME_ONLY))
             {
                 msg(D_LOW,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202
Gerrit-Change-Number: 1638
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email )

Change subject: Fixup: prompting password from management
......................................................................

Fixup: prompting password from management

Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on response_from_stdin which is always true! Fix by explicitly checking for password_from_stdin.

Github: fixes OpenVPN/openvpn#1021

Change-Id I4d46c3672691b159cbd98a17020c4f30782bc202

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36739.html

---
M src/openvpn/misc.c

1 file changed, 1 insertion(+), 0 deletions(-)
src/openvpn/misc.c +1 -0
index 979293f..10bfc35 100644
@@ -336,6 +336,7 @@
              */
             if (management && (flags & GET_USER_PASS_MANAGEMENT)
                 && management_query_user_pass_enabled(management)
+                && password_from_stdin
                 && !(flags & GET_USER_PASS_USERNAME_ONLY))
             {
                 msg(D_LOW,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1638?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202
Gerrit-Change-Number: 1638
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>