Skip to contentSkip to conversation

ASoC: tlv320aic3x: Add virtual output pin Detection

PATCH Applied Jarkko Nikula 3 participants 3 messages Sep 17, 2010 – Sep 20, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: tlv320aic3x: Add virtual output pin Detection

Purpose of this virtual Detection pin is to keep codec bias on whenever the GPIO or jack detection features are needed.

Jack detection needs a mic bias so machine drivers can construct a following route for instance for keeping the path and codec bias on:

"Input Jack" -> "Mic Bias xV" -> "Detection" -> detection block inside codec.

For the GPIO the machine driver can force the pin on with snd_soc_dapm_force_enable_pin.

---
PLL is activated when in SND_SOC_BIAS_PREPARE or _ON so it could be running but I have a vague impression that it's active only when ADC or DAC is on. I don't have at the moment possibility to measure it and don't want to move it to DAPM either before doing some oscilloscope and pop & clicks measurements. Current consumption anyway doesn't differ between standby and on when there is no active stream and other widgets are off.

---
 sound/soc/codecs/tlv320aic3x.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
sound/soc/codecs/tlv320aic3x.c +8 -0
index 7b5f159..6190351 100644
@@ -605,6 +605,14 @@ static const struct snd_soc_dapm_widget aic3x_dapm_widgets[] = {
 	SND_SOC_DAPM_INPUT("LINE1R"),
 	SND_SOC_DAPM_INPUT("LINE2L"),
 	SND_SOC_DAPM_INPUT("LINE2R"),
+
+	/*
+	 * Virtual output pin to detection block inside codec. This can be
+	 * used to keep codec bias on if gpio or detection features are needed.
+	 * Force pin on or construct a path with an input jack and mic bias
+	 * widgets.
+	 */
+	SND_SOC_DAPM_OUTPUT("Detection"),
 };
 
 static const struct snd_soc_dapm_widget aic3007_dapm_widgets[] = {
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jarkko Nikula

Purpose of this virtual Detection pin is to keep codec bias on whenever the GPIO or jack detection features are needed.

Jack detection needs a mic bias so machine drivers can construct a following route for instance for keeping the path and codec bias on:

Quoted 6 lines

"Input Jack" -> "Mic Bias xV" -> "Detection" -> detection block inside codec.

For the GPIO the machine driver can force the pin on with snd_soc_dapm_force_enable_pin.

#2 lore raw
Quoted 7 lines · Mark Brown
Quoted 5 lines · Jarkko Nikula

Purpose of this virtual Detection pin is to keep codec bias on whenever the GPIO or jack detection features are needed.

Jack detection needs a mic bias so machine drivers can construct a following route for instance for keeping the path and codec bias on:

Quoted 8 lines
Quoted 6 lines

"Input Jack" -> "Mic Bias xV" -> "Detection" -> detection block inside codec.

For the GPIO the machine driver can force the pin on with snd_soc_dapm_force_enable_pin.

Applied.

Thanks

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk