Skip to contentSkip to conversation

drivers: mtd: spi-nor: Add flash property for mt25qu512a and mt35xu02g

PATCH Superseded Ashish Kumar 3 participants 8 messages Aug 13, 2019 – Aug 29, 2019

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drivers: mtd: spi-nor: Add flash property for mt25qu512a and mt35xu02g

mt25qu512a is rebranded after its spinoff from STM, so it is different only in term of operating frequency, initial JEDEC id is same as that of n25q512a. In order to avoid any confussion with respect to name new entry is added.
This flash is tested for Single I/O and QUAD I/O mode on LS1046FRWY.

mt35xu02g is Octal flash supporting Single I/O and QCTAL I/O and it has been tested on LS1028ARDB

---
v3:
-Reword commits msg
-rebase to top of mtd-linux spi-nor/next
v2:
Incorporate review comments from Vignesh

 drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +9 -0
index 03cc788..97d3de8 100644
@@ -1988,6 +1988,12 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ "n25q256a",    INFO(0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "n25q256ax1",  INFO(0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
+
+	/* Micron */
+	{ "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024, SECT_4K |
+				USE_FSR | SPI_NOR_DUAL_READ |
+				SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+
 	{ "n25q512a",    INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q512ax3",  INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q00",      INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
@@ -2003,6 +2009,9 @@ static const struct flash_info spi_nor_ids[] = {
 			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
 			SPI_NOR_4B_OPCODES)
 	},
+	{ "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+			SPI_NOR_4B_OPCODES) },
 
 	/* PMC */
 	{ "pm25lv512",   INFO(0,        0, 32 * 1024,    2, SECT_4K_PMC) },
Signature · 1 line
2.7.4
#1 lore raw
Quoted 14 lines

-----Original Message-----
From: Ashish Kumar <[email protected]>
Sent: Tuesday, August 13, 2019 4:08 PM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Cc: [email protected]; Ashish Kumar <[email protected]>; Kuldeep Singh <[email protected]>; Ashish Kumar <[email protected]>
Subject: [Patch v3] drivers: mtd: spi-nor: Add flash property for mt25qu512a and mt35xu02g

Hi Vignesh, Tudor Ambarus,

Could you please update, if there are any further comments on this patch.

Regards
Ashish

Quoted 58 lines

mt25qu512a is rebranded after its spinoff from STM, so it is different only in term of operating frequency, initial JEDEC id is same as that of n25q512a. In order to avoid any confussion with respect to name new entry is added. This flash is tested for Single I/O and QUAD I/O mode on LS1046FRWY.

mt35xu02g is Octal flash supporting Single I/O and QCTAL I/O and it has been tested on LS1028ARDB

---
v3:

(quoted diff) +0 -2
-Reword commits msg
-rebase to top of mtd-linux spi-nor/next

v2:
Incorporate review comments from Vignesh

 drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +3 -0
index 03cc788..97d3de8 100644
@@ -1988,6 +1988,12 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256, SECT_4K |
 SPI_NOR_QUAD_READ) },
 	{ "n25q256a",    INFO(0x20ba19, 0, 64 * 1024,  512, SECT_4K |
 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "n25q256ax1",  INFO(0x20bb19, 0, 64 * 1024,  512, SECT_4K |
 SPI_NOR_QUAD_READ) },
+
+	/* Micron */
+	{ "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024,

SECT_4K |

drivers/mtd/spi-nor/spi-nor.c +2 -0
+				USE_FSR | SPI_NOR_DUAL_READ |
+				SPI_NOR_QUAD_READ |

SPI_NOR_4B_OPCODES) },

drivers/mtd/spi-nor/spi-nor.c +1 -0
+
 	{ "n25q512a",    INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K |

USE_FSR | SPI_NOR_QUAD_READ) },
{ "n25q512ax3", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K |
USE_FSR | SPI_NOR_QUAD_READ) },
{ "n25q00", INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },

drivers/mtd/spi-nor/spi-nor.c +3 -1
@@ -2003,6 +2009,9 @@ static const struct flash_info spi_nor_ids[] = {
 			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
 			SPI_NOR_4B_OPCODES)
 	},
+	{ "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+			SPI_NOR_4B_OPCODES) },
 
 	/* PMC */
 	{ "pm25lv512",   INFO(0,        0, 32 * 1024,    2, SECT_4K_PMC) },
--

2.7.4

maintainer Reviewed-by on v3 1/1
#2 lore raw
In reply to Ashish Kumar
Quoted 6 lines · Ashish Kumar

mt25qu512a is rebranded after its spinoff from STM, so it is different only in term of operating frequency, initial JEDEC id is same as that of n25q512a. In order to avoid any confussion with respect to name new entry is added.
This flash is tested for Single I/O and QUAD I/O mode on LS1046FRWY.

Quoted 6 lines

mt35xu02g is Octal flash supporting Single I/O and QCTAL I/O and it has been tested on LS1028ARDB

---

Regards
Vignesh

Quoted 37 lines

v3:

(quoted diff) +0 -2
-Reword commits msg
-rebase to top of mtd-linux spi-nor/next

v2:
Incorporate review comments from Vignesh

 drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +9 -0
index 03cc788..97d3de8 100644
@@ -1988,6 +1988,12 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ "n25q256a",    INFO(0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "n25q256ax1",  INFO(0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
+
+	/* Micron */
+	{ "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024, SECT_4K |
+				USE_FSR | SPI_NOR_DUAL_READ |
+				SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+
 	{ "n25q512a",    INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q512ax3",  INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q00",      INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
@@ -2003,6 +2009,9 @@ static const struct flash_info spi_nor_ids[] = {
 			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
 			SPI_NOR_4B_OPCODES)
 	},
+	{ "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+			SPI_NOR_4B_OPCODES) },
 
 	/* PMC */
 	{ "pm25lv512",   INFO(0,        0, 32 * 1024,    2, SECT_4K_PMC) },
Signature · 6 lines
Regards
Vignesh

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#3 lore raw
In reply to Ashish Kumar
Quoted 9 lines · Ashish Kumar

mt25qu512a is rebranded after its spinoff from STM, so it is different only in term of operating frequency, initial JEDEC id is same as that of n25q512a. In order to avoid any confussion with respect to name new entry is added.
This flash is tested for Single I/O and QUAD I/O mode on LS1046FRWY.

mt35xu02g is Octal flash supporting Single I/O and QCTAL I/O and it has been tested on LS1028ARDB

$subject should start as "mtd: spi-nor:" and should be tweaked as:

mtd: spi-nor: Add mt25qu512a and mt35xu02g flash entries

May be Tudor can fix this while applying, if there are no further comments.

Regards
Vignesh

Quoted 40 lines

---
v3:

(quoted diff) +0 -2
-Reword commits msg
-rebase to top of mtd-linux spi-nor/next

v2:
Incorporate review comments from Vignesh

 drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +9 -0
index 03cc788..97d3de8 100644
@@ -1988,6 +1988,12 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ "n25q256a",    INFO(0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "n25q256ax1",  INFO(0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
+
+	/* Micron */
+	{ "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024, SECT_4K |
+				USE_FSR | SPI_NOR_DUAL_READ |
+				SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+
 	{ "n25q512a",    INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q512ax3",  INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q00",      INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
@@ -2003,6 +2009,9 @@ static const struct flash_info spi_nor_ids[] = {
 			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
 			SPI_NOR_4B_OPCODES)
 	},
+	{ "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+			SPI_NOR_4B_OPCODES) },
 
 	/* PMC */
 	{ "pm25lv512",   INFO(0,        0, 32 * 1024,    2, SECT_4K_PMC) },
Signature · 6 lines
Regards
Vignesh

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#4 lore raw
In reply to Ashish Kumar

Hi, Ashish,

Quoted 29 lines · Ashish Kumar

External E-Mail

mt25qu512a is rebranded after its spinoff from STM, so it is different only in term of operating frequency, initial JEDEC id is same as that of n25q512a. In order to avoid any confussion with respect to name new entry is added.
This flash is tested for Single I/O and QUAD I/O mode on LS1046FRWY.

mt35xu02g is Octal flash supporting Single I/O and QCTAL I/O and it has been tested on LS1028ARDB

---
v3:

(quoted diff) +0 -2
-Reword commits msg
-rebase to top of mtd-linux spi-nor/next

v2:
Incorporate review comments from Vignesh

 drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +0 -0
index 03cc788..97d3de8 100644

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1995

Quoted 8 lines
drivers/mtd/spi-nor/spi-nor.c +5 -0
@@ -1988,6 +1988,12 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ "n25q256a",    INFO(0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "n25q256ax1",  INFO(0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
+
+	/* Micron */
+	{ "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024, SECT_4K |
+				USE_FSR | SPI_NOR_DUAL_READ |
+				SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

I'm looking at the following datasheets: mt25qu512a [1] and n25q512a [2]. Both flashes have the same Extended Device ID data. What will happen, is that you'll always hit the first valid entry, so "mt25qu512a", and you'll indicate a 'wrong' flash name for n25q512a. If there is nothing that differentiate between the two, maybe you can add a comment in the code that says that "n25q512a" was re-branded to "mt25qu512a" after the STM spin-off. Whatever solution will be, it will be better if you do it in a separate patch.

[1]
https://static6.arrow.com/aropdfconversion/1a8b08cb08427821f166137d064c4837eca70f15/12682797700728481268266842945946mt25q_qlkt_u_512_abb_0.pdf.pdf

[2]
https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=2ahUKEwjZlJ_M_KLkAhWB66QKHV6WAX4QFjAAegQIAhAC&url=https%3A%2F%2Fwww.micron.com%2F-%2Fmedia%2Fdocuments%2Fproducts%2Fdata-sheet%2Fnor-flash%2Fserial-nor%2Fn25q%2Fn25q_512mb_1_8v_65nm.pdf&usg=AOvVaw3BSiUIfTgikFZ0FZ7O_D61

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 2014

Quoted 11 lines
drivers/mtd/spi-nor/spi-nor.c +4 -0
+
 	{ "n25q512a",    INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q512ax3",  INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ "n25q00",      INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
@@ -2003,6 +2009,9 @@ static const struct flash_info spi_nor_ids[] = {
 			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
 			SPI_NOR_4B_OPCODES)
 	},
+	{ "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+			SPI_NOR_4B_OPCODES) },

Is there a public datasheet for this flash?

Cheers,
ta

#5 lore raw
Quoted 61 lines

-----Original Message-----
From: linux-mtd <[email protected]> On Behalf Of [email protected]
Sent: Tuesday, August 27, 2019 5:34 PM
To: Ashish Kumar <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Cc: Kuldeep Singh <[email protected]>; [email protected]
Subject: [EXT] Re: [Patch v3] drivers: mtd: spi-nor: Add flash property for mt25qu512a and mt35xu02g

Caution: EXT Email

Hi, Ashish,

Quoted 29 lines · Ashish Kumar

External E-Mail

mt25qu512a is rebranded after its spinoff from STM, so it is different only in term of operating frequency, initial JEDEC id is same as that of n25q512a. In order to avoid any confussion with respect to name new entry is added.
This flash is tested for Single I/O and QUAD I/O mode on LS1046FRWY.

mt35xu02g is Octal flash supporting Single I/O and QCTAL I/O and it has been tested on LS1028ARDB

---
v3:

(quoted diff) +0 -2
-Reword commits msg
-rebase to top of mtd-linux spi-nor/next

v2:
Incorporate review comments from Vignesh

 drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++
 1 file changed, 9 insertions(+)
(quoted diff) +0 -0

b/drivers/mtd/spi-nor/spi-nor.c index 03cc788..97d3de8 100644

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1988

Quoted 1 line
drivers/mtd/spi-nor/spi-nor.c +0 -0
@@ -1988,6 +1988,12 @@ static const struct flash_info spi_nor_ids[] = {
      { "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256, SECT_4K |

SPI_NOR_QUAD_READ) },

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1989

Quoted 1 line
drivers/mtd/spi-nor/spi-nor.c +0 -0
      { "n25q256a",    INFO(0x20ba19, 0, 64 * 1024,  512, SECT_4K |

SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = {

Quoted 8 lines
drivers/mtd/spi-nor/spi-nor.c +6 -0
      { "n25q256ax1",  INFO(0x20bb19, 0, 64 * 1024,  512, SECT_4K |
 SPI_NOR_QUAD_READ) },
+
+     /* Micron */
+     { "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024, SECT_4K |
+                             USE_FSR | SPI_NOR_DUAL_READ |
+                             SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES)
+ },
Quoted 7 lines

I'm looking at the following datasheets: mt25qu512a [1] and n25q512a [2]. Both flashes have the same Extended Device ID data. What will happen, is that you'll always hit the first valid entry, so "mt25qu512a", and you'll indicate a 'wrong' flash name for n25q512a. If there is nothing that differentiate between the two, maybe you can add a comment in the code that says that "n25q512a" was re-branded to "mt25qu512a" after the STM spin-off. Whatever solution will be, it will be better if you do it in a separate patch.

Hi Tudor,
Considering both are same, should I rename to mt25qu51a, and add SPI_NOR_4B_OPCODES or Keep n25q512a, and comment about mt25qu51a and add SPI_NOR_4B_OPCODES.

For separate patch comment you mean split mt25qu512a and mt35xu02g into 2 patch.

Quoted 31 lines

[1]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstatic
6.arrow.com%2Faropdfconversion%2F1a8b08cb08427821f166137d064c4837e ca70f15%2F12682797700728481268266842945946mt25q_qlkt_u_512_abb_0.p df.pdf&amp;data=02%7C01%7Cashish.kumar%40nxp.com%7C26e59cbcfac14 8e5218c08d72ae6c46b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7 C637025042940681828&amp;sdata=gWBeML98ws80FAnwA7nvB4qvVbFWUa YTyr8PV6IUP3A%3D&amp;reserved=0

[2]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww
.google.com%2Furl%3Fsa%3Dt%26rct%3Dj%26q%3D%26esrc%3Ds%26source %3Dweb%26cd%3D1%26cad%3Drja%26uact%3D8%26ved%3D2ahUKEwjZlJ_ M_KLkAhWB66QKHV6WAX4QFjAAegQIAhAC%26url%3Dhttps%253A%252F% 252Fwww.micron.com%252F- %252Fmedia%252Fdocuments%252Fproducts%252Fdata-sheet%252Fnor- flash%252Fserial- nor%252Fn25q%252Fn25q_512mb_1_8v_65nm.pdf%26usg%3DAOvVaw3BSi UIfTgikFZ0FZ7O_D61&amp;data=02%7C01%7Cashish.kumar%40nxp.com%7C 26e59cbcfac148e5218c08d72ae6c46b%7C686ea1d3bc2b4c6fa92cd99c5c30163 5%7C0%7C1%7C637025042940681828&amp;sdata=0bbEjEbOWQJfVYhDjBx55 d6YkDzgR2fP2XBurJvDrMU%3D&amp;reserved=0

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1999

Quoted 2 lines
drivers/mtd/spi-nor/spi-nor.c +1 -0
+
      { "n25q512a",    INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ) },

Quoted 1 line
      { "n25q512ax3",  INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR

| SPI_NOR_QUAD_READ) },

Quoted 1 line
      { "n25q00",      INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },

Quoted 9 lines

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 2014

Quoted 7 lines
drivers/mtd/spi-nor/spi-nor.c +3 -0
@@ -2003,6 +2009,9 @@ static const struct flash_info spi_nor_ids[] = {
                      SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
                      SPI_NOR_4B_OPCODES)
      },
+     { "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+                     SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+                     SPI_NOR_4B_OPCODES) },

Is there a public datasheet for this flash?

No, data sheet in under NDA, I have asked micron FAE for public data sheet, will resend after the same is published.

Regards
Ashish

Quoted 11 lines

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.in
fradead.org%2Fmailman%2Flistinfo%2Flinux- mtd%2F&amp;data=02%7C01%7Cashish.kumar%40nxp.com%7C26e59cbcfac 148e5218c08d72ae6c46b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1 %7C637025042940681828&amp;sdata=rNBZ%2B0F%2BW8Oxr55LGfABHLZSM M4neUMW8kinK1qh6eo%3D&amp;reserved=0

#6 lore raw
Quoted 36 lines · Ashish Kumar

External E-Mail

Quoted 32 lines

-----Original Message-----
From: linux-mtd <[email protected]> On Behalf Of [email protected]
Sent: Tuesday, August 27, 2019 5:34 PM
To: Ashish Kumar <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Cc: Kuldeep Singh <[email protected]>; [email protected]
Subject: [EXT] Re: [Patch v3] drivers: mtd: spi-nor: Add flash property for mt25qu512a and mt35xu02g

Caution: EXT Email

Hi, Ashish,

Quoted 15 lines · Ashish Kumar

External E-Mail

mt25qu512a is rebranded after its spinoff from STM, so it is different only in term of operating frequency, initial JEDEC id is same as that of n25q512a. In order to avoid any confussion with respect to name new entry is added.
This flash is tested for Single I/O and QUAD I/O mode on LS1046FRWY.

mt35xu02g is Octal flash supporting Single I/O and QCTAL I/O and it has been tested on LS1028ARDB

---

cut

Quoted 14 lines
Quoted 7 lines

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = {

Quoted 6 lines
drivers/mtd/spi-nor/spi-nor.c +6 -0
+
+     /* Micron */
+     { "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024, SECT_4K |
+                             USE_FSR | SPI_NOR_DUAL_READ |
+                             SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES)
+ },
Quoted 7 lines

I'm looking at the following datasheets: mt25qu512a [1] and n25q512a [2]. Both flashes have the same Extended Device ID data. What will happen, is that you'll always hit the first valid entry, so "mt25qu512a", and you'll indicate a 'wrong' flash name for n25q512a. If there is nothing that differentiate between the two, maybe you can add a comment in the code that says that "n25q512a" was re-branded to "mt25qu512a" after the STM spin-off. Whatever solution will be, it will be better if you do it in a separate patch.

Quoted 3 lines

Hi Tudor,
Considering both are same, should I rename to mt25qu51a, and add SPI_NOR_4B_OPCODES or Keep n25q512a, and comment about mt25qu51a and add SPI_NOR_4B_OPCODES.

I see two options:
1/ either rename "n25q512a" to "mt25qu512a (n25q512a)" and add the SPI_NOR_4B_OPCODES
2/ or keep "n25q512a", add SPI_NOR_4B_OPCODES, and add a comment about re-branding to mt25qu512a.

Which one do you like better? What about you, Vignesh?

Quoted 2 lines

For separate patch comment you mean split mt25qu512a and mt35xu02g into 2 patch.

yes, send a separate patch for mt35xu02g, as the changes are not related.

Quoted 2 lines
Quoted 2 lines

cut

Quoted 7 lines
Quoted 5 lines

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 2014

Quoted 3 lines
drivers/mtd/spi-nor/spi-nor.c +3 -0
+     { "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+                     SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+                     SPI_NOR_4B_OPCODES) },

Is there a public datasheet for this flash?

No, data sheet in under NDA, I have asked micron FAE for public data sheet, will resend after the same is published.

No need to wait, I'll trust you. It was better if I could verify the info, but if we can't, that's it. Just send a different patch for this change.

Cheers,
ta

#7 lore raw

Hi,

On 29/08/19 1:39 PM, [email protected] wrote:
[...]

Quoted 15 lines
Quoted 15 lines
Quoted 15 lines

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = {

Quoted 7 lines
drivers/mtd/spi-nor/spi-nor.c +6 -0
+
+     /* Micron */
+     { "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024, SECT_4K |
+                             USE_FSR | SPI_NOR_DUAL_READ |
+                             SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES)
+ },

I'm looking at the following datasheets: mt25qu512a [1] and n25q512a [2]. Both flashes have the same Extended Device ID data. What will happen, is that you'll always hit the first valid entry, so "mt25qu512a", and you'll indicate a 'wrong' flash name for n25q512a. If there is nothing that differentiate between the two, maybe you can add a comment in the code that says that "n25q512a" was re-branded to "mt25qu512a" after the STM spin-off. Whatever solution will be, it will be better if you do it in a separate patch.

Quoted 7 lines
Quoted 3 lines

Hi Tudor,
Considering both are same, should I rename to mt25qu51a, and add SPI_NOR_4B_OPCODES or Keep n25q512a, and comment about mt25qu51a and add SPI_NOR_4B_OPCODES.

I see two options:
1/ either rename "n25q512a" to "mt25qu512a (n25q512a)" and add the SPI_NOR_4B_OPCODES

I would go with first option so as not to alarm the users who are used to seeing n25q512a in kernel log. This option shows both old and new brand names.

Regards
Vignesh

Quoted 28 lines

2/ or keep "n25q512a", add SPI_NOR_4B_OPCODES, and add a comment about re-branding to mt25qu512a.

Which one do you like better? What about you, Vignesh?

Quoted 2 lines

For separate patch comment you mean split mt25qu512a and mt35xu02g into 2 patch.

yes, send a separate patch for mt35xu02g, as the changes are not related.

Quoted 2 lines
Quoted 2 lines

cut

Quoted 7 lines
Quoted 5 lines

drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 2014

Quoted 3 lines
drivers/mtd/spi-nor/spi-nor.c +3 -0
+     { "mt35xu02g",  INFO(0x2c5b1c, 0, 128 * 1024, 2048,
+                     SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
+                     SPI_NOR_4B_OPCODES) },

Is there a public datasheet for this flash?

No, data sheet in under NDA, I have asked micron FAE for public data sheet, will resend after the same is published.

No need to wait, I'll trust you. It was better if I could verify the info, but if we can't, that's it. Just send a different patch for this change.

Cheers,
ta

Signature · 6 lines
Regards
Vignesh

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/