Kconfig: distro: Use imply instead of select for CMD_FAT
PATCH 1/1 Kconfig: distro: Use imply instead of select for CMD_FAT
From: Tien Fong Chee <[email protected]>
Using imply instead of select for CMD_FAT so overwritten is allowed in later configuration.
--- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Kconfig +1 -1
@@ -201,7 +201,7 @@ config DISTRO_DEFAULTS select CMD_ENV_EXISTS select CMD_EXT2 select CMD_EXT4 - select CMD_FAT + imply CMD_FAT select CMD_FS_GENERIC select CMD_PART if PARTITIONS select CMD_PING if CMD_NET
Signature · 1 line
2.26.2
Tom Rini
NAKQuoted 15 lines · Jit Loon Lim
From: Tien Fong Chee <[email protected]>
Using imply instead of select for
CMD_FATso overwritten is allowed in later configuration.Signed-off-by Tien Fong Chee <[email protected]>--- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Kconfig +0
-0
Kconfig config DISTRO_DEFAULTS · line 207
Quoted 8 lines
Kconfig +1
-1@@ -201,7 +201,7 @@ config DISTRO_DEFAULTS select CMD_ENV_EXISTS select CMD_EXT2 select CMD_EXT4 - select CMD_FAT + imply CMD_FAT select CMD_FS_GENERIC select CMD_PART if PARTITIONS select CMD_PING if CMD_NET
NAK, at least without explaining what the use case here is. A big part of generic distro work is "oh, you have that FAT32 ESP to use".
Signature · 1 line
Tom
Hi Tom,
Quoted 13 lines · Tom Rini
Quoted 10 lines · Jit Loon Lim
From: Tien Fong Chee <[email protected]>
Using imply instead of select for
CMD_FATso overwritten is allowed in later configuration.Signed-off-by Tien Fong Chee <[email protected]>--- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Kconfig config DISTRO_DEFAULTS · line 207
Quoted 13 lines
Kconfig +1
-1@@ -201,7 +201,7 @@ config DISTRO_DEFAULTS select CMD_ENV_EXISTS select CMD_EXT2 select CMD_EXT4 - select CMD_FAT + imply CMD_FAT select CMD_FS_GENERIC select CMD_PART if PARTITIONS select CMD_PING if CMD_NETNAK, at least without explaining what the use case here is. A big part of generic distro work is "oh, you have that FAT32 ESP to use".
Isn't that just for EFI?
In general I try to use 'imply' so it is possible for a board to disable the option.
Regards,
Simon
Quoted 33 lines · Simon Glass
Hi Tom,
Quoted 13 lines · Tom Rini
Quoted 10 lines · Jit Loon Lim
From: Tien Fong Chee <[email protected]>
Using imply instead of select for
CMD_FATso overwritten is allowed in later configuration.Signed-off-by Tien Fong Chee <[email protected]>--- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 16 lines
Kconfig config DISTRO_DEFAULTS · line 207
Quoted 13 lines
Kconfig +1
-1@@ -201,7 +201,7 @@ config DISTRO_DEFAULTS select CMD_ENV_EXISTS select CMD_EXT2 select CMD_EXT4 - select CMD_FAT + imply CMD_FAT select CMD_FS_GENERIC select CMD_PART if PARTITIONS select CMD_PING if CMD_NETNAK, at least without explaining what the use case here is. A big part of generic distro work is "oh, you have that FAT32 ESP to use".
Quoted 4 lines
Isn't that just for EFI?
In general I try to use 'imply' so it is possible for a board to disable the option.
Calling it an ESP? Yes. Expecting the first partition to be FAT? No, that's a forever-and-ever thing distros have been expecting on x86 and want to see everyone else do too (so their installer logic doesn't have to get further complex).
Signature · 1 line
Tom
Hi Tom,
Quoted 37 lines · Tom Rini
Quoted 35 lines · Simon Glass
Hi Tom,
Quoted 13 lines · Tom Rini
Quoted 10 lines · Jit Loon Lim
From: Tien Fong Chee <[email protected]>
Using imply instead of select for
CMD_FATso overwritten is allowed in later configuration.Signed-off-by Tien Fong Chee <[email protected]>--- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 16 lines
Kconfig config DISTRO_DEFAULTS · line 207
Quoted 13 lines
Kconfig +1
-1@@ -201,7 +201,7 @@ config DISTRO_DEFAULTS select CMD_ENV_EXISTS select CMD_EXT2 select CMD_EXT4 - select CMD_FAT + imply CMD_FAT select CMD_FS_GENERIC select CMD_PART if PARTITIONS select CMD_PING if CMD_NETNAK, at least without explaining what the use case here is. A big part of generic distro work is "oh, you have that FAT32 ESP to use".
Isn't that just for EFI?
Quoted 7 lines
Quoted 2 lines
In general I try to use 'imply' so it is possible for a board to disable the option.
Calling it an ESP? Yes. Expecting the first partition to be FAT? No, that's a forever-and-ever thing distros have been expecting on x86 and want to see everyone else do too (so their installer logic doesn't have to get further complex).
OK I See. Well, 'imply' is more friendly since it allows the choice, if the function is not used. In fact 'DISTRO_DEFAULTS' is mostly DISTRO_REQUIRED at this point :-)
Regards,
Simon
Quoted 43 lines · Simon Glass
Hi Tom,
Quoted 40 lines · Tom Rini
Quoted 37 lines · Simon Glass
Hi Tom,
Quoted 13 lines · Tom Rini
Quoted 10 lines · Jit Loon Lim
From: Tien Fong Chee <[email protected]>
Using imply instead of select for
CMD_FATso overwritten is allowed in later configuration.Signed-off-by Tien Fong Chee <[email protected]>--- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 16 lines
Kconfig config DISTRO_DEFAULTS · line 207
Quoted 13 lines
Kconfig +1
-1@@ -201,7 +201,7 @@ config DISTRO_DEFAULTS select CMD_ENV_EXISTS select CMD_EXT2 select CMD_EXT4 - select CMD_FAT + imply CMD_FAT select CMD_FS_GENERIC select CMD_PART if PARTITIONS select CMD_PING if CMD_NETNAK, at least without explaining what the use case here is. A big part of generic distro work is "oh, you have that FAT32 ESP to use".
Isn't that just for EFI?
In general I try to use 'imply' so it is possible for a board to disable the option.
Quoted 8 lines
Quoted 4 lines
Calling it an ESP? Yes. Expecting the first partition to be FAT? No, that's a forever-and-ever thing distros have been expecting on x86 and want to see everyone else do too (so their installer logic doesn't have to get further complex).
OK I See. Well, 'imply' is more friendly since it allows the choice, if the function is not used. In fact '
DISTRO_DEFAULTS' is mostlyDISTRO_REQUIREDat this point :-)
Well, yes. It's supposed to be thee option that you set and then all of the common general Linux distros (and the BSD families have adopted this as well) Just Work, so it needs to be selecting.
Signature · 1 line
Tom