Skip to contentSkip to conversation

config: Add 'update_bootimg' command to update flash.bin on Phytec's imx8mm

PATCH Superseded Lukasz Majewski 2 participants 3 messages Aug 5, 2024 – Aug 6, 2024 Arm i.MX and Layerscape

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 config: Add 'update_bootimg' command to update flash.bin on Phytec's imx8mm

This command allows easy update on SD card or eMMC of the flash.bin generated (with binman) during u-boot build.

---
Changes for v2:
- Remove 'update_mmc_part' variable
- Change path for hostname
- Use full version of dhcp command (${loadaddr} added)

---
 include/configs/phycore_imx8mm.h | 10 ++++++++++
 1 file changed, 10 insertions(+)
include/configs/phycore_imx8mm.h +10 -0
index ce6dc87c69..361e665676 100644
@@ -29,6 +29,16 @@
 	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
 	"mmcpart=1\0" \
 	"mmcroot=2\0" \
+	"update_offset=0x42\0" \
+	"update_filename=flash.bin\0" \
+	"hostname=/srv/tftp/\0" \
+	"update_bootimg="						\
+		"mmc dev ${mmcdev} ; "		\
+		"if dhcp ${loadaddr} ${hostname}/${update_filename} ; then "	\
+		"setexpr fw_sz ${filesize} / 0x200 ; "	/* SD block size */ \
+		"setexpr fw_sz ${fw_sz} + 1 ; "				\
+		"mmc write ${loadaddr} ${update_offset} ${fw_sz} ; "	\
+		"fi\0" \
 	"mmcautodetect=yes\0" \
 	"mmcargs=setenv bootargs console=${console} " \
 		"root=/dev/mmcblk${mmcdev}p${mmcroot} rootwait rw\0" \
Signature · 1 line
2.39.2
reviewer
#1 lore raw

Hi Lukasz,

include/configs/phycore_imx8mm.h

Quoted 8 lines · Lukasz Majewski
include/configs/phycore_imx8mm.h +8 -0
+       "update_offset=0x42\0" \
+       "update_filename=flash.bin\0" \
+       "hostname=/srv/tftp/\0" \
+       "update_bootimg="                                               \
+               "mmc dev ${mmcdev} ; "          \
+               "if dhcp ${loadaddr} ${hostname}/${update_filename} ; then "    \
+               "setexpr fw_sz ${filesize} / 0x200 ; "  /* SD block size */ \
+               "setexpr fw_sz ${fw_sz} + 1 ; "

As Benjamin pointed out earlier this increment by one is not necessary.

All other i.MX8M docs don't have this increment.

#2 lore raw

Hi Fabio,

Quoted 16 lines

Hi Lukasz,

Quoted 11 lines · Lukasz Majewski
include/configs/phycore_imx8mm.h +6 -0
+       "update_offset=0x42\0" \
+       "update_filename=flash.bin\0" \
+       "hostname=/srv/tftp/\0" \
+       "update_bootimg="
    \
+               "mmc dev ${mmcdev} ; "          \
+               "if dhcp ${loadaddr} ${hostname}/${update_filename}

; then " \
+ "setexpr fw_sz ${filesize} / 0x200 ; " /* SD block
size */ \
+ "setexpr fw_sz ${fw_sz} + 1 ; "

Quoted 4 lines

As Benjamin pointed out earlier this increment by one is not necessary.

All other i.MX8M docs don't have this increment.

So apparently the BSP build scripts in OE/Yocto take always care to have 0x200 aligned binaries (imx-boot and flash.bin).

OK, I will remove it.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]