Skip to contentSkip to conversation

Add device tree for Nvidia's GB200NVL BMC

PATCH In review Willie Thai 3 participants 7 messages Apr 1, 2025 – Apr 7, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v5 cover Add device tree for Nvidia's GB200NVL BMC

The GB200NVL BMC is an Aspeed Ast2600 based BMC for Nvidia Blackwell GB200NVL platform. Reference to Ast2600 SOC [1].
Reference to Blackwell GB200NVL Platform [2].

---
Changes v1 -> v2:
- Fix the SOB name [Krzysztof]
- Fix warnings from scripts/checkpatch.pl run [Krzysztof]
- Fix DTS coding style [Krzysztof]
- Move pinctrl override to the bottom [Krzysztof]
- Drop bootargs [Krzysztof]
- Follow DTS coding style and change naming for leds node [Krzysztof]
- Change flash 0 status property [Krzysztof]
- Change the phy-mode to rgmii [Andrew]
- Remove the max-speed in mac0 [Andrew]
- Put gpio line name in one line per group of 8 gpios, but keep some b/c they can exceed length limit [Paul]
Changes v2 -> v3:
- Fix missing new line [Krzysztof]
- Fix missing binding define, adding it in the patch no.1 of this patch set v3 [Krzysztof, Rob]
- Fix DTS coding style [Krzysztof]
- Modify nodes name to generic name for: i2c expander pca9546, gpio expander pca9555, power monitor lm5066i, fan controller max31790 [Krzysztof]
- Skip mac setting and wait till the delay issue in phy-mode fix from Aspeed SOC vendor side [Andrew]
- Remove i2c-scl-clk-low-timeout-us which is Apseed proprietary property [Mars]
Changes v3 -> v4:
- Order binding patch first in the patch set [Andrew Jeffery]
- Make the commit message more concise [Krzysztof]
- Remove stray blank lines [Krzysztof]
- Remove unnecessary comments [Krzysztof]
- Remove underscore, repalce by dash symbol in node name [Krzysztof]
- Remove disable-master property in i2c as it is downstream added property [Rob, Andrew Jeffery]
- Remove #address-cells, #size-cells in nxp,pca9555 and maxim,max31790 as they are no longer defined [Rob, Andrew Jeffery]
Changes v4 -> v5:
- Drop emmc node for now as it requires specific pin configuration [Andrew Jeffery]
---

Willie Thai (2):
dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC
ARM: dts: aspeed: Add device tree for Nvidia's GB200NVL BMC

 .../bindings/arm/aspeed/aspeed.yaml           |    1 +
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../aspeed/aspeed-bmc-nvidia-gb200nvl-bmc.dts | 1128 +++++++++++++++++
 3 files changed, 1130 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-gb200nvl-bmc.dts
Signature · 1 line
2.25.1
#1 lore raw

PATCH v5 1/2 dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC

Add Nvidia's GB200NVL BMC board compatible.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index 01333ac111fb..a3736f134130 100644
@@ -98,6 +98,7 @@ properties:
               - inventec,starscream-bmc
               - inventec,transformer-bmc
               - jabil,rbp-bmc
+              - nvidia,gb200nvl-bmc
               - qcom,dc-scm-v1-bmc
               - quanta,s6q-bmc
               - ufispace,ncplite-bmc
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC

Quoted 5 lines · Willie Thai

Add Nvidia's GB200NVL BMC board compatible.

Why are you faking tags/email addresses? Read carefully submitting patches. I really suggest using b4 instead of manually editing things. And if you decide for manual way, you must never, *never* edit people's tag. You can only copy and paste it.

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC

Quoted 10 lines · Willie Thai
Quoted 5 lines

Add Nvidia's GB200NVL BMC board compatible.

Why are you faking tags/email addresses? Read carefully submitting patches. I really suggest using b4 instead of manually editing things. And if you decide for manual way, you must never, *never* edit people's tag. You can only copy and paste it.

Thanks for the quick response, this is not faking tags/email address, I should have copied your whole ack tag.

maintainer
#4 lore raw

Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC

In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · Willie Thai

Add Nvidia's  GB200NVL BMC board compatible.

Quoted 6 lines

Why are you faking tags/email addresses? Read carefully submitting patches. I really suggest using b4 instead of manually editing things.
And if you decide for manual way, you must never, *never* edit people's
tag. You can only copy and paste it.

I've applied the series, fixing the tag in the process, along with the line-wrapping of the commit message in the second patch.

Willie: scripts/checkpatch.pl warns of some of these things. Please make sure to use it in the future, or if you adopt b4 as Krzysztof suggests, use b4 prep --check.

Andrew

#5 lore raw

Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC

Quoted 15 lines · Krzysztof Kozlowski
Quoted 7 lines · Willie Thai
Quoted 5 lines

Add Nvidia's GB200NVL BMC board compatible.

Quoted 6 lines

Why are you faking tags/email addresses? Read carefully submitting patches. I really suggest using b4 instead of manually editing things.
And if you decide for manual way, you must never, *never* edit people's
tag. You can only copy and paste it.

Quoted 6 lines

I've applied the series, fixing the tag in the process, along with the line-wrapping of the commit message in the second patch.

Willie: scripts/checkpatch.pl warns of some of these things. Please make sure to use it in the future, or if you adopt b4 as Krzysztof suggests, use b4 prep --check.

Thanks Andrew !

#6 lore raw

PATCH v5 2/2 ARM: dts: aspeed: Add device tree for Nvidia's GB200NVL BMC

In reply to Willie Thai

The GB200NVL BMC is an Aspeed Ast2600 based BMC for Nvidia Blackwell GB200NVL platform. Reference to Ast2600 SOC [1].
Reference to Blackwell GB200NVL Platform [2].

---
Changes v4 -> v5:
- Drop emmc node for now as it requires specific pin configuration [Andrew Jeffery]
---

---
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../aspeed/aspeed-bmc-nvidia-gb200nvl-bmc.dts | 1128 +++++++++++++++++
 2 files changed, 1129 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-gb200nvl-bmc.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index 2e5f4833a073..20fd357a1ee9 100644
@@ -50,6 +50,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-lenovo-hr630.dtb \
 	aspeed-bmc-lenovo-hr855xg2.dtb \
 	aspeed-bmc-microsoft-olympus.dtb \
+	aspeed-bmc-nvidia-gb200nvl-bmc.dtb \
 	aspeed-bmc-opp-lanyang.dtb \
 	aspeed-bmc-opp-mowgli.dtb \
 	aspeed-bmc-opp-nicole.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-gb200nvl-bmc.dts new file +1128 -0

1,128 lines not on this page · raw message

Signature · 1 line
2.25.1