Skip to contentSkip to conversation

arm64: dts: rockchip: Add EmbedFire LubanCat 1

PATCH Applied Yuteng Zhong 3 participants 9 messages Dec 23, 2022 – Jan 10, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v9 1/3 arm64: dts: rockchip: Add EmbedFire LubanCat 1

From: Wenhao Cui <[email protected]>

The LubanCat 1 is a RK3566 based SBC, developed by Dongguan EmbedFire Electronic Technology Co., Ltd.

It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header

---

Changed in V2:
- Remove RNG node
Changed in V3:
- Sent E-mail with a wrong attachment
Changed in V4:
- Modify all node names
Changed in V5:
- Fixed node name of vcc3v3_sys
- Fixed order in document
- Fixed commit message wrapping
Changed in V6:
- Fixed Signed-off-by order
Changed in V7:
- Fixed From with real name
Changed in V8:
- Fixed whitespaces in rk3566-lubancat-1.dts
- Add vendor prefix in Documentation/devicetree/bindings/vendor-prefixes.yaml
Changed in V9:
- Remove unnecessary copyright in comment

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3566-lubancat-1.dts   | 595 ++++++++++++++++++
 2 files changed, 596 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 0a76a2ebb5f6..e52bda04d45a 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +595 -0

595 lines not on this page · raw message

Signature · 1 line
2.27.0
#1 lore raw

PATCH v9 2/3 dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

From: Wenhao Cui <[email protected]>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index 88ff4422a8c1..058ed707f3cd 100644
@@ -95,6 +95,11 @@ properties:
           - const: elgin,rv1108-r1
           - const: rockchip,rv1108
 
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566
+
       - description: Engicam PX30.Core C.TOUCH 2.0
         items:
           - const: engicam,px30-core-ctouch2
Signature · 1 line
2.27.0
#2 lore raw

PATCH v9 3/3 dt-bindings: vendor-prefixes: Document EmbedFire

From: Wenhao Cui <[email protected]>

EmbedFire is a manufacturer of embed computers and education platform for embed devices from Dongguan.

Add vendor prefix for it.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 00493b962bd7..0f04ee30bdc2 100644
@@ -396,6 +396,8 @@ patternProperties:
     description: Elimo Engineering Ltd.
   "^elpida,.*":
     description: Elpida Memory, Inc.
+  "^embedfire,.*":
+    description: Dongguan EmbedFire Electronic Technology Co., Ltd.
   "^embest,.*":
     description: Shenzhen Embest Technology Co., Ltd.
   "^emlid,.*":
Signature · 1 line
2.27.0
Acked-by on v9 3/3
#3 lore raw

Re: [PATCH v9 3/3] dt-bindings: vendor-prefixes: Document EmbedFire

Quoted 10 lines · Yuteng Zhong

From: Wenhao Cui <[email protected]>

EmbedFire is a manufacturer of embed computers and education platform for embed devices from Dongguan.

Add vendor prefix for it.

---

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH v9 2/3] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

In reply to Yuteng Zhong
Quoted 7 lines · Yuteng Zhong

From: Wenhao Cui <[email protected]>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

---

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

author
#5 lore raw

Re: [PATCH v9 2/3] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Hi, Krzysztof,

Sorry, we do not know the process, this is our first contribution to the Linux Kernel. There is no change since the last review of this file.

Quoted 28 lines · Krzysztof Kozlowski <[email protected]> 于2022年12月23日周五 16:01写道:
Quoted 7 lines · Yuteng Zhong

From: Wenhao Cui <[email protected]>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

---

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH v9 2/3] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Quoted 5 lines · ty

Hi, Krzysztof,

Sorry, we do not know the process, this is our first contribution to the Linux Kernel. There is no change since the last review of this file.

So I linked you the process and explain it.

Best regards,
Krzysztof

author
#7 lore raw

Re: [PATCH v9 2/3] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Got it. 2/3 and 3/3 will have the Acked-By line in the next PATCH version.

May I ask whether there are any changes required in [PATCH v9 1/3]?

Quoted 14 lines · Krzysztof Kozlowski <[email protected]> 于2022年12月23日周五 18:18写道:
Quoted 5 lines · ty

Hi, Krzysztof,

Sorry, we do not know the process, this is our first contribution to the Linux Kernel. There is no change since the last review of this file.

So I linked you the process and explain it.

Best regards,
Krzysztof

maintainer Applied
#8 lore raw
In reply to Yuteng Zhong
Quoted 21 lines · Yuteng Zhong

From: Wenhao Cui <[email protected]>

The LubanCat 1 is a RK3566 based SBC, developed by Dongguan EmbedFire Electronic Technology Co., Ltd.

It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header

Quoted 1 line

[...]

Applied, thanks!

[1/3] arm64: dts: rockchip: Add EmbedFire LubanCat 1

      commit: 8d94da58de534634c835f22a43070f56caa2fcb6
[2/3] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
      commit: 1e83f6bfaf84d9e0bcb221304bb47e74c0e80924
[3/3] dt-bindings: vendor-prefixes: Document EmbedFire
      commit: 43ba22818788f5a8fff5b1feaa329fa4991a3225

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>