Add support for MediaTek AHCI SATA
Subsystems (3)
v3 cover Add support for MediaTek AHCI SATA
Hi,
This patch series add support for AHCI compatible SATA controller, and it is compliant with the ahci 1.3 and sata 3.0 specification. This driver is slightly different than ahci_platform.c (e.g., reset control, subsystem setting).
changes since v3:
- update binding text: fix a typo and modify compatible strings.
changes since v2:
- according to Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines"). replace devm_reset_control_get_optional() by devm_reset_control_get_optional_exclusive().
changes since v1:
- update binding text: add missing "specifier pairs" descriptions.
- fix kbuild test warning: fix the error handling.
Ryder Lee (2):
ata: mediatek: add support for MediaTek SATA controller
dt-bindings: ata: add DT bindings for MediaTek SATA controller
Documentation/devicetree/bindings/ata/ahci-mtk.txt | 51 ++++++ drivers/ata/Kconfig | 10 ++ drivers/ata/Makefile | 1 + drivers/ata/ahci_mtk.c | 196 +++++++++++++++++++++ 4 files changed, 258 insertions(+) create mode 100644 Documentation/devicetree/bindings/ata/ahci-mtk.txt create mode 100644 drivers/ata/ahci_mtk.c
Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v3 1/2 ata: mediatek: add support for MediaTek SATA controller
This adds support the AHCI-compliant Serial ATA controller present on MediaTek SoCs.
--- drivers/ata/Kconfig | 10 +++ drivers/ata/Makefile | 1 + drivers/ata/ahci_mtk.c | 196 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 207 insertions(+) create mode 100644 drivers/ata/ahci_mtk.c
drivers/ata/Kconfig +10 -0
@@ -153,6 +153,16 @@ config AHCI_CEVA If unsure, say N. +config AHCI_MTK + tristate "MediaTek AHCI SATA support" + depends on ARCH_MEDIATEK + select MFD_SYSCON + help + This option enables support for the MediaTek SoC's + onboard AHCI SATA controller. + + If unsure, say N. + config AHCI_MVEBU tristate "Marvell EBU AHCI SATA support" depends on ARCH_MVEBU
drivers/ata/Makefile +1 -0
@@ -17,6 +17,7 @@ obj-$(CONFIG_AHCI_CEVA) += ahci_ceva.o libahci.o libahci_platform.o obj-$(CONFIG_AHCI_DA850) += ahci_da850.o libahci.o libahci_platform.o obj-$(CONFIG_AHCI_DM816) += ahci_dm816.o libahci.o libahci_platform.o obj-$(CONFIG_AHCI_IMX) += ahci_imx.o libahci.o libahci_platform.o +obj-$(CONFIG_AHCI_MTK) += ahci_mtk.o libahci.o libahci_platform.o obj-$(CONFIG_AHCI_MVEBU) += ahci_mvebu.o libahci.o libahci_platform.o obj-$(CONFIG_AHCI_OCTEON) += ahci_octeon.o obj-$(CONFIG_AHCI_SUNXI) += ahci_sunxi.o libahci.o libahci_platform.o
drivers/ata/ahci_mtk.c new file +196 -0
196 lines not on this page · raw message
Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/2] ata: mediatek: add support for MediaTek SATA controller
Quoted 4 lines · Ryder Lee
This adds support the AHCI-compliant Serial ATA controller present on MediaTek SoCs.
Signed-off-by Ryder Lee <[email protected]>
Looks good to me.
If others are okay with it, please let me know how the patches should be routed. I can push both through libata, both can be routed through dt tree, or we can handle them separately.
Thanks.
Signature · 1 line
tejun
Matthias Brugger
maintainerRe: [PATCH v3 1/2] ata: mediatek: add support for MediaTek SATA controller
Quoted 6 lines · Tejun Heo
Quoted 4 lines · Ryder Lee
This adds support the AHCI-compliant Serial ATA controller present on MediaTek SoCs.
Signed-off-by Ryder Lee <[email protected]>
Quoted 8 lines
Looks good to me.
Acked-by Tejun Heo <[email protected]>If others are okay with it, please let me know how the patches should be routed. I can push both through libata, both can be routed through dt tree, or we can handle them separately.
Please take the device tree bindings through your tree as well. You might want to wait for a Ack from a device tree maintainer though.
Thanks,
Matthias
PATCH v3 2/2 dt-bindings: ata: add DT bindings for MediaTek SATA controller
In reply to Ryder LeeAdd DT bindings for the onboard SATA controller present on the MediaTek SoCs.
--- Documentation/devicetree/bindings/ata/ahci-mtk.txt | 51 ++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/ata/ahci-mtk.txt
Documentation/devicetree/bindings/ata/ahci-mtk.txt new file +51 -0
@@ -0,0 +1,51 @@ +MediaTek Serial ATA controller + +Required properties: + - compatible : Must be "mediatek,soc-model-ahci", "mediatek,mtk-ahci". + When using "mediatek,mtk-ahci" compatible strings, you + need SoC specific ones in addition, one of: + - "mediatek,mt7622-ahci" + - reg : Physical base addresses and length of register sets. + - interrupts : Interrupt associated with the SATA device. + - interrupt-names : Associated name must be: "hostc". + - clocks : A list of phandle and clock specifier pairs, one for each + entry in clock-names. + - clock-names : Associated names must be: "ahb", "axi", "asic", "rbc", "pm". + - phys : A phandle and PHY specifier pair for the PHY port. + - phy-names : Associated name must be: "sata-phy". + - ports-implemented : See ./ahci-platform.txt for details. + +Optional properties: + - power-domains : A phandle and power domain specifier pair to the power + domain which is responsible for collapsing and restoring + power to the peripheral. + - resets : Must contain an entry for each entry in reset-names. + See ../reset/reset.txt for details. + - reset-names : Associated names must be: "axi", "sw", "reg". + - mediatek,phy-mode : A phandle to the system controller, used to enable + SATA function. + +Example: + + sata: sata@1a200000 { + compatible = "mediatek,mt7622-ahci", + "mediatek,mtk-ahci"; + reg = <0 0x1a200000 0 0x1100>; + interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "hostc"; + clocks = <&pciesys CLK_SATA_AHB_EN>, + <&pciesys CLK_SATA_AXI_EN>, + <&pciesys CLK_SATA_ASIC_EN>, + <&pciesys CLK_SATA_RBC_EN>, + <&pciesys CLK_SATA_PM_EN>; + clock-names = "ahb", "axi", "asic", "rbc", "pm"; + phys = <&u3port1 PHY_TYPE_SATA>; + phy-names = "sata-phy"; + ports-implemented = <0x1>; + power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>; + resets = <&pciesys MT7622_SATA_AXI_BUS_RST>, + <&pciesys MT7622_SATA_PHY_SW_RST>, + <&pciesys MT7622_SATA_PHY_REG_RST>; + reset-names = "axi", "sw", "reg"; + mediatek,phy-mode = <&pciesys>; + };
Signature · 1 line
1.9.1
Re: [PATCH v3 2/2] dt-bindings: ata: add DT bindings for MediaTek SATA controller
Quoted 15 lines · Ryder Lee
Add DT bindings for the onboard SATA controller present on the MediaTek SoCs.
Signed-off-by Ryder Lee <[email protected]>--- Documentation/devicetree/bindings/ata/ahci-mtk.txt | 51 ++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/ata/ahci-mtk.txtDocumentation/devicetree/bindings/ata/ahci-mtk.txt new file +0
-0
Documentation/devicetree/bindings/ata/ahci-mtk.txt line 4
Quoted 4 lines
Documentation/devicetree/bindings/ata/ahci-mtk.txt new file +4
-0@@ -0,0 +1,51 @@ +MediaTek Serial ATA controller + +Required properties: + - compatible : Must be "mediatek,soc-model-ahci", "mediatek,mtk-ahci".
Instead of "soc-model", pick something checkpatch.pl understands. IIRC, "<chip>" is one.
With that,