Skip to contentSkip to conversation

arm64: dts: rockchip: Add EmbedFire LubanCat 1

PATCH Superseded Yuteng Zhong 2 participants 6 messages Dec 21, 2022

Subsystems (2)

v5 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/2 arm64: dts: rockchip: Add EmbedFire LubanCat 1

From: DHDAXCW <[email protected]>

The LubanCat 1 is a RK3566 based SBC, developed by EmbedFire Electronics Co., Ltd.

It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header

---

Changed in V2:
- Remove RNG node
Changed in V3:
- Sent E-mail with a wrong attachment
Changed in V4:
- Modify all node names
Changed in V5:
- Fixed node name of vcc3v3_sys
- Fixed order in document
- Fixed commit message wrapping

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3566-lubancat-1.dts   | 598 ++++++++++++++++++
 2 files changed, 599 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 0a76a2ebb5f6..e52bda04d45a 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +598 -0

598 lines not on this page · raw message

Signature · 1 line
2.27.0
#1 lore raw

PATCH v5 2/2 dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

From: DHDAXCW <[email protected]>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index 88ff4422a8c1..058ed707f3cd 100644
@@ -95,6 +95,11 @@ properties:
           - const: elgin,rv1108-r1
           - const: rockchip,rv1108
 
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566
+
       - description: Engicam PX30.Core C.TOUCH 2.0
         items:
           - const: engicam,px30-core-ctouch2
Signature · 1 line
2.27.0
#2 lore raw

Re: [PATCH v5 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Quoted 7 lines · Yuteng Zhong

From: DHDAXCW <[email protected]>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

---

Thanks for the changes. The SoB chain is not correct - wrong order. "DHDAXCW" does not look person's name and we need real names.

Best regards,
Krzysztof

#5 lore raw
In reply to Yuteng Zhong
Quoted 21 lines · Yuteng Zhong

From: DHDAXCW <[email protected]>

The LubanCat 1 is a RK3566 based SBC, developed by EmbedFire Electronics Co., Ltd.

It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header

Quoted 2 lines

This also needs fixes (SoB order, full name)

Best regards,
Krzysztof

author
#3 lore raw

Re: [PATCH v5 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

In reply to Krzysztof Kozlowski

Got it. So the two SoB lines should be swapped? They should be changed to:

Quoted 16 lines · Krzysztof Kozlowski <[email protected]> 于2022年12月21日周三 23:06写道:
Quoted 7 lines · Yuteng Zhong

From: DHDAXCW <[email protected]>

Add devicetree binding documentation for the EmbedFire LubanCat 1.

---

Thanks for the changes. The SoB chain is not correct - wrong order. "DHDAXCW" does not look person's name and we need real names.

Best regards,
Krzysztof

Signature · 3 lines
Y. T. Zhong
Student of The University of Hong Kong, major in Computer Science.
E-mail: [email protected]