Skip to contentSkip to conversation

Initial attempt at flashing instructions.

RFC PATCH Superseded [email protected] 3 participants 13 messages Jun 16, 2017 – Jun 22, 2017

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Initial attempt at flashing instructions.

From: Drew Moseley <[email protected]>

This set of patches adds the native tools and target components needed to reflash the CHIP boards. Additionally a shell script is added to the deploy directory showing how to kick off a flash update. It's not ideal as I've hardcoded a max size for the UBI image into the script and didn't see much of an alternative. It does function though.

Drew

The following changes since commit 0079e6ac10fc371d6f527270c23b887561f717aa:

chip: Append to MACHINE_EXTRA_RRECOMMENDS rather than overwriting (2017-06-15 13:37:19 +0100)

are available in the git repository at:

[email protected]:drewmoseley/meta-chip.git flashing-instructions

for you to fetch changes up to 195a92fc1faa49495d1a2b6cda0134f07ce72189:

chip: Add chip-u-boot-scr recipe and flash script (2017-06-15 11:27:06 -0400)

----------------------------------------------------------------
Drew Moseley (3):
u-boot-chip: Deploy the sunxi-spl-with-ecc.bin file.
chip: Build sunxi-tools-native.
chip: Add chip-u-boot-scr recipe and flash script

 README                                          | 26 ++++++++-
 conf/layer.conf                                 |  3 ++
 conf/machine/chip.conf                          |  3 +-
 recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb  | 70 +++++++++++++++++++++++++
 recipes-bsp/chip-u-boot-scr/files/boot.cmd.full | 32 +++++++++++
 recipes-bsp/chip-u-boot-scr/files/boot.cmd.in   | 43 +++++++++++++++
 recipes-bsp/u-boot/u-boot-chip_git.bb           |  7 +++
 7 files changed, 182 insertions(+), 2 deletions(-)
 create mode 100644 recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb
 create mode 100644 recipes-bsp/chip-u-boot-scr/files/boot.cmd.full
 create mode 100644 recipes-bsp/chip-u-boot-scr/files/boot.cmd.in

Drew Moseley (3):
u-boot-chip: Deploy the sunxi-spl-with-ecc.bin file.
chip: Build sunxi-tools-native.
chip: Add chip-u-boot-scr recipe and flash script

 README                                          | 26 ++++++++-
 conf/layer.conf                                 |  3 ++
 conf/machine/chip.conf                          |  3 +-
 recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb  | 70 +++++++++++++++++++++++++
 recipes-bsp/chip-u-boot-scr/files/boot.cmd.full | 32 +++++++++++
 recipes-bsp/chip-u-boot-scr/files/boot.cmd.in   | 43 +++++++++++++++
 recipes-bsp/u-boot/u-boot-chip_git.bb           |  7 +++
 7 files changed, 182 insertions(+), 2 deletions(-)
 create mode 100644 recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb
 create mode 100644 recipes-bsp/chip-u-boot-scr/files/boot.cmd.full
 create mode 100644 recipes-bsp/chip-u-boot-scr/files/boot.cmd.in
Signature · 1 line
2.7.4
#1 lore raw

RFC PATCH 1/3 u-boot-chip: Deploy the sunxi-spl-with-ecc.bin file.

From: Drew Moseley <[email protected]>

---
 conf/machine/chip.conf                | 1 +
 recipes-bsp/u-boot/u-boot-chip_git.bb | 6 ++++++
 2 files changed, 7 insertions(+)
conf/machine/chip.conf +1 -0
index 0a45a2f..8f54067 100644
@@ -21,6 +21,7 @@ KERNEL_IMAGETYPE = "zImage"
 KERNEL_DEVICETREE = "sun5i-r8-chip.dtb"
 
 SPL_BINARY = "sunxi-spl.bin"
+SPL_ECC_BINARY = "sunxi-spl-with-ecc.bin"
 UBOOT_BINARY = "u-boot-dtb.bin"
 UBOOT_MACHINE = "CHIP_defconfig"
 
recipes-bsp/u-boot/u-boot-chip_git.bb +6 -0
index 8e2be50..f12fae6 100644
@@ -19,7 +19,13 @@ SRC_URI = " \
 S = "${WORKDIR}/git"
 
 do_compile_append() {
+    install ${B}/spl/${SPL_ECC_BINARY} ${B}/${SPL_ECC_BINARY}
     install ${B}/spl/${SPL_BINARY} ${B}/${SPL_BINARY}
 }
 
 COMPATIBLE_MACHINE = "chip"
+
+do_deploy_append() {
+    install -m 644 ${B}/${SPL_ECC_BINARY} ${DEPLOYDIR}/${SPL_ECC_BINARY}-${PV}-${PR}
+    ln -sf ${SPL_ECC_BINARY}-${PV}-${PR} ${DEPLOYDIR}/${SPL_ECC_BINARY}
+}
\ No newline at end of file
Signature · 1 line
2.7.4
#2 lore raw

RFC PATCH 2/3 chip: Build sunxi-tools-native.

In reply to [email protected]

From: Drew Moseley <[email protected]>

Add LAYERDEPENDS on meta-sunxi and add the sunxi-tools-native pacakage to EXTRA_IMAGEDEPENDS.

---
 conf/layer.conf        | 3 +++
 conf/machine/chip.conf | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
conf/layer.conf +3 -0
index 5dad66e..3324908 100644
@@ -8,3 +8,6 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
 BBFILE_COLLECTIONS += "meta-chip"
 BBFILE_PATTERN_meta-chip = "^${LAYERDIR}/"
 BBFILE_PRIORITY_meta-chip = "6"
+
+# Add this to get access to sunxi-tools recipe
+LAYERDEPENDS_meta-chip = "meta-sunxi"
\ No newline at end of file
conf/machine/chip.conf +1 -1
index 8f54067..ae166f9 100644
@@ -5,7 +5,7 @@
 MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS = " kernel-image kernel-devicetree"
 
-EXTRA_IMAGEDEPENDS += "u-boot"
+EXTRA_IMAGEDEPENDS += "u-boot sunxi-tools-native"
 
 DEFAULTTUNE ?= "cortexa8t-neon"
 include conf/machine/include/tune-cortexa8.inc
Signature · 1 line
2.7.4
#3 lore raw

Re: [meta-chip][RFC PATCH 2/3] chip: Build sunxi-tools-native.

Quoted 2 lines · On Fri, Jun 16, 2017 at 5:15 PM, <[email protected]> wrote:

Add LAYERDEPENDS on meta-sunxi and add the sunxi-tools-native pacakage to EXTRA_IMAGEDEPENDS.

meta-chip's README should also indicate this dependency.

#4 lore raw

RFC PATCH 3/3 chip: Add chip-u-boot-scr recipe and flash script

In reply to [email protected]

From: Drew Moseley <[email protected]>

Add a U-Boot script to handle flashing the SPL, U-Boot and UBI root filesystem images into the onboard flash. Also generate a script showing how to execute the flash steps.

---
 README                                          | 26 ++++++++-
 recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb  | 70 +++++++++++++++++++++++++
 recipes-bsp/chip-u-boot-scr/files/boot.cmd.full | 32 +++++++++++
 recipes-bsp/chip-u-boot-scr/files/boot.cmd.in   | 43 +++++++++++++++
 recipes-bsp/u-boot/u-boot-chip_git.bb           |  1 +
 5 files changed, 171 insertions(+), 1 deletion(-)
 create mode 100644 recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb
 create mode 100644 recipes-bsp/chip-u-boot-scr/files/boot.cmd.full
 create mode 100644 recipes-bsp/chip-u-boot-scr/files/boot.cmd.in
README +25 -1
index cccf59e..cf52e05 100644
@@ -59,4 +59,28 @@ To build a machine supported by this BSP layer follow the next steps:
 II. Flashing a C.H.I.P. board
 ========================================
 
-<TODO>
+As part of the build including this BSP layer, a U-Boot script and a shell script
+are created to assist in flashing your images to the CHIP board.  Note that this
+script assumes a maximum size for your UBI image of 0x0A000000 bytes.  If your UBI
+image exceeds that, then you will need to adapt this to your environment.
+
+To successfully run this script you will first need to set your board into FEL mode.
+chip. https://docs.getchip.com/chip.html#flash-chip-with-an-os
+Insert a wire into the U14 header between pin 7 (FEL) and GND.  Then connect the
+board with a USB cable to your build system.
+
+You need to specify the base filename of your UBI image using the UBI_IMAGE shell
+variable before invoking the generated script as follows:
+
+$ UBI_IMAGE=core-image-full-cmdline-chip.ubi ./tmp/deploy/images/chip/flash_CHIP_board.sh
+
+This script will take some time to execute.  If you have a serial console connected to
+your board, you will see the progress and a message on the console will indicate when
+the flashing is completed. Additionally, once the image is properly flashed, the status
+LED on the CHIP board will flash 30 times per second indicating that it is safe to power
+down your board and disable FEL mode.
+
+WARNING: This will erase the entire contents of your CHIP board.
+
+NOTE: This setup is still compatible with the CHIP flashing utility available
+at http://flash.getchip.com if you choose to reinstall the stock images.
recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb new file +70 -0

70 lines not on this page · raw message

recipes-bsp/chip-u-boot-scr/files/boot.cmd.full new file +32 -0
new file mode 100644
index 0000000..9589c87
@@ -0,0 +1,32 @@
+echo Scrubbing NAND
+nand scrub -y 0x0 0x200000000
+echo Writing SPL (with ECC) to NAND address 0x0
+nand write.raw.noverify $SPL_MEM_ADDR 0x0 $PADDED_SPL_SIZE
+echo Writing SPL (with ECC) to NAND address 0x400000
+nand write.raw.noverify $SPL_MEM_ADDR 0x400000 $PADDED_SPL_SIZE
+echo Writing UBoot image to address 0x800000
+nand write $UBOOT_MEM_ADDR 0x800000 $PADDED_UBOOT_SIZE
+
+# Setup the default environment
+setenv bootargs root=ubi0:rootfs rootfstype=ubifs rw earlyprintk ubi.mtd=4
+setenv bootcmd 'mtdparts; ubi part UBI; ubifsmount ubi0:rootfs; ubifsload \$fdt_addr_r /boot/sun5i-r8-chip.dtb; ubifsload \$kernel_addr_r /boot/zImage; bootz \$kernel_addr_r - \$fdt_addr_r'
+setenv fel_booted 0
+
+echo Enabling Splash
+setenv stdout serial
+setenv stderr serial
+setenv splashpos m,m
+
+echo Setting Video Mode
+setenv video-mode sunxi:640x480-24@60,monitor=composite-ntsc,overscan_x=40,overscan_y=20
+
+echo Saving default environment
+saveenv
+
+echo Writing UBI rootfs to NAND address 0x1000000
+nand write.slc-mode.trimffs $UBI_MEM_ADDR 0x1000000 $UBI_SIZE
+
+echo ===========================================================
+echo Flashing Complete.  Please power down and disable FEL mode.
+echo ===========================================================
+
recipes-bsp/chip-u-boot-scr/files/boot.cmd.in new file +43 -0

43 lines not on this page · raw message

recipes-bsp/u-boot/u-boot-chip_git.bb +1 -0
index f12fae6..008f346 100644
@@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = "file://Licenses/README;md5=0507cd7da8e7ad6d6701926ec9b84c95"
 
 DEPENDS += "dtc-native"
 PROVIDES += "u-boot"
+RDEPENDS_${PN}_append_chip = " chip-u-boot-scr"
 
 UBOOT_VERSION ?= "2016.01"
 PV = "${UBOOT_VERSION}+git${SRCPV}"
Signature · 1 line
2.7.4
#5 lore raw

Re: [meta-chip][RFC PATCH 3/3] chip: Add chip-u-boot-scr recipe and flash script

README To build a machine supported by this BSP layer follow the next steps:

Quoted 5 lines · On Fri 2017-06-16 @ 05:15:40 PM, [email protected] wrote:
README +0 -0
index cccf59e..cf52e05 100644
@@ -59,4 +59,28 @@ To build a machine supported by this BSP layer follow the next steps:

Please wrap the additions to the README to 80 columns.

Quoted 8 lines
README +4 -1
 II. Flashing a C.H.I.P. board
 ========================================
 
-<TODO>
+As part of the build including this BSP layer, a U-Boot script and a shell script
+are created to assist in flashing your images to the CHIP board.  Note that this
+script assumes a maximum size for your UBI image of 0x0A000000 bytes.  If your UBI
+image exceeds that, then you will need to adapt this to your environment.

README To build a machine supported by this BSP layer follow the next steps: · line 75

Quoted 10 lines
README +10 -0
+
+To successfully run this script you will first need to set your board into FEL mode.
+chip. https://docs.getchip.com/chip.html#flash-chip-with-an-os
+Insert a wire into the U14 header between pin 7 (FEL) and GND.  Then connect the
+board with a USB cable to your build system.
+
+You need to specify the base filename of your UBI image using the UBI_IMAGE shell
+variable before invoking the generated script as follows:
+
+$ UBI_IMAGE=core-image-full-cmdline-chip.ubi ./tmp/deploy/images/chip/flash_CHIP_board.sh

Outside of a udev tweak, this script needs to be run as root. It's traditional to indicate commands run as root by prefixing them with a PS1 of '#'.

Quoted 11 lines
README +11 -0
+
+This script will take some time to execute.  If you have a serial console connected to
+your board, you will see the progress and a message on the console will indicate when
+the flashing is completed. Additionally, once the image is properly flashed, the status
+LED on the CHIP board will flash 30 times per second indicating that it is safe to power
+down your board and disable FEL mode.
+
+WARNING: This will erase the entire contents of your CHIP board.
+
+NOTE: This setup is still compatible with the CHIP flashing utility available
+at http://flash.getchip.com if you choose to reinstall the stock images.
#6 lore raw

Re: [meta-chip][RFC PATCH 3/3] chip: Add chip-u-boot-scr recipe and flash script

In reply to [email protected]
Quoted 1 line · On Fri 2017-06-16 @ 05:15:40 PM, [email protected] wrote:

+This script will take some time to execute.

true

Review

Quoted 3 lines

If you have a serial console connected to

(quoted diff) +2 -0
+your board, you will see the progress and a message on the console will indicate when
+the flashing is completed.

hmmm, never saw this. I have a console connected, the moment the script started, on the console I got:

	U-Boot SPL 2016.01 (Jun 19 2017 - 00:32:19)
	DRAM: 512 MiB
	CPU: 1008000000Hz, AXI/AHB/APB: 3/2/2
	Trying to boot from

which looks right, the date+time are good.

Where I started the script I get:

	# UBI_IMAGE=core-image-full-cmdline-chip.ubi
	# tmp-glibc/deploy/images/chip/flash_CHIP_board.sh
	100% [================================================]  3537 kB,  557.5 kB/s 
	100% [================================================]   616 kB,  823.9 kB/s 
	100% [================================================]     2 kB,  733.9 kB/s
	100% [================================================] 654311 kB,  771.4 kB/s

README To build a machine supported by this BSP layer follow the next steps: · line 81

Quoted 3 lines

Additionally, once the image is properly flashed, the status

README +2 -0
+LED on the CHIP board will flash 30 times per second indicating that it is safe to power
+down your board and disable FEL mode.

I don't get any LED flashing, and nothing other than what I've pasted above on the console.

Rebooting the board after flashing outside of FEL mode simply boots the previous u-boot and image.

Any thoughts?

#7 lore raw

Re: [meta-chip][RFC PATCH 3/3] chip: Add chip-u-boot-scr recipe and flash script

Quoted 2 lines · Trevor Woerner

On Fri 2017-06-16 @ 05:15:40 PM, [email protected] wrote:
Any thoughts?

It appears my image was too large. Using a smaller image appears to work as expected!

#8 lore raw

Re: [meta-chip][RFC PATCH 3/3] chip: Add chip-u-boot-scr recipe and flash script

In reply to Trevor Woerner
Quoted 10 lines · Trevor Woerner

Review

Quoted 4 lines

If you have a serial console connected to

(quoted diff) +2 -0
+your board, you will see the progress and a message on the console will indicate when
+the flashing is completed.

hmmm, never saw this. I have a console connected, the moment the script started, on the console I got:

Quoted 6 lines
	U-Boot SPL 2016.01 (Jun 19 2017 - 00:32:19)
	DRAM: 512 MiB
	CPU: 1008000000Hz, AXI/AHB/APB: 3/2/2
	Trying to boot from

which looks right, the date+time are good.

Did you see the proper serial output after using a smaller image?

Drew

#9 lore raw

Re: [meta-chip][RFC PATCH 3/3] chip: Add chip-u-boot-scr recipe and flash script

Quoted 10 lines · Drew Moseley
Quoted 10 lines · Trevor Woerner

Review

Quoted 4 lines

If you have a serial console connected to

(quoted diff) +2 -0
+your board, you will see the progress and a message on the console will indicate when
+the flashing is completed.

hmmm, never saw this. I have a console connected, the moment the script started, on the console I got:

Quoted 8 lines
Quoted 6 lines
      U-Boot SPL 2016.01 (Jun 19 2017 - 00:32:19)
      DRAM: 512 MiB
      CPU: 1008000000Hz, AXI/AHB/APB: 3/2/2
      Trying to boot from

which looks right, the date+time are good.

Did you see the proper serial output after using a smaller image?

Yes. With a smaller image (~90MB) the flash update worked. Maybe another improvement for a v2 would be for the script to look at the size of /full/path/to/UBI_IMAGE and issue a warning/error if it's too big?

I think the wording of what to expect on the host and over the serial console could use some updating. Not to mention you say: "the status LED on the CHIP board will flash 30 times per second..." which doesn't seem to be the case, it looks more like the LED is toggled every 2 seconds (??), in any case, it's a lot slower than 30/sec.

#10 lore raw

Re: [meta-chip][RFC PATCH 3/3] chip: Add chip-u-boot-scr recipe and flash script

2017-06-19 16:40 skrev Trevor Woerner:

Quoted 1 line

On Mon, Jun 19, 2017 at

Quoted 2 lines · Drew Moseley
Quoted 2 lines
Quoted 2 lines

On Jun 19,

Quoted 2 lines · Trevor Woerner
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

If you have a serial console connected to +your board, you will see the progress and a message on the console will indicate when +the flashing is completed.

Quoted 1 line
Quoted 1 line
Quoted 1 line

hmmm, never saw this. I have a console connected, the

moment the script started, on the console I got: U-Boot SPL 2016.01 (Jun 19 2017 - 00:32:19) DRAM: 512 MiB CPU: 1008000000Hz, AXI/AHB/APB: 3/2/2 Trying to boot from which looks right, the date+time are good.

Quoted 1 line
Quoted 1 line

Did

you see the proper serial output after using a smaller image?

Quoted 2 lines

Yes.

With a smaller image (~90MB) the flash update worked. Maybe

Quoted 1 line

another

improvement for a v2 would be for the script to look at the

Quoted 1 line

size of

/full/path/to/UBI_IMAGE and issue a warning/error if it's too

Quoted 4 lines

big?

I think the wording of what to expect on the host and over the

serial

Quoted 1 line

console could use some updating. Not to mention you say: "the

status

Quoted 1 line

LED on the CHIP board will flash 30 times per second..." which

doesn't

Quoted 1 line

seem to be the case, it looks more like the LED is toggled

every 2

Quoted 1 line

seconds (??), in any case, it's a lot slower than 30/sec.

I
also had the same experience as Trevor, that the led seems to flash every 2 seconds. Also the code indicate that 2 x 1 sec sleep is used in this area, so please go through the above description when it comes to led experience during flashing. Another minor comment is that I believe you should update the UBI_IMAGE example in README to use the "default" meta-chip hwup image (chip-hwup-image-chip.ubi).

BR Petter

Petter
Mabäcker

Technux <[email protected]>
www.technux.se

#11 lore raw

Re: [meta-chip][RFC PATCH 3/3] chip: Add chip-u-boot-scr recipe and flash script

Quoted 21 lines · Petter Mabäcker

2017-06-19 16:40 skrev Trevor Woerner:

Quoted 11 lines · On Mon, Jun 19, 2017 at 7:22 AM, Drew Moseley <[email protected]…
Quoted 5 lines
Quoted 4 lines · On Jun 19, 2017, at 1:48 AM, Trevor Woerner <[email protected]…
Quoted 2 lines

If you have a serial console connected to +your board, you will see the progress and a message on the console will indicate when +the flashing is completed.

hmmm, never saw this. I have a console connected, the moment the script started, on the console I got: U-Boot SPL 2016.01 (Jun 19 2017 - 00:32:19) DRAM: 512 MiB CPU: 1008000000Hz, AXI/AHB/APB: 3/2/2 Trying to boot from which looks right, the date+time are good.

Did you see the proper serial output after using a smaller image?

Yes. With a smaller image (~90MB) the flash update worked. Maybe another improvement for a v2 would be for the script to look at the size of /full/path/to/UBI_IMAGE and issue a warning/error if it's too big?

Quoted 5 lines

I think the wording of what to expect on the host and over the serial console could use some updating. Not to mention you say: "the status LED on the CHIP board will flash 30 times per second..." which doesn't seem to be the case, it looks more like the LED is toggled every 2 seconds (??), in any case, it's a lot slower than 30/sec.

Quoted 8 lines

I also had the same experience as Trevor, that the led seems to flash every 2 seconds. Also the code indicate that 2 x 1 sec sleep is used in this area, so please go through the above description when it comes to led experience during flashing. Another minor comment is that I believe you should update the UBI_IMAGE example in README to use the "default" meta-chip hwup image (chip-hwup-image-chip.ubi).

BR Petter

Petter Mabäcker

Technux <[email protected]>
www.technux.se

Indeed. The comment was intended to say that it flashes 30/min. Obviously flashing 30/sec would not be a very easy thing for people to spot.

I’ll work through the comments and submit V2. It will take me a few days.

Many thanks for the feedback.

Drew

#12 lore raw
In reply to [email protected]

2017-06-16 23:15 skrev [email protected]:

Quoted 1 line

From: Drew

Moseley <[email protected]>

Quoted 2 lines

This set of patches adds the

native tools and target components needed to

Quoted 1 line

reflash the CHIP boards.

Additionally a shell script is added to the deploy

Quoted 1 line

directory showing

how to kick off a flash update. It's not ideal as I've

Quoted 1 line

hardcoded a max

size for the UBI image into the script and didn't see much

Quoted 1 line

of an

alternative. It does function though.

Quoted 4 lines

Drew

The following

changes since commit 0079e6ac10fc371d6f527270c23b887561f717aa:

Quoted 2 lines

chip: Append to MACHINE_EXTRA_RRECOMMENDS rather than overwriting (2017-06-15 13:37:19 +0100)

Quoted 2 lines

are available in the git repository

at:

Quoted 2 lines

[email protected]:drewmoseley/meta-chip.git

flashing-instructions

Quoted 2 lines

for you to fetch changes up to

195a92fc1faa49495d1a2b6cda0134f07ce72189:

Quoted 2 lines

chip: Add chip-u-boot-scr

recipe and flash script (2017-06-15 11:27:06 -0400)

Quoted 2 lines

----------------------------------------------------------------

Quoted 1 line

Drew

Moseley (3):

Quoted 2 lines

u-boot-chip: Deploy the sunxi-spl-with-ecc.bin file.

chip: Build sunxi-tools-native.

Quoted 1 line

chip: Add chip-u-boot-scr recipe and

flash script

Quoted 4 lines

README | 26 ++++++++-
conf/layer.conf | 3 ++

conf/machine/chip.conf | 3 +-

Quoted 1 line

recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb | 70
+++++++++++++++++++++++++

Quoted 1 line

recipes-bsp/chip-u-boot-scr/files/boot.cmd.full | 32 +++++++++++

Quoted 1 line

recipes-bsp/chip-u-boot-scr/files/boot.cmd.in | 43 +++++++++++++++

Quoted 1 line

recipes-bsp/u-boot/u-boot-chip_git.bb | 7 +++

Quoted 1 line
7 files changed, 182

insertions(+), 2 deletions(-)

Quoted 1 line

create mode 100644

recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb

Quoted 1 line

create mode 100644

recipes-bsp/chip-u-boot-scr/files/boot.cmd.full

Quoted 1 line

create mode 100644

recipes-bsp/chip-u-boot-scr/files/boot.cmd.in

Quoted 3 lines

Drew Moseley (3):

u-boot-chip: Deploy the sunxi-spl-with-ecc.bin file.

Quoted 1 line

chip: Build

sunxi-tools-native.

Quoted 1 line

chip: Add chip-u-boot-scr recipe and flash

script

Quoted 4 lines

README | 26 ++++++++-
conf/layer.conf | 3 ++

conf/machine/chip.conf | 3 +-

Quoted 1 line

recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb | 70
+++++++++++++++++++++++++

Quoted 1 line

recipes-bsp/chip-u-boot-scr/files/boot.cmd.full | 32 +++++++++++

Quoted 1 line

recipes-bsp/chip-u-boot-scr/files/boot.cmd.in | 43 +++++++++++++++

Quoted 1 line

recipes-bsp/u-boot/u-boot-chip_git.bb | 7 +++

Quoted 1 line
7 files changed, 182

insertions(+), 2 deletions(-)

Quoted 1 line

create mode 100644

recipes-bsp/chip-u-boot-scr/chip-u-boot-scr.bb

Quoted 1 line

create mode 100644

recipes-bsp/chip-u-boot-scr/files/boot.cmd.full

Quoted 1 line

create mode 100644

recipes-bsp/chip-u-boot-scr/files/boot.cmd.in

Quoted 3 lines
Signature · 2 lines
-- 
2.7.4

Hi Drew,

First of all, great work. The flashing mechanism have been sort of a headache for many. Even if like you say there are some limitations etc with this proposal, it works and it's easy to use. Also since no other major concern have been provided by other reviewers, I think you should fix the comments received and then send it as non-RFC patch. Also check with Andrei if he want to have this as a PR in github as well.

BR
Petter

Petter Mabäcker

Technux <[email protected]>
www.technux.se