Skip to contentSkip to conversation

Adjustments in function call

PATCH Superseded Javier F. Arias 4 participants 9 messages Oct 19, 2019 – Oct 26, 2019 Staging

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

cover Adjustments in function call

This patchset fixes a warning and simplify a boolean expression in a function call.

Javier F. Arias (2):
staging: rtl8723bs: Fix line over 80 characters
staging: rtl8723bs: Simplify boolean expression

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/2 staging: rtl8723bs: Fix line over 80 characters

Fix line over 80 characters by wrapping arguments in function call. Fix suggested by Julia Lawall <[email protected]>.

---
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +3 -1
index c514cb735afd..0c2f3b2d4326 100644
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv,
+				  ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1
#7 lore raw

PATCH 2/2 staging: rtl8723bs: Simplify boolean expression

In reply to Javier F. Arias

Simplify expression that it's inverting a boolean value. Issue found by Coccinelle.

---
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +1 -1
index 0c2f3b2d4326..6f341d52afb6 100644
@@ -190,7 +190,7 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		ODM_CmnInfoUpdate(&pHalData->odmpriv,
 				  ODM_CMNINFO_BT_ENABLED,
-				  ((bBtDisabled == true)?false:true));
+				  !bBtDisabled);
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1
#8 lore raw
In reply to Javier F. Arias
Quoted 2 lines · Javier F. Arias

This patchset fixes a warning and simplify a boolean expression in a function call.

This is a v2 of something that you sent before, even though it was previously only one patch. Greg has to know what to take and what to drop.

julia

Quoted 16 lines

Javier F. Arias (2):
staging: rtl8723bs: Fix line over 80 characters
staging: rtl8723bs: Simplify boolean expression

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--
2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1571448899.git.jarias.linux%40gmail.com.

#2 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

In reply to Javier F. Arias
Quoted 2 lines · Javier F. Arias

Fix line over 80 characters by wrapping arguments in function call. Fix suggested by Julia Lawall <[email protected]>.

There is a Suggested-by: tag that would be better to use than the second line. That would limit the log message to what you are doing and why.

julia

Quoted 29 lines
---
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +3 -2
index c514cb735afd..0c2f3b2d4326 100644
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv,
+				  ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/eaa22be21885d04e47f1be2ad7be007182bf22bc.1571448899.git.jarias.linux%40gmail.com.

#3 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

Hello again Julia,

I updated the patch but I didn't receive any feedback nor acceptance by Greg. Is there something I'm doing wrong?

Thanks

Quoted 49 lines · Julia Lawall
Quoted 2 lines · Javier F. Arias

Fix line over 80 characters by wrapping arguments in function call. Fix suggested by Julia Lawall <[email protected] <javascript:>>.

There is a Suggested-by: tag that would be better to use than the second line. That would limit the log message to what you are doing and why.

julia

Review

Quoted 7 lines
Signed-off-by Javier F. Arias <[email protected] <javascript:>>

---

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++- 
 1 file changed, 3 insertions(+), 1 deletion(-) 
(quoted diff) +0 -0

b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c

drivers/staging/rtl8723bs/hal/rtl8723b_dm.c void rtl8723b_HalDmWatchDog(struct adapter *Adapter) · line 191

Quoted 8 lines

index c514cb735afd..0c2f3b2d4326 100644

drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +0 -1
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter) 
 
                 bBtDisabled = hal_btcoex_IsBtDisabled(Adapter); 
 
-                ODM_CmnInfoUpdate(&pHalData->odmpriv, 

ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));

Quoted 11 lines
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +3 -0
+                ODM_CmnInfoUpdate(&pHalData->odmpriv, 
+                                  ODM_CMNINFO_BT_ENABLED, 
+                                  ((bBtDisabled == true)?false:true)); 
 
                 ODM_DMWatchdog(&pHalData->odmpriv); 
         } 
Signature · 4 lines
2.20.1 

-- 
You received this message because you are subscribed to the Google 

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/eaa22be21885d04e47f1be2ad7be007182bf22bc.1571448899.git.jarias.linux%40gmail.com.

Quoted 1 line
#4 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

Quoted 4 lines · Javier Arias

Hello again Julia,

I updated the patch but I didn't receive any feedback nor acceptance by Greg. Is there something I'm doing wrong?

I have caught up with almost all outreachy patches, but not all. Give me another few days to do that. If you have not heard back about a patch within a week, feel free to resend it.

When I have caught up with everything, I will email the list letting people know so that if they sent something and did not get a response, they know to redo it.

thanks,

greg k-h

#5 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

Ahh, I just was a bit worried that I sent them incorrectly. I'll wait. Thank you for your time!

Quoted 19 lines · Greg KH
Quoted 4 lines · Javier Arias

Hello again Julia,

I updated the patch but I didn't receive any feedback nor acceptance by Greg. Is there something I'm doing wrong?

I have caught up with almost all outreachy patches, but not all. Give me another few days to do that. If you have not heard back about a patch within a week, feel free to resend it.

When I have caught up with everything, I will email the list letting people know so that if they sent something and did not get a response, they know to redo it.

thanks,

greg k-h

#6 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: Fix line over 80 characters

Quoted 2 lines · Javier Arias

Ahh, I just was a bit worried that I sent them incorrectly. I'll wait. Thank you for your time!

Hi Javier,

Please don't top post. See the section 'Responding to emails and responding inline' in the kernel first patch tutorial over
here: https://kernelnewbies.org/FirstKernelPatch

Thanks!

Quoted 24 lines · Greg KH
Quoted 11 lines · Javier Arias
Quoted 4 lines

Hello again Julia,

I updated the patch but I didn't receive any feedback nor acceptance by Greg. Is there something I'm doing wrong?

I have caught up with almost all outreachy patches, but not all. Give me another few days to do that. If you have not heard back about a patch within a week, feel free to resend it.

Quoted 7 lines

When I have caught up with everything, I will email the list letting people know so that if they sent something and did not get a response, they know to redo it.

thanks,

greg k-h

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/3cc42615-39cb-4f9e-b162-4f4f800f2cca%40googlegroups.com.