Skip to contentSkip to conversation

drm/amdgpu: update documentation for amdgpu_drv.c

PATCH Superseded Sonny Jiang 3 participants 5 messages Jul 4, 2018 – Jul 5, 2018 4 messages not in the archive

Subsystems (4)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drm/amdgpu: update documentation for amdgpu_drv.c

---
 Documentation/gpu/amdgpu.rst            |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 370 +++++++++++++++++++++++++++++++-
 2 files changed, 370 insertions(+), 7 deletions(-)
Documentation/gpu/amdgpu.rst +7 -0
index 765c2a3..a740e49 100644
@@ -5,6 +5,13 @@
 The drm/amdgpu driver supports all AMD Radeon GPUs based on the Graphics Core
 Next (GCN) architecture.
 
+Module Parameters
+=================
+
+The amdgpu driver supports the following module parameters:
+
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+
 Core Driver Infrastructure
 ==========================
 
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +363 -7

545 lines not on this page · raw message

Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1530728444-32347-1-git-send-email-sonny.jiang-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 04.07.2018 um 20:20 schrieb Sonny Jiang:

Quoted 8 lines

[SNIP]

+/**
+ * DOC: lockup_timeout (int)
+ * Set GPU scheduler timeout value in ms. It must be > 0. The default is 10000.
+ */
MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms > 0 (default 10000)"); module_param_named(lockup_timeout, amdgpu_lockup_timeout, int, 0444);

Actually the description here is incorrect, a value of 0 is handled as infinite timeout IIRC. Please fix while at it.

Apart from that the patch is Acked-by: Christian König <[email protected]>.

Christian.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 7279fc27-0bba-a818-7682-f4e06815b8da-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#4 lore raw

Change it to,

Value 0 is invalidated, will be adjusted to 10000. Negative values mean 'infinite timeout' (MAX_JIFFY_OFFSET).

Thanks,

Sonny

________________________________
From: Christian König <[email protected]>
Sent: Thursday, July 5, 2018 3:30:28 AM
To: Jiang, Sonny; [email protected]
Subject: Re: [PATCH v3] drm/amdgpu: update documentation for amdgpu_drv.c

Am 04.07.2018 um 20:20 schrieb Sonny Jiang:

Quoted 8 lines

[SNIP]

+/**
+ * DOC: lockup_timeout (int)
+ * Set GPU scheduler timeout value in ms. It must be > 0. The default is 10000.
+ */
MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms > 0 (default 10000)"); module_param_named(lockup_timeout, amdgpu_lockup_timeout, int, 0444);

Actually the description here is incorrect, a value of 0 is handled as infinite timeout IIRC. Please fix while at it.

Apart from that the patch is Acked-by: Christian König <[email protected]>.

Christian.

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CY4PR12MB1511F4BC97EABF20A34503D8FD400-rpdhrqHFk06XKdXwTjA44gdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#6 lore raw

Sounds like my memory fooled me, but we should document that as well.

Christian.

Am 05.07.2018 um 16:47 schrieb Jiang, Sonny:

Quoted 27 lines

Change it to,

Value 0 is invalidated, will be adjusted to 10000. Negative values mean 'infinite timeout' (MAX_JIFFY_OFFSET).

Thanks,

Sonny

------------------------------------------------------------------------
*From:* Christian König <[email protected]> *Sent:* Thursday, July 5, 2018 3:30:28 AM
*To:* Jiang, Sonny; [email protected] *Subject:* Re: [PATCH v3] drm/amdgpu: update documentation for amdgpu_drv.c Am 04.07.2018 um 20:20 schrieb Sonny Jiang:

Quoted 5 lines

[SNIP]

+/**
+ * DOC: lockup_timeout (int)
+ * Set GPU scheduler timeout value in ms. It must be > 0.  The

default is 10000.

Quoted 2 lines

+ */
   MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms > 0

(default 10000)");

Quoted 1 line

   module_param_named(lockup_timeout, amdgpu_lockup_timeout, int, 0444);

Quoted 7 lines

Actually the description here is incorrect, a value of 0 is handled as infinite timeout IIRC. Please fix while at it.

Apart from that the patch is Acked-by: Christian König <[email protected]>.

Christian.

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 131f66f1-8871-de93-2c3a-50b8c15cb9d8-5C7GfCeVMHo@public.gmane.org

#8 lore raw

Mhm, double checking that I now knew why my memory fooled me: We use 0 as infinite timeout in radeon.

Maybe we should change amdgpu to do the same and reject negative values.

Christian.

Am 05.07.2018 um 16:54 schrieb Christian König:

Quoted 38 lines

Sounds like my memory fooled me, but we should document that as well.

Christian.

Am 05.07.2018 um 16:47 schrieb Jiang, Sonny:

Quoted 33 lines

Change it to,

Value 0 is invalidated, will be adjusted to 10000. Negative values mean 'infinite timeout' (MAX_JIFFY_OFFSET).

Thanks,

Sonny

------------------------------------------------------------------------
*From:* Christian König <[email protected]> *Sent:* Thursday, July 5, 2018 3:30:28 AM
*To:* Jiang, Sonny; [email protected] *Subject:* Re: [PATCH v3] drm/amdgpu: update documentation for amdgpu_drv.c Am 04.07.2018 um 20:20 schrieb Sonny Jiang:

Quoted 5 lines

[SNIP]

+/**
+ * DOC: lockup_timeout (int)
+ * Set GPU scheduler timeout value in ms. It must be > 0.  The

default is 10000.

Quoted 2 lines

+ */
   MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms > 0

(default 10000)");

Quoted 1 line

   module_param_named(lockup_timeout, amdgpu_lockup_timeout, int, 0444);

Actually the description here is incorrect, a value of 0 is handled as infinite timeout IIRC. Please fix while at it.

Apart from that the patch is Acked-by: Christian König <[email protected]>.

Quoted 8 lines
Quoted 1 line

Christian.

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx