arm64: dts: qcom: add initial support for Samsung Galaxy S22
v8 cover arm64: dts: qcom: add initial support for Samsung Galaxy S22
Changes in v8:
- Rebase on 'arm64: dts: qcom: sm8450: Flatten usb controller node'
- Use real name for sign-offs
- Remove device tree binding patch as it's already in the tree, merged by Bjorn
Changes in v7:
- Document the reserved GPIO pins, remove pin 50 as it does not need to be reserved
- Clarify the phone isn't limited to USB 2.0 but rather USB 3.0 isn't implemented yet
- Add a newline before every 'status' node
Changes in v6:
- Remove debug features (bootargs, etc) that slipped in the v5 DTS
- Format and organize nodes correctly based on existing DTS, move "status = "okay";" to the bottom always
- Solve "ddr_device_type" and "qcom,rmtfs-mem" warnings, the rest are from existing SoC .dtsi
- Disable buttons, ufs and other features for later revision
Changes in v5:
- Properly format the thread
Changes in v4:
- Try to properly format the thread
Changes in v3:
- Removed unnecessary initrd start and end addresses
- Make sure r0q is in right order on Makefile
- Properly format memory addresses
- Set r0q to the correct, alphabetical order in documents
Changes in v2:
- Attempt to format the patchset thread correctly
Eric Gonçalves (1):
arm64: dts: qcom: add initial support for Samsung Galaxy S22
arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm8450-samsung-r0q.dts | 145 ++++++++++++++++++ 2 files changed, 146 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
Signature · 1 line
2.50.1
PATCH RESEND v8 1/1 arm64: dts: qcom: add initial support for Samsung Galaxy S22
Add new device support for the Samsung Galaxy S22 (SM-S901E) phone
What works:
- SimpleFB
- USB
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm8450-samsung-r0q.dts | 145 ++++++++++++++++++ 2 files changed, 146 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8350-sony-xperia-sagami-pdx214.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8350-sony-xperia-sagami-pdx215.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm8450-samsung-r0q.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-hdk.dtb
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +145 -0
145 lines not on this page · raw message
Signature · 1 line
2.50.1
Quoted 52 lines · Eric Gonçalves
Add new device support for the Samsung Galaxy S22 (SM-S901E) phone
What works:
- SimpleFB
- USBSigned-off-by Eric Gonçalves <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm8450-samsung-r0q.dts | 145 ++++++++++++++++++ 2 files changed, 146 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8350-sony-xperia-sagami-pdx214.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8350-sony-xperia-sagami-pdx215.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm8450-samsung-r0q.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8550-hdk.dtbarch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +21
-0@@ -0,0 +1,145 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/dts-v1/; + +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> + +#include "sm8450.dtsi" +#include "pm8350.dtsi" +#include "pm8350c.dtsi" + +/ { + model = "Samsung Galaxy S22 5G"; + compatible = "samsung,r0q", "qcom,sm8450"; + chassis-type = "handset"; + + chosen { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + framebuffer: framebuffer@b8000000 {
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts line 31
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +10
-0+ compatible = "simple-framebuffer"; + reg = <0x0 0xb8000000 0x0 0x2b00000>; + width = <1080>; + height = <2340>; + stride = <(1080 * 4)>; + format = "a8r8g8b8"; + }; + }; + + vph_pwr: vph-pwr-regulator {
Could you please change this to regulator-vph-pwr? This keeps all regulator nodes together.
LGTM otherwise
Quoted 8 lines
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts new file +8
-0+ compatible = "regulator-fixed"; + regulator-name = "vph_pwr"; + regulator-min-microvolt = <3700000>; + regulator-max-microvolt = <3700000>; + regulator-always-on; + regulator-boot-on; + }; +
Signature · 2 lines
With best wishes Dmitry