iio: humidity: ens210: Fix missing I2C functionality checks
PATCH 1/1 iio: humidity: ens210: Fix missing I2C functionality checks
The ENS210 driver uses both i2c_smbus_read_byte_data() and i2c_smbus_read_word_data() during the read and probe phases. However, i2c_check_functionality() was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.
Add I2C_FUNC_SMBUS_READ_BYTE_DATA and I2C_FUNC_SMBUS_READ_WORD_DATA to the functionality check mask to ensure the adapter supports the required operations before communication begins.
--- drivers/iio/humidity/ens210.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/humidity/ens210.c +2 -0
@@ -204,6 +204,8 @@ static int ens210_probe(struct i2c_client *client)if (!i2c_check_functionality (client->adapter,I2C_FUNC_SMBUS_WRITE_BYTE_DATA |I2C_FUNC_SMBUS_WRITE_BYTE | +I2C_FUNC_SMBUS_READ_BYTE_DATA | +I2C_FUNC_SMBUS_READ_WORD_DATA |I2C_FUNC_SMBUS_READ_I2C_BLOCK )) {return dev_err_probe (&client->dev, -EOPNOTSUPP ,"adapter does not support some i2c transactions\n" );
Signature · 1 line
2.43.0
Quoted 10 lines · Salah Triki
The ENS210 driver uses both
i2c_smbus_read_byte_data()andi2c_smbus_read_word_data()during the read and probe phases. However,i2c_check_functionality()was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.Add
I2C_FUNC_SMBUS_READ_BYTE_DATAandI2C_FUNC_SMBUS_READ_WORD_DATAto the functionality check mask to ensure the adapter supports the required operations before communication begins.
Can we rather modify the driver to use SW emulation for these cases?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Salah Triki
The ENS210 driver uses both
i2c_smbus_read_byte_data()andi2c_smbus_read_word_data()during the read and probe phases. However,i2c_check_functionality()was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.
Quoted 11 lines
Quoted 3 lines
Add
I2C_FUNC_SMBUS_READ_BYTE_DATAandI2C_FUNC_SMBUS_READ_WORD_DATAto the functionality check mask to ensure the adapter supports the required operations before communication begins.Can we rather modify the driver to use SW emulation for these cases?
Signature · 2 lines
With Best Regards, Andy Shevchenko
I'll update the probe function to check for I2C_FUNC_SMBUS_EMUL instead of the individual functions.
Thanks for the suggestion.
Best regards
--
Salah Triki
Quoted 9 lines · Salah Triki
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Salah Triki
The ENS210 driver uses both
i2c_smbus_read_byte_data()andi2c_smbus_read_word_data()during the read and probe phases. However,i2c_check_functionality()was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Add
I2C_FUNC_SMBUS_READ_BYTE_DATAandI2C_FUNC_SMBUS_READ_WORD_DATAto the functionality check mask to ensure the adapter supports the required operations before communication begins.Can we rather modify the driver to use SW emulation for these cases?
I'll update the probe function to check for
I2C_FUNC_SMBUS_EMULinstead of the individual functions.
Hmm... But will it work with the drivers that do not provide EMUL, but the native functions?
Please, carefully check all this and come up with a solution that works for most of the cases if not all.
Signature · 2 lines
With Best Regards, Andy Shevchenko