Skip to contentSkip to conversation

iio: humidity: ens210: Fix missing I2C functionality checks

PATCH Superseded Salah Triki 3 participants 4 messages May 5 IIO

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: humidity: ens210: Fix missing I2C functionality checks

The ENS210 driver uses both i2c_smbus_read_byte_data() and i2c_smbus_read_word_data() during the read and probe phases. However, i2c_check_functionality() was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.

Add I2C_FUNC_SMBUS_READ_BYTE_DATA and I2C_FUNC_SMBUS_READ_WORD_DATA to the functionality check mask to ensure the adapter supports the required operations before communication begins.

Fixes c524fbca672e ("iio: humidity: Add support for ENS210")
---
 drivers/iio/humidity/ens210.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/humidity/ens210.c +2 -0
index 77418d97f30d..e8633f247b10 100644
@@ -204,6 +204,8 @@ static int ens210_probe(struct i2c_client *client)
 	if (!i2c_check_functionality(client->adapter,
 				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
 				     I2C_FUNC_SMBUS_WRITE_BYTE |
+				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
+				     I2C_FUNC_SMBUS_READ_WORD_DATA |
 				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
 		return dev_err_probe(&client->dev, -EOPNOTSUPP,
 			"adapter does not support some i2c transactions\n");
Signature · 1 line
2.43.0
#1 lore raw
Quoted 10 lines · Salah Triki

The ENS210 driver uses both i2c_smbus_read_byte_data() and i2c_smbus_read_word_data() during the read and probe phases. However, i2c_check_functionality() was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.

Add I2C_FUNC_SMBUS_READ_BYTE_DATA and I2C_FUNC_SMBUS_READ_WORD_DATA to the functionality check mask to ensure the adapter supports the required operations before communication begins.

Can we rather modify the driver to use SW emulation for these cases?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Salah Triki

The ENS210 driver uses both i2c_smbus_read_byte_data() and i2c_smbus_read_word_data() during the read and probe phases. However, i2c_check_functionality() was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.

Quoted 11 lines
Quoted 3 lines

Add I2C_FUNC_SMBUS_READ_BYTE_DATA and I2C_FUNC_SMBUS_READ_WORD_DATA to the functionality check mask to ensure the adapter supports the required operations before communication begins.

Can we rather modify the driver to use SW emulation for these cases?

Signature · 2 lines
With Best Regards,
Andy Shevchenko

I'll update the probe function to check for I2C_FUNC_SMBUS_EMUL instead of the individual functions.

Thanks for the suggestion.

Best regards
--
Salah Triki

#3 lore raw
Quoted 9 lines · Salah Triki
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Salah Triki

The ENS210 driver uses both i2c_smbus_read_byte_data() and i2c_smbus_read_word_data() during the read and probe phases. However, i2c_check_functionality() was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Add I2C_FUNC_SMBUS_READ_BYTE_DATA and I2C_FUNC_SMBUS_READ_WORD_DATA to the functionality check mask to ensure the adapter supports the required operations before communication begins.

Can we rather modify the driver to use SW emulation for these cases?

I'll update the probe function to check for I2C_FUNC_SMBUS_EMUL instead of the individual functions.

Hmm... But will it work with the drivers that do not provide EMUL, but the native functions?
Please, carefully check all this and come up with a solution that works for most of the cases if not all.

Signature · 2 lines
With Best Regards,
Andy Shevchenko