Skip to contentSkip to conversation

ice: Fix fall-through warnings for Clang

PATCH RESEND Superseded Gustavo A. R. Silva 3 participants 3 messages Mar 5, 2021 – Mar 10, 2021

Subsystems (3)
Networking Network drivers Intel Ethernet

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH RESEND 1/1 ice: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/intel/ice/ice_txrx_lib.c +1 -0
index 02b12736ea80..207f6ee3a7f6 100644
@@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
 	case ICE_RX_PTYPE_INNER_PROT_UDP:
 	case ICE_RX_PTYPE_INNER_PROT_SCTP:
 		skb->ip_summed = CHECKSUM_UNNECESSARY;
+		break;
 	default:
 		break;
 	}
Signature · 1 line
2.27.0
#1 lore raw

Dear Gustavo,

Thank you for working on that.

Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:

Quoted 3 lines

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case.

It would be nice to have a short summary of the discrepancy between GCC and clang, and it was decided to go with the ?clang decision?, and not have clang adapt to GCC.

Quoted 11 lines
Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
  drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
  1 file changed, 1 insertion(+)
drivers/net/ethernet/intel/ice/ice_txrx_lib.c +0 -0
index 02b12736ea80..207f6ee3a7f6 100644

drivers/net/ethernet/intel/ice/ice_txrx_lib.c ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb, · line 149

Quoted 7 lines
drivers/net/ethernet/intel/ice/ice_txrx_lib.c +1 -0
@@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
  	case ICE_RX_PTYPE_INNER_PROT_UDP:
  	case ICE_RX_PTYPE_INNER_PROT_SCTP:
  		skb->ip_summed = CHECKSUM_UNNECESSARY;
+		break;
  	default:
  		break;
  	}

Kind regards,

Paul

Tested-by
#2 lore raw
Quoted 18 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Paul Menzel
Sent: Friday, March 5, 2021 1:04 AM
To: Gustavo A. R. Silva <[email protected]>; Brandeburg, Jesse <[email protected]>; Nguyen, Anthony L <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>
Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; linux- hardening at vger.kernel.org; linux-kernel at vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

Dear Gustavo,

Thank you for working on that.

Quoted 14 lines

Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:

Quoted 3 lines

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case.

It would be nice to have a short summary of the discrepancy between GCC and clang, and it was decided to go with the ?clang decision?, and not have clang adapt to GCC.

Quoted 5 lines
Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
  drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
  1 file changed, 1 insertion(+)
Tested-by Tony Brelinski <[email protected]> A Contingent Worker at Intel