Skip to contentSkip to conversation

drm/nouveau: Fix fall-through warnings for Clang

PATCH RESEND Superseded Gustavo A. R. Silva 3 participants 5 messages Mar 5, 2021 – Jun 4, 2021

Subsystems (3)
DRM drivers DRM misc nouveau

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH RESEND 1/1 drm/nouveau: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/gpu/drm/nouveau/nouveau_bo.c        | 1 +
 drivers/gpu/drm/nouveau/nouveau_connector.c | 1 +
 2 files changed, 2 insertions(+)
drivers/gpu/drm/nouveau/nouveau_bo.c +1 -0
index 2375711877cf..62903c3b368d 100644
@@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig)
 			break;
 		case TTM_PL_TT:
 			error |= !(domain & NOUVEAU_GEM_DOMAIN_GART);
+			break;
 		default:
 			break;
 		}
drivers/gpu/drm/nouveau/nouveau_connector.c +1 -0
index 61e6d7412505..eb844cdcaec2 100644
@@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector,
 			default:
 				break;
 			}
+			break;
 		case DRM_MODE_SCALE_FULLSCREEN:
 		case DRM_MODE_SCALE_CENTER:
 		case DRM_MODE_SCALE_ASPECT:
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

Quoted 36 lines · Gustavo A. R. Silva

In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/gpu/drm/nouveau/nouveau_bo.c        | 1 +
 drivers/gpu/drm/nouveau/nouveau_connector.c | 1 +
 2 files changed, 2 insertions(+)
drivers/gpu/drm/nouveau/nouveau_bo.c +1 -0
index 2375711877cf..62903c3b368d 100644
@@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig)
 			break;
 		case TTM_PL_TT:
 			error |= !(domain & NOUVEAU_GEM_DOMAIN_GART);
+			break;
 		default:
 			break;
 		}
drivers/gpu/drm/nouveau/nouveau_connector.c +1 -0
index 61e6d7412505..eb844cdcaec2 100644
@@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector,
 			default:
 				break;
 			}
+			break;
 		case DRM_MODE_SCALE_FULLSCREEN:
 		case DRM_MODE_SCALE_CENTER:
 		case DRM_MODE_SCALE_ASPECT:
#2 lore raw

Hi,

Friendly second ping: who can take this?

I can add this to my -next branch for 5.14 if you don't mind.

JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings.

Thanks
--
Gustavo

Quoted 45 lines · Gustavo A. R. Silva

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

Quoted 36 lines · Gustavo A. R. Silva

In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/gpu/drm/nouveau/nouveau_bo.c        | 1 +
 drivers/gpu/drm/nouveau/nouveau_connector.c | 1 +
 2 files changed, 2 insertions(+)
drivers/gpu/drm/nouveau/nouveau_bo.c +1 -0
index 2375711877cf..62903c3b368d 100644
@@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig)
 			break;
 		case TTM_PL_TT:
 			error |= !(domain & NOUVEAU_GEM_DOMAIN_GART);
+			break;
 		default:
 			break;
 		}
drivers/gpu/drm/nouveau/nouveau_connector.c +1 -0
index 61e6d7412505..eb844cdcaec2 100644
@@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector,
 			default:
 				break;
 			}
+			break;
 		case DRM_MODE_SCALE_FULLSCREEN:
 		case DRM_MODE_SCALE_CENTER:
 		case DRM_MODE_SCALE_ASPECT:
Reviewed-by
#3 lore raw

all three nouveau patches are

Reviewed-by Karol Herbst <[email protected]>

and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers?

Quoted 56 lines · Gustavo A. R. Silva

Hi,

Friendly second ping: who can take this?

I can add this to my -next branch for 5.14 if you don't mind.

JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings.

Thanks
--
Gustavo

Quoted 41 lines · Gustavo A. R. Silva

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

Quoted 32 lines · Gustavo A. R. Silva

In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/gpu/drm/nouveau/nouveau_bo.c        | 1 +
 drivers/gpu/drm/nouveau/nouveau_connector.c | 1 +
 2 files changed, 2 insertions(+)
drivers/gpu/drm/nouveau/nouveau_bo.c +1 -0
index 2375711877cf..62903c3b368d 100644
@@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig)
                     break;
             case TTM_PL_TT:
                     error |= !(domain & NOUVEAU_GEM_DOMAIN_GART);
+                    break;
             default:
                     break;
             }
drivers/gpu/drm/nouveau/nouveau_connector.c +1 -0
index 61e6d7412505..eb844cdcaec2 100644
@@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector,
                     default:
                             break;
                     }
+                    break;
Quoted 9 lines
Quoted 4 lines

drivers/gpu/drm/nouveau/nouveau_connector.c nouveau_conn_atomic_set_property(struct drm_connector *connector, · line 163

Quoted 4 lines
drivers/gpu/drm/nouveau/nouveau_connector.c +0 -0
             case DRM_MODE_SCALE_FULLSCREEN:
             case DRM_MODE_SCALE_CENTER:
             case DRM_MODE_SCALE_ASPECT:

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau

#4 lore raw
Quoted 7 lines · Karol Herbst

all three nouveau patches are

Reviewed-by Karol Herbst <[email protected]>

and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers?

No other person has replied after pinging multiple times and resending these patches, so I guess people don't care.

I'll add this and the other similar patches to my -next branch for 5.14.

Thanks, Karol.
--
Gustavo

Quoted 69 lines
Quoted 65 lines · Gustavo A. R. Silva

Hi,

Friendly second ping: who can take this?

I can add this to my -next branch for 5.14 if you don't mind.

JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings.

Thanks
--
Gustavo

Quoted 37 lines · Gustavo A. R. Silva

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

Quoted 28 lines · Gustavo A. R. Silva

In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/gpu/drm/nouveau/nouveau_bo.c        | 1 +
 drivers/gpu/drm/nouveau/nouveau_connector.c | 1 +
 2 files changed, 2 insertions(+)
drivers/gpu/drm/nouveau/nouveau_bo.c +1 -0
index 2375711877cf..62903c3b368d 100644
@@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig)
                     break;
             case TTM_PL_TT:
                     error |= !(domain & NOUVEAU_GEM_DOMAIN_GART);
+                    break;
             default:
                     break;
             }
drivers/gpu/drm/nouveau/nouveau_connector.c +0 -0
index 61e6d7412505..eb844cdcaec2 100644
@@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector,
Quoted 8 lines

drivers/gpu/drm/nouveau/nouveau_connector.c nouveau_conn_atomic_set_property(struct drm_connector *connector, · line 163

Quoted 8 lines
drivers/gpu/drm/nouveau/nouveau_connector.c +1 -0
                     default:
                             break;
                     }
+                    break;
             case DRM_MODE_SCALE_FULLSCREEN:
             case DRM_MODE_SCALE_CENTER:
             case DRM_MODE_SCALE_ASPECT:

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau