hwmon: (max6621) Fix fall-through warnings for Clang
PATCH RESEND 1/1 hwmon: (max6621) Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
--- drivers/hwmon/max6621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/max6621.c +1 -1
@@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,default :break ; } - +break ;default :break ; }
Signature · 1 line
2.27.0
Guenter Roeck
maintainerQuoted 8 lines · Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
Acked-by Guenter Roeck <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>---
I Acked those, thus assuming that they would be applied through some other tree. If that is not the case, you'll need to let me know. The resend only means to me that whatever tree was supposed to pick it up did not do it, but it doesn't result in any action from my side.
Guenter
Quoted 19 lines
drivers/hwmon/max6621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/max6621.c +1
-1@@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,default :break ; } - +break ;default :break ; }Signature · 1 line
2.27.0
Hi Guenter,
Quoted 10 lines · Guenter Roeck
Quoted 8 lines · Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
Acked-by Guenter Roeck <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>---
Quoted 4 lines
I Acked those, thus assuming that they would be applied through some other tree. If that is not the case, you'll need to let me know. The resend only means to me that whatever tree was supposed to pick it up did not do it, but it doesn't result in any action from my side.
This was not directed at you, in particular. I'm resending this for the cosideration of whomever is in charge of this code. If this is not taken or ignored once again, I will consider adding this to my own tree.
Thanks
--
Gustavo
Quoted 19 lines
Quoted 19 lines
drivers/hwmon/max6621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/max6621.c +1
-1@@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,default :break ; } - +break ;default :break ; }Signature · 1 line
2.27.0
Hi Guenter,
Quoted 10 lines · Guenter Roeck
Quoted 8 lines · Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
Acked-by Guenter Roeck <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>---
Quoted 4 lines
I Acked those, thus assuming that they would be applied through some other tree. If that is not the case, you'll need to let me know. The resend only means to me that whatever tree was supposed to pick it up did not do it, but it doesn't result in any action from my side.
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
Quoted 22 lines
Guenter
Quoted 19 lines
drivers/hwmon/max6621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/max6621.c +1
-1@@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,default :break ; } - +break ;default :break ; }Signature · 1 line
2.27.0
Guenter Roeck
maintainerQuoted 13 lines · Gustavo A. R. Silva
Hi Guenter,
Quoted 10 lines · Guenter Roeck
Quoted 8 lines · Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
Acked-by Guenter Roeck <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>---
Quoted 7 lines
Quoted 4 lines
I Acked those, thus assuming that they would be applied through some other tree. If that is not the case, you'll need to let me know. The resend only means to me that whatever tree was supposed to pick it up did not do it, but it doesn't result in any action from my side.
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Ok with me for all.
Guenter
Quoted 28 lines
Thanks
--
Gustavo[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
Quoted 22 lines
Guenter
Quoted 19 lines
drivers/hwmon/max6621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/max6621.c +1
-1@@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,default :break ; } - +break ;default :break ; }Signature · 1 line
2.27.0