Skip to contentSkip to conversation

mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Mar 5, 2021 – Mar 11, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case.

---
Changes in v3:
Update the changelog text according to the actual code change.

Changes in v2:
Make use of a break statement instead of fallthrough for consistency.

 drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/nand/raw/stm32_fmc2_nand.c +2 -0
index 550bda4d1415..1c277fbb91f2 100644
@@ -531,6 +531,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
 		switch (b % 4) {
 		case 2:
 			bit_position += shifting;
+			break;
 		case 1:
 			break;
 		default:
@@ -546,6 +547,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
 		switch (b % 4) {
 		case 2:
 			byte_addr += shifting;
+			break;
 		case 1:
 			break;
 		default:
Signature · 1 line
2.27.0