Skip to contentSkip to conversation

net: bridge: Fix fall-through warnings for Clang

PATCH RESEND Applied Gustavo A. R. Silva 2 participants 2 messages Mar 10, 2021

Subsystems (3)
Networking Network drivers Ethernet bridge

v1 of 3 Applied 1/1 Latest is v3 →

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH RESEND 1/1 net: bridge: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Acked-by Nikolay Aleksandrov <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>

---
Changes in RESEND:
- None. Resending now that net-next is open.

 net/bridge/br_input.c | 1 +
 1 file changed, 1 insertion(+)
net/bridge/br_input.c +1 -0
index 222285d9dae2..8875e953ac53 100644
@@ -144,6 +144,7 @@ int br_handle_frame_finish(struct net *net, struct sock *sk, struct sk_buff *skb
 		break;
 	case BR_PKT_UNICAST:
 		dst = br_fdb_find_rcu(br, eth_hdr(skb)->h_dest, vid);
+		break;
 	default:
 		break;
 	}
Signature · 1 line
2.27.0
CI Applied
#1 lore raw
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 9 lines · On Tue, 9 Mar 2021 23:41:15 -0600 you wrote:

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.

Link https://github.com/KSPP/linux/issues/115
Acked-by Nikolay Aleksandrov <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>

[...]

Here is the summary with links:
- [RESEND,next] net: bridge: Fix fall-through warnings for Clang

    https://git.kernel.org/netdev/net-next/c/ecd1c6a51fcc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html