5.10.275-rc1 review
Subsystems (7)
Greg Kroah-Hartman
maintainerPATCH 531/1848 RDS/IB: validate receive fragment completions
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Shubham Antil <[email protected]>
[ Upstream commit 65cf6863606b0507a7c3bd1711317e4f5d6b8b7e ]
rds_ib_process_recv() accounts every receive fragment as contributing min(i_recv_data_rem, RDS_FRAG_SIZE) bytes, regardless of the completion length. When a completion is shorter than the header-declared amount, receive accounting can advance beyond the payload supplied by the completion.
Only an IB_WC_RECV completion has the buffer layout expected by this receive path. Other successful completion opcodes must not be interpreted as ordinary receive completions.
Reject successful completions with any other opcode before processing their length. For ordinary receive completions, require enough payload to cover the amount accounted to the fragment before linking its page into the incoming message.
This is compatible with the current transmit paths. MSG_ZEROCOPY is restricted to RDS/TCP, while RDS/IB copied and page-vector messages use full-sized non-final scatterlist entries.
Found during an LLM-assisted source audit and validated under KMSAN with a malformed short receive completion.
--- net/rds/ib_recv.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
net/rds/ib_recv.c +12 -1
@@ -948,6 +948,12 @@ static void rds_ib_process_recv(struct rds_connection *conn, } } +if (data_len <min_t (u32, ic->i_recv_data_rem,RDS_FRAG_SIZE )) { +rds_ib_conn_error (conn, +"fragment shorter than header-declared length; forcing reconnect\n" ); + goto done; + } +list_add_tail (&recv->r_frag->f_item, &ibinc->ii_frags); recv->r_frag =NULL ;
@@ -1003,7 +1009,12 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,* event is processed. */ if (wc->status ==IB_WC_SUCCESS ) { -rds_ib_process_recv (conn, recv, wc->byte_len, state); +if (wc->opcode !=IB_WC_RECV ) +rds_ib_conn_error (conn, +"recv completion had unexpected opcode %u, disconnecting and reconnecting\n" , + wc->opcode); +else +rds_ib_process_recv (conn, recv, wc->byte_len, state); }else {/* We expect errors as the qp is drained during shutdown */ if (rds_conn_up (conn) ||rds_conn_connecting (conn))
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 532/1848 ALSA: seq: oss: Skip events until fully initialized
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Takashi Iwai <[email protected]>
[ Upstream commit 68d4a6ea6cc6091a05836f783bc17d525d266d0b ]
When an OSS sequencer device is opened, it creates a sequencer port, then further initializes the internal states like a timer instance, etc. Since the sequencer port is published, an event can be already delivered, and this may hit unexpected event handling, which can eventually cause a NULL dereference (like the timer start/stop event triggered before the timer initialization).
For avoiding such a race, introduce a simple guard and skips the event processing until the port is fully initialized.
At releasing the device, in turn, clear this guard, so that any input events will be discarded during the teardown.
--- sound/core/seq/oss/seq_oss_device.h | 1 + sound/core/seq/oss/seq_oss_event.c | 3 +++ sound/core/seq/oss/seq_oss_init.c | 2 ++ 3 files changed, 6 insertions(+)
sound/core/seq/oss/seq_oss_device.h +1 -0
@@ -73,6 +73,7 @@ struct seq_oss_devinfo {int cseq;/* sequencer client number */ int port;/* sequencer port number */ int queue;/* sequencer queue number */ +bool initialized;struct snd_seq_addr addr;/* address of this device */
sound/core/seq/oss/seq_oss_event.c +3 -0
@@ -425,6 +425,9 @@ snd_seq_oss_event_input(struct snd_seq_event *ev, int direct, void *private_datastruct seq_oss_devinfo *dp = (struct seq_oss_devinfo *)private_data;union evrec *rec; +if (!dp || !smp_load_acquire (&dp->initialized)) +return 0 ;/* ignored */ +if (ev->type !=SNDRV_SEQ_EVENT_ECHO )return snd_seq_oss_midi_input (ev, direct, private_data);
sound/core/seq/oss/seq_oss_init.c +2 -0
@@ -264,6 +264,7 @@ snd_seq_oss_open(struct file *file, int level) client_table[dp->index] = dp; num_clients++; +smp_store_release (&dp->initialized, true);return 0 ;
@@ -408,6 +409,7 @@ snd_seq_oss_release(struct seq_oss_devinfo *dp) client_table[dp->index] =NULL ; num_clients--; +smp_store_release (&dp->initialized, false);snd_seq_oss_reset (dp);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 533/1848 alpha: run check_mmu_context() from finish_arch_post_lock_switch()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Magnus Lindholm <[email protected]>
[ Upstream commit 020d2e70b7538b66eee3c3480d2b8921fb182f0c ]
check_mmu_context() clears asn_lock and acts on need_new_asn, but it runs only as the tail of switch_to(), after alpha_switch_to() returns.
A newly forked user task never gets there: its first context switch resumes at ret_from_fork and reaches schedule_tail() without returning to the code following alpha_switch_to().
asn_lock is left set on that CPU, so the new user task can run with interrupts enabled while shootdown IPIs keep taking the deferred path. The handshake meant to complete those invalidations never runs.
New kernel threads also reach schedule_tail(), but context_switch() does not call switch_mm() for a task without an mm. They therefore do not set asn_lock in the first place and are not affected by this bug.
Move check_mmu_context() to finish_arch_post_lock_switch(), which is called by finish_task_switch() for both existing and newly created tasks. Drop the now redundant call from switch_to().
The hook runs after finish_lock_switch() releases the rq lock and enables interrupts. An IPI arriving before asn_lock is cleared retires the slot through flush_tlb_other(); an IPI arriving afterwards can flush directly, since PAL_swpctx has already installed the incoming context.
Set need_new_asn whether ev5_switch_mm() reuses or allocates an ASN. An IPI in that interval can zero either slot. Without this, the allocated case can return to user space with a live ASN but a zero context slot, which a later context-based shootdown shortcut could mistake for an inactive CPU. check_mmu_context() reloads only when the slot is zero.
Call the hook unconditionally. Alpha selects ARCH_NO_PREEMPT, and neither kthread_use_mm() nor sched_force_init_mm() sleeps between the direct switch and this hook. RCU_STRICT_GRACE_PERIOD can enable PREEMPT_COUNT, but cannot make those callers migrate there. Testing preemptible() would only leave asn_lock set in that configuration.
This requires the preceding direct-switch fix, "alpha: load the MMU context when switch_mm() switches the current task". It installs the borrowed context before kthread_use_mm() reaches this hook, so clearing asn_lock cannot expose a targeted invalidate against the wrong context.
--- arch/alpha/include/asm/mmu_context.h | 15 +++++++++++++-- arch/alpha/include/asm/switch_to.h | 1 - 2 files changed, 13 insertions(+), 3 deletions(-)
arch/alpha/include/asm/mmu_context.h +13 -2
@@ -152,8 +152,8 @@ ev5_switch_mm(struct mm_struct *prev_mm, struct mm_struct *next_mm, next_mm->context[cpu] = mmc; }#ifdef CONFIG_SMP - else - cpu_data[cpu].need_new_asn = 1; +/* A deferred shootdown can also invalidate a newly allocated ASN. */ + cpu_data[cpu].need_new_asn =1 ;#endif /* Always update the PCB ASN. Another thread may have allocated
@@ -201,6 +201,17 @@ do { \#define check_mmu_context () do { } while(0)#endif +/* +* Also called from kthread_use_mm() with preemption enabled. Alpha has +* no kernel preemption, so the task is still on the CPU that ran +* switch_mm(). +*/ +#define finish_arch_post_lock_switch finish_arch_post_lock_switch +static inline void finish_arch_post_lock_switch (void ) +{ +check_mmu_context (); +} + __EXTERN_INLINE voidev5_activate_mm (struct mm_struct *prev_mm,struct mm_struct *next_mm) {
arch/alpha/include/asm/switch_to.h +0 -1
@@ -9,7 +9,6 @@ extern struct task_struct *alpha_switch_to(unsigned long, struct task_struct *);#define switch_to (P ,N ,L ) \ do { \ (L) = alpha_switch_to(virt_to_phys(&task_thread_info(N)->pcb), (P)); \ - check_mmu_context(); \ } while (0)#endif /* __ALPHA_SWITCH_TO_H */
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 534/1848 alpha: only use a targeted tbi() when the target mm is really current
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Magnus Lindholm <[email protected]>
[ Upstream commit 0d92845ac5dbc79e4ac4810b33c673f4c1c227e3 ]
ipi_flush_tlb_page() gates a targeted tbi() on current->active_mm. tbi() acts on the address space context currently loaded on the CPU, so it is only guaranteed to reach an mm's translations when a thread of that mm is running there. current->active_mm is not sufficient: under lazy TLB an idle or kernel task keeps an mm as its active_mm while a different ASN is loaded, so the invalidate is issued against the wrong context and the stale entry can survive. Nothing retires the old ASN afterwards either, mm->context[cpu] still being valid, so the resuming thread can reuse it.
Test current->mm instead and otherwise fall back to flush_tlb_other(), which clears mm->context[cpu] and forces a fresh ASN at the next switch whatever is loaded now.
For an mm borrowed through kthread_use_mm(), patch 1 of this series installs the context before the task can take a shootdown IPI. The current->mm test therefore covers that case as well.
--- arch/alpha/kernel/smp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/alpha/kernel/smp.c +2 -1
@@ -679,7 +679,8 @@ ipi_flush_tlb_page(void *x)struct flush_tlb_page_struct *data = (struct flush_tlb_page_struct *)x;struct mm_struct * mm = data->mm; -if (mm == current->active_mm && !asn_locked ()) +/* A targeted tbi() needs a thread of MM to be current. */ +if (mm == current->mm && !asn_locked ())flush_tlb_current_page (mm, data->vma, data->addr);else flush_tlb_other (mm);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 535/1848 alpha: invalidate the local context in flush_tlb_page()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Magnus Lindholm <[email protected]>
[ Upstream commit c0db730bf05eb3c10c1fae64b19f6913dce129fc ]
When the target mm is not the calling CPU's active_mm, flush_tlb_page() does nothing locally, and smp_call_function() reaches only the other CPUs. This CPU may still hold translations for the mm and can later reuse the old ASN together with them.
Add the missing else branch. flush_tlb_other() clears mm->context[cpu] so a fresh ASN is taken at the next switch. Add this before changing the current->active_mm test to current->mm: that change will also send lazy callers here, so their local invalidate must already be in place.
The uniprocessor implementations of flush_tlb_mm() and flush_icache_user_page() in asm/tlbflush.h and asm/cacheflush.h already contain exactly this branch.
--- arch/alpha/kernel/smp.c | 3 +++ 1 file changed, 3 insertions(+)
arch/alpha/kernel/smp.c +3 -0
@@ -707,6 +707,9 @@ flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)preempt_enable ();return ; } + }else { +/* smp_call_function() does not call back into this CPU. */ +flush_tlb_other (mm); } data.vma = vma;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 536/1848 alpha: fix the local TLB invalidate in flush_tlb_page()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Magnus Lindholm <[email protected]>
[ Upstream commit 32f4dd420d626f96128fcfeea2ab24760b4f21a6 ]
flush_tlb_page() invalidates the calling CPU itself before asking the others, and gates that on current->active_mm. For a non-executable vma that means a targeted tbi(2, addr), which acts on the context currently loaded and is only guaranteed to invalidate the intended translations when the target mm's context is the loaded one. A lazy active_mm does not establish that, so as in ipi_flush_tlb_page() the target mm's stale translations can survive, and nothing forces the old ASN to be retired afterwards.
Test current->mm instead. A lazy caller then takes the flush_tlb_other() branch added by the previous patch, retiring its local context. Adding that branch first preserves the local invalidate at every step, including on EV7 where a targeted tbi() against a foreign ASN appeared to work.
Which callers reach here with a foreign mm depends on the configuration. folio_mkclean(), from the writeback flusher kworker that has no mm of its own, accounted for about half the calls during writeback of a shared mapping and none at all on anonymous memory. Those counts were measured with CONFIG_COMPACTION=n: with COMPACTION=y, asm/pgtable.h overrides ptep_clear_flush() to call migrate_flush_tlb_page(), which rendezvouses with every CPU and handles the context itself, so folio_mkclean() does not reach this function.
--- arch/alpha/kernel/smp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/alpha/kernel/smp.c +2 -1
@@ -694,7 +694,8 @@ flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)preempt_disable (); -if (mm == current->active_mm) { +/* As in ipi_flush_tlb_page(): a targeted tbi() needs MM current. */ +if (mm == current->mm) {flush_tlb_current_page (mm, vma, addr);if (atomic_read (&mm->mm_users) <=1 ) {int cpu, this_cpu =smp_processor_id ();
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 537/1848 alpha: fix the local TLB invalidate in the UP flush_tlb_page()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Magnus Lindholm <[email protected]>
[ Upstream commit c825bf802a7a43fd302c879ef25c975e067a2e94 ]
The uniprocessor flush_tlb_page() in asm/tlbflush.h has the same wrong test as the SMP one: a targeted tbi() is only guaranteed to invalidate the intended translations when the target mm's context is loaded, but the gate is current->active_mm, which a lazily borrowed mm also satisfies.
Test current->mm instead. The else branch it falls to already exists here, so unlike the SMP side this is the whole fix. arch/alpha/kernel/smp.c is not built with CONFIG_SMP=n, so this is how the same defect reaches a uniprocessor, where the flusher kworker necessarily shares the only CPU with the writer.
--- arch/alpha/include/asm/tlbflush.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/alpha/include/asm/tlbflush.h +2 -1
@@ -118,7 +118,8 @@ flush_tlb_page(struct vm_area_struct *vma, unsigned long addr) {struct mm_struct *mm = vma->vm_mm; -if (mm == current->active_mm) +/* A targeted tbi() needs a thread of MM to be current. */ +if (mm == current->mm)flush_tlb_current_page (mm, vma, addr);else flush_tlb_other (mm);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 538/1848 alpha: invalidate the local context in flush_tlb_mm()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Magnus Lindholm <[email protected]>
[ Upstream commit 721bb7a129771f0ff9cef1dd5abfc106ef65feba ]
flush_tlb_mm() has the same caller-CPU omission that was fixed in flush_tlb_page(): when the target mm is not the calling CPU's active_mm nothing happens locally, and smp_call_function() handles only the other CPUs, so this CPU may later reuse the old ASN together with the translations it still holds.
The active_mm test itself is left alone here. That path calls flush_tlb_current(), which loads a fresh context through __load_new_mm_context() rather than issuing a targeted tbi() against whatever ASN happens to be loaded, so it does not depend on which context is current.
The uniprocessor implementation in asm/tlbflush.h already has the missing branch. Counted over a fork-heavy run, flush_tlb_mm() was entered with the mm not this CPU's active_mm 2934 times, and 632 times while otherwise idle.
The proposed Alpha hugetlb support routes hugetlb invalidations through flush_tlb_range(), which calls this function. Unmapping or migrating a hugetlb folio from another context will also need this local invalidate.
--- arch/alpha/kernel/smp.c | 3 +++ 1 file changed, 3 insertions(+)
arch/alpha/kernel/smp.c +3 -0
@@ -659,6 +659,9 @@ flush_tlb_mm(struct mm_struct *mm)preempt_enable ();return ; } + }else { +/* smp_call_function() does not call back into this CPU. */ +flush_tlb_other (mm); }smp_call_function (ipi_flush_tlb_mm, mm,1 );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 539/1848 alpha: invalidate the local context in flush_icache_user_page()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Magnus Lindholm <[email protected]>
[ Upstream commit 4244c555ac440a445cc168f860b2677099d761f9 ]
flush_icache_user_page() has the same caller-CPU omission that the previous patch fixed in flush_tlb_mm(): when the target mm is not the calling CPU's active_mm nothing happens locally, and smp_call_function() handles only the other CPUs, so this CPU may later reuse the old ASN together with the translations it still holds.
This matters here in particular because the function exists for operating on another process's mappings: the comment above it describes setting breakpoints through ptrace, and access_remote_vm() reaches it through copy_to_user_page(). The calling CPU is therefore often running something other than the target mm.
As in flush_tlb_mm(), the uniprocessor implementation in asm/cacheflush.h already has the missing case.
No imb() is needed, here or in ipi_flush_icache_page(). Alpha's user-space I-cache flush works by allocating a new ASN rather than by invalidating the I-cache: the entries stay, but they are tagged with the old ASN and can no longer match. An imb() is only required when the ASN space wraps and numbers are reused, and __get_new_mm_context() already does one in that case.
--- arch/alpha/kernel/smp.c | 3 +++ 1 file changed, 3 insertions(+)
arch/alpha/kernel/smp.c +3 -0
@@ -768,6 +768,9 @@ flush_icache_user_page(struct vm_area_struct *vma, struct page *page,preempt_enable ();return ; } + }else { +/* smp_call_function() does not call back into this CPU. */ +flush_tlb_other (mm); }smp_call_function (ipi_flush_icache_page, mm,1 );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 540/1848 ALSA: hda/via: Apply runtime PM workaround for ASUS X55A
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vasiliy Kovalev <[email protected]>
[ Upstream commit f6e8d5ebde5ceb7d3c0eef6e9e4d82862b503ade ]
ASUS X55A requires the same workaround like other machines with VT1802, otherwise it loses the codec power on a few nodes and the sound stays silent.
--- sound/pci/hda/patch_via.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/patch_via.c +1 -0
@@ -1046,6 +1046,7 @@ static const struct hda_fixup via_fixups[] = {static const struct snd_pci_quirk vt2002p_fixups[] = {SND_PCI_QUIRK (0x1043 ,0x13f7 ,"Asus B23E" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x1487 ,"Asus G75" ,VIA_FIXUP_ASUS_G75 ), +SND_PCI_QUIRK (0x1043 ,0x1c33 ,"Asus X55A" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x8532 ,"Asus X202E" ,VIA_FIXUP_INTMIC_BOOST ),SND_PCI_QUIRK_VENDOR (0x1558 ,"Clevo" ,VIA_FIXUP_POWER_SAVE ), {}
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 541/1848 hwmon: (corsair-cpro) Make wait_input_report_lock IRQ safe
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sanan Hasanov <[email protected]>
[ Upstream commit e4fdc82f55cf0e3d5df5c88278da5baa76a109d1 ]
ccp_raw_event() is the HID ->raw_event() callback and takes wait_input_report_lock with a plain spin_lock(). This callback can run in very different contexts depending on the transport: from process context (e.g. uhid, via a write() to /dev/uhid) with softirqs and interrupts enabled, and from URB completion, which is softirq context for HCDs using HCD_BH and hard interrupt context for HCDs that do not (e.g. OHCI, UHCI).
Taking the lock from process context with softirqs enabled while the same lock is also taken from softirq context can deadlock if the softirq interrupts the lock holder on the same CPU. Lockdep reports:
WARNING: inconsistent lock state inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
...
spin_lock include/linux/spinlock.h:347 [inline] ccp_raw_event+0x51/0x110 drivers/hwmon/corsair-cpro.c:161 __hid_input_report+0x41c/0x580 drivers/hid/hid-core.c:2175 hid_irq_in+0x492/0x710 drivers/hid/usbhid/hid-core.c:287 __usb_hcd_giveback_urb+0x378/0x540 drivers/usb/core/hcd.c:1657 dummy_timer+0xa91/0x4cc0 drivers/usb/gadget/udc/dummy_hcd.c:2023
For the same reason, the spin_lock_bh() in send_usb_cmd() is not sufficient when ccp_raw_event() is called from hard interrupt context.
Use spin_lock_irqsave() in ccp_raw_event(), since it may be called with interrupts already disabled, and spin_lock_irq() in send_usb_cmd(), which always runs in process context.
--- drivers/hwmon/corsair-cpro.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/hwmon/corsair-cpro.c +5 -4
@@ -128,9 +128,9 @@ static int send_usb_cmd(struct ccp_device *ccp, u8 command, u8 byte1, u8 byte2,* the raw event parsing and marked the ccp->wait_input_report * completion as done. */ -spin_lock_bh (&ccp->wait_input_report_lock); +spin_lock_irq (&ccp->wait_input_report_lock);reinit_completion (&ccp->wait_input_report); -spin_unlock_bh (&ccp->wait_input_report_lock); +spin_unlock_irq (&ccp->wait_input_report_lock); ret =hid_hw_output_report (ccp->hdev, ccp->cmd_buffer,OUT_BUFFER_SIZE );if (ret <0 )
@@ -149,15 +149,16 @@ static int send_usb_cmd(struct ccp_device *ccp, u8 command, u8 byte1, u8 byte2,static int ccp_raw_event (struct hid_device *hdev,struct hid_report *report,u8 *data,int size) {struct ccp_device *ccp =hid_get_drvdata (hdev); +unsigned long flags;/* only copy buffer when requested */ -spin_lock (&ccp->wait_input_report_lock); +spin_lock_irqsave (&ccp->wait_input_report_lock, flags);if (!completion_done (&ccp->wait_input_report)) {memcpy (ccp->buffer, data,min (IN_BUFFER_SIZE , size)); ccp->buffer_recv_size = size;complete_all (&ccp->wait_input_report); } -spin_unlock (&ccp->wait_input_report_lock); +spin_unlock_irqrestore (&ccp->wait_input_report_lock, flags);return 0 ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 542/1848 f2fs: flush SIT journal during filesystem resize
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wenjie Qi <[email protected]>
[ Upstream commit a6ede405455106bf42164ec96fd84008c5aabdd9 ]
During a filesystem resize, SBI_IS_RESIZEFS prevents new SIT entries from being added to the journal and forces existing entries to the SIT area. However, f2fs_flush_sit_entries() returns early when there are no new dirty sentries, leaving existing journal entries behind.
After the main area shrinks, a later checkpoint can access a journal entry whose segment number is outside the new geometry and trigger f2fs_bug_on().
Only take the zero-dirty fast path when entries may be written back to the journal. This lets resize drain existing entries through remove_sits_in_journal() even when there are no new dirty sentries.
--- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/segment.c +1 -1
@@ -4139,7 +4139,7 @@ void f2fs_flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)down_write (&sit_i->sentry_lock); -if (!sit_i->dirty_sentries) +if (!sit_i->dirty_sentries && to_journal) goto out;/*
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 543/1848 rtc: cmos: Disable ACPI RTC event before handling it
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Gregory Price <[email protected]>
[ Upstream commit 3f67038df8b5cba07254d1cff60d73e988b49ab7 ]
Users of RTC_UIE_ON can stop receiving update interrupts when rtc-cmos handles alarms through ACPI. In one 50-run test, 40 runs passed and 10 timed out after receiving between one and four of five expected events.
The ACPI ff_rt_clk counter stopped at 218, exactly matching the number of events delivered to userspace, and reported:
218 STS disabled unmasked
rtc_handler() runs in the threaded ACPI SCI handler and calls cmos_interrupt(), which schedules rtc->irqwork. The work can run before rtc_handler() returns:
ACPI SCI thread rtc->irqwork
cmos_interrupt()
schedule_work()
__rtc_set_alarm()
rtc_wake_on()
acpi_clear_event()
acpi_disable_event()The SCI thread then disables the event that the worker enabled for the next alarm. That alarm sets its status while delivery remains disabled, so no update interrupt reaches userspace.
Clear and disable the current ACPI RTC event before cmos_interrupt() schedules the work. The worker can then enable the next event without the handler undoing it. With this ordering, 150 runs delivered all 750 events without a stall.
--- drivers/rtc/rtc-cmos.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/rtc/rtc-cmos.c +3 -3
@@ -764,7 +764,9 @@ static u32 rtc_handler(void *context)unsigned char rtc_intr;unsigned long flags; - +/* Quiesce this event before rtc->irqwork can arm the next one. */ +acpi_clear_event (ACPI_EVENT_RTC ); +acpi_disable_event (ACPI_EVENT_RTC ,0 );/* * Always update rtc irq when ACPI is used as RTC Alarm. * Or else, ACPI SCI is enabled during suspend/resume only,
@@ -787,8 +789,6 @@ static u32 rtc_handler(void *context) }pm_wakeup_hard_event (dev); -acpi_clear_event (ACPI_EVENT_RTC ); -acpi_disable_event (ACPI_EVENT_RTC ,0 );return ACPI_INTERRUPT_HANDLED ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 544/1848 hwmon: (sht3x) Return the consumed count for heater writes
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Baek Kyu, Kim <[email protected]>
[ Upstream commit 817ac527100c8e20684211eb919ffd6d875adc7a ]
heater_enable_store() returns the result of i2c_master_send(), which is the two-byte command length on success rather than the sysfs input count. This can report more bytes than were supplied, or a partial write for a fully processed input. For example, writing "on\n" returns two instead of three, so a caller retrying the remaining newline gets -EINVAL even though the heater command succeeded. Retrying the remainder of "off\n" can also send the heater-off command twice.
Return count after a complete command transfer. Preserve negative I2C errors and return -EIO for nonnegative incomplete transfers, so a zero-message transfer is not reported as a successful zero-byte write. Keep the existing boolean parsing, command selection and locking.
--- drivers/hwmon/sht3x.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/hwmon/sht3x.c +4 -1
@@ -541,7 +541,10 @@ static ssize_t heater_enable_store(struct device *dev,mutex_unlock (&data->i2c_lock); -return ret; +if (ret !=SHT3X_CMD_LENGTH ) +return ret <0 ? ret : -EIO ; + +return count; } static ssize_t update_interval_show(struct device *dev,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 545/1848 netdevsim: reject cls_bpf programs bound to another device
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jamal Hadi Salim <[email protected]>
[ Upstream commit 5820ca58b409402505b9e904d1ded4908e0b6b81 ]
The issue:nsim_bpf_setup_tc_block_cb() installs any device-bound SCHED_CLS program without checking that its offload device matches the target netdev. The core cls_bpf attach path rejects a mismatching program, but a netdev that joins a shared block later is replayed the stored filter by cls_bpf_reoffload() before it is inserted into block->ports, so the attach-time check cannot see it. The driver callback is the authoritative per-device acceptance boundary and must enforce the match itself, as nfp already does in nfp_net_bpf_offload().
Without the check, replaying a device-bound program onto a different bpf_offload_dev installs it into that device's netdevsim state, which trips the WARN in nsim_bpf_uninit() (ns->bpf_offloaded set on a foreign device) and can dereference a NULL prog->aux->offload in nsim_prog_set_loaded().
The Fix:
Reject a device-bound program whose offload device does not match the target netdev, with -EINVAL and an extack so the rejected replay is not silent. The check is intentionally narrower than nfp's: it fires only for a dev-bound program, so nsim's bpf_tc_non_bound_accept mode (which admits an unbound program onto the device) is unaffected. Teardown is never blocked: the guard is on the program being installed and an unbind passes cls_bpf.prog = NULL.
Conditions to recreate the bug:
- CONFIG_NETDEVSIM=y, CONFIG_NET_CLS_BPF=y
- load and pin a dev-bound SCHED_CLS program for netdevsim device B
- install the program on a shared block owned by B
- add an independently backed netdevsim device C to that block; the bind replays the filter to C's callback, and C's ports/0/bpf_offloaded_id takes the B-bound program id.
The reported Sashiko review is at
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/[email protected]
--- drivers/net/netdevsim/bpf.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/netdevsim/bpf.c +11 -0
@@ -150,6 +150,17 @@ int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type,return -EOPNOTSUPP ; } +/* A dev-bound program can be replayed here when a netdev joins +* a shared block, after the core attach-time check has run; +* enforce the device match as nfp does. +*/ +if (prog &&bpf_prog_is_dev_bound (prog->aux) && + !bpf_offload_dev_match (prog, ns->netdev)) { +NSIM_EA (cls_bpf->common.extack, +"program bound to a different device" ); +return -EINVAL ; + } +if (cls_bpf->command !=TC_CLSBPF_OFFLOAD )return -EOPNOTSUPP ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 546/1848 ALSA: compress: add missing OPEN-state gate to SET_METADATA
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit 931f5714b7921290cd1a4742e185aeeae7270ee6 ]
snd_compr_set_metadata() calls stream->ops->set_metadata() straight after copy_from_user(), without ever checking runtime->state, even though the function's own comment says a parameter change should only be allowed once the stream has left the OPEN state. Every other metadata/param entry point in this file (SET_PARAMS, WRITE, ...) enforces that gate.
A codec driver's set_metadata callback can assume SET_PARAMS has already run and initialised its private state; calling it while the stream is still OPEN can operate on that uninitialised state.
Add the OPEN-state check the existing comment already documents.
--- sound/core/compress_offload.c | 3 +++ 1 file changed, 3 insertions(+)
sound/core/compress_offload.c +3 -0
@@ -674,6 +674,9 @@ snd_compr_set_metadata(struct snd_compr_stream *stream, unsigned long arg)* we should allow parameter change only when stream has been * opened not in other cases */ +if (stream->runtime->state ==SNDRV_PCM_STATE_OPEN ) +return -EBADFD ; +if (copy_from_user (&metadata, (void __user *)arg,sizeof (metadata)))return -EFAULT ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 547/1848 blk-mq: clear stale inactive flag on hctx reuse
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nirmoy Das <[email protected]>
[ Upstream commit afc1de47a7ab607ae6403c4bfda36b0bf3cd342f ]
When the last CPU mapped to an hctx goes offline, blk_mq_hctx_notify_offline() sets BLK_MQ_S_INACTIVE. Updating the number of hardware queues exits every hctx and parks it on q->unused_hctx_list. A later update can reuse a parked hctx through blk_mq_alloc_and_init_hctx(), at any queue index, and nothing clears the flag.
If the reused hctx is mapped to an online CPU, blk_mq_get_tag() keeps returning BLK_MQ_NO_TAG for it. __blk_mq_alloc_requests() sleeps and retries, expecting CPU hotplug to move the task to another CPU, so a task that stays on that CPU never gets a tag. Onlining the original CPU doesn't recover it either, because blk_mq_hctx_notify_online() only clears the flag on the hctx that CPU now maps to.
Clear BLK_MQ_S_INACTIVE in blk_mq_init_hctx() so a reused hctx starts like a freshly allocated one. A reused hctx has no cpuhp instances at that point, so the offline callback can't set the flag again before blk_mq_add_hw_queues_cpuhp() registers it. Clearing the flag in blk_mq_exit_hctx() is not enough, because a parked hctx keeps its cpuhp instances until blk_mq_remove_hw_queues_cpuhp(). Preserve the other hctx state flags.
Reproduced with null_blk on v7.3 in a four-vCPU arm64 QEMU/KVM guest:
modprobe null_blk nr_devices=0
mkdir /sys/kernel/config/nullb/nullb0
cd /sys/kernel/config/nullb/nullb0
echo 4 > submit_queues; echo 1 > memory_backed; echo 16 > size echo 1 > power
echo 0 > /sys/devices/system/cpu/cpu3/online
echo 2 > submit_queues
echo 4 > submit_queues
Offlining CPU3 marks hctx3 inactive. After the two updates it comes back as hctx1 and is mapped to CPU0:
# cat /sys/block/nullb0/mq/1/cpu_list 0 # cat /sys/kernel/debug/block/nullb0/hctx1/state INACTIVE
A 4K O_DIRECT read pinned to CPU0 hangs in D state, while the same read on CPU1 and CPU2 completes. Onlining CPU3 again leaves hctx1 inactive and the CPU0 read still hangs. With this change hctx1 state is empty and the reads on CPU0, CPU1 and CPU2 complete, before and after onlining CPU3.
--- block/blk-mq.c | 1 + 1 file changed, 1 insertion(+)
block/blk-mq.c +1 -0
@@ -2734,6 +2734,7 @@ static int blk_mq_init_hctx(struct request_queue *q, struct blk_mq_hw_ctx *hctx, unsigned hctx_idx) { hctx->queue_num = hctx_idx; +clear_bit (BLK_MQ_S_INACTIVE , &hctx->state);if (!(hctx->flags &BLK_MQ_F_STACKING )) cpuhp_state_add_instance_nocalls(CPUHP_AP_BLK_MQ_ONLINE,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 548/1848 drm/amdgpu: reset CIK ASIC on Apple boards with VRAM at 0
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Maciej Kucharek <[email protected]>
[ Upstream commit 095f634ea0aa5b9da19495520b5fc1a155b2c137 ]
On MacBookPros with switchable graphics, the firmware puts VRAM at MC address 0 when the iGPU is enabled. A later post (S3 resume, GPU reset) moves VRAM back to the VBIOS default. The SI fix resets and posts the ASIC at load, so the driver uses the VBIOS layout from the start:
"drm/amdgpu: reset SI ASIC on MacBookPros with VRAM at 0"
No MacBookPro has a CIK GPU, and no affected CIK board is known. Add the same test to cik_need_reset_on_init(), so that SI, CIK and VI handle this firmware layout in the same way. gmc_v7_0 reads MC_VM_FB_LOCATION once at init and does not reprogram it. A CIK board with VRAM at 0 therefore has the same problem as the SI boards.
After the reset, FB_BASE is not 0, so the new test does not fire again on a module reload.
Only compile-tested.
--- drivers/gpu/drm/amd/amdgpu/cik.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/amd/amdgpu/cik.c +10 -0
@@ -1882,6 +1882,16 @@ static bool cik_need_reset_on_init(struct amdgpu_device *adev) {u32 clock_cntl, pc; +/* +* MacBookPros with switchable graphics put VRAM at 0 when the iGPU +* is enabled. Any later post (S3 resume, GPU reset) moves it back to +* the vbios default, so reset and post on load to start with the +* vbios layout. +*/ +if (adev->pdev->subsystem_vendor ==PCI_VENDOR_ID_APPLE && + !(RREG32 (mmMC_VM_FB_LOCATION) &MC_VM_FB_LOCATION__FB_BASE_MASK )) +return true; +if (adev->flags &AMD_IS_APU )return false;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 549/1848 drm/amdgpu: reset VI ASIC on Apple boards with VRAM at 0
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Maciej Kucharek <[email protected]>
[ Upstream commit 92a5184787b81e67f7b831ad860ca9b053505cf8 ]
On MacBookPros with switchable graphics, the firmware puts VRAM at MC address 0 when the iGPU is enabled. A later post (S3 resume, GPU reset) moves VRAM back to the VBIOS default. gmc_v8_0 reads MC_VM_FB_LOCATION once at init and reprograms it only on SR-IOV. On bare metal, the driver then keeps using the old layout.
vi_reset_quirks[] handles this for the MacBookPro14,3 by PCI ID:
commit b6b1d9721851 ("drm/amdgpu: reset VI ASIC on MacBookPro14,3")
Add the test that SI and CIK use: an Apple subsystem vendor and VRAM at
0. Other Polaris MacBookPros then get the same reset at load, for example the MacBookPro13,3 if its firmware leaves VRAM at 0. These boards are not tested.
Keep vi_reset_quirks[]. Its MacBookPro15,1 entries fix a different failure, a module reload after S3:
commit a5be7ad8f5f0 ("drm/amdgpu: reset VI ASIC on MacBookPro15,1")
VRAM is not at 0 at that point, so the new test may not cover it.
After the reset, FB_BASE is not 0, so the new test does not fire again on a module reload.
Only compile-tested.
--- drivers/gpu/drm/amd/amdgpu/vi.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/amd/amdgpu/vi.c +10 -0
@@ -1076,6 +1076,16 @@ static bool vi_need_reset_on_init(struct amdgpu_device *adev)unsigned int i;u32 clock_cntl, pc; +/* +* MacBookPros with switchable graphics put VRAM at 0 when the iGPU +* is enabled. Any later post (S3 resume, GPU reset) moves it back to +* the vbios default, so reset and post on load to start with the +* vbios layout. +*/ +if (adev->pdev->subsystem_vendor ==PCI_VENDOR_ID_APPLE && + !(RREG32 (mmMC_VM_FB_LOCATION) &MC_VM_FB_LOCATION__FB_BASE_MASK )) +return true; +for (i =0 ; i <ARRAY_SIZE (vi_reset_quirks); i++) if (adev->pdev->device == vi_reset_quirks[i].device && adev->pdev->subsystem_vendor == vi_reset_quirks[i].subsystem_vendor &&
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 550/1848 drm/amdgpu: reject ANONONLY userptrs that span multiple VMAs
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jesse Zhang <[email protected]>
[ Upstream commit d577b68a854d0f590f480777249b041507d0708c ]
For AMDGPU_GEM_USERPTR_ANONONLY, amdgpu_ttm_tt_get_user_pages() only checks the VMA at the start of the range for a backing file, and amdgpu_hmm_range_get_pages() then faults in the whole range, across any other VMAs. The check used to reject ranges ending beyond the first VMA (vma->vm_end < end), which got lost when the code moved to HMM.
An ANONONLY userptr over one page of file-backed memory is rejected with -EPERM, but one over an anonymous page followed by the same file-backed page is accepted.
Restore the check and reject ANONONLY userptrs that cross more than one VMA. The second userptr is now rejected too.
v2: reject ranges spanning multiple VMAs instead of walking every VMA
(Christian)
v3: cast num_pages to u64 to avoid an overflow (Christian)
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 -1
@@ -885,7 +885,8 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages) goto out_unlock; }if (unlikely ((gtt->userflags &AMDGPU_GEM_USERPTR_ANONONLY ) && - vma->vm_file)) { + (vma->vm_file || + vma->vm_end < start + (u64 )ttm->num_pages *PAGE_SIZE ))) { r = -EPERM ; goto out_unlock; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 551/1848 ipv6: initialize temporary ifaddr before publication
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daehyeon Ko <[email protected]>
[ Upstream commit ed7f278812e540db507f683e5bf9b6d0a1f5bc1e ]
ipv6_create_tempaddr() holds a reference to the public ifaddr, publishes the new temporary address through ipv6_add_addr(), and only then stores the reference and final timestamps.
addrconf_ifdown() can remove the temporary address before ifpub is stored, leaking the public ifaddr reference. Publishing ifpub alone is
insufficient: manage_tempaddrs() can then find the object before cstamp and tstamp are final, update its lifetimes, and have the constructor overwrite its timestamp with an older value.
This follow-on was found by source review and was not separately triggered at runtime.
Pass the public ifaddr and both timestamps in ifa6_config. Initialize all three fields before adding the temporary address to either the hash or per-device lists. On success the existing public-ifaddr reference transfers to the temporary object. On error it remains owned and released by ipv6_create_tempaddr().
--- include/net/addrconf.h | 3 +++ net/ipv6/addrconf.c | 20 +++++++++++++------- 2 files changed, 16 insertions(+), 7 deletions(-)
include/net/addrconf.h +3 -0
@@ -73,6 +73,9 @@ struct ifa6_config {unsigned int plen;const struct in6_addr *peer_pfx; +struct inet6_ifaddr *ifpub; +unsigned long cstamp; +unsigned long tstamp;u32 rt_priority;u32 ifa_flags;
net/ipv6/addrconf.c +13 -7
@@ -1135,10 +1135,19 @@ ipv6_add_addr(struct inet6_dev *idev, struct ifa6_config *cfg, ifa->flags |=IFA_F_TENTATIVE ; ifa->valid_lft = cfg->valid_lft; ifa->prefered_lft = cfg->preferred_lft; - ifa->cstamp = ifa->tstamp = jiffies; ifa->tokenized = false; ifa->rt = f6i; + ifa->ifpub = cfg->ifpub; +if (cfg->ifpub) { + ifa->cstamp = cfg->cstamp; + ifa->tstamp = cfg->tstamp; + }else { +unsigned long now = jiffies; + + ifa->cstamp = now; + ifa->tstamp = now; + } ifa->idev = idev;in6_dev_hold (idev);
@@ -1424,6 +1433,9 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) cfg.pfx = &addr; cfg.scope =ipv6_addr_scope (cfg.pfx); + cfg.ifpub = ifp; + cfg.cstamp = now; + cfg.tstamp = tmp_tstamp; ift =ipv6_add_addr (idev, &cfg, block,NULL );if (IS_ERR (ift)) {
@@ -1434,12 +1446,6 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) goto retry; } -spin_lock_bh (&ift->lock); - ift->ifpub = ifp; - ift->cstamp = now; - ift->tstamp = tmp_tstamp; -spin_unlock_bh (&ift->lock); -addrconf_dad_start (ift);in6_ifa_put (ift);in6_dev_put (idev);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 552/1848 ipv6: do not restart DAD for a dead ifaddr
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daehyeon Ko <[email protected]>
[ Upstream commit ffb668669ce4144347973d8b2fad449e9be0563d ]
addrconf_dad_failure() can create a stable-privacy replacement without RTNL. After ipv6_add_addr() publishes it, addrconf_ifdown() can mark the new ifaddr DEAD, clear its route, and unlink it before the recovery path takes ifp2->lock.
The recovery path then unconditionally changes the state back to PREDAD and queues delayed DAD work. The MTU teardown path can leave IF_READY set. For an optimistic address, addrconf_dad_begin() can consequently pass the cleared NULL route to ip6_ins_rt().
This follow-on was found by source review and was not separately triggered at runtime.
The new ifaddr is already initialized in PREDAD. Under ifp2->lock, record the retry and queue DAD only if teardown has not changed the state to DEAD. If teardown wins after this check, the work observes DEAD and exits without reviving the address.
This complements the existing lock_errdad check that preserves the original ifaddr's DEAD state after the same function reacquires its lock.
--- net/ipv6/addrconf.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
net/ipv6/addrconf.c +7 -3
@@ -2130,6 +2130,7 @@ void addrconf_dad_failure(struct sk_buff *skb, struct inet6_ifaddr *ifp) ifp->idev->dev->name, &ifp->addr, eth_hdr(skb)->h_source);if (ifp->flags &IFA_F_STABLE_PRIVACY ) { +bool start_dad = false;struct in6_addr new_addr;struct inet6_ifaddr *ifp2;int retries = ifp->stable_privacy_retry +1 ;
@@ -2168,11 +2169,14 @@ void addrconf_dad_failure(struct sk_buff *skb, struct inet6_ifaddr *ifp) goto lock_errdad;spin_lock_bh (&ifp2->lock); - ifp2->stable_privacy_retry = retries; - ifp2->state =INET6_IFADDR_STATE_PREDAD ; +if (ifp2->state !=INET6_IFADDR_STATE_DEAD ) { + ifp2->stable_privacy_retry = retries; + start_dad = true; + }spin_unlock_bh (&ifp2->lock); -addrconf_mod_dad_work (ifp2, net->ipv6.sysctl.idgen_delay); +if (start_dad) +addrconf_mod_dad_work (ifp2, net->ipv6.sysctl.idgen_delay);in6_ifa_put (ifp2); lock_errdad:spin_lock_bh (&ifp->lock);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 553/1848 net/rds: ib: dont enable IRQs in rds_ib_conn_free()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nguyen Ngoc Thang <[email protected]>
[ Upstream commit f6fa1d60ec3ceb7e6c26aa91eadfef34f94014e1 ]
__rds_conn_create() calls trans->conn_free() with rds_conn_lock held and IRQs disabled when it loses the race to insert a connection. rds_ib_conn_free() takes the device list lock with spin_lock_irq() and releases it with spin_unlock_irq(), so IRQs are turned on while rds_conn_lock is still held:
raw_local_irq_restore() called with IRQs enabled
WARNING: kernel/locking/irqflag-debug.c:10 at warn_bogus_irq_restore+0xc/0x20 _raw_spin_unlock_irqrestore+0x67/0x80 __rds_conn_create+0x1de5/0x2290 rds_conn_create_outgoing+0x43/0x60 rds_sendmsg+0xfca/0x20e0 __sys_sendto+0x408/0x5a0
It needs an RDS socket bound to an address on an RDMA device (e.g. rxe) and two concurrent sendto() calls to the same new destination.
The TCP and loopback ->conn_free() callbacks already use irqsave, so do the same here.
--- net/rds/ib_cm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
net/rds/ib_cm.c +4 -2
@@ -1304,6 +1304,7 @@ void rds_ib_conn_free(void *arg) {struct rds_ib_connection *ic = arg;spinlock_t *lock_ptr; +unsigned long flags;rdsdebug ("ic %p\n" , ic);
@@ -1314,9 +1315,10 @@ void rds_ib_conn_free(void *arg)*/ lock_ptr = ic->rds_ibdev ? &ic->rds_ibdev->spinlock : &ib_nodev_conns_lock; -spin_lock_irq (lock_ptr); +/* May be called with IRQs already disabled (see __rds_conn_create()) */ +spin_lock_irqsave (lock_ptr, flags);list_del (&ic->ib_node); -spin_unlock_irq (lock_ptr); +spin_unlock_irqrestore (lock_ptr, flags);rds_ib_recv_free_caches (ic);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 554/1848 net: unix: reject negative max_dgram_qlen values
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yingjie Wang <[email protected]>
[ Upstream commit 1a4e7bc6e3457ad95515a9d2c042452c3161bb2c ]
net.unix.max_dgram_qlen is parsed as a signed int and copied to the u32 sock::sk_max_ack_backlog when an AF_UNIX socket is created. Consequently, a negative value such as -1 is accepted and converted to UINT_MAX. Since the receive queue length is also u32, its fullness check cannot become true for that limit.
max_dgram_qlen has no documented negative sentinel. Its existing signed interface represents nonnegative values only through INT_MAX; negative bit patterns are not a supported encoding for the upper half of the u32 consumer range.
Switch to proc_dointvec_minmax and make the established 0..INT_MAX input range explicit. This rejects negative values without adding new accepted values or changing the default and zero-value behavior. Very large valid values can still make the queue limit impractical to reach; this change corrects the input domain rather than imposing a new resource ceiling.
--- Documentation/networking/ip-sysctl.rst | 3 ++- net/unix/sysctl_net_unix.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-)
Documentation/networking/ip-sysctl.rst +2 -1
@@ -2698,5 +2698,6 @@ addr_scope_policy - INTEGER max_dgram_qlen - INTEGER The maximum length of dgram socket receive queue - Default: 10 + Possible values: 0 - INT_MAX + Default: 10
net/unix/sysctl_net_unix.c +3 -1
@@ -17,7 +17,9 @@ static struct ctl_table unix_table[] = { .data = &init_net.unx.sysctl_max_dgram_qlen, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_INT_MAX, }, { } };
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 555/1848 net/smc: queue the copied chunk when smc_tx_sendmsg() faults
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bryam Vargas <[email protected]>
[ Upstream commit c0703534b223a5c6993e0f000fd1c3abe621fb65 ]
When a send wraps the end of the send buffer, smc_tx_sendmsg() copies the data in two chunks. If memcpy_from_msg() faults on the second one, smc_tx_sendmsg() returns send_done, which already counts the first chunk, but leaves tx_curs_prep and sndbuf_space as they were. send() reports bytes the peer never receives, and the next send() overwrites them. Any caller can hit this on its own stream with a buffer whose tail is unreadable.
On a fault in the second chunk, queue the first one. The next pass retries the rest and returns send_done if it faults again, so send() reports only what it queued, as TCP does.
--- net/smc/smc_tx.c | 7 +++++++ 1 file changed, 7 insertions(+)
net/smc/smc_tx.c +7 -0
@@ -193,6 +193,13 @@ int smc_tx_sendmsg(struct smc_sock *smc, struct msghdr *msg, size_t len) rc =memcpy_from_msg (sndbuf_base + chunk_off, msg, chunk_len);if (rc) { +if (chunk) { +/* send_done counts the first chunk: +* queue it and retry the rest +*/ + copylen -= chunk_len; +break ; + }smc_sndbuf_sync_sg_for_device (conn);if (send_done)return send_done;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 556/1848 ocfs2: reserve metadata for a new xattr block and its value tree
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joseph Qi <[email protected]>
[ Upstream commit 8ad5fa0c11246d260d7b12c9672e604b1f431b2e ]
Patch series "ocfs2: fix metadata reservation for xattr value trees".
ocfs2_calc_xattr_set_need() reserves too little metadata for a new xattr value's extent tree on three paths. The reservation cannot be topped up once the transaction has started, so ocfs2_add_clusters_in_btree() gives up with RESTART_META when the value root fills and nothing is left. ocfs2_xattr_extend_allocation() turns that into -ENOSPC, after ocfs2_xa_cleanup_value_truncate() has dropped the entry and leaked the clusters already handed out; before commit 0cdc7dde00ec ("ocfs2: fix missing metadata reservation for large xattrs") it was a BUG_ON() instead. It takes a fragmented cluster allocator to get there, since the first extent always fits in the root.
Patch 1 fixes the create side of meta_guess: commit 3ed2be719eb9 ("ocfs2:
allow for more than one data extent when creating xattr") replaced the block reserved for the new xattr block with the two the value tree needs instead of adding them together.
Patch 2 fixes the arm that moves an xattr back into the inode, which charges credits for a value tree but no metadata for one.
Patch 3 drops a second copy of the same reservation on the path that falls through to meta_guess. That one is cleanup rather than a fix and is not for stable, and it must not be backported without patch 1: the duplicate it removes is what currently covers the shortfall patch 1 fixes.
This patch (of 3):
The create side of meta_guess in ocfs2_calc_xattr_set_need() reserves metadata for the new value's extent tree and nothing for the xattr block that will hold it:
} else {
credits += OCFS2_XATTR_BLOCK_CREATE_CREDITS;
if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) {
struct ocfs2_extent_list *el = &def_xv.xv.xr_list;
meta_add += ocfs2_extend_meta_needed(el);
...Commit 3ed2be719eb9 ("ocfs2: allow for more than one data extent when creating xattr") meant to add that tree on top of the meta_add += 1 the branch already had, but it moved the 1 into the else arm instead, so the external-value case lost it. The 1 is not optional: it is what ocfs2_create_xattr_block() takes from meta_ac through ocfs2_claim_metadata(), and it is spent before the value tree exists.
ocfs2_extend_meta_needed() on the empty def_xv list returns 2, so the branch reserves 2 where 3 are needed. The xattr block consumes one, and when the cluster allocator is fragmented enough that the value needs more than one extent, ocfs2_add_clusters_in_btree() comes back around with a full value root and ocfs2_alloc_context_bits_left() of 1 against a threshold of 2. It answers RESTART_META, which ocfs2_xattr_extend_allocation() turns into a BUG_ON(). Commit 0cdc7dde00ec ("ocfs2: fix missing metadata reservation for large xattrs") downgraded that to -ENOSPC, at the cost of leaking the clusters already handed out: ocfs2_xa_cleanup_value_truncate() takes its !orig_clusters arm, drops the entry and leaves the clusters for fsck.ocfs2 to reclaim.
Reserve for the block and the tree separately.
--- fs/ocfs2/xattr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
fs/ocfs2/xattr.c +7 -1
@@ -3249,7 +3249,13 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, credits +=OCFS2_XATTR_BLOCK_CREATE_CREDITS ;if (xi->xi_value_len >OCFS2_XATTR_INLINE_SIZE ) {struct ocfs2_extent_list *el = &def_xv.xv.xr_list; - meta_add +=ocfs2_extend_meta_needed (el); +/* +* One block for the xattr block we may have to +* allocate, the rest for growing the value tree it +* would hold. If ocfs2_xattr_ibody_set() succeeds +* instead, that first block goes unused. +*/ + meta_add +=1 +ocfs2_extend_meta_needed (el); credits +=ocfs2_calc_extend_credits (inode->i_sb, el); }else {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 557/1848 ocfs2: reserve value tree metadata when moving an xattr into the inode
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joseph Qi <[email protected]>
[ Upstream commit f5aee8ae5f85f8dfa78160e5c4963494319cdd64 ]
ocfs2_calc_xattr_set_need() charges no metadata for the case where an xattr living in an xattr block or bucket moves back into the inode:
if (old_in_xb) {
if (ocfs2_xattr_can_be_in_inode(inode, xi, xis)) {
clusters_add += new_clusters;
credits += ...;
if (!ocfs2_xattr_is_local(xe))
credits += ocfs2_calc_extend_credits(...);
goto out;
}
}The credits for extending a value tree are there but the matching blocks are not, so meta_add stays 0, ocfs2_init_xattr_set_ctxt() skips ocfs2_reserve_new_metadata_blocks() and ctxt->meta_ac is left NULL.
This is the shape commit 0cdc7dde00ec ("ocfs2: fix missing metadata reservation for large xattrs") fixed for the xattr block case, and it is reached the same way: namevalue_size() charges a value larger than OCFS2_XATTR_INLINE_SIZE as only OCFS2_XATTR_ROOT_SIZE, so ocfs2_xattr_can_be_in_inode() accepts a new value that will be stored outside. ocfs2_xa_prepare_entry() installs a value root from def_xv and grows it, and once the cluster allocator is fragmented enough to need a second extent ocfs2_add_clusters_in_btree() finds the root full with no meta_ac at all and answers RESTART_META. ocfs2_xattr_extend_allocation() turns that into -ENOSPC, or into a BUG_ON() without that commit, and ocfs2_xa_cleanup_value_truncate() takes its !orig_clusters arm, dropping the entry and leaking the clusters already handed out until fsck.ocfs2 reclaims them.
Reserve for the value tree here too. The entry moves back into the inode rather than into a new xattr block, so unlike the create side of meta_guess this needs no block of its own.
--- fs/ocfs2/xattr.c | 8 ++++++++ 1 file changed, 8 insertions(+)
fs/ocfs2/xattr.c +8 -0
@@ -3149,6 +3149,14 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, credits +=ocfs2_calc_extend_credits ( inode->i_sb, &def_xv.xv.xr_list); +/* +* A value too big to stay inline is only charged as +* OCFS2_XATTR_ROOT_SIZE above, so it can still need a +* value tree of its own. No xattr block is allocated +* on this path, so the tree is all we reserve for. +*/ +if (xi->xi_value_len >OCFS2_XATTR_INLINE_SIZE ) + meta_add +=ocfs2_extend_meta_needed (&def_xv.xv.xr_list); goto out; } }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 558/1848 sh: maple: Use the matching IRQ cookie when invoking free_irq()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Runyu Xiao <[email protected]>
[ Upstream commit e3ef44e77b40e3cecfb34757ff3c15ecceea0309 ]
The Maple DMA and VBLANK handlers are registered with &maple_unsupported_device as their dev_id. Passing NULL to free_irq() cannot find either action, so the handlers remain registered and the IRQ core warns.
Use the same cookie when freeing both handlers on the error paths.
--- drivers/sh/maple/maple.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/sh/maple/maple.c +2 -2
@@ -871,10 +871,10 @@ static int __init maple_bus_init(void)kmem_cache_destroy (maple_queue_cache); cleanup_bothirqs: -free_irq (HW_EVENT_VSYNC ,0 ); +free_irq (HW_EVENT_VSYNC , &maple_unsupported_device); cleanup_irq: -free_irq (HW_EVENT_MAPLE_DMA ,0 ); +free_irq (HW_EVENT_MAPLE_DMA , &maple_unsupported_device); cleanup_dma:free_pages ((unsigned long ) maple_sendbuf,MAPLE_DMA_PAGES );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 559/1848 tipc: fix broadcast sender hang on last acker departure
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Henry Martin <[email protected]>
[ Upstream commit f4377bf85887f57b59abb5479f7660a81ffe4449 ]
TIPC group broadcast senders are blocked while a replicast still has outstanding member acks: tipc_group_bc_cong() returns true as long as grp->bc_ackers is non-zero, and clears *grp->open, which is what tipc_poll() uses to report EPOLLOUT (via tsk->group_is_open).
When the last outstanding acker departs before acking, tipc_group_delete_member() decrements grp->bc_ackers to zero but never restores *grp->open. As a result poll(EPOLLOUT) never fires again. A writer blocked in sendmsg() is only released if some other wakeup happens after the deletion: with TIPC_GROUP_MEMBER_EVTS the leave event delivery calls sk_data_ready() and wakes it, but without member events nothing does and it sleeps indefinitely, since the default send timeout is MAX_SCHEDULE_TIMEOUT.
Commit 99cc2a62e07a ("tipc: reject invalid and unexpected GRP_ACK_MSG to prevent bc_ackers underflow") already calls this out in its changelog as a pre-existing issue.
Restore the open state exactly on the 1->0 transition in the delete path, mirroring the GRP_ACK_MSG completion path, and invoke sk->sk_write_space() from tipc_sk_filter_rcv() when the group just became writable again.
Also make the ack accounting precise. The delete path used to test less(m->bc_acked, grp->bc_snd_nxt - 1), which also matches members that were never counted for the current replicast (JOINING/LEAVING members keep a stale bc_acked), and the GRP_ACK_MSG handler accepted an ack from any member whose bc_acked differed from the expected value. Either could zero bc_ackers on behalf of a member that owes nothing and silently void an ack still owed by a real acker. Track whether a member owes an ack for the current replicast in a new per-member bc_pending flag, set when the member is counted and cleared when its ack arrives, and use it both to accept an ack and to decide on deletion. bc_acked has no remaining user and is removed. Suggested by Tung Quang Nguyen.
This issue was discovered by Tencent CodeBuddy Security.
--- net/tipc/group.c | 19 ++++++++++--------- net/tipc/socket.c | 12 +++++++++++- 2 files changed, 21 insertions(+), 10 deletions(-)
net/tipc/group.c +10 -9
@@ -73,7 +73,7 @@ struct tipc_member {u16 window;u16 bc_rcv_nxt;u16 bc_syncpt; -u16 bc_acked; +bool bc_pending; };struct tipc_group {
@@ -315,7 +315,6 @@ static struct tipc_member *tipc_group_create_member(struct tipc_group *grp, m->node = node; m->port = port; m->instance = instance; - m->bc_acked = grp->bc_snd_nxt -1 ; ret =tipc_group_add_to_tree (grp, m);if (ret <0 ) {kfree (m);
@@ -339,9 +338,12 @@ static void tipc_group_delete_member(struct tipc_group *grp,rb_erase (&m->tree_node, &grp->members); grp->member_cnt--; -/* Check if we were waiting for replicast ack from this member */ -if (grp->bc_ackers &&less (m->bc_acked, grp->bc_snd_nxt -1 )) - grp->bc_ackers--; +/* If this member owed an ack for the current replicast and it +* was the last one, restore the open state so blocked broadcast +* senders can proceed. +*/ +if (grp->bc_ackers && m->bc_pending && !--grp->bc_ackers) + *grp->open = true;list_del_init (&m->list);list_del_init (&m->small_win);
@@ -393,7 +395,6 @@ void tipc_group_update_member(struct tipc_member *m, int len)void tipc_group_update_bc_members (struct tipc_group *grp,int len,bool ack) { -u16 prev = grp->bc_snd_nxt -1 ;struct tipc_member *m;struct rb_node *n;u16 ackers =0 ;
@@ -402,8 +403,8 @@ void tipc_group_update_bc_members(struct tipc_group *grp, int len, bool ack) m = container_of(n, struct tipc_member, tree_node);if (tipc_group_is_receiver (m)) {tipc_group_update_member (m, len); - m->bc_acked = prev; ackers++; + m->bc_pending = ack; } }
@@ -799,9 +800,9 @@ void tipc_group_proto_rcv(struct tipc_group *grp, bool *usr_wakeup,if (!m || !grp->bc_ackers)return ; acked =msg_grp_bc_acked (hdr); -if (acked != grp->bc_snd_nxt || m->bc_acked == acked) +if (acked != grp->bc_snd_nxt || !m->bc_pending)return ; - m->bc_acked = acked; + m->bc_pending = false;if (--grp->bc_ackers)return ;list_del_init (&m->small_win);
net/tipc/socket.c +11 -1
@@ -2355,8 +2355,18 @@ static void tipc_sk_filter_rcv(struct sock *sk, struct sk_buff *skb,if (unlikely (!msg_isdata (hdr)))tipc_sk_proto_rcv (sk, &inputq, xmitq); -if (unlikely (grp)) +if (unlikely (grp)) { +bool was_open = tsk->group_is_open; +tipc_group_filter_msg (grp, &inputq, xmitq); +/* A departing member may have held the last outstanding +* replicast ack, which can restore the open state inside +* tipc_group_filter_msg(); wake up senders blocked in +* poll()/write() if the group just became writable. +*/ +if (!was_open && tsk->group_is_open) + sk->sk_write_space (sk); + }if (unlikely (!grp) && mtyp ==TIPC_MCAST_MSG )tipc_mcast_filter_msg (net, &tsk->mc_method.deferredq, &inputq);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 560/1848 i2c: designware: queue only one read command for block reads
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Navon John Lukose <[email protected]>
[ Upstream commit 73dae605cad7921800677d982bfaeb81cc930dec ]
i2c_dw_xfer_msg() pre-queues up to rx_fifo_depth read commands based on the initial msg.len. For I2C_M_RECV_LEN transfers the real length is unknown until the first byte arrives and i2c_dw_recv_len() runs. When a large initial length is passed, the surplus pre-queued reads leave rx_outstanding non-zero after i2c_dw_recv_len() adjusts msg.len, so the completion condition is never met and the transfer times out. In a loop, this repeatedly times out the controller and disrupts unrelated driver-bound devices on the same adapter.
Queue only one read command while I2C_M_RECV_LEN is pending. i2c_dw_recv_len() re-enables TX_EMPTY, and the rest are queued once the device-reported length is known.
--- drivers/i2c/busses/i2c-designware-master.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/i2c/busses/i2c-designware-master.c +8 -0
@@ -346,6 +346,14 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev)if (dev->rx_outstanding >= dev->rx_fifo_depth)break ; +/* +* For block reads, queue only the length +* byte until i2c_dw_recv_len() runs. +*/ +if ((flags &I2C_M_RECV_LEN ) && + buf_len < msgs[dev->msg_write_idx].len) +break ; +regmap_write (dev->map,DW_IC_DATA_CMD , cmd |0x100 ); rx_limit--;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 561/1848 tpm: tpm_nsc: fix NULL pointer dereference on init failure
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pei Xiao <[email protected]>
[ Upstream commit 1900449684cf71427a51e0bb1d7914c0c8b39152 ]
tpm_nsc_remove() is used as the release callback of the hand-created platform device and dereferences the chip drvdata unconditionally. If init fails before tpmm_chip_alloc() (e.g. request_region() cannot claim the ports), the error path drops the last device reference and the release callback runs with chip == NULL, crashing module init.
Return early when the chip has not been created yet.
--- drivers/char/tpm/tpm_nsc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/char/tpm/tpm_nsc.c +6 -1
@@ -258,7 +258,12 @@ static struct platform_device *pdev = NULL;static void tpm_nsc_remove (struct device *dev) {struct tpm_chip *chip =dev_get_drvdata (dev); -struct tpm_nsc_priv *priv =dev_get_drvdata (&chip->dev); +struct tpm_nsc_priv *priv; + +if (!chip) +return ; + + priv =dev_get_drvdata (&chip->dev);tpm_chip_unregister (chip);release_region (priv->base,2 );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 562/1848 tpm: tpm_nsc: stop using the cleanup callback as dev.release
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pei Xiao <[email protected]>
[ Upstream commit df0ef271087623439a1e900f323ed2a57204706d ]
tpm_nsc_remove() is called explicitly from cleanup_nsc() and also runs as the platform device release callback on the final platform_device_put(), so the cleanup executes twice on module exit; the second invocation operates on a chip that has already been freed by the devm cleanup, and the I/O region is released twice.
Overwriting the release callback installed by platform_device_alloc() also keeps platform_device_release() from running, leaking the platform object allocation.
Leave the default release callback in place; the explicit call in cleanup_nsc() remains the single cleanup point.
--- drivers/char/tpm/tpm_nsc.c | 1 - 1 file changed, 1 deletion(-)
drivers/char/tpm/tpm_nsc.c +0 -1
@@ -326,7 +326,6 @@ static int __init init_nsc(void) pdev->num_resources =0 ; pdev->dev.driver = &nsc_drv.driver; - pdev->dev.release = tpm_nsc_remove;if ((rc =platform_device_add (pdev)) <0 ) goto err_put_dev;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 563/1848 tpm: fix zero-length read discarding the pending response
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pei Xiao <[email protected]>
[ Upstream commit 6fc1b05077b8ac7c3193616f0bc419f6185988c6 ]
POSIX requires that a read() with a count of zero returns zero and has no other effects. tpm_common_read() treats such a call as a consumed response: it marks the pending response as read and drops it, so the response can never be retrieved; subsequent reads return zero and the next write() is allowed to overwrite the response buffer, silently breaking the command/response pairing of the TPM character devices.
Return early when the caller passes a zero count, leaving any pending response untouched for the next read. A zero-length read will not report a deferred asynchronous error; POSIX permits read() to skip error detection for a zero count.
--- drivers/char/tpm/tpm-dev-common.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/char/tpm/tpm-dev-common.c +3 -0
@@ -132,6 +132,9 @@ ssize_t tpm_common_read(struct file *file, char __user *buf,ssize_t ret_size =0 ;int rc; +if (!size) +return 0 ; +mutex_lock (&priv->buffer_mutex);if (priv->response_length) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 564/1848 parisc: eisa_enumerator: Fix out-of-bounds reads of the EEPROM buffer
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jean Delu <[email protected]>
[ Upstream commit c0a3e153804f0c14f4159ddbd2b73483c9cb3577 ]
eisa_enumerator() trusts the contents of the EISA EEPROM. The number of slots is read from the EEPROM header and used to access the slot records at HPEE_SLOT_INFO(i) = 20 + 48*i within the fixed-size eeprom_buf (HPEE_MAX_LENGTH, 8192 bytes) without any bound check. As struct eeprom_eisa_slot_info is 48 bytes, only 170 records fit into the buffer, but num_slots is a u8 and may be up to 255, so a corrupted EEPROM makes the code read up to about 4 kB past the end of the buffer (e.g. record 254 is accessed at offset 20 + 48*254 = 12212).
parse_slot_config() has the same kind of problem: it clamps config_data_length against HPEE_MAX_LENGTH but does not take config_data_offset into account, so the parser can walk past the end of the buffer even when the offset itself is valid.
Clamp the number of slots so that all slot records fit into the buffer, and hand the number of bytes actually available to parse_slot_config() and bound the parse by it.
--- drivers/parisc/eisa_enumerator.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/parisc/eisa_enumerator.c +12 -3
@@ -311,6 +311,7 @@ static int configure_function(const unsigned char *buf, int *more)static int parse_slot_config (int slot,const unsigned char *buf, +unsigned int buflen,struct eeprom_eisa_slot_info *es,struct resource *io_parent,struct resource *mem_parent)
@@ -333,8 +334,8 @@ static int parse_slot_config(int slot,printk (KERN_INFO "EISA slot %d: %s %s " , slot, board, es->flags&HPEE_FLAG_BOARD_IS_ISA ?"ISA" :"EISA" ); - maxlen = es->config_data_length <HPEE_MAX_LENGTH ? - es->config_data_length :HPEE_MAX_LENGTH ; +/* never parse beyond the data that is actually in the buffer */ + maxlen = min_t(unsigned int, es->config_data_length, buflen);while ((pos < maxlen) && (num_func <= es->num_functions)) { pos+=configure_function (buf+pos, &function_len);
@@ -491,6 +492,13 @@ int eisa_enumerator(unsigned long eeprom_addr,printk (KERN_INFO "Enumerating EISA bus\n" ); eh = (struct eeprom_header *)(eeprom_buf); +/* +* The EEPROM contents are not to be trusted: clamp the number of +* slots so that all slot records fit into eeprom_buf. +*/ + eh->num_slots =min_t (u8, eh->num_slots, + (HPEE_MAX_LENGTH -sizeof (*eh)) / +sizeof (struct eeprom_eisa_slot_info ));for (i=0 ;i<eh->num_slots;i++) {struct eeprom_eisa_slot_info *es;
@@ -503,7 +511,8 @@ int eisa_enumerator(unsigned long eeprom_addr,if (es->config_data_offset <HPEE_MAX_LENGTH ) {if (parse_slot_config (i+1 , &eeprom_buf[es->config_data_offset], - es, io_parent, mem_parent)) { +HPEE_MAX_LENGTH - es->config_data_offset, + es, io_parent, mem_parent)) {return -1 ; } }else {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 565/1848 i2c: mt7621: fix copying uninitialized kernel stack with reduced page_len
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian Marangi <[email protected]>
[ Upstream commit b7fd977fec0d3f2bdd4f13bb59949c817a365652 ]
When a page_len is less than 5 bytes in mtk_i2c_xfer, uninitialized kernel stack data is copied and written to REG_SM0D1_REG. Equally on the read part, an unnecessary read is done.
Guard these extra copy/write and read for the page_len to fix leaking uninitialized stack memory.
--- drivers/i2c/busses/i2c-mt7621.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-mt7621.c +6 -3
@@ -143,7 +143,6 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,u16 addr;int i, j, ret, len, page_len;u32 cmd; -u32 data[2 ]; i2c =i2c_get_adapdata (adap);
@@ -189,6 +188,8 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,/* transfer data */ for (len = pmsg->len, j =0 ; len >0 ; len -=8 , j +=8 ) { +u32 data[2 ] = { }; + page_len = (len >=8 ) ?8 : len;if (pmsg->flags &I2C_M_RD ) {
@@ -197,7 +198,8 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, }else {memcpy (data, &pmsg->buf[j], page_len);iowrite32 (data[0 ], i2c->base +REG_SM0D0_REG ); -iowrite32 (data[1 ], i2c->base +REG_SM0D1_REG ); +if (page_len >4 ) +iowrite32 (data[1 ], i2c->base +REG_SM0D1_REG ); cmd =SM0CTL1_WRITE ; }
@@ -207,7 +209,8 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,if (pmsg->flags &I2C_M_RD ) { data[0 ] =ioread32 (i2c->base +REG_SM0D0_REG ); - data[1 ] =ioread32 (i2c->base +REG_SM0D1_REG ); +if (page_len >4 ) + data[1 ] =ioread32 (i2c->base +REG_SM0D1_REG );memcpy (&pmsg->buf[j], data, page_len); }else {if (!(pmsg->flags &I2C_M_IGNORE_NAK )) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 566/1848 posix-cpu-timers: Fix pid refcount leak in do_cpu_nanosleep() signal path
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Cen Zhang (Microsoft) <[email protected]>
[ Upstream commit 8ccd731b63a0183ca2b0e18f3ca15864b3f37eda ]
do_cpu_nanosleep() sleeps on a temporary k_itimer whose reference on the target's struct pid is taken by posix_cpu_timer_create() and dropped by posix_cpu_timer_del(). When a signal ends the sleep, the timer is disarmed with posix_cpu_timer_set(), but posix_cpu_timer_del() is only called for a result of 0 or TIMER_RETRY. If the target thread or process has exited in the meantime, timer_lock_sighand() finds no task, posix_cpu_timer_set() returns -ESRCH and the pid reference is leaked.
An unprivileged user can trigger this: sleep on the CPU clock of a thread, let that thread exit, then signal the sleeper. Each round leaks one struct pid. Repeating it exhausts unreclaimable slab memory within minutes:
Out of memory: Killed process 150 (poc) total-vm:789292kB, anon-rss:484kB
Kernel panic - not syncing: System is deadlocked on memory
Fix this by also calling posix_cpu_timer_del() on -ESRCH. With the target gone, the deletion is safe. It finds no task either and only drops the pid reference.
--- kernel/time/posix-cpu-timers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/time/posix-cpu-timers.c +2 -2
@@ -1559,8 +1559,8 @@ static int do_cpu_nanosleep(const clockid_t which_clock, int flags,*/ expires =cpu_timer_getexpires (&timer.it.cpu); error =posix_cpu_timer_set (&timer,0 , &zero_it, &it); -if (!error) { -/* Timer is now unarmed, deletion can not fail. */ +if (error !=TIMER_RETRY ) { +/* Unarmed or target gone (-ESRCH), deletion can not fail. */ posix_cpu_timer_del (&timer); }else {while (error ==TIMER_RETRY ) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 567/1848 timekeeping: Update offsets on sequence counter retry in ktime_get_update_offsets_now()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Thomas Weißschuh (Schneider Electric) <[email protected]>
[ Upstream commit 6541fbc942f3b63bb8bd44e34eee6223e0abe719 ]
The sequence counter of the cwsseq target is modified during the sequence counter loop. If the loop retries, cwsseq will now match but the offsets contain the values from the previous loop iteration. These are not guaranteed to be consistent in themselves or with the current loops "now.
Save the target's original sequence counter value so that the update also happens on loop retries.
--- kernel/time/timekeeping.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/time/timekeeping.c +2 -1
@@ -2296,6 +2296,7 @@ ktime_t ktime_get_update_offsets_now(unsigned int *cwsseq, ktime_t *offs_real, ktime_t *offs_boot, ktime_t *offs_tai) {struct timekeeper *tk = &tk_core.timekeeper; +u32 cwsseq_orig = *cwsseq;unsigned int seq;ktime_t base;u64 nsecs;
@@ -2307,7 +2308,7 @@ ktime_t ktime_get_update_offsets_now(unsigned int *cwsseq, ktime_t *offs_real, nsecs =timekeeping_get_ns (&tk->tkr_mono); base =ktime_add_ns (base, nsecs); -if (*cwsseq != tk->clock_was_set_seq) { +if (cwsseq_orig != tk->clock_was_set_seq) { *cwsseq = tk->clock_was_set_seq; *offs_real = tk->offs_real; *offs_boot = tk->offs_boot;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 568/1848 scsi: ufs: core: Clear stale UIC result byte before peer DME retries
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stanley Jhu <[email protected]>
[ Upstream commit e4a9b7640914b248eb7537d4507aa42db080586a ]
Peer DME get and set retry a failed attempt with the same struct uic_command. UIC completion ORs the ConfigResultCode into argument2[7:0], and nothing clears it before the next attempt. Once an attempt fails, every retry keeps reporting that error code, even when the device returns success, so a transient failure becomes a hard failure after three retries. Each such retry also triggers the WARN_ON_ONCE() in ufshcd_dispatch_uic_cmd(). In ufshcd_dme_set_attr(), ufshcd_uic_cmd_compl() also overwrites argument3 with the register readback before the next attempt.
Clear the result byte and restore argument3 in ufshcd_dme_set_attr() when an attempt fails.
--- drivers/scsi/ufs/ufshcd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/scsi/ufs/ufshcd.c +7 -2
@@ -3696,9 +3696,12 @@ int ufshcd_dme_set_attr(struct ufs_hba *hba, u32 attr_sel,do {/* for peer attributes we retry upon failure */ ret =ufshcd_send_uic_cmd (hba, &uic_cmd); -if (ret) +if (ret) {dev_dbg (hba->dev,"%s: attr-id 0x%x val 0x%x error code %d\n" , set,UIC_GET_ATTR_ID (attr_sel), mib_val, ret); + uic_cmd.argument2 &= ~MASK_UIC_COMMAND_RESULT ; + uic_cmd.argument3 = mib_val; + } }while (ret && peer && --retries);if (ret)
@@ -3763,9 +3766,11 @@ int ufshcd_dme_get_attr(struct ufs_hba *hba, u32 attr_sel,do {/* for peer attributes we retry upon failure */ ret =ufshcd_send_uic_cmd (hba, &uic_cmd); -if (ret) +if (ret) {dev_dbg (hba->dev,"%s: attr-id 0x%x error code %d\n" , get,UIC_GET_ATTR_ID (attr_sel), ret); + uic_cmd.argument2 &= ~MASK_UIC_COMMAND_RESULT ; + } }while (ret && peer && --retries);if (ret)
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 569/1848 scsi: libiscsi_tcp: Prevent R2T range check overflow
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ratnaker Gautam <[email protected]>
[ Upstream commit eb7aa7fd673fdc1582223cd133bcc5f54e7af19f ]
An iSCSI target controls the R2T data offset and length as 32-bit values. Adding them before comparing the result with the SCSI data buffer length can wrap. An R2T with offset 1 and length U32_MAX then passes the check for a 4096-byte write.
The transmit path treats the wrapped range as valid, exhausts the command scatterlist, and dereferences the NULL next entry in iscsi_tcp_segment_done().
Check the offset first, then compare the length with the remaining bytes in the data buffer.
--- drivers/scsi/libiscsi_tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/libiscsi_tcp.c +2 -1
@@ -577,7 +577,8 @@ static int iscsi_tcp_r2t_rsp(struct iscsi_conn *conn, struct iscsi_task *task) data_length, session->max_burst); data_offset =be32_to_cpu (rhdr->data_offset); -if (data_offset + data_length > task->sc->sdb.length) { +if (data_offset > task->sc->sdb.length || + data_length > task->sc->sdb.length - data_offset) { iscsi_conn_printk(KERN_ERR, conn, "invalid R2T with data len %u at offset %u " "and total length %d\n", data_length,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 570/1848 compat: avoid double rounding in times()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hungyu Lin <[email protected]>
[ Upstream commit 6b30c39a5e333cfb1475acf0f73de6ef954eea8a ]
do_sys_times() already converts CPU time to USER_HZ ticks. The compat path converts each value back to jiffies before converting it to COMPAT_USER_HZ. This round trip can lose precision even when the two userspace rates match.
With HZ=250 and USER_HZ=COMPAT_USER_HZ=100, one user tick becomes two jiffies and then zero compat ticks. Every odd tick count loses one tick, so any of the four tms fields can underreport CPU time by an additional 10 ms.
Return the value directly when the native and compat units match. Keep the existing conversion for differing rates.
--- kernel/sys.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/sys.c +3 -0
@@ -994,6 +994,9 @@ SYSCALL_DEFINE1(times, struct tms __user *, tbuf)#ifdef CONFIG_COMPAT static compat_clock_t clock_t_to_compat_clock_t (clock_t x) { +if (USER_HZ ==COMPAT_USER_HZ ) +return x; +return compat_jiffies_to_clock_t (clock_t_to_jiffies (x)); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 571/1848 ocfs2: snapshot the dentry name while tracing file release
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Cen Zhang <[email protected]>
[ Upstream commit 5898987d4a92b70ae73fd8355cc3a388b4dfa4e6 ]
ocfs2_file_release() passes the live dentry name and length to a trace event while holding oi->ip_lock. This lock protects the open count and delays RCU reclamation of external names, but it does not serialize name changes during rename. The dentry can switch between inline and external names, and a separately loaded length can describe a different name.
The ocfs2__file_ops event sizes and copies its __string separately. A concurrently rewritten inline name need not remain consistent between those operations. External names can also be selected at this call site; the existing spinlock critical section protects their allocation lifetime, while a snapshot additionally pairs a stable name with its length.
Take a name snapshot before acquiring oi->ip_lock and release it after dropping the lock. Keep the trace call and open-count argument inside the original critical section. Cache the event-enabled check so the snapshot stays paired even if tracing is toggled meanwhile.
--- fs/ocfs2/file.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
fs/ocfs2/file.c +13 -5
@@ -142,18 +142,26 @@ static int ocfs2_file_open(struct inode *inode, struct file *file)static int ocfs2_file_release (struct inode *inode,struct file *file) {struct ocfs2_inode_info *oi =OCFS2_I (inode); +struct dentry *dentry = file->f_path.dentry; +struct name_snapshot name; +bool trace_enabled =trace_ocfs2_file_release_enabled (); + +if (trace_enabled) +take_dentry_name_snapshot (&name, dentry);spin_lock (&oi->ip_lock);if (!--oi->ip_open_count) oi->ip_flags &= ~OCFS2_INODE_OPEN_DIRECT ; -trace_ocfs2_file_release (inode, file, file->f_path.dentry, - oi->ip_blkno, - file->f_path.dentry->d_name.len, - file->f_path.dentry->d_name.name, - oi->ip_open_count); +if (trace_enabled) +trace_ocfs2_file_release (inode, file, dentry, + oi->ip_blkno, name.name.len, + name.name.name, oi->ip_open_count);spin_unlock (&oi->ip_lock); +if (trace_enabled) +release_dentry_name_snapshot (&name); +ocfs2_free_file_private (inode, file);return 0 ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 572/1848 ocfs2/cluster: remove zero-address nodes from IP tree on teardown
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Cen Zhang <[email protected]>
[ Upstream commit 5dd57e77eff4ba3e85b3df126a55417c88245708 ]
o2nm_node_ipv4_address_store() accepts 0.0.0.0. It sets O2NM_NODE_ATTR_ADDRESS and links nd_ip_node into cl_node_ip_tree under cl_nodes_lock, but o2nm_node_group_drop_item() uses nd_ipv4_address as a membership test. A zero address therefore leaves the rbtree node linked when config_item_put() releases and frees struct o2nm_node. A later address store or IP lookup can then walk the stale node and dereference freed memory.
During teardown, drop_item takes cl_nodes_lock, skips rb_erase() for the zero key, and then calls config_item_put(). A later o2nm_node_ipv4_address_store() duplicate check or o2nm_get_node_by_ip() lookup takes the same lock and walks the stale cl_node_ip_tree entry. Use O2NM_NODE_ATTR_ADDRESS for teardown so every published nd_ip_node is erased before configfs can release the node, without rejecting 0.0.0.0 or changing lookup semantics.
--- fs/ocfs2/cluster/nodemanager.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
fs/ocfs2/cluster/nodemanager.c +5 -2
@@ -627,8 +627,11 @@ static void o2nm_node_group_drop_item(struct config_group *group,write_lock (&cluster->cl_nodes_lock); -/* XXX sloppy */ -if (node->nd_ipv4_address) +/* +* 0.0.0.0 is a valid configured address, so nd_ipv4_address does +* not tell us whether nd_ip_node was published in the IP tree. +*/ +if (test_bit (O2NM_NODE_ATTR_ADDRESS , &node->nd_set_attributes))rb_erase (&node->nd_ip_node, &cluster->cl_node_ip_tree);/* nd_num might be 0 if the node number hasn't been set.. */
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 573/1848 fbdev: atmel_lcdfb: fix list_first_entry() on possibly empty modelist in probe
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wang Haoran <[email protected]>
[ Upstream commit 01d1204582f16e8b7bfce29648e5cf77a585d962 ]
list_first_entry() does not return NULL on an empty list; it returns a bogus pointer computed by container_of() from the list head. atmel_lcdfb_probe() initializes info->modelist with INIT_LIST_HEAD() and later takes its first entry with list_first_entry(), assuming atmel_lcdfb_of_init() populated it. However, atmel_lcdfb_of_init() drops the return value of fb_add_videomode() — unlike every other fallible call in the same function — so if fb_add_videomode() fails (its internal kmalloc can return -ENOMEM under memory pressure or fault injection), the list stays empty while of_init() reports success. The probe path then dereferences the bogus pointer in fb_videomode_to_var(&info->var, &modelist->mode). Because the bogus pointer lands inside the contiguous fb_info allocation, this may not fault immediately; instead it silently reads adjacent memory as a struct fb_videomode and programs garbage timing parameters into the LCD controller. This was found by code audit; we do not have Atmel hardware to reproduce it.
Fix this on two levels: check the return value of fb_add_videomode() in atmel_lcdfb_of_init() so the failure is propagated (root cause), and use list_first_entry_or_null() in atmel_lcdfb_probe() with a NULL check that fails probe gracefully with -EINVAL (defense in depth), consistent with the surrounding error handling which bails out to stop_clk.
--- drivers/video/fbdev/atmel_lcdfb.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/video/fbdev/atmel_lcdfb.c +10 -3
@@ -1032,7 +1032,9 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)if (ret <0 ) goto put_display_node; -fb_add_videomode (&fb_vm, &info->modelist); + ret =fb_add_videomode (&fb_vm, &info->modelist); +if (ret <0 ) + goto put_display_node; put_display_node:of_node_put (display_np);
@@ -1100,8 +1102,13 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) }atmel_lcdfb_start_clock (sinfo); - modelist =list_first_entry (&info->modelist, - struct fb_modelist, list); + modelist =list_first_entry_or_null (&info->modelist, + struct fb_modelist, list); +if (!modelist) { +dev_err (dev,"no video mode available\n" ); + ret = -EINVAL ; + goto stop_clk; + }fb_videomode_to_var (&info->var, &modelist->mode);atmel_lcdfb_check_var (&info->var, info);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 574/1848 timers/itimer: Keep a nonzero value at CPU timer expiry
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hungyu Lin <[email protected]>
[ Upstream commit ef60f61208a30eb5b941b707debdf04517271b4f ]
get_cpu_itimer() returns a zero remaining time when the sampled CPU time is exactly equal to the nonzero expiry. This makes an armed ITIMER_VIRTUAL or ITIMER_PROF timer appear disarmed.
The cputime cleanup replaced cputime_le(), which implements <=, with <. Restore the inclusive comparison so the equality case returns TICK_NSEC, like the overdue case and set_process_cpu_timer().
--- kernel/time/itimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/itimer.c +1 -1
@@ -60,7 +60,7 @@ static void get_cpu_itimer(struct task_struct *tsk, unsigned int clock_id,thread_group_sample_cputime (tsk, samples); t = samples[clock_id]; -if (val < t) +if (val <= t)/* about to fire */ val =TICK_NSEC ;else
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 575/1848 time/namespace: Fix overflow when converting absolute deadlines
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hungyu Lin <[email protected]>
[ Upstream commit d69cfd33b5a8d176124c564513b9ceb933595d93 ]
do_timens_ktime_to_host() subtracts the namespace offset from an absolute deadline and clamps the result to [0, KTIME_MAX]. A negative offset can make a large deadline overflow to a negative value. Since ktime_t is signed and KTIME_MAX is its maximum value, the subsequent comparison against KTIME_MAX can never detect this overflow.
For example, with a -1 second boottime offset, an absolute CLOCK_BOOTTIME timerfd deadline of KTIME_MAX can expire immediately. An absolute clock_nanosleep() using the same clock and deadline can also return immediately instead of waiting.
The earlier tim < offset check already handles the lower bound. A negative subtraction result in the remaining branch therefore indicates overflow. Detect that result and clamp it to KTIME_MAX.
--- kernel/time/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/namespace.c +1 -1
@@ -49,7 +49,7 @@ ktime_t do_timens_ktime_to_host(clockid_t clockid, ktime_t tim, tim =0 ; }else { tim =ktime_sub (tim, offset); -if (unlikely (tim >KTIME_MAX )) +if (unlikely (tim <0 )) tim =KTIME_MAX ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 576/1848 libceph: only set read_from_replica on read requests
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xiubo Li <[email protected]>
[ Upstream commit d6c7a5fcd08873c45a2dcd645a0690fd1443af50 ]
ceph_osdc_alloc_request() ORs the mount option's read_from_replica flag into r_flags for every request, writes included. The flag is meant for reads: calc_target() skips the replica choice for any request that has CEPH_OSD_FLAG_WRITE, and the OSDs only know BALANCE_READS on read ops. Sending it on writes is at best ignored; with read_from_replica=balance a buffered write that fell back to ceph_sync_write() after losing BUFFER to a revoke failed with -EIO, while the same run without the option works fine.
Gate the flag on CEPH_OSD_FLAG_READ.
--- net/ceph/osd_client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/ceph/osd_client.c +3 -1
@@ -1094,7 +1094,9 @@ struct ceph_osd_request *ceph_osdc_new_request(struct ceph_osd_client *osdc, req->r_base_oloc.pool = layout->pool_id; req->r_base_oloc.pool_ns =ceph_try_get_string (layout->pool_ns);ceph_oid_printf (&req->r_base_oid,"%llx.%08llx" , vino.ino, objnum); - req->r_flags = flags | osdc->client->options->read_from_replica; + req->r_flags = flags; +if (flags &CEPH_OSD_FLAG_READ ) + req->r_flags |= osdc->client->options->read_from_replica; req->r_snapid = vino.snap;if (flags &CEPH_OSD_FLAG_WRITE )
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 577/1848 libceph: Fix unsafe decode in ceph_redirect_decode()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Raphael Zimmer <[email protected]>
[ Upstream commit 0405670e50f213594366ab7eddc07002bd7f84c0 ]
ceph_redirect_decode handles unchecked data received over the network from an OSD. Currently, there is only a bounds check covering the first three decode operations. After decoding the first len field from the message, the only remaining check ensures there is enough buffer space to hold len bytes. However, there is no guarantee that this value is large enough to hold the subsequently decoded fields. The decoding of the second len field is missing an explicit bounds check. Consequently, a corrupted message can trigger an out-of-bounds read.
This patch fixes the issue by switching the decoding from ceph_decode_32() to the bounds-checked version ceph_decode_32_safe().
--- net/ceph/osd_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ceph/osd_client.c +1 -1
@@ -3575,7 +3575,7 @@ static int ceph_redirect_decode(void **p, void *end,if (ret) goto out; - len =ceph_decode_32 (p); +ceph_decode_32_safe (p, end, len, e_inval);if (len >0 ) {pr_warn ("ceph_request_redirect::object_name is set\n" ); goto e_inval;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 578/1848 libceph: Fix multiple unsafe decodes in ceph_oloc_decode()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Raphael Zimmer <[email protected]>
[ Upstream commit 10655007b9b679e46a9e383202c7bb791e5d1d13 ]
ceph_oloc_decode handles unchecked data received over the network from an OSD. Currently, there are multiple decode operations that aren't covered by any bounds check. Decoding these fields can therefore result in out-of-bounds reads if a corrupted message is received.
This patch fixes the issue by adding bounds checks covering all previously uncovered decode operations.
[ idryomov: use ceph_decode_64_safe() for hash ]
--- net/ceph/osd_client.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
net/ceph/osd_client.c +5 -2
@@ -3503,6 +3503,7 @@ static int ceph_oloc_decode(void **p, void *end,ceph_decode_need (p, end, len, e_inval); struct_end = *p + len; +ceph_decode_need (p, end,8 +4 +4 , e_inval); oloc->pool =ceph_decode_64 (p); *p +=4 ;/* skip preferred */
@@ -3515,7 +3516,7 @@ static int ceph_oloc_decode(void **p, void *end,if (struct_v >=5 ) {bool changed = false; - len =ceph_decode_32 (p); +ceph_decode_32_safe (p, end, len, e_inval);if (len >0 ) {ceph_decode_need (p, end, len, e_inval); if (!oloc->pool_ns ||
@@ -3534,7 +3535,9 @@ static int ceph_oloc_decode(void **p, void *end, }if (struct_v >=6 ) { -s64 hash =ceph_decode_64 (p); +s64 hash; + +ceph_decode_64_safe (p, end, hash, e_inval);if (hash !=-1 ) {pr_warn ("ceph_object_locator::hash is set\n" ); goto e_inval;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 579/1848 libceph: reject mismatched CRUSH weight-set sizes
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Felix Hoffmann <[email protected]>
[ Upstream commit d8fc89b5bfe4cb3aebe4c8a818247d11291b841c ]
A CEPH_MSG_OSD_MAP message can contain CRUSH choose args with replacement weight vectors for straw2 buckets. decode_choose_args() validates the optional IDs vector against the referenced bucket, but does not validate the size of any replacement-weight vector.
The CRUSH mapper assumes that each replacement vector has exactly as many entries as the bucket. A zero-length vector for a nonempty bucket makes bucket_straw2_choose() dereference NULL, while a shorter nonzero vector causes an out-of-bounds read. An authenticated monitor or OSD can deliver such a map and crash a kernel client when it performs placement for an ordinary request.
Reject a nonempty collection of weight sets for an absent bucket and require every replacement-weight vector to match its bucket size.
--- net/ceph/osdmap.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
net/ceph/osdmap.c +12 -2
@@ -362,7 +362,9 @@ static int decode_choose_args(void **p, void *end, struct crush_map *c)ceph_decode_32_safe (p, end, num_buckets, e_inval);while (num_buckets--) {struct crush_choose_arg *arg; +struct crush_bucket *bucket;u32 bucket_index; +u32 i;ceph_decode_32_safe (p, end, bucket_index, e_inval);if (bucket_index >= arg_map->size)
@@ -373,10 +375,18 @@ static int decode_choose_args(void **p, void *end, struct crush_map *c)if (ret) goto fail; + bucket = c->buckets[bucket_index];if (arg->ids_size && - (!c->buckets[bucket_index] || - arg->ids_size != c->buckets[bucket_index]->size)) + (!bucket || arg->ids_size != bucket->size)) goto e_inval; + +if (arg->weight_set_size && !bucket) + goto e_inval; + +for (i =0 ; i < arg->weight_set_size; i++) { +if (arg->weight_set[i].size != bucket->size) + goto e_inval; + } }if (!__insert_choose_arg_map (&c->choose_args, arg_map)) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 580/1848 ceph: Fix xattr buffer leak in __send_cap()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wentao Liang <[email protected]>
[ Upstream commit e51cf76e7275d1bb5ad2d529bb00feade632dadc ]
__prep_cap() takes a reference on the xattr blob via ceph_buffer_get() and also grabs a reference to the old xattr blob returned by __ceph_build_xattrs_blob(). These references are normally dropped in __send_cap() after the cap message has been sent, but when ceph_msg_new() fails, __send_cap() requeues the cap and returns early without dropping them, leaking both buffers on every allocation failure.
Release arg->old_xattr_buf and arg->xattr_buf on the ceph_msg_new() failure path before returning.
--- fs/ceph/caps.c | 2 ++ 1 file changed, 2 insertions(+)
fs/ceph/caps.c +2 -0
@@ -1462,6 +1462,8 @@ static void __send_cap(struct cap_msg_args *arg, struct ceph_inode_info *ci)spin_lock (&ci->i_ceph_lock);__cap_delay_requeue (arg->session->s_mdsc, ci);spin_unlock (&ci->i_ceph_lock); +ceph_buffer_put (arg->old_xattr_buf); +ceph_buffer_put (arg->xattr_buf);return ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 581/1848 ceph: Fix mds session leak in __open_export_target_session()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wentao Liang <[email protected]>
[ Upstream commit 6c80207392fdb86107d7acbdbf4c86cac38da1af ]
__open_export_target_session() holds a reference on the target session, either from __ceph_lookup_mds_session() or from register_session(), which the caller is expected to drop. When __open_session() fails, the helper returns ERR_PTR(ret) without dropping that reference, leaking one session reference on every open failure.
Drop the session reference before returning the error.
--- fs/ceph/mds_client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/ceph/mds_client.c +3 -1
@@ -1433,8 +1433,10 @@ __open_export_target_session(struct ceph_mds_client *mdsc, int target)if (session->s_state ==CEPH_MDS_SESSION_NEW || session->s_state ==CEPH_MDS_SESSION_CLOSING ) { ret =__open_session (mdsc, session); -if (ret) +if (ret) { +ceph_put_mds_session (session);return ERR_PTR (ret); + } }return session;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 582/1848 libceph: fix out-of-bounds reads from repeated CRUSH bucket entries
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jérémy Jean <[email protected]>
[ Upstream commit 569a9bb1e5615c2b88b8d76f03a4ab82e65a673e ]
decode_choose_arg() assumes that its destination is zero-initialized. Although decode_choose_args() zeroes the argument array, it does not reject a repeated bucket_index and can decode into an already populated entry.
Repeating a bucket with weight_set_size=0 preserves its existing weight_set pointer but clears the count. Placement then reads weight_set[-1].weights and dereferences the resulting pointer.
A malformed monitor OSDMap triggers this during RBD placement:
BUG: KASAN: slab-out-of-bounds in crush_bucket_choose+0xdd1/0xf90 Read of size 8 at addr ffff88800290df70 by task init/75
Reject populated arguments before decoding another entry, so the error path can free their original allocations.
--- net/ceph/osdmap.c | 2 ++ 1 file changed, 2 insertions(+)
net/ceph/osdmap.c +2 -0
@@ -371,6 +371,8 @@ static int decode_choose_args(void **p, void *end, struct crush_map *c) goto e_inval; arg = &arg_map->args[bucket_index]; +if (arg->ids || arg->weight_set) + goto e_inval; ret =decode_choose_arg (p, end, arg);if (ret) goto fail;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 583/1848 ceph: clamp MDS reply result code to the errno range
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yuanfu Xie <[email protected]>
[ Upstream commit ec8d583469ed64b4973192a21b5a41c33219721f ]
ceph_mdsc_wait_request() returns the reply head result code of the MDS request to its callers as a plain int errno. The value is a server-controlled u32 and nothing checks that it actually is an errno; several callers pass it straight to ERR_PTR(), e.g. ceph_finish_lookup() on the atomic open path:
err = ceph_mdsc_wait_request(...) /* e.g. +0x50fc00 */ ... if (err) dentry = ERR_PTR(err);
IS_ERR() only recognizes the [-MAX_ERRNO, -1] window, so an out-of-range value is not caught anywhere and survives as a "struct dentry *". On the open path the positive error travels ceph_finish_lookup() -> ceph_atomic_open() -> ERR_PTR() in fs/namei.c's atomic_open() wrapper -> step_into(), which dereferences it as a dentry and oopses (mainline 7.3-rc3-135-g4982d3552a3b, the value in R12 is the server-supplied result):
BUG: KASAN: probably user-memory-access in range [0x000000000050fc00-0x000000000050fc07] RIP: 0010:step_into_slowpath+0x3e3/0xe60 R12: 000000000050fc00 Call Trace: <TASK> ? __pfx_ceph_atomic_open+0x10/0x10 path_openat+0xf41/0x2440 do_file_open+0x228/0x480 do_sys_openat2+0x103/0x1d0 __x64_sys_openat+0x141/0x200 do_syscall_64+0xe8/0x4f0 entry_SYSCALL_64_after_hwframe+0x77/0x79 </TASK>
(0xdffffc00000a1f80 in the full report is the KASAN shadow of 0x50fc00; without KASAN the raw value is read.) Values with the top bit set fare no better: 0xd8000000 sign-extends through the int conversion into the kernel address range and takes a page fault instead.
Clamp the result at the single read and return -EIO for anything outside the errno range, which is what a malformed reply means there. net/9p does the same to server errno values with safe_errno(). This is the path the reported crash takes; the other readers of head->result, including the ceph_async_create_cb() and ceph_async_unlink_cb() callbacks, are not covered by this patch.
Each of the six crashing opens was run on a build of 7.3-rc3-135-g4982d3552a3bf with only this change applied: it crashes the unpatched kernel on the first openat() (verified on the same tree without the patch), and with the patch the open fails cleanly without an oops. A few hundred normal file operations on the patched kernel also completed without a crash; valid errno values pass through unchanged.
--- fs/ceph/mds_client.c | 8 ++++++++ 1 file changed, 8 insertions(+)
fs/ceph/mds_client.c +8 -0
@@ -3051,6 +3051,14 @@ static int ceph_mdsc_wait_request(struct ceph_mds_client *mdsc,/* only abort if we didn't race with a real reply */ if (test_bit (CEPH_MDS_R_GOT_RESULT , &req->r_req_flags)) { err =le32_to_cpu (req->r_reply_info.head->result); +if (err >0 || err < -MAX_ERRNO ) { +/* +* The result is server-controlled. Values outside +* the errno range are turned into bogus pointers by +* the ERR_PTR() users among the callers. +*/ + err = -EIO ; + } }else if (err <0 ) {dout ("aborted request %lld with %d\n" , req->r_tid, err);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 584/1848 ceph: bound name skips in ceph_mdsmap_decode() by the message end
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: sung byeongchan <[email protected]>
[ Upstream commit 7f702e1703c9648fcb02a217d66c880d00417150 ]
ceph_mdsmap_decode() reads two remote u32 name lengths and advances its parser cursor without checking that either string remains in the message. On a 32-bit client, a sufficiently large length can wrap the cursor below end. The following numerical bounds check then succeeds and dereferences the wrapped address.
Use ceph_decode_skip_n() for both names so the remaining bytes are checked before the cursor advances.
The issue produced a page fault in ceph_mdsmap_decode twice on the tested i386 baseline. The same frame was rejected without a fault twice after this change, while a normal MDSMap continued to be accepted.
--- fs/ceph/mdsmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ceph/mdsmap.c +2 -2
@@ -201,7 +201,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)ceph_decode_need (p, end,sizeof (u64) +sizeof (u32), bad); *p +=sizeof (u64); namelen =ceph_decode_32 (p);/* skip mds name */ - *p += namelen; +ceph_decode_skip_n (p, end, namelen, bad); ceph_decode_need(p, end, 4*sizeof(u32) + sizeof(u64) +
@@ -218,7 +218,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) laggy = laggy_since.tv_sec !=0 || laggy_since.tv_nsec !=0 ; *p +=sizeof (u32);ceph_decode_32_safe (p, end, namelen, bad); - *p += namelen; +ceph_decode_skip_n (p, end, namelen, bad);if (info_v >=2 ) {ceph_decode_32_safe (p, end, num_export_targets, bad); export_targets_len = size_mul(num_export_targets,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 585/1848 ceph: validate encoded xattr name lengths
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: sung byeongchan <[email protected]>
[ Upstream commit 166375898d29fea050a9abec855da6075050d5c9 ]
__build_xattrs() advances over an MDS-provided name length before checking that the name remains in the encoded xattr blob. On 32-bit clients, UINT_MAX wraps the cursor and is stored as a negative internal name length. A later ordinary listxattr() converts it back to a UINT_MAX memcpy size and corrupts kernel memory.
Check the name range before advancing and reject name, value, or aggregate sizes that overflow the signed internal accounting.
The malformed blob corrupted kernel state in two baseline boots. It was rejected cleanly twice with this change, while normal and length-only controls remained safe.
--- fs/ceph/xattr.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
fs/ceph/xattr.c +10 -0
@@ -11,6 +11,7 @@#include <linux/security.h> #include <linux/posix_acl_xattr.h> #include <linux/slab.h> +#include <linux/overflow.h> #define XATTR_CEPH_PREFIX "ceph."#define XATTR_CEPH_PREFIX_LEN (sizeof (XATTR_CEPH_PREFIX) - 1)
@@ -710,14 +711,23 @@ static int __build_xattrs(struct inode *inode) } err = -EIO ;while (numattr--) { +int names_size, vals_size; +ceph_decode_32_safe (&p, end, len, bad); namelen = len; name = p; +ceph_decode_need (&p, end, namelen, bad); p += len;ceph_decode_32_safe (&p, end, len, bad);ceph_decode_need (&p, end, len, bad); val = p; p += len; +if (namelen >INT_MAX || len >INT_MAX || +check_add_overflow (ci->i_xattrs.names_size, + (int )namelen, &names_size) || +check_add_overflow (ci->i_xattrs.vals_size, + (int )len, &vals_size)) + goto bad; err =__set_xattr (ci, name, namelen, val, len,0 ,0 , &xattrs[numattr]);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 586/1848 ASoC: qcom: qdsp6: q6afe: fix clk vote response type mismatch
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Val Packett <[email protected]>
[ Upstream commit f3c7bee984aa0ba2b48a44e16a6f3ec2c27f851e ]
The response sent by the firmware when requesting a clock vote (opcode AFE_CMD_RSP_REMOTE_LPASS_CORE_HW_VOTE_REQUEST) does not actually have the same opcode + status payload as APR_BASIC_RSP_RESULT. Rather, it returns one single u32 which is the client_handle that must be used in future unvote requests for the same clock.
As a result of this type confusion, the status returned by the callback to q6afe_vote_lpass_core_hw was actually an out-of-bounds read. It was only interpreted as success (0) most of the time due to luck, but there are some reports of random errors such as:
[ 20.961100] qcom-q6afe aprsvc:service:4:4: AFE failed to vote (3) [ 20.961131] Failed to prepare clk 'core': -110
Fix by correctly interpreting the response as a single u32, and actually store it as the client_handle to ensure unvote would work correctly.
--- sound/soc/qcom/qdsp6/q6afe.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
sound/soc/qcom/qdsp6/q6afe.c +8 -2
@@ -367,6 +367,7 @@ struct q6afe {struct q6core_svc_api_info ainfo;struct mutex lock;struct aprv2_ibasic_rsp_result_t result; +uint32_t vote_result;wait_queue_head_t wait;struct list_head port_list;spinlock_t port_list_lock;
@@ -867,13 +868,14 @@ static int q6afe_callback(struct apr_device *adev, struct apr_resp_pkt *data)struct aprv2_ibasic_rsp_result_t *res;struct apr_hdr *hdr = &data->hdr;struct q6afe_port *port; +uint32_t *vote_res;if (!data->payload_size)return 0 ; - res = data->payload;switch (hdr->opcode) {case APR_BASIC_RSP_RESULT : { + res = data->payload;if (res->status) {dev_err (afe->dev,"cmd = 0x%x returned error = 0x%x\n" , res->opcode, res->status);
@@ -900,8 +902,10 @@ static int q6afe_callback(struct apr_device *adev, struct apr_resp_pkt *data) }break ;case AFE_CMD_RSP_REMOTE_LPASS_CORE_HW_VOTE_REQUEST : + vote_res = data->payload; afe->result.opcode = hdr->opcode; - afe->result.status = res->status; + afe->result.status =0 ; + afe->vote_result = *vote_res;wake_up (&afe->wait);break ;default :
@@ -1714,6 +1718,8 @@ int q6afe_vote_lpass_core_hw(struct device *dev, uint32_t hw_block_id, AFE_CMD_RSP_REMOTE_LPASS_CORE_HW_VOTE_REQUEST);if (ret)dev_err (afe->dev,"AFE failed to vote (%d)\n" , hw_block_id); +else + *client_handle = afe->vote_result;kfree (pkt);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 587/1848 net: usb: pegasus: check rx pkt_len against the received length
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wei Jie Law <[email protected]>
[ Upstream commit efee699f6de06611234ef9b0abd52db1340e5452 ]
read_bulk_callback() takes the frame length from the device, from the receive header on the 0x8513 and from the trailing status bytes on the other chips, and only checks it against PEGASUS_MTU before passing that many bytes up the stack. In two cases the stack then uses bytes that the device did not send:
- A device that sends a short transfer but claims a long frame gets the stale or uninitialized remainder of the receive skb delivered as packet data.
- A device that claims a frame shorter than an Ethernet header gets past the check as well. eth_type_trans() takes pkt_type from h_dest and the protocol from h_proto without checking skb->len. If the transfer is also short, those come from bytes left in the skb by an earlier transfer, or from uninitialized memory.
Drop frames shorter than ETH_HLEN, and frames whose claimed length, plus the 0x8513 header, does not fit in the bytes actually received, and count them as length errors. urb->actual_length never exceeds the PEGASUS_MTU sized transfer buffer, so this also covers the existing PEGASUS_MTU check. Valid Ethernet frames are at least 60 bytes long without the FCS, so they are not affected.
Found by code review with LLM assistance. With an emulated USB device, a 101-byte transfer claiming a 1500-byte frame was passed up as a 1500-byte packet before this change and is dropped after it, and frames claiming 0, 4 and 13 bytes were passed up and are now dropped and counted in rx_length_errors. The extra bytes happened to be zero in the first test, so disclosure of actual kernel data was not demonstrated.
--- drivers/net/usb/pegasus.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/net/usb/pegasus.c +9 -3
@@ -556,11 +556,17 @@ static void read_bulk_callback(struct urb *urb) }/* -* If the packet is unreasonably long, quietly drop it rather than -* kernel panicing by calling skb_put. +* Drop frames shorter than an Ethernet header, because +* eth_type_trans() reads the header whatever the length, and frames +* longer than what was actually received. Passing either up would +* expose stale buffer contents, and skb_put() could panic on the +* latter. count is at most PEGASUS_MTU. */ -if (pkt_len >PEGASUS_MTU - rx_offset) +if (pkt_len <ETH_HLEN || pkt_len + rx_offset > count) { + net->stats.rx_errors++; + net->stats.rx_length_errors++; goto goon; + }/* * at this point we are sure pegasus->rx_skb != NULL
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 588/1848 bonding: fix out-of-bounds read of arp_ip_target
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jiayuan Chen <[email protected]>
[ Upstream commit a81513bf5bdf29cf00c0a11f56be515c1ec260f4 ]
arp_ip_target is a module parameter array with BOND_MAX_ARP_TARGETS entries. In the loop parsing it in bond_check_params(), arp_ip_count is the number of accepted targets, while i is the index into arp_ip_target. Invalid and duplicate entries are skipped without bumping arp_ip_count, so bounding the loop with arp_ip_count lets i run past the end of arp_ip_target, e.g. 16 targets with one duplicate:
BUG: KASAN: global-out-of-bounds in bond_check_params.constprop.0+0x1148/0x1440 Read of size 8 at addr ffffffff96e9ee00 by task swapper/0/1 Call Trace: <TASK> dump_stack_lvl+0x91/0xf0 print_report+0xd1/0x630 kasan_report+0xf3/0x130 __asan_report_load8_noabort+0x14/0x30 bond_check_params.constprop.0+0x1148/0x1440 bonding_init+0x13/0xe0 do_one_initcall+0xe7/0x5b0 kernel_init_freeable+0xa91/0x1120 kernel_init+0x24/0x220 ret_from_fork+0x5b3/0x820 ret_from_fork_asm+0x1a/0x30 </TASK> The buggy address belongs to the variable: arp_ip_target+0x80/0xa0
Bound the loop with i instead. arp_ip_count never exceeds i, so it stays within BOND_MAX_ARP_TARGETS too.
--- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +1 -1
@@ -5178,7 +5178,7 @@ static int bond_check_params(struct bond_params *params) }for (arp_ip_count =0 , i =0 ; - (arp_ip_count <BOND_MAX_ARP_TARGETS ) && arp_ip_target[i]; i++) { + (i <BOND_MAX_ARP_TARGETS ) && arp_ip_target[i]; i++) {__be32 ip;/* not a complete check, but good enough to catch mistakes */
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 589/1848 ipmr: fully initialize the synthetic IP header in ipmr_get_route()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ido Schimmel <[email protected]>
[ Upstream commit 134351edc28e083c61012b6c69e8e54dd7fa5bcc ]
For an unresolved multicast route query, ipmr_get_route() builds a synthetic IP header in the headroom obtained from skb_realloc_headroom(), which does not zero the memory it allocates. Only a few fields are initialized, leaving others as stale heap contents.
ipmr_cache_report() copies this header into the IGMPMSG_NOCACHE report that is queued to the mroute socket, so a recvmsg() on that socket leaks the uninitialized bytes to user space: the 'tos' field [1] and the 'id' and 'frag_off' fields [2].
Fix by zeroing the IP header before filling in the few fields that are used, so that the entire header is initialized, as in ip6mr_get_route().
[1]
BUG: KMSAN: kernel-infoleak in _copy_to_iter raw_recvmsg
Uninit was stored to memory at:
ipmr_cache_report
ipmr_cache_unresolved
ipmr_get_route
Uninit was created at:
pskb_expand_head
skb_realloc_headroom
ipmr_get_route
Byte 1 of 28 is uninitialized
[2]
BUG: KMSAN: kernel-infoleak in _copy_to_iter raw_recvmsg
Uninit was stored to memory at:
ipmr_cache_report
ipmr_cache_unresolved
ipmr_get_route
Uninit was created at:
pskb_expand_head
skb_realloc_headroom
ipmr_get_route
Bytes 4-7 of 28 are uninitialized
--- net/ipv4/ipmr.c | 1 + 1 file changed, 1 insertion(+)
net/ipv4/ipmr.c +1 -0
@@ -2297,6 +2297,7 @@ int ipmr_get_route(struct net *net, struct sk_buff *skb,skb_push (skb2,sizeof (struct iphdr ));skb_reset_network_header (skb2); iph =ip_hdr (skb2); +memset (iph,0 ,sizeof (*iph)); iph->ihl =sizeof (struct iphdr ) >>2 ; iph->saddr = saddr; iph->daddr = daddr;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 590/1848 ALSA: hda: Reject codec reset on ASoC (ext_ops) buses
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit a4311e9447bbb219044db38897f95be112f46a8a ]
Writing to the reconfig or clear sysfs nodes of a codec handled by ASoC (SOF via hdac_hda, AVS via codecs/hda) hangs the writer.
snd_hda_codec_reset() sets card->shutdown and calls device_release_driver(). With ext_ops the driver unbind unregisters the ASoC component, which unbinds and frees the whole ASoC card:
- snd_card_disconnect() returns early as card->shutdown is already set, so the card's child devices are not removed and snd_card_free() waits for the card release forever.
- Even without that, freeing the card removes the codec's hwdep device, which owns the sysfs node the reset was issued from, deadlocking in kernfs while waiting for the active write to finish.
The legacy HDA driver keeps the card across a driver rebind, ASoC does not, so the reset cannot be supported there. Return -EOPNOTSUPP and skip the misleading "codec is being used" messages in the callers.
--- sound/pci/hda/hda_codec.c | 6 ++++++ sound/pci/hda/hda_sysfs.c | 4 ++++ 2 files changed, 10 insertions(+)
sound/pci/hda/hda_codec.c +6 -0
@@ -1802,6 +1802,12 @@ int snd_hda_codec_reset(struct hda_codec *codec) {struct hda_bus *bus = codec->bus; +/* ASoC: driver unbind frees the card, incl. the hwdep issuing the reset */ +if (bus->core.ext_ops) { +codec_err (codec,"Codec reset is not supported with ASoC\n" ); +return -EOPNOTSUPP ; + } +if (snd_hda_lock_devices (bus) <0 )return -EBUSY ;
sound/pci/hda/hda_sysfs.c +4 -0
@@ -119,6 +119,8 @@ static int clear_codec(struct hda_codec *codec)int err; err =snd_hda_codec_reset (codec); +if (err == -EOPNOTSUPP ) +return err;if (err <0 ) {codec_err (codec,"The codec is being used, can't free.\n" );return err;
@@ -134,6 +136,8 @@ static int reconfig_codec(struct hda_codec *codec)snd_hda_power_up (codec);codec_info (codec,"hda-codec: reconfiguring\n" ); err =snd_hda_codec_reset (codec); +if (err == -EOPNOTSUPP ) +return err;if (err <0 ) {codec_err (codec,"The codec is being used, can't reconfigure.\n" );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 591/1848 ixgbe: reserve TX timestamp after skb preparation
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Dumazet <[email protected]>
[ Upstream commit f75062536e2d45ee182828f0e47e0124be2fdc8d ]
ixgbe_xmit_frame_ring() takes an extra skb reference with skb_get() for the pending TX timestamp before preparing the skb for transmit. Several of the following steps may need to reallocate the skb head:
- ixgbe_tso() calls skb_cow_head(), which reaches pskb_expand_head() when the header is cloned (e.g. a packet tap holds a clone).
- ixgbe_tx_csum() falls back to skb_checksum_help() for unsupported checksum offsets, which can call pskb_expand_head() through skb_ensure_writable().
- With DCB and a software VLAN tag, skb_cow_head() is called to rewrite the VLAN priority.
pskb_expand_head() used to BUG() on shared skbs. Since commit c7d8bc3dd511 ("net: skbuff: don't BUG() on bad arguments to pskb_expand_head()") it returns -EINVAL instead, so these packets are dropped (TSO, DCB) or sent with an unfinished checksum (skb_checksum_help() errors are ignored by ixgbe_tx_csum()).
Reserve the TX timestamp right before ixgbe_tx_map(), after all skb preparation, as i40e and ice already do. The timestamp request remains covered on the FCoE path, and the cleanup on ixgbe_tx_map() failure is unchanged.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 40 +++++++++++-------- 1 file changed, 23 insertions(+), 17 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +23 -17
@@ -8665,23 +8665,6 @@ netdev_tx_t ixgbe_xmit_frame_ring(struct sk_buff *skb, } protocol =vlan_get_protocol (skb); -if (unlikely (skb_shinfo (skb)->tx_flags &SKBTX_HW_TSTAMP ) && - adapter->ptp_clock) { -if (adapter->tstamp_config.tx_type ==HWTSTAMP_TX_ON && - !test_and_set_bit_lock (__IXGBE_PTP_TX_IN_PROGRESS, - &adapter->state)) { -skb_shinfo (skb)->tx_flags |=SKBTX_IN_PROGRESS ; - tx_flags |=IXGBE_TX_FLAGS_TSTAMP ; - -/* schedule check for Tx timestamp */ - adapter->ptp_tx_skb =skb_get (skb); - adapter->ptp_tx_start = jiffies; -schedule_work (&adapter->ptp_tx_work); - }else { - adapter->tx_hwtstamp_skipped++; - } - } -#ifdef CONFIG_PCI_IOV /* * Use the l2switch_enable flag - would be false if the DMA
@@ -8746,6 +8729,29 @@ netdev_tx_t ixgbe_xmit_frame_ring(struct sk_buff *skb,#ifdef IXGBE_FCOE xmit_fcoe:#endif /* IXGBE_FCOE */ +/* Reserve the Tx timestamp only after all skb preparation: +* skb_get() makes the skb shared, and pskb_expand_head() +* (reached from skb_cow_head() or skb_checksum_help()) +* refuses shared skbs. +*/ +if (unlikely (skb_shinfo (skb)->tx_flags &SKBTX_HW_TSTAMP ) && + adapter->ptp_clock) { +if (adapter->tstamp_config.tx_type ==HWTSTAMP_TX_ON && + !test_and_set_bit_lock (__IXGBE_PTP_TX_IN_PROGRESS, + &adapter->state)) { +skb_shinfo (skb)->tx_flags |=SKBTX_IN_PROGRESS ; + tx_flags |=IXGBE_TX_FLAGS_TSTAMP ; + first->tx_flags |=IXGBE_TX_FLAGS_TSTAMP ; + +/* schedule check for Tx timestamp */ + adapter->ptp_tx_skb =skb_get (skb); + adapter->ptp_tx_start = jiffies; +schedule_work (&adapter->ptp_tx_work); + }else { + adapter->tx_hwtstamp_skipped++; + } + } +if (ixgbe_tx_map (tx_ring, first, hdr_len)) goto cleanup_tx_timestamp;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 592/1848 ASoC: hdac_hda: Balance the runtime PM disable in codec remove
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit f26c0d5f91d918bb66cbbc8916f41836adb38346 ]
hdac_hda_codec_remove() disables runtime PM of the codec device before releasing the HDA link and calling the codec driver's remove callback, so that no runtime resume can race with the teardown and access the link or the already freed codec driver data. snd_hda_codec_cleanup_for_unbind() then disables runtime PM again.
On the next probe snd_hda_codec_register() enables runtime PM only once, leaving it disabled after the ASoC card or the codec driver has been unbound and bound again: the codec stays powered and runtime_status reads 'unsupported'.
Re-enable runtime PM at the end of hdac_hda_codec_remove() to balance its own disable. The codec remains disabled until it is registered again.
--- sound/soc/codecs/hdac_hda.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/soc/codecs/hdac_hda.c +4 -0
@@ -520,6 +520,7 @@ static void hdac_hda_codec_remove(struct snd_soc_component *component)return ; } +/* prevent runtime PM callbacks while the link and the codec are torn down */ pm_runtime_disable (&hdev->dev);snd_hdac_ext_bus_link_put (hdev->bus, hlink);
@@ -527,6 +528,9 @@ static void hdac_hda_codec_remove(struct snd_soc_component *component) codec->patch_ops.free (codec);snd_hda_codec_cleanup_for_unbind (codec); + +/* Balances the disable above, cleanup_for_unbind keeps runtime PM disabled */ +pm_runtime_enable (&hdev->dev); }static const struct snd_soc_dapm_route hdac_hda_dapm_routes[] = {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 593/1848 cpufreq: stats: Fix potential out-of-bounds access in deferred reset
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Zhongqiu Han <[email protected]>
[ Upstream commit 8a702989677216489e471a6f27599da53f753567 ]
cpufreq_stats_create_table() sets stats->last_index to -1 if policy->cur is not in the frequency table. It then stays at -1, because cpufreq_stats_record_transition() returns early on old_index == -1 before it gets to update last_index.
Commit 46a310b80bc2 ("[CPUFREQ] Don't set stat->last_index to -1 if the pol->cur has incorrect value.") added that check. However, since commit 40c3bd4cfa6f ("cpufreq: stats: Defer stats update to cpufreq_stats_record_transition()"), the stats reset is deferred to the beginning of cpufreq_stats_record_transition(), before that check, and cpufreq_stats_reset_table() ends with an unconditional cpufreq_stats_update(). So if the "reset" attribute is written while last_index is -1, the next frequency transition accesses time_in_state[-1].
Fix it by also returning early on last_index == -1 in cpufreq_stats_reset_table().
--- drivers/cpufreq/cpufreq_stats.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/cpufreq/cpufreq_stats.c +4 -0
@@ -52,6 +52,10 @@ static void cpufreq_stats_reset_table(struct cpufreq_stats *stats)* reset_pending accesses in cpufreq_stats_record_transition(). */ smp_rmb (); + +if (stats->last_index ==-1 ) +return ; +cpufreq_stats_update (stats,READ_ONCE (stats->reset_time)); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 594/1848 macvlan: fix passthru promiscuity accounting while down
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xia Yan <[email protected]>
[ Upstream commit b6743653d134c9ef8436e2db1be1ad4c1e0d0091 ]
macvlan_changelink() adjusts the lower device's promiscuity count when NOPROMISC changes, even if the passthru macvlan is down. The reference is acquired in macvlan_open() and released in macvlan_stop(), so a down interface has no reference to change.
Clearing NOPROMISC while down leaves an extra reference after the next open/stop cycle. Setting it while down can remove a reference held by another user of the lower device.
Guard the count adjustment with netif_running(dev). Keep storing the requested flags while down so the next open uses the new setting.
Comparing changelink with open/stop exposed the unmatched count changes; the same issue was also described in earlier macvlan reviews. A netlink test on UML reproduced both DOWN cases before the fix and verified the expected counts afterwards. Repeated flag updates, two open/stop cycles, deletion and bidirectional small-frame delivery were also checked.
Full x86_64 builds completed with WERROR disabled for allmodconfig, and WERROR and KASAN disabled for allyesconfig, including the resulting dependency changes. Neither comparison showed new diagnostics.
--- drivers/net/macvlan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/macvlan.c +2 -1
@@ -1580,7 +1580,8 @@ static int macvlan_changelink(struct net_device *dev,if (data && data[IFLA_MACVLAN_FLAGS ]) {__u16 flags =nla_get_u16 (data[IFLA_MACVLAN_FLAGS ]);bool promisc = (flags ^ vlan->flags) &MACVLAN_FLAG_NOPROMISC ; -if (macvlan_passthru (vlan->port) && promisc) { +if (macvlan_passthru (vlan->port) && promisc && +netif_running (dev)) {int err;if (flags &MACVLAN_FLAG_NOPROMISC )
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 595/1848 net: hisilicon: hisi_femac: Stop the receiver before releasing the RX ring
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Yang <[email protected]>
[ Upstream commit d54b21d824302af52d06574870817fbe14774dab ]
hisi_femac_net_close() frees the receive ring while the RX address queue still holds every address that was pushed to IQ_ADDR.
A port that keeps receiving then DMAs arrived frames into buffers that other slab caches have already taken back; on an EC6108V9C (hi3798mv100) the queue still held all 52 armed addresses right after the interface was closed, and had dropped to 43 after 15 s of broadcast traffic.
Reset the port before the buffers are released, so that the receiver no longer holds any of their addresses.
--- drivers/net/ethernet/hisilicon/hisi_femac.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/hisilicon/hisi_femac.c +1 -0
@@ -491,6 +491,7 @@ static int hisi_femac_net_close(struct net_device *dev)netif_stop_queue (dev);napi_disable (&priv->napi); +hisi_femac_port_reset (priv);hisi_femac_free_skb_rings (priv);return 0 ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 596/1848 ASoC: hdac_hda: Keep runtime PM state in sync across codec remove/probe
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit 99203e8d8968def973e82bb712ea959c6a46c16e ]
After the codec has been removed, its runtime PM status is RPM_SUSPENDED while hdac_hda_codec_probe() powers the codec up via snd_hda_codec_device_new(). The pm_runtime_put()/snd_hda_power_down() calls on probe and registration then see an already suspended device, the codec suspend callback is not called and the codec, its HDA link and the codec_powered bit stay set, preventing the controller from runtime suspending.
The remove has a similar problem with the codec link accounting:hdac_hda_codec_remove() drops the link reference taken in probe without looking at the runtime PM state of the codec. If the codec was already runtime suspended, the link reference has been dropped by the codec suspend callback and the remove drops it a second time.
Resume the codec in hdac_hda_codec_remove() before disabling runtime PM so that the link reference and the codec_powered bit are always in the same state as after the probe, and mark the device active on probe once the codec has been powered up.
Finally mark the codec device suspended at the end of the remove. Its runtime PM is disabled at this point and if only the ASoC card is unbound (e.g. by unbinding the machine driver), a following system suspend would otherwise call the runtime suspend callback on the already cleaned up codec via pm_runtime_force_suspend().
This is a followup patch to address Sashiko reports.
--- sound/soc/codecs/hdac_hda.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
sound/soc/codecs/hdac_hda.c +12 -0
@@ -481,6 +481,9 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component)snd_hdac_display_power (hdev->bus,HDA_CODEC_IDX_CONTROLLER , false); +/* The codec is in D0, the status is RPM_SUSPENDED after a previous unbind */ +pm_runtime_set_active (&hdev->dev); +/* match for forbid call in snd_hda_codec_device_new() */ pm_runtime_allow (&hdev->dev);
@@ -520,6 +523,12 @@ static void hdac_hda_codec_remove(struct snd_soc_component *component)return ; } +/* +* Resume the codec to have its link reference (dropped below) and +* codec_powered bit in the same state as after the probe. +*/ +pm_runtime_get_sync (&hdev->dev); +/* prevent runtime PM callbacks while the link and the codec are torn down */ pm_runtime_disable (&hdev->dev);snd_hdac_ext_bus_link_put (hdev->bus, hlink);
@@ -531,6 +540,9 @@ static void hdac_hda_codec_remove(struct snd_soc_component *component)/* Balances the disable above, cleanup_for_unbind keeps runtime PM disabled */ pm_runtime_enable (&hdev->dev); +pm_runtime_put_noidle (&hdev->dev); +/* The codec is cleaned up, system suspend must skip it from now on */ +pm_runtime_set_suspended (&hdev->dev); }static const struct snd_soc_dapm_route hdac_hda_dapm_routes[] = {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 597/1848 ppp: fix stale pointer access after pskb_may_pull in ppp_ccp_peek
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tristan Madani <[email protected]>
[ Upstream commit 1e860f42f41c6fbf3304f6a52be38245b9394982 ]
ppp_ccp_peek() caches a pointer to skb->data in dp after the first pskb_may_pull(), then uses dp after a second pskb_may_pull(skb, len + 2) in the CCP_CONFACK handler. If the second pull triggers pskb_expand_head() due to a cloned skb or frag linearization, skb->head is freed and reallocated, leaving dp stale.
The stale dp is subsequently used in CCP_OPT_LENGTH() and passed to decomp_init()/comp_init() which read from the freed memory.
Re-derive dp from skb->data after the second pskb_may_pull.
--- drivers/net/ppp/ppp_generic.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ppp/ppp_generic.c +1 -0
@@ -2980,6 +2980,7 @@ ppp_ccp_peek(struct ppp *ppp, struct sk_buff *skb, int inbound) len =CCP_LENGTH (dp);if (!pskb_may_pull (skb, len +2 ))return ;/* too short */ + dp = skb->data +2 ; dp +=CCP_HDRLEN ; len -=CCP_HDRLEN ;if (len <CCP_OPT_MINLEN || len <CCP_OPT_LENGTH (dp))
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 598/1848 nvmet-rdma: reject short connection requests
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Weiming Shi <[email protected]>
[ Upstream commit 635e760169a87abf03874cd4636cd91b580cb427 ]
nvmet_rdma_parse_cm_connect_req() treats RDMA-CM private data as a struct nvme_rdma_cm_req but accepts any nonzero private_data_len. The iWARP path allocates exactly the peer-provided length, so a six-byte MPA request reaches the parser and the hsqsize load reads two bytes past the allocation.
Require the complete request structure before reading any of its fields. The decoded KASAN report is:
BUG: KASAN: slab-out-of-bounds in nvmet_rdma_cm_handler
(drivers/nvme/target/rdma.c:1427 drivers/nvme/target/rdma.c:1475
drivers/nvme/target/rdma.c:1614 drivers/nvme/target/rdma.c:1814)
Read of size 2 at addr ff1100010459d366 by task kworker/u16:1/41
Workqueue: iw_cm_wq cm_work_handler
Call Trace:
<TASK>
dump_stack_lvl (lib/dump_stack.c:94 lib/dump_stack.c:120)
print_report (mm/kasan/report.c:378 mm/kasan/report.c:482)
kasan_report (mm/kasan/report.c:595)
nvmet_rdma_cm_handler
(drivers/nvme/target/rdma.c:1427 drivers/nvme/target/rdma.c:1475
drivers/nvme/target/rdma.c:1614 drivers/nvme/target/rdma.c:1814)
cma_cm_event_handler (drivers/infiniband/core/cma.c:2181)
iw_conn_req_handler (drivers/infiniband/core/cma.c:2640)
cm_work_handler
(drivers/infiniband/core/cm.c:2502
drivers/infiniband/core/cm.c:3858)
process_one_work (kernel/workqueue.c:3396)
worker_thread (kernel/workqueue.c:3479 kernel/workqueue.c:3560)
kthread (kernel/kthread.c:436)
ret_from_fork (arch/x86/kernel/process.c:158)
ret_from_fork_asm (arch/x86/entry/entry_64.S:245)
</TASK>
Allocated by task 12:
__kasan_kmalloc (mm/kasan/common.c:398 mm/kasan/common.c:415)
__kmalloc_node_track_caller_noprof
(mm/slub.c:5414 mm/slub.c:5545)
kmemdup_noprof (mm/util.c:138)
cm_event_handler
(drivers/infiniband/core/iwcm.c:194
drivers/infiniband/core/iwcm.c:1076)
siw_cm_upcall (drivers/infiniband/sw/siw/siw_cm.c:408)
siw_proc_mpareq (drivers/infiniband/sw/siw/siw_cm.c:750)
siw_cm_work_handler (drivers/infiniband/sw/siw/siw_cm.c:1086) The buggy address is located 0 bytes to the right of allocated 6-byte region [ff1100010459d360, ff1100010459d366)
--- drivers/nvme/target/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/rdma.c +1 -1
@@ -1392,7 +1392,7 @@ nvmet_rdma_parse_cm_connect_req(struct rdma_conn_param *conn,struct nvme_rdma_cm_req *req; req = (struct nvme_rdma_cm_req *)conn->private_data; -if (!req || conn->private_data_len ==0 ) +if (!req || conn->private_data_len <sizeof (*req))return NVME_RDMA_CM_INVALID_LEN ;if (le16_to_cpu (req->recfmt) !=NVME_RDMA_CM_FMT_1_0 )
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 599/1848 nvmet-fc: only send read data for successful commands
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrea Parri <[email protected]>
[ Upstream commit 94f93c61b1a5dd08d011be58172ce4392b849008 ]
When a read command completes with an error, __nvmet_fc_fcp_nvme_cmd_done() still pushes the whole data buffer to the host before the response. nvmet_fc_alloc_tgt_pgs() allocates that buffer with sgl_alloc() and no __GFP_ZERO, and a command rejected by nvmet_check_transfer_len() leaves it untouched, so the host receives stale target memory.
The buffer is as large as the data length in the command IU, so the amount of stale memory returned is up to the host.
The tcp and rdma targets send data only when cqe->status is zero (see nvmet_tcp_need_data_out() and nvmet_rdma_need_data_out()), so no nvmet command can rely on returning data with an error status. Do the same for fc. The ERSP then reports a transferred length of fod->offset, which is 0, matching what nvme_fc_fcpio_done() checks on the host.
Tested over nvme-fcloop: a failed read command no longer transfers data and still completes with its error status, and successful reads are unaffected.
--- drivers/nvme/target/fc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/nvme/target/fc.c +4 -4
@@ -2451,11 +2451,11 @@ __nvmet_fc_fcp_nvme_cmd_done(struct nvmet_fc_tgtport *tgtport, }else {/* -* try to push the data even if the SQE status is non-zero. -* There may be a status where data still was intended to -* be moved +* A failed command may not have filled its read buffer, so +* only push data for success, as the tcp and rdma targets do. */ -if ((fod->io_dir ==NVMET_FCP_READ ) && (fod->data_sg_cnt)) { +if (fod->io_dir ==NVMET_FCP_READ && fod->data_sg_cnt && + !cqe->status) {/* push the data over before sending rsp */ nvmet_fc_transfer_fcp_data (tgtport, fod,NVMET_FCOP_READDATA );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 600/1848 nvmet: Finish the blk plug when integrity allocation fails
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Guixin Liu <[email protected]>
[ Upstream commit 18fc5f6f1ca945630dae5404265de55d65194e22 ]
nvmet_bdev_execute_rw() starts a plug before building the bios, but the two error exits taken when nvmet_bdev_alloc_bip() fails return without calling blk_finish_plug(). current->plug is left pointing at the stack frame of the returned function, so the next blk_flush_plug() walks a stale list.
Route both failures through a common exit that finishes the plug.
--- drivers/nvme/target/io-cmd-bdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/nvme/target/io-cmd-bdev.c +3 -2
@@ -285,7 +285,7 @@ static void nvmet_bdev_execute_rw(struct nvmet_req *req) &prot_miter);if (unlikely (rc)) {bio_io_error (bio); -return ; + goto out_plug; } }
@@ -306,11 +306,12 @@ static void nvmet_bdev_execute_rw(struct nvmet_req *req) rc =nvmet_bdev_alloc_bip (req, bio, &prot_miter);if (unlikely (rc)) {bio_io_error (bio); -return ; + goto out_plug; } }submit_bio (bio); +out_plug:blk_finish_plug (&plug); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 601/1848 kgdb: Fix buffer overflow in the m packet handler
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Fang Xieyan <[email protected]>
[ Upstream commit ac0159129e2cb99a70c4b80cfbf58d03e092dc7b ]
gdb_cmd_memread() passes the length of the 'm' packet straight to kgdb_mem2hex(), which hex-encodes the reply into remcom_out_buffer[BUFMAX] without checking that the reply fits. A client on the KGDB I/O console can ask for a read of any size, and the hex encoding runs off the end of the buffer. kgdb_mem2hex() takes that length as an int count, so 2^31 truncates to a negative value and copy_from_kernel_nofault() is handed buf + count as its destination.
On x86 BUFMAX is 1024, so a read of 512 bytes overruns by the single byte that terminates the hex string:
BUG: KASAN: global-out-of-bounds in kgdb_mem2hex+0x1dd/0x230 Write of size 1 at addr ffffffff87651780 by task sh/1 ... The buggy address belongs to the variable: remcom_out_buffer+0x400/0x420
Bounds check the length before the hex encoding:
if (length > (BUFMAX - 1) / 2) {
error_packet(remcom_out_buffer, -EINVAL);
return;
}gdbstub_msg_write() already bounds the count it hex-encodes against BUFMAX. Reads over the limit never returned valid data, so an error reply loses nothing.
--- kernel/debug/gdbstub.c | 8 ++++++++ 1 file changed, 8 insertions(+)
kernel/debug/gdbstub.c +8 -0
@@ -564,6 +564,14 @@ static void gdb_cmd_memread(struct kgdb_state *ks)if (kgdb_hex2long (&ptr, &addr) >0 && *ptr++ ==',' &&kgdb_hex2long (&ptr, &length) >0 ) { +/* +* The hex-encoded reply needs 2 * length + 1 bytes +* in remcom_out_buffer[BUFMAX]. +*/ +if (length > (BUFMAX -1 ) /2 ) { +error_packet (remcom_out_buffer, -EINVAL ); +return ; + } err =kgdb_mem2hex ((char *)addr, remcom_out_buffer, length);if (!err)error_packet (remcom_out_buffer, -EINVAL );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 602/1848 kgdb: Fix buffer overflow in the qRcmd packet handler
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Fang Xieyan <[email protected]>
[ Upstream commit 9ca9e8c857b55a081d5a1f8039b27cbb4d646b49 ]
gdb_cmd_query() decodes the hex payload of a qRcmd packet (the GDB "monitor" command passthrough to kdb) into remcom_out_buffer and hands it to kdb_parse(). It sizes the decode with strlen() of the payload:
int len = strlen(remcom_in_buffer + 6); ... kgdb_hex2mem(remcom_in_buffer + 6, remcom_out_buffer, len); len = len / 2;
kgdb_hex2mem() takes count as the number of bytes to produce and decodes them in place at buf, reading and writing 2 * count bytes there. len here is the hex character count, twice the decoded size, so the decode runs over 2 * len bytes at remcom_in_buffer + 6, off the end of the buffer. On x86 BUFMAX is 1024, so a 256-byte monitor command (512 hex characters) overruns remcom_in_buffer during the in-place decode:
BUG: KASAN: global-out-of-bounds in kgdb_hex2mem+0x131/0x160 Read of size 1 at addr ffffffff8765ef05 by task sh/1 ... kgdb_hex2mem+0x131/0x160 gdb_serial_stub+0x16d4/0x3170 kgdb_cpu_enter+0xb68/0x1520 ... The buggy address belongs to the variable: remcom_in_buffer+0x405/0x420
Halve len before the call so kgdb_hex2mem() gets the decoded byte count. It then reads the len hex characters already in remcom_in_buffer and writes len / 2 bytes, all inside the buffer, and remcom_out_buffer holds the same command as before.
--- kernel/debug/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/debug/gdbstub.c +1 -1
@@ -787,9 +787,9 @@ static void gdb_cmd_query(struct kgdb_state *ks)strcpy (remcom_out_buffer,"E01" );break ; } + len = len /2 ;kgdb_hex2mem (remcom_in_buffer +6 , remcom_out_buffer, len); - len = len /2 ; remcom_out_buffer[len++] =0 ;kdb_common_init_state (ks);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 603/1848 mount: refuse setns() with a shared fs_struct again
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josef Bacik <[email protected]>
[ Upstream commit 948e604aca8af30490accf7d46d44814ffa26f80 ]
mntns_install() refuses to switch the mount namespace of a task that shares its fs_struct, since root and cwd of the others would move to a namespace they are not in. It looks at nsset->fs for that. If more than the mount namespace is asked for, that is a private copy made by prepare_nsset(), which has one user by definition; commit_nsset() then writes root and cwd of the copy to the fs_struct of the task.
A thread of a process with two threads, pidfd of a task in another mount namespace:
setns(pidfd, CLONE_NEWNS) -EINVAL
setns(pidfd, CLONE_NEWNS | CLONE_NEWUTS) 0
and after the second call the other thread, still in the old mount namespace, has lost its cwd (/tmp became /) and sees the mounts of the other namespace under /.
Look at the fs_struct that is going to be changed. The second call then fails with -EINVAL like the first one.
--- fs/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
@@ -4259,7 +4259,7 @@ static int mntns_install(struct nsset *nsset, struct ns_common *ns)if (is_anon_ns (mnt_ns))return -EINVAL ; -if (fs->users !=1 ) +if (current->fs->users !=1 )return -EINVAL ;get_mnt_ns (mnt_ns);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 604/1848 blk-iocost: abort weight transfer on invalid donation weights
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kunhai Dai <[email protected]>
[ Upstream commit c810ee88cdab27f443c32270dc7c0eaad2cca3f8 ]
transfer_surpluses() warns and then keeps going when the donation calculation produced invalid weights. The following propagation can then divide by a zero hweight_inuse, so the warning is immediately followed by a divide error.
When the check trips, abandon this period's donation transfer and release the walk lists. This trades one period without donation for not crashing; the invalid state is not expected on the normal path.
Developed with assistance from Claude Code (Anthropic): the assistant analysed the failure path, drafted the change and ran the checks listed below. The author reviewed the result and remains responsible for it.
--- block/blk-iocost.c | 2 ++ 1 file changed, 2 insertions(+)
block/blk-iocost.c +2 -0
@@ -1914,6 +1914,7 @@ static void transfer_surpluses(struct list_head *surpluses, struct ioc_now *now)pr_cont (": active=%u donating=%u after=%u\n" , iocg->hweight_active, iocg->hweight_donating, iocg->hweight_after_donation); + goto out; } }
@@ -2012,6 +2013,7 @@ static void transfer_surpluses(struct list_head *surpluses, struct ioc_now *now)__propagate_weights (iocg, iocg->active, inuse, true, now); } +out:/* walk list should be dissolved after use */ list_for_each_entry_safe (iocg, tiocg, &inner_walk, walk_list)list_del_init (&iocg->walk_list);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 605/1848 tcp: check congestion control restriction first
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Zhiling Zou <[email protected]>
[ Upstream commit dda51b73721684637ab8e9bd97c78228b99c4bd2 ]
tcp_set_default_congestion_control() takes a reference to an algorithm before checking whether a non-init network namespace may select it. A rejected request returns -EPERM without dropping the reference.
This affects module-backed algorithms too; BPF is not required. For example, after root loads tcp_bbr, a user with CAP_NET_ADMIN in a non-init network namespace can repeatedly request it as the default although it is not in tcp_allowed_congestion_control. Each rejected write leaks a module reference. Since module->refcnt is an atomic_t, 2^31 such writes can make it negative; later module_put() calls warn, and rmmod can hit the BUG_ON() in try_release_module_ref().
Check the namespace restriction before acquiring the reference, as tcp_set_congestion_control() already does.
--- net/ipv4/tcp_cong.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/ipv4/tcp_cong.c +2 -2
@@ -228,12 +228,12 @@ int tcp_set_default_congestion_control(struct net *net, const char *name) ca =tcp_ca_find_autoload (net, name);if (!ca) { ret = -ENOENT ; - }else if (!bpf_try_module_get (ca, ca->owner)) { - ret = -EBUSY ; }else if (!net_eq (net, &init_net) && !(ca->flags &TCP_CONG_NON_RESTRICTED )) {/* Only init netns can set default to a restricted algorithm */ ret = -EPERM ; + }else if (!bpf_try_module_get (ca, ca->owner)) { + ret = -EBUSY ; }else { prev =xchg (&net->ipv4.tcp_congestion_control, ca);if (prev)
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 606/1848 tcp: fix reordering addition overflow in MTU probing
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kyle Zeng <[email protected]>
[ Upstream commit c1df9c0c0536393de43310f84ca4f8b217271a00 ]
Commit efb8763d7bbb ("net: ipv4: bound TCP reordering sysctl writes and MTU probe sizes") widened size_needed and the MSS multiplication, but tp->reordering + 1 is still evaluated as u32. RTAX_REORDERING accepts an unrestricted u32, and tcp_init_metrics() can install U32_MAX.
In that case the extra-data requirement becomes zero. A write queue with probe_size - 1 data bytes and a FIN satisfies the sequence-space check. The coalescing walk can pass the queue head to tcp_skb_can_collapse(), and tcp_clone_payload() can produce an skb whose advertised payload exceeds the data in its fragments. Local delivery followed by TCP_ZEROCOPY_RECEIVE can then walk beyond the fragment array. KASAN reports a slab-out-of-bounds read in can_map_frag().
Cast reordering before incrementing it so the arithmetic handles the entire u32 metric range. For U32_MAX, the required size exceeds the 32-bit queue and window limits, so the existing checks skip the probe. The calculation is unchanged for all other reordering values.
--- net/ipv4/tcp_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/tcp_output.c +1 -1
@@ -2367,7 +2367,7 @@ static int tcp_mtu_probe(struct sock *sk) mss_now =tcp_current_mss (sk); probe_size =tcp_mtu_to_mss (sk, (icsk->icsk_mtup.search_high + icsk->icsk_mtup.search_low) >>1 ); - size_needed = probe_size + (tp->reordering +1 ) * (u64 )tp->mss_cache; + size_needed = probe_size + ((u64 )tp->reordering +1 ) * tp->mss_cache; interval = icsk->icsk_mtup.search_high - icsk->icsk_mtup.search_low;/* When misfortune happens, we are reprobing actively, * and then reprobe timer has expired. We stick with current
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 607/1848 fs: skip copy_file_range write limits when there is no data
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hungyu Lin <[email protected]>
[ Upstream commit 81dfa035891f0502674332ee97db348a16486de0 ]
generic_copy_file_checks() reduces count to zero for a source offset at or beyond EOF, but still checks the destination write limits. If pos_out is at RLIMIT_FSIZE, this sends SIGXFSZ and returns -EFBIG even though there is no data to write.
For example, GNU cat copying a 1024-byte regular file to another regular file with RLIMIT_FSIZE=1024 copies all bytes and is then killed by its next copy_file_range() call at EOF. A zero-length request can fail in the same way.
Check write limits only when count is nonzero, as the ordinary write checks already do. Keep the other copy validation in place.
--- fs/read_write.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
fs/read_write.c +5 -3
@@ -1447,9 +1447,11 @@ static int generic_copy_file_checks(struct file *file_in, loff_t pos_in,else count =min (count, size_in - (uint64_t )pos_in); - ret =generic_write_check_limits (file_out, pos_out, &count); -if (ret) -return ret; +if (count) { + ret =generic_write_check_limits (file_out, pos_out, &count); +if (ret) +return ret; + }/* Don't allow overlapped copying within the same file. */ if (inode_in == inode_out &&
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 608/1848 wifi: brcmfmac: map msgbuf RX packet IDs bidirectional
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jason Perlow <[email protected]>
[ Upstream commit 7ed5dce55fa8393972b1bf2bf5af1c818c5e7dc2 ]
Commit f0ba5fd51ff2 ("wifi: brcmfmac: Set DMA direction for msgbuf packet IDs") maps the RX packet ID buffers DMA_FROM_DEVICE. The BCM4364 firmware also reads posted RX buffers, so with VT-d translation enabled every such read faults ("PTE Read access is not set") and the firmware crashes and resets in a loop.
Map the RX pool DMA_BIDIRECTIONAL again, as before that commit. TX keeps DMA_TO_DEVICE.
--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c +1 -1
@@ -1617,7 +1617,7 @@ int brcmf_proto_msgbuf_attach(struct brcmf_pub *drvr)if (!msgbuf->tx_pktids) goto fail; msgbuf->rx_pktids =brcmf_msgbuf_init_pktids (NR_RX_PKTIDS , -DMA_FROM_DEVICE ); +DMA_BIDIRECTIONAL );if (!msgbuf->rx_pktids) goto fail;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 609/1848 smb: client: validate the data area in SMB2_read()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Abdifatah Suruur <[email protected]>
[ Upstream commit 2ec9cdf469dd32bcf33073aeb30c08e9356e0ca1 ]
SMB2_read() copies le32_to_cpu(rsp->DataLength) bytes from (char *)rsp + rsp->DataOffset without checking that the range lies within the response actually received. A READ response with DataOffset == 0 makes smb2_get_data_area_len() zero the data length, so smb2_check_message() accepts a frame as short as the fixed response, while SMB2_read() still uses the server-supplied DataLength, capped only by CIFS_MAX_MSGSIZE and the caller's length.
A malicious server can answer the synchronous read used by the mfsymlinks (or SFU) symlink parser with an 81-byte READ response carrying DataOffset 0 and DataLength 1067, making the client copy 1067 bytes from a 448-byte receive object (KASAN slab-out-of-bounds; up to 16 KiB in the general case).
Clamp a zero (or header-overlapping) DataOffset to read_rsp_size, as handle_read_data() does for the asynchronous path, and reject the response unless DataOffset + DataLength fits within rsp_iov.iov_len. The SMB1 helper was fixed the same way in 5be5bdda5863.
--- fs/cifs/smb2pdu.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)
fs/cifs/smb2pdu.c +22 -1
@@ -4162,6 +4162,7 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms,struct kvec iov[1 ];struct kvec rsp_iov;unsigned int total_len; +u16 data_offset;int flags =CIFS_LOG_ERROR ;struct cifs_ses *ses = io_parms->tcon->ses;
@@ -4218,8 +4219,28 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms, *nbytes =0 ; } + data_offset = rsp->DataOffset; +if (data_offset < io_parms->server->vals->read_rsp_size) { +/* +* win2k8 sometimes sends an offset of 0 when the read is beyond +* the EOF. Treat it as if the data starts just after the header, +* as handle_read_data() does. +*/ +cifs_dbg (FYI ,"data offset %u inside read response header\n" , + data_offset); + data_offset = io_parms->server->vals->read_rsp_size; + } + +/* The data area must lie within the response actually received */ +if (*nbytes && (size_t )data_offset + *nbytes > rsp_iov.iov_len) { +cifs_dbg (FYI ,"bad data offset %u length %u for response of %zu\n" , + data_offset, *nbytes, rsp_iov.iov_len); + rc = -EIO ; + *nbytes =0 ; + } +if (*buf) { -memcpy (*buf, (char *)rsp + rsp->DataOffset, *nbytes); +memcpy (*buf, (char *)rsp + data_offset, *nbytes);free_rsp_buf (resp_buftype, rsp_iov.iov_base); }else if (resp_buftype !=CIFS_NO_BUFFER ) { *buf = rsp_iov.iov_base;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 610/1848 NFSD: Set nn->cld_net before registering the cld pipe
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
[ Upstream commit 14996e662f3b734427e2d645cacffc27b779f7d1 ]
rpc_mkpipe_dentry() instantiates the pipe's dentry before it returns, so the cld pipe can be opened as soon as nfsd4_cld_register_net() has run. __nfsd4_init_cld_pipe() does not store the new cld_net in nn->cld_net until after that call. cld_pipe_downcall() reaches the cld_net only through that pointer and takes cn_lock without checking it, so a write() that lands in the window oopses.
Store nn->cld_net once @cn is fully initialized and before the pipe is registered, and clear it again when registration fails.
--- fs/nfsd/nfs4recover.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
fs/nfsd/nfs4recover.c +8 -2
@@ -1014,6 +1014,13 @@ __nfsd4_init_cld_pipe(struct net *net) }spin_lock_init (&cn->cn_lock);INIT_LIST_HEAD (&cn->cn_list); + cn->cn_has_legacy = false; + +/* +* The pipe's methods reach @cn through nn->cld_net, so set +* it before the pipe can be opened. +*/ + nn->cld_net = cn; dentry =nfsd4_cld_register_net (net, cn->cn_pipe);if (IS_ERR (dentry)) {
@@ -1022,11 +1029,10 @@ __nfsd4_init_cld_pipe(struct net *net) } cn->cn_pipe->dentry = dentry; - cn->cn_has_legacy = false; - nn->cld_net = cn;return 0 ; err_destroy_data: + nn->cld_net =NULL ;rpc_destroy_pipe_data (cn->cn_pipe); err:kfree (cn);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 611/1848 rxrpc: Fix update of call->tx_pending without holding lock
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Howells <[email protected]>
[ Upstream commit 7801c42c3bb737cfb06194a383873fcad8daacf5 ]
Currently, rxrpc_send_data() updates call->tx_pending just before it returns - but it won't be holding the call->user_mutex when it does this if a wait was interrupted by a signal. This would allow a parallel sendmsg() to race.
Further, both the callers of rxrpc_send_data() call it with the lock held, and then it returns an indication through the parameter list to say whether it has dropped the lock or not - after which the callers both just drop the lock if it's still held.
Fix this by:
(1) Moving the release of call->user_mutex down into rxrpc_send_data() and get rid of the indicator parameter. This makes it easier to see where the lock is held.
(2) After waiting, if the attempt to reacquire the mutex is interrupted, just return directly there rather than going to out_unlock
(3) Restricting the txb variable to inside the buffering loop and leaving
->tx_pending set until we've queued the buffer.
Note that there's a slight change in behaviour in that wait_for_space failure now doesn't check for completion because it doesn't hold the call user_mutex. The caller, however, should re-issue the send and pick up any error at a second attempt.
--- net/rxrpc/sendmsg.c | 57 ++++++++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 29 deletions(-)
net/rxrpc/sendmsg.c +28 -29
@@ -287,11 +287,10 @@ static int rxrpc_queue_packet(struct rxrpc_sock *rx, struct rxrpc_call *call,static int rxrpc_send_data (struct rxrpc_sock *rx,struct rxrpc_call *call,struct msghdr *msg,size_t len, -rxrpc_notify_end_tx_t notify_end_tx, -bool *_dropped_lock) +rxrpc_notify_end_tx_t notify_end_tx) + __releases(&call->user_mutex) {struct rxrpc_skb_priv *sp; -struct sk_buff *skb;struct sock *sk = &rx->sk;enum rxrpc_call_state state;long timeo;
@@ -325,11 +324,9 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, goto maybe_error; } - skb = call->tx_pending; - call->tx_pending =NULL ; -rxrpc_see_skb (skb, rxrpc_skb_seen); - do { + struct sk_buff *skb = call->tx_pending; + /* Check to see if there's a ping ACK to reply to. */ if (call->ackr_reason == RXRPC_ACK_PING_RESPONSE) rxrpc_send_ack_packet(call, false, NULL);
@@ -386,6 +383,9 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, sp->remain); skb->ip_summed =CHECKSUM_UNNECESSARY ; + call->tx_pending = skb; + }else { +rxrpc_see_skb (skb, rxrpc_skb_seen); }_debug ("append" );
@@ -449,13 +449,13 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, ret = call->security->secure_packet ( call, skb, skb->mark, skb->head);if (ret <0 ) - goto out; + goto out_unlock; ret =rxrpc_queue_packet (rx, call, skb, !msg_data_left (msg) && !more, notify_end_tx);/* Should check for failure here */ - skb =NULL ; + call->tx_pending =NULL ; } }while (msg_data_left (msg) >0 );
@@ -467,45 +467,46 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, ret = call->error;read_unlock_bh (&call->state_lock); } -out: - call->tx_pending = skb; +out_unlock: +mutex_unlock (&call->user_mutex);_leave (" = %d" , ret);return ret; call_terminated: -rxrpc_free_skb (skb, rxrpc_skb_freed); -_leave (" = %d" , call->error); -return call->error; + ret = call->error; + goto out_unlock; maybe_error:if (copied) goto success; - goto out; + goto out_unlock; efault: ret = -EFAULT ; - goto out; + goto out_unlock; wait_for_space: ret = -EAGAIN ;if (msg->msg_flags &MSG_DONTWAIT ) goto maybe_error;mutex_unlock (&call->user_mutex); - *_dropped_lock = true; + ret =rxrpc_wait_for_tx_window (rx, call, &timeo, msg->msg_flags &MSG_WAITALL );if (ret <0 ) - goto maybe_error; + goto out_nolock;if (call->interruptibility ==RXRPC_INTERRUPTIBLE ) {if (mutex_lock_interruptible (&call->user_mutex) <0 ) { ret =sock_intr_errno (timeo); - goto maybe_error; + goto out_nolock; } }else {mutex_lock (&call->user_mutex); } - *_dropped_lock = false; goto reload; +out_nolock: +_leave (" = %d [intr]" , ret); +return copied ?: ret; }/*
@@ -667,7 +668,6 @@ int rxrpc_do_sendmsg(struct rxrpc_sock *rx, struct msghdr *msg, size_t len)enum rxrpc_call_state state;struct rxrpc_call *call;unsigned long now, j; -bool dropped_lock = false;int ret;struct rxrpc_send_params p = {
@@ -777,12 +777,12 @@ int rxrpc_do_sendmsg(struct rxrpc_sock *rx, struct msghdr *msg, size_t len) }else if (p.command !=RXRPC_CMD_SEND_DATA ) { ret = -EINVAL ; }else { - ret =rxrpc_send_data (rx, call, msg, len,NULL , &dropped_lock); + ret =rxrpc_send_data (rx, call, msg, len,NULL ); + goto error_put; } out_put_unlock: -if (!dropped_lock) -mutex_unlock (&call->user_mutex); +mutex_unlock (&call->user_mutex); error_put:rxrpc_put_call (call, rxrpc_call_put);_leave (" = %d" , ret);
@@ -810,7 +810,6 @@ int rxrpc_kernel_send_data(struct socket *sock, struct rxrpc_call *call, struct msghdr *msg, size_t len, rxrpc_notify_end_tx_t notify_end_tx) { - bool dropped_lock = false; int ret;_enter ("{%d,%s}," , call->debug_id, rxrpc_call_states[call->state]);
@@ -828,8 +827,8 @@ int rxrpc_kernel_send_data(struct socket *sock, struct rxrpc_call *call,case RXRPC_CALL_SERVER_ACK_REQUEST :case RXRPC_CALL_SERVER_SEND_REPLY : ret =rxrpc_send_data (rxrpc_sk (sock->sk), call, msg, len, - notify_end_tx, &dropped_lock); -break ; + notify_end_tx); + goto out;case RXRPC_CALL_COMPLETE :read_lock_bh (&call->state_lock); ret = call->error;
@@ -842,8 +841,8 @@ int rxrpc_kernel_send_data(struct socket *sock, struct rxrpc_call *call,break ; } -if (!dropped_lock) -mutex_unlock (&call->user_mutex); +mutex_unlock (&call->user_mutex); +out:_leave (" = %d" , ret);return ret; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 612/1848 SUNRPC: fix oversized GSS proxy token copy
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jérémy Jean <[email protected]>
[ Upstream commit 62319c2534b603b416fa2aa2f3ef18c311f75010 ]
gss_read_proxy_verf() allocates one page per token chunk, but it copies the entire linear head of an RPC request into in_token->pages[0]. A UDP datagram can leave more than PAGE_SIZE bytes in the linear head, so a large RPCSEC_GSS INIT token overwrites following pages.
Copy the linear head in page-sized chunks before switching to the request page array. The linear head itself can span multiple pages.
--- net/sunrpc/auth_gss/svcauth_gss.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
net/sunrpc/auth_gss/svcauth_gss.c +4 -3
@@ -1183,10 +1183,11 @@ static int gss_read_proxy_verf(struct svc_rqst *rqstp, } length = min_t(unsigned int, inlen, argv->iov_len); -if (length) -memcpy (page_address (in_token->pages[0 ]), argv->iov_base, length); +for (to_offs =0 ; to_offs < length; to_offs +=PAGE_SIZE ) +memcpy (page_address (in_token->pages[to_offs >>PAGE_SHIFT ]), + (char *)argv->iov_base + to_offs, + min_t(unsigned int, length - to_offs, PAGE_SIZE)); inlen -= length; - to_offs = length; from_offs = rqstp->rq_arg.page_base;while (inlen) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 613/1848 ALSA: x86: hdmi: fix chmap array missing terminator entry
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit f5e1a9a3fddab8421416b68bb132ae9626d07156 ]
had_build_channel_allocation_map() allocates a single struct snd_pcm_chmap_elem via kzalloc() and stores it as intelhaddata->chmap->chmap. struct snd_pcm_chmap.chmap is expected to be a zero-terminated array (see snd_pcm_std_chmaps[]), but had_register_chmap_ctls() never overrides the TLV callback installed by snd_pcm_add_chmap_ctls(), so the generic pcm_chmap_ctl_tlv() from ALSA core is left in place.
pcm_chmap_ctl_tlv() is reachable by any local user via SNDRV_CTL_IOCTL_TLV_READ on the "Playback Channel Map" control and walks the array with "for (map = info->chmap; map->channels; map++)". Since the driver's single element is never terminated, this walks past the allocation. The same pointer is also freed on hot-unplug and rebuilt on hot-plug under intelhaddata->mutex, while the TLV callback runs under card->controls_rwsem without that mutex, so the walk can also race a concurrent free of the array.
Fix this by allocating a second, zeroed element so the array is properly terminated, and by dropping the inherited TLV callback entirely at registration time, since the driver never implements one of its own.
--- sound/x86/intel_hdmi_audio.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
sound/x86/intel_hdmi_audio.c +8 -1
@@ -476,7 +476,8 @@ static void had_build_channel_allocation_map(struct snd_intelhad *intelhaddata)kfree (intelhaddata->chmap->chmap); intelhaddata->chmap->chmap =NULL ; - chmap =kzalloc (sizeof (*chmap),GFP_KERNEL ); +/* info->chmap must be zero-terminated; allocate a spare terminator entry */ + chmap =kcalloc (2 ,sizeof (*chmap),GFP_KERNEL );if (!chmap)return ;
@@ -579,6 +580,12 @@ static int had_register_chmap_ctls(struct snd_intelhad *intelhaddata, intelhaddata->chmap->kctl->info = had_chmap_ctl_info; intelhaddata->chmap->kctl->get = had_chmap_ctl_get; intelhaddata->chmap->chmap =NULL ; + +/* drop the inherited TLV read: it walks chmap without our mutex */ + intelhaddata->chmap->kctl->tlv.c =NULL ; + intelhaddata->chmap->kctl->vd[0 ].access &= + ~(SNDRV_CTL_ELEM_ACCESS_TLV_READ |SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK ); +return 0 ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 614/1848 nvmet-rdma: fix out-of-bounds write in nvmet_rdma_map_sgl_inline()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrew Stellman <[email protected]>
[ Upstream commit d1512773a0d539669440bd9f6d050b8e12923b5f ]
nvmet_rdma_map_sgl_inline() bounds the host-supplied in-capsule SGL offset with "off + len > inline_data_size", evaluated in 64-bit arithmetic. off is taken straight from the host SGL descriptor (le64_to_cpu(sgl->addr)) and len is promoted to 64-bit, so the sum
wraps: an off within len of 2^64 makes it small and the check passes. off is then used as page_idx = off / PAGE_SIZE to index the fixed-size rsp->cmd->inline_sg[] array (NVMET_RDMA_MAX_INLINE_SGE entries), so a crafted offset yields an out-of-bounds scatterlist index that is written through in nvmet_rdma_use_inline_sg().
The mapping runs while handling a received capsule, before the command executes, so a remote RDMA peer can reach it (the Connect capsule is a write and takes this path on a queue that has no controller yet). The host controls only the low bits of the resulting displacement, so the expected impact is an out-of-bounds write that faults the target (remote denial of service).
This wrap was reported, with a KASAN reproduction, on linux-nvme in May, and the check below was suggested in that thread. The fix that was applied, 48c0162f647b, reworked how the offset is mapped but kept the original check, and its page index turns a wrapped offset into an out-of-bounds index into inline_sg[].
Reject the offset before it can wrap.
Found independently by static analysis with AI assistance, not reproduced at runtime.
--- drivers/nvme/target/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/nvme/target/rdma.c +2 -1
@@ -862,7 +862,8 @@ static u16 nvmet_rdma_map_sgl_inline(struct nvmet_rdma_rsp *rsp)return NVME_SC_INVALID_FIELD |NVME_SC_DNR ; } -if (off + len > rsp->queue->dev->inline_data_size) { +if (off > (u64 )rsp->queue->dev->inline_data_size || + len > (u64 )rsp->queue->dev->inline_data_size - off) {pr_err ("invalid inline data offset!\n" );return NVME_SC_SGL_INVALID_OFFSET |NVME_SC_DNR ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 615/1848 net: limit priority VLAN untag depth
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kamil Sawicki <[email protected]>
[ Upstream commit d3ff07f5acc573e5f72bf1c581bae5d05191ba61 ]
The priority VLAN receive path can repeatedly remove VID 0 tags and retry packet processing. Unlike the read-only VLAN protocol parser, this path has no limit on the number of nested tags it consumes.
Each skb_vlan_untag() advances skb->data and resets header offsets. The offsets are stored in 16-bit fields. With enough nested tags, the network or transport offset can wrap. A later protocol handler can then derive a large pull length from the wrapped offsets and access memory outside the skb allocation.
Apply the existing VLAN_MAX_DEPTH limit to the exceptional VID 0 retry. Count the tag already stored in skb VLAN metadata as the first level, then stop before untagging a ninth level. Keep the accounting inside this uncommon branch so the regular VLAN receive path is unaffected.
A single VID 0 priority tag before a real VLAN tag is valid. No normal deployment was found that intentionally emits multiple consecutive VID 0 tags; permitting eight levels is therefore conservative.
The issue was found while researching the Linux network receive path for Google kvmCTF, with OpenAI Codex (gpt-5.6-sol) assisting the analysis. The affected path, reproducer and fix were manually reviewed and tested.
[ Backport to 5.10.y: __netif_receive_skb_core() has no local
drop_reason variable, and this branch does not define SKB_DROP_REASON_RECURSION_LIMIT. Omit the upstream assignment and keep the existing drop path, which frees the skb with kfree_skb(). ]
--- net/core/dev.c | 6 ++++++ 1 file changed, 6 insertions(+)
net/core/dev.c +6 -0
@@ -5315,6 +5315,8 @@ static int __netif_receive_skb_core(struct sk_buff **pskb, bool pfmemalloc, }if (unlikely (skb_vlan_tag_present (skb)) && !netdev_uses_dsa (skb->dev)) { +unsigned int priority_tag_depth =1 ; + check_vlan_id:if (skb_vlan_tag_get_id (skb)) {/* Vlan id is non 0 and vlan_do_receive() above couldn't
@@ -5327,6 +5329,10 @@ static int __netif_receive_skb_core(struct sk_buff **pskb, bool pfmemalloc,* 802.1Q or 802.1AD and vlan_do_receive() above could * not find vlan dev for vlan id 0. */ +if (unlikely (priority_tag_depth >=VLAN_MAX_DEPTH )) + goto drop; + + priority_tag_depth++;__vlan_hwaccel_clear_tag (skb); skb =skb_vlan_untag (skb);if (unlikely (!skb))
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 616/1848 smb: client: hold server info until cifsd exits
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eduard Zateev <[email protected]>
[ Upstream commit 482c117c6dbeee382790168af10959810450ab09 ]
The last session reference can be dropped while the cifsd demultiplex thread is still running clean_demultiplex_info(). That thread frees TCP_Server_Info there, racing with cifs_put_tcp_session() as it releases the server crypto state. syzbot reported a KASAN use-after-free in cifs_crypto_secmech_release().
Keep an object reference for the cifsd thread. Defer final crypto, session-key, network namespace, string, and structure cleanup until both the last session reference and the thread reference are dropped. Drop the thread reference after clean_demultiplex_info() has finished using the server.
Build-tested with ARCH=arm64 and W=1 for fs/smb/client/connect.o. The KASAN reproducer was not run on the patched kernel.
--- fs/cifs/cifsglob.h | 2 ++ fs/cifs/connect.c | 29 +++++++++++++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-)
fs/cifs/cifsglob.h +2 -0
@@ -25,6 +25,7 @@#include <linux/scatterlist.h> #include <linux/mm.h> #include <linux/mempool.h> +#include <linux/refcount.h> #include <linux/workqueue.h> #include <linux/fcntl.h> #include "cifs_fs_sb.h"
@@ -674,6 +675,7 @@ struct TCP_Server_Info {struct list_head tcp_ses_list;struct list_head smb_ses_list;int srv_count;/* reference counter */ +refcount_t obj_refs;/* struct lifetime: srv_count users + cifsd */ /* 15 character server name + 0x20 16th byte indicating type = srv */ char server_RFC1001_name[RFC1001_NAME_LEN_WITH_NULL ];struct smb_version_operations *ops;
fs/cifs/connect.c +19 -10
@@ -880,6 +880,18 @@ handle_mid(struct mid_q_entry *mid, struct TCP_Server_Info *server,dequeue_mid (mid, malformed); } +static void cifs_tcp_server_put (struct TCP_Server_Info *server) +{ +if (!refcount_dec_and_test (&server->obj_refs)) +return ; + +cifs_crypto_secmech_release (server); +kfree_sensitive (server->session_key.response); +put_net (cifs_net_ns (server)); +kfree (server->hostname); +kfree_sensitive (server); +} +static void clean_demultiplex_info (struct TCP_Server_Info *server) {int length;
@@ -964,12 +976,11 @@ static void clean_demultiplex_info(struct TCP_Server_Info *server)*/ } -kfree (server->hostname); -kfree (server); - length =atomic_dec_return (&tcpSesAllocCount);if (length >0 )mempool_resize (cifs_req_poolp, length + cifs_min_rcv); + +cifs_tcp_server_put (server); } static int
@@ -2498,8 +2509,6 @@ cifs_put_tcp_session(struct TCP_Server_Info *server, int from_reconnect)return ; } -put_net (cifs_net_ns (server)); -list_del_init (&server->tcp_ses_list);spin_unlock (&cifs_tcp_ses_lock);
@@ -2520,16 +2529,13 @@ cifs_put_tcp_session(struct TCP_Server_Info *server, int from_reconnect) server->tcpStatus = CifsExiting;spin_unlock (&GlobalMid_Lock); -cifs_crypto_secmech_release (server);cifs_fscache_release_client_cookie (server); -kfree (server->session_key.response); - server->session_key.response =NULL ; - server->session_key.len =0 ; - task =xchg (&server->tsk,NULL );if (task)send_sig (SIGKILL , task,1 ); + +cifs_tcp_server_put (server); } struct TCP_Server_Info *
@@ -2550,6 +2556,7 @@ cifs_get_tcp_session(struct smb_vol *volume_info) rc = -ENOMEM ; goto out_err; } +refcount_set (&tcp_ses->obj_refs,1 ); tcp_ses->ops = volume_info->ops; tcp_ses->vals = volume_info->vals;
@@ -2637,6 +2644,8 @@ cifs_get_tcp_session(struct smb_vol *volume_info)* this will succeed. No need for try_module_get(). */ __module_get (THIS_MODULE ); +/* Keep the server alive until the demultiplex thread has exited */ +refcount_inc (&tcp_ses->obj_refs); tcp_ses->tsk =kthread_run (cifs_demultiplex_thread, tcp_ses,"cifsd" );if (IS_ERR (tcp_ses->tsk)) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 617/1848 ovl: take a snapshot of the name for copy up
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Mason <[email protected]>
[ Upstream commit 65bf000962a33ec9d2488e4e1797b6cf630abcbb ]
The copy up of a directory reads a freed dentry name when a lookup moves the directory at the same time.
A pointer to the name of a dentry is only valid while something stops a move of the dentry. ovl_do_copy_up() keeps a plain copy of c->dentry->d_name in c->destname, and ovl_copy_up_start() only keeps ovl_rename() away. When a lookup finds the same directory under another name after a change to the lower layer, d_splice_alias() moves the dentry and frees its external name.
With a delay in ovl_do_copy_up(), a chmod of a lower-only directory with a 60 byte name raced with a rename of that directory in the lower layer and a stat of the new name, and KASAN reported a use-after-free in lookup_noperm_common().
Fix this by using take_dentry_name_snapshot() for c->destname.
--- fs/overlayfs/copy_up.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
fs/overlayfs/copy_up.c +14 -2
@@ -709,6 +709,7 @@ static int ovl_do_copy_up(struct ovl_copy_up_ctx *c) {int err;struct ovl_fs *ofs = c->dentry->d_sb->s_fs_info; +struct name_snapshot name;bool to_index = false;/*
@@ -737,13 +738,23 @@ static int ovl_do_copy_up(struct ovl_copy_up_ctx *c)/* Disconnected dentry must be copied up to index dir */ return -EIO ; }else { +/* +* ovl_copy_up_start() keeps ovl_rename() away from c->dentry, +* because ovl_rename() calls ovl_copy_up() on source and target +* dentry. It does not stop d_splice_alias() from moving a +* directory that a lookup found under another name after a +* change to the lower layer. That move frees an external name, +* so take a snapshot. +*/ +take_dentry_name_snapshot (&name, c->dentry); + c->destname = name.name;/* * Mark parent "impure" because it may now contain non-pure * upper */ err =ovl_set_impure (c->parent, c->destdir);if (err) -return err; + goto out; }/* Should we copyup with O_TMPFILE or with workdir? */
@@ -775,6 +786,8 @@ static int ovl_do_copy_up(struct ovl_copy_up_ctx *c) out:if (to_index)kfree (c->destname.name); +else +release_dentry_name_snapshot (&name);return err; }
@@ -895,7 +908,6 @@ static int ovl_copy_up_one(struct dentry *parent, struct dentry *dentry,if (parent) {ovl_path_upper (parent, &parentpath); ctx.destdir = parentpath.dentry; - ctx.destname = dentry->d_name; err = vfs_getattr(&parentpath, &ctx.pstat, STATX_ATIME | STATX_MTIME,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 618/1848 ovl: do not copy up an xattr value that was never read
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Mason <[email protected]>
[ Upstream commit 755b5c5c9277be251a51623d6065abab948c61bc ]
Copy-up stores uninitialized kernel memory in an xattr of the upper file, where the user can read it.
ovl_copy_xattr() may only pass bytes to ovl_do_setxattr() that ovl_do_getxattr() has read. When the read fails with -ERANGE the function asks for the size again, and if the new size fits the buffer it stores the buffer although nothing was read into it. The buffer comes from kvmalloc(), or it still holds the value of the previous xattr.
A FUSE lower layer that answers every sized GETXATTR with -ERANGE made copy-up store 4096 bytes that the server never sent, with a kernel pointer in them, as an xattr of the upper file.
Fix this by failing the copy-up with -EIO when the size that follows -ERANGE fits the buffer.
--- fs/overlayfs/copy_up.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
fs/overlayfs/copy_up.c +5 -1
@@ -94,8 +94,12 @@ int ovl_copy_xattr(struct super_block *sb, struct dentry *old, } retry: size =vfs_getxattr (old, name, value, value_size); -if (size == -ERANGE ) +if (size == -ERANGE ) { size =vfs_getxattr (old, name,NULL ,0 ); +/* Nothing was read into value, so it must not be used */ +if (size >=0 && size <= value_size) + size = -EIO ; + }if (size <0 ) { error = size;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 619/1848 ovl: hold a reference on the parent in readdir
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Mason <[email protected]>
[ Upstream commit 16d319e12328acafeafd3eecdf09c46d7fb43452 ]
Listing a directory on an overlay uses a freed dentry and crashes the kernel when a lookup moves the directory at the same time.
Code that can sleep may only use d_parent without a reference while something stops a move of the dentry. ovl_iterate_real(), ovl_need_adjust_d_ino() and ovl_cache_update() use the d_parent of the listed directory and hold only the lock of that directory. When a lookup finds the directory under another parent after a change to a layer, d_splice_alias() moves it without that lock and drops its reference on the old parent.
With a delay in ovl_iterate_real(), getdents64 on an overlay directory raced a rename in the lower layer and a lookup that moved its dentry, and after an rmdir of the old parent KASAN reported a use-after-free in security_inode_getattr().
Fix this by using dget_parent() in the three functions.
--- fs/overlayfs/readdir.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-)
fs/overlayfs/readdir.c +18 -6
@@ -474,8 +474,8 @@ static int ovl_cache_update_ino(struct path *path, struct ovl_cache_entry *p) goto get; }if (p->len ==2 && p->name[1 ] =='.' ) { -/* we shall not be moved */ - this =dget (dir->d_parent); +/* d_splice_alias() can move even a locked dir */ + this =dget_parent (dir); goto get; } }
@@ -691,6 +691,7 @@ static int ovl_iterate_real(struct file *file, struct dir_context *ctx)struct ovl_dir_file *od = file->private_data;struct dentry *dir = file->f_path.dentry;const struct ovl_layer *lower_layer =ovl_layer_lower (dir); +struct dentry *parent;struct ovl_readdir_translate rdt = { .ctx.actor = ovl_fill_real, .orig_ctx = ctx,
@@ -701,18 +702,26 @@ static int ovl_iterate_real(struct file *file, struct dir_context *ctx)if (rdt.xinobits && lower_layer) rdt.fsid = lower_layer->fsid; -if (OVL_TYPE_MERGE (ovl_path_type (dir->d_parent))) { +/* +* The lock on dir does not stop d_splice_alias() from moving it to +* another parent, which drops the reference dir holds on this one. +*/ + parent =dget_parent (dir); +if (OVL_TYPE_MERGE (ovl_path_type (parent))) {struct kstat stat;struct path statpath = file->f_path; - statpath.dentry = dir->d_parent; + statpath.dentry = parent; err =vfs_getattr (&statpath, &stat,STATX_INO ,0 ); -if (err) +if (err) { +dput (parent);return err; + }WARN_ON_ONCE (dir->d_sb->s_dev != stat.dev); rdt.parent_ino = stat.ino; } +dput (parent);if (ovl_is_impure_dir (file)) { rdt.cache =ovl_cache_get_impure (&file->f_path);
@@ -740,6 +749,8 @@ static int ovl_iterate(struct file *file, struct dir_context *ctx)ovl_dir_reset (file);if (od->is_real) { +struct dentry *parent =dget_parent (dentry); +/* * If parent is merge, then need to adjust d_ino for '..', if * dir is impure then need to adjust d_ino for copied up
@@ -748,11 +759,12 @@ static int ovl_iterate(struct file *file, struct dir_context *ctx)if (ovl_xino_bits (dentry->d_sb) || (ovl_same_fs (dentry->d_sb) && (ovl_is_impure_dir (file) || -OVL_TYPE_MERGE (ovl_path_type (dentry->d_parent))))) { +OVL_TYPE_MERGE (ovl_path_type (parent))))) { err =ovl_iterate_real (file, ctx); }else { err =iterate_dir (od->realfile, ctx); } +dput (parent); goto out; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 620/1848 ovl: do not copy up a dentry that was removed
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Mason <[email protected]>
[ Upstream commit f635192ad223d2009ee640b63adf5ce3198aa338 ]
A change to a removed file through an open descriptor replaces whatever has its old name in the upper layer.
Copy up must only create a name in the upper directory, never replace one. After an unlink, an rmdir or a rename over a lower dentry, a dentry that an open file keeps alive still has its old parent and name, but in the upper directory that name is now a whiteout or a new object. ovl_copy_up_workdir() renames the copy over it, which brings back the removed object and destroys whatever took its name.
An unprivileged user opened a lower FIFO and unlinked it, root created a file at that name, and fchmod on the old descriptor replaced the file of root with the FIFO.
Fix this by looking up the target name of the rename in ovl_copy_up_workdir() with LOOKUP_EXCL, so that copy up fails with -EEXIST if the name is taken, as copy up with O_TMPFILE already does when it links the copy to the name.
--- fs/overlayfs/copy_up.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/overlayfs/copy_up.c +4 -1
@@ -626,7 +626,10 @@ static int ovl_copy_up_workdir(struct ovl_copy_up_ctx *c)if (IS_ERR (upper)) goto cleanup; - err =ovl_do_rename (wdir, temp, udir, upper,0 ); +/* The name may have been taken since lookup, never replace it */ + err = -EEXIST ; +if (d_is_negative (upper)) + err =ovl_do_rename (wdir, temp, udir, upper,0 );dput (upper);if (err) goto cleanup;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 621/1848 ovl: check that the parents of volatile/dirty are dirs
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Mason <[email protected]>
[ Upstream commit e34d2ef818e4c7676d8d8e1bf43e6a1ed39efb2a ]
An unprivileged user crashes the kernel by mounting overlayfs with the volatile option.
A dentry that serves as the parent of a lookup must be a directory. ovl_create_volatile_dirty() walks work/incompat/volatile/dirty by name, and ovl_lookup_or_create() returns an existing entry whatever its type. A file or a symlink that another task creates during the mount becomes the parent of the next lookup, which calls a NULL ->lookup.
An unprivileged user mounted overlayfs with "volatile" in a user namespace while a second process created a symlink named work/incompat, and the mount task oopsed on a NULL ->lookup call.
Fix this by returning -ENOTDIR from ovl_lookup_or_create() when the caller asked for a directory and the existing entry is a non-dir.
--- fs/overlayfs/super.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
fs/overlayfs/super.c +12 -5
@@ -1242,16 +1242,23 @@ static int ovl_check_rename_whiteout(struct dentry *workdir) }static struct dentry *ovl_lookup_or_create (struct dentry *parent, -const char *name,umode_t mode) +const char *name,bool is_dir) {size_t len =strlen (name);struct dentry *child;inode_lock_nested (parent->d_inode,I_MUTEX_PARENT ); child =lookup_one_len (name, parent, len); -if (!IS_ERR (child) && !child->d_inode) - child =ovl_create_real (parent->d_inode, child, -OVL_CATTR (mode)); +if (!IS_ERR (child)) { +if (!child->d_inode) { + child =ovl_create_real (parent->d_inode, child, +OVL_CATTR (is_dir ?S_IFDIR : +S_IFREG )); + }else if (is_dir && !d_can_lookup (child)) { +dput (child); + child =ERR_PTR (-ENOTDIR ); + } + }inode_unlock (parent->d_inode);dput (parent);
@@ -1272,7 +1279,7 @@ static int ovl_create_volatile_dirty(struct ovl_fs *ofs)const char *const *name = volatile_path;for (ctr =ARRAY_SIZE (volatile_path); ctr; ctr--, name++) { - d =ovl_lookup_or_create (d, *name, ctr >1 ?S_IFDIR :S_IFREG ); + d =ovl_lookup_or_create (d, *name, ctr >1 );if (IS_ERR (d))return PTR_ERR (d); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 622/1848 smb: client: fix fiemap wild read on empty truncated response
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Abdifatah Suruur <[email protected]>
[ Upstream commit f5baa17a0f316c235d61623ac8e8fb32c2b3c0cc ]
smb3_fiemap() treats -E2BIG from SMB2_ioctl() as a truncated range blob and loops for the next chunk. If the server reports STATUS_BUFFER_OVERFLOW with OutputCount == 0, SMB2_ioctl() returns -E2BIG with out_data == NULL and out_data_len == 0, and the existing length checks accept the empty result. The loop then evaluates
next = out_data[num - 1].file_offset + ...
with num == 0, reading 16 bytes before NULL.
Reject a truncated range blob that contains no range, so the resume offset is never computed from an empty response. Also require the last range in a truncated blob to advance the resume offset without overflowing, and to stay within the requested range; a malicious or broken server could otherwise make no progress or underflow len and loop forever. Free the previous response buffer before retrying.
Reproduced on 6.6.87.2 with a malicious SMB2 server that answers FSCTL_QUERY_ALLOCATED_RANGES with STATUS_BUFFER_OVERFLOW and OutputCount == 0; an FS_IOC_FIEMAP ioctl on the mount oopses in cifs_fiemap() with CR2 = fffffffffffffff8. The code path is unchanged on mainline.
--- fs/cifs/smb2ops.c | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-)
fs/cifs/smb2ops.c +27 -3
@@ -3915,6 +3915,15 @@ static int smb3_fiemap(struct cifs_tcon *tcon, goto out; } +/* +* A truncated range blob must contain at least one range, otherwise +* there is no offset to resume from and out_data is NULL. +*/ +if (!last_blob && out_data_len ==0 ) { + rc = -EINVAL ; + goto out; + } + num = out_data_len /sizeof (struct file_allocated_range_buffer );for (i =0 ; i < num; i++) { flags =0 ;
@@ -3935,10 +3944,25 @@ static int smb3_fiemap(struct cifs_tcon *tcon, }if (!last_blob) { - next =le64_to_cpu (out_data[num -1 ].file_offset) + -le64_to_cpu (out_data[num -1 ].length); - len = len - (next - start); +u64 last_start, last_len; + + last_start =le64_to_cpu (out_data[num -1 ].file_offset); + last_len =le64_to_cpu (out_data[num -1 ].length); + +if (check_add_overflow (last_start, last_len, &next) || + next <= start) { + rc = -EINVAL ; + goto out; + } +if (next - start >= len) { + rc =0 ; + goto out; + } + + len -= next - start; start = next; +kfree (out_data); + out_data =NULL ; goto again; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 623/1848 smb: client: fix buffer overflow in SMB2_tcon()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Luxiao Xu <[email protected]>
[ Upstream commit 73cc469b0ff7551f8537ea919709973e6dc4f514 ]
In SMB2_tcon(), unc_path is allocated with a fixed buffer size of MAX_SHARENAME_LENGTH * 2 bytes (672 bytes). However, the user-controlled UNC path (tree) length is passed to cifs_strtoUTF16(), which assumes the destination buffer is large enough and writes strlen(tree) + 1 UTF-16 code units.
Commit 62a1a439e0fd ("cifs: clean up handling of unc= option") removed the length check on UNC mount options, allowing mount paths to exceed MAX_SHARENAME_LENGTH while retaining the fixed-size buffer allocation in SMB2_tcon(). Consequently, an oversized UNC string causes cifs_strtoUTF16() to write past the end of the heap object, resulting in a slab-out-of-bounds write. Furthermore, if a tree exceeds MAX_TREE_SIZE characters, strscpy() truncates it in cifs_tcon::tree_name, causing subsequent reconnects or failovers to fail.
Fix this by first verifying that the length of tree does not exceed MAX_TREE_SIZE, returning -EINVAL if it does. Then, dynamically allocate unc_path based on the length of tree so that it safely accommodates all UTF-16 code units for paths within MAX_TREE_SIZE.
--- fs/cifs/smb2pdu.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
fs/cifs/smb2pdu.c +9 -3
@@ -1703,8 +1703,6 @@ static inline void cifs_stats_fail_inc(struct cifs_tcon *tcon, uint16_t code)cifs_stats_inc (&tcon->stats.smb2_stats.smb2_com_failed[code]); } -#define MAX_SHARENAME_LENGTH (255 /* server */ + 80 /* share */ + 1 /* NULL */) -/* These are similar values to what Windows uses */ static inline void init_copy_chunk_defaults (struct cifs_tcon *tcon) {
@@ -1738,7 +1736,15 @@ SMB2_tcon(const unsigned int xid, struct cifs_ses *ses, const char *tree,if (!server || !tree)return -EIO ; - unc_path =kmalloc (MAX_SHARENAME_LENGTH *2 ,GFP_KERNEL ); + total_len =strlen (tree); +if (total_len >MAX_TREE_SIZE ) { +cifs_server_dbg (VFS |ONCE , +"%s: tree name exceeded %u characters\n" , + __func__,MAX_TREE_SIZE ); +return -EINVAL ; + } + + unc_path =kmalloc ((total_len +1 ) *sizeof (*unc_path),GFP_KERNEL );if (unc_path ==NULL )return -ENOMEM ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 624/1848 smb: client: validate SMB1 EA list bounds before parsing
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ratnaker Gautam <[email protected]>
[ Upstream commit ddc7a7e1eeb116ccaf010a6f1fb6ab927f3f888d ]
CIFSSMBQAllEAs() checks the server-provided EA list length by adding it to the response pointer. On 32-bit systems, a positive length can wrap the pointer and pass the comparison. The parser then walks outside the received response while reading the next FEA header.
A response with a list length of 0x40000000 reproduces this as a native i386 page fault and kernel panic from listxattr() against an SMB1 server.
Check that the EA list starts within the SMB byte area before reading its header. Keep its length unsigned and compare it with the bytes left in the response without pointer addition.
SMB1 is not negotiated by default and requires an explicit vers=1.0 mount.
--- fs/cifs/cifssmb.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-)
fs/cifs/cifssmb.c +16 -5
@@ -6197,9 +6197,11 @@ CIFSSMBQAllEAs(const unsigned int xid, struct cifs_tcon *tcon,int rc =0 ;int bytes_returned;int list_len; +u32 ea_list_len;struct fealist *ea_response_data;struct fea *temp_fea;char *temp_ptr; +char *byte_area;char *end_of_smb;__u16 params, byte_count, data_offset;unsigned int ea_name_len = ea_name ?strlen (ea_name) :0 ;
@@ -6276,9 +6278,18 @@ CIFSSMBQAllEAs(const unsigned int xid, struct cifs_tcon *tcon, ea_response_data = (struct fealist *) (((char *) &pSMBr->hdr.Protocol) + data_offset); - list_len =le32_to_cpu (ea_response_data->list_len); -cifs_dbg (FYI ,"ea length %d\n" , list_len); -if (list_len <=8 ) { + byte_area =pByteArea (&pSMBr->hdr); + end_of_smb = byte_area +get_bcc (&pSMBr->hdr); +if ((char *)ea_response_data < byte_area || + (char *)ea_response_data > + end_of_smb -sizeof (ea_response_data->list_len)) { + rc = -EIO ; + goto QAllEAsOut; + } + + ea_list_len =le32_to_cpu (ea_response_data->list_len); +cifs_dbg (FYI ,"%s: ea length: %u\n" , __func__, ea_list_len); +if (ea_list_len <=8 ) {cifs_dbg (FYI ,"empty EA list returned from server\n" );/* didn't find the named attribute */ if (ea_name)
@@ -6287,12 +6298,12 @@ CIFSSMBQAllEAs(const unsigned int xid, struct cifs_tcon *tcon, }/* make sure list_len doesn't go past end of SMB */ - end_of_smb = (char *)pByteArea (&pSMBr->hdr) +get_bcc (&pSMBr->hdr); -if ((char *)ea_response_data + list_len > end_of_smb) { +if (ea_list_len > end_of_smb - (char *)ea_response_data) {cifs_dbg (FYI ,"EA list appears to go beyond SMB\n" ); rc = -EIO ; goto QAllEAsOut; } + list_len = ea_list_len;/* account for ea list len */ list_len -=4 ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 625/1848 xfs: check for buffer overruns when examining local/remote xattr entries
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Darrick J. Wong <[email protected]>
[ Upstream commit 91c41f9524906a8ebd2ae68c98a07b4bd5255ddb ]
LOLLM noticed that the xattr scrub and repair code can walk off the end of the buffer if the xattr entry record starts so close to the end of the buffer that there's not even space for the entry structure itself. Strengthen the bounds checking here.
--- fs/xfs/scrub/attr.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
fs/xfs/scrub/attr.c +12 -0
@@ -276,6 +276,12 @@ xchk_xattr_entry(/* Check the name information. */ if (ent->flags &XFS_ATTR_LOCAL ) { lentry =xfs_attr3_leaf_name_local (leaf, idx); + name_end = (char *)lentry + offsetof(typeof(*lentry), nameval[0]); +if (name_end > buf_end) { +xchk_da_set_corrupt (ds, level); +return ; + } + namesize =xfs_attr_leaf_entsize_local (lentry->namelen,be16_to_cpu (lentry->valuelen)); name_end = (char *)lentry + namesize;
@@ -283,6 +289,12 @@ xchk_xattr_entry(xchk_da_set_corrupt (ds, level); }else { rentry =xfs_attr3_leaf_name_remote (leaf, idx); + name_end = (char *)rentry + offsetof(typeof(*rentry), name[0]); +if (name_end > buf_end) { +xchk_da_set_corrupt (ds, level); +return ; + } + namesize =xfs_attr_leaf_entsize_remote (rentry->namelen); name_end = (char *)rentry + namesize;if (rentry->namelen ==0 )
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 626/1848 xfs: improve dirent bounds checking in scrub and repair
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Darrick J. Wong <[email protected]>
[ Upstream commit 5d470234d04dae6fe2ca2cf4b9ef277b78c7e05a ]
LOLLM complains that we don't do enough bounds checking of the directory entries in directory blocks when we're looking for errors or trying to salvage entries. Let's improve that with more detailed checks.
--- fs/xfs/scrub/dir.c | 61 +++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 55 insertions(+), 6 deletions(-)
fs/xfs/scrub/dir.c +55 -6
@@ -205,6 +205,7 @@ xchk_dir_rec(xfs_dahash_t hash;struct xfs_dir3_icleaf_hdr hdr;unsigned int tag; +bool foundit = false;int error; ASSERT(blk->magic == XFS_DIR2_LEAF1_MAGIC ||
@@ -249,28 +250,68 @@ xchk_dir_rec( dent = bp->b_addr + off;/* Make sure we got a real directory entry. */ - iter_off = geo->data_entry_offset; end =xfs_dir3_data_end_offset (geo, bp->b_addr);if (!end) {xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno); goto out_relse; } -for (;;) { + iter_off = geo->data_entry_offset; +while (iter_off < end) {struct xfs_dir2_data_entry *dep = bp->b_addr + iter_off;struct xfs_dir2_data_unused *dup = bp->b_addr + iter_off; +unsigned int advance; -if (iter_off >= end) { +/* must have freetag */ + advance = offsetof(typeof(*dup), length); +if (iter_off + advance >= end) {xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno); goto out_relse; }if (be16_to_cpu (dup->freetag) ==XFS_DIR2_DATA_FREE_TAG ) { - iter_off +=be16_to_cpu (dup->length); +if (iter_off +sizeof (*dup) > end) { +xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , + rec_bno); + goto out_relse; + } + + advance =round_up (be16_to_cpu (dup->length), +XFS_DIR2_DATA_ALIGN ); +if (!advance || iter_off + advance > end) { +xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , + rec_bno); + goto out_relse; + } + + iter_off += advance;continue ; } -if (dep == dent) + +/* must have namelen */ + advance = offsetof(typeof(*dep), name); +if (iter_off + advance >= end) { +xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno); + goto out_relse; + } + +/* Don't walk off the end of the block. */ + advance =xfs_dir2_data_entsize (mp, dep->namelen); +if (!advance || iter_off + advance > end) { +xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno); + goto out_relse; + } + +if (dep == dent) { + foundit = true;break ; - iter_off +=xfs_dir2_data_entsize (mp, dep->namelen); + } + iter_off += advance; + } + +/* Hash tree must point to the exact dirent */ +if (!foundit) { +xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno); + goto out_relse; }/* Retrieve the entry, sanity check it, and compare hashes. */
@@ -283,6 +324,14 @@ xchk_dir_rec(xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno); goto out_relse; } + +/* Name must not overflow end of block */ +if ((char *)dent->name + dent->namelen > + (char *)bp->b_addr +BBTOB (bp->b_length)) { +xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno); + goto out_relse; + } + calc_hash =xfs_da_hashname (dent->name, dent->namelen);if (calc_hash != hash)xchk_fblock_set_corrupt (ds->sc,XFS_DATA_FORK , rec_bno);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 627/1848 NFSv4/pnfs: bound the CB_NOTIFY_DEVICEID array count before allocating
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Benjamin Coddington <[email protected]>
[ Upstream commit 32f0967ea296d447925465c98e7eec71d4e2f755 ]
decode_devicenotify_args() hands the server's notification count straight to kmalloc_objs() as the array length, without checking it against the message that carried it. Bound it the way nfs4xdr.c bounds an attribute length, against xdr_stream_remaining().
--- fs/nfs/callback_xdr.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/nfs/callback_xdr.c +7 -0
@@ -272,6 +272,13 @@ __be32 decode_devicenotify_args(struct svc_rqst *rqstp,if (n ==0 ) goto out; +/* sanity check the count against the remaining stream */ +if (n >xdr_stream_remaining (xdr) / + ((4 *sizeof (uint32_t )) +NFS4_DEVICEID4_SIZE )) { + status =htonl (NFS4ERR_BADXDR ); + goto out; + } + args->devs =kmalloc_array (n,sizeof (*args->devs),GFP_KERNEL );if (!args->devs) { status =htonl (NFS4ERR_DELAY );
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 628/1848 smb: client: bound POSIX lock data area by response length
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ratnaker Gautam <[email protected]>
[ Upstream commit 8fc9af68c57156ff64769f30e831553cd03b3000 ]
CIFSSMBPosixLock() receives a TRANS2 response whose server-provided DataOffset and DataCount are not required by validate_t2() to describe an interval inside the response. A server can therefore make the client read a cifs_posix_lock beyond the response buffer and return those kernel bytes through F_GETLK.
Use smbCalcSize() to obtain the full response length after any multipart TRANS2 reassembly, then reject data areas that extend past it before dereferencing them.
--- fs/cifs/cifssmb.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/cifs/cifssmb.c +7 -0
@@ -2592,6 +2592,7 @@ CIFSSMBPosixLock(const unsigned int xid, struct cifs_tcon *tcon,cifs_dbg (FYI ,"Send error in Posix Lock = %d\n" , rc); }else if (pLockData) {/* lock structure can be returned on get */ +unsigned int rsp_len;__u16 data_offset;__u16 data_count; rc =validate_t2 ((struct smb_t2_rsp *)pSMBr);
@@ -2602,10 +2603,16 @@ CIFSSMBPosixLock(const unsigned int xid, struct cifs_tcon *tcon, } data_offset =le16_to_cpu (pSMBr->t2.DataOffset); data_count =le16_to_cpu (pSMBr->t2.DataCount); + rsp_len =smbCalcSize (&pSMBr->hdr) -4 ;if (data_count <sizeof (struct cifs_posix_lock )) { rc = -EIO ; goto plk_err_exit; } +if (data_offset > rsp_len || + data_count > rsp_len - data_offset) { + rc = -EIO ; + goto plk_err_exit; + } parm_data = (struct cifs_posix_lock *) ((char *)&pSMBr->hdr.Protocol + data_offset);if (parm_data->lock_type ==cpu_to_le16 (CIFS_UNLCK ))
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 629/1848 NFSv4/flexfiles: fail I/O to the data server once a lock is lost
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Benjamin Coddington <[email protected]>
[ Upstream commit 7fa2ad367abe6d3155daefb57331e7fce1a17afd ]
When a client loses a byte-range lock, because its lease expired and it may not recover the lock (nfs.recover_lost_locks=0) or because reclaim failed, it marks the lock state NFS_LOCK_LOST and fails further I/O by that lock owner. Otherwise an application that believes it holds a lock over a range is never told that the lock is gone, and can overwrite data that another client has since written under its own lock on that range.
The NFSv4 READ/WRITE and file layout I/O paths apply this in rpc_call_prepare, where nfs4_set_rw_stateid() returns -EIO for a lost lock. The flexfiles data server I/O path does not: the NFSv3 data server path never checked, and the check on the NFSv4 path was removed when the data server stateid began to be taken from the layout.
Fail read and write RPCs to the data server in rpc_call_prepare when the lock is lost. The data server path has no use for the stateid that nfs4_set_rw_stateid() selects, and selecting it looks up a delegation or open stateid on every I/O.
Instead add nfs4_lock_context_lost(), which only tests NFS_LOCK_LOST, and check it alongside the open state. Its lookup, __nfs4_lookup_lock_state(), is split out of __nfs4_find_lock_state() and takes no reference: a lock state is only unlinked from state->lock_states under state->state_lock, so one found while holding that lock cannot be freed before it is released. Use it in nfs4_copy_lock_stateid() as well, which only reads the lock state under that lock. That drops a reference get and put from stateid selection for all NFSv4 I/O without changing the stateid selected.
Terminating the RPC in rpc_call_prepare is not enough on its own. The done callback reads the -EIO as a data server connection error, forgets the device ID, and resets the I/O to pNFS (or, for an NFSv4 data server, possibly to the MDS). After a reset to pNFS a new LAYOUTGET is granted and rpc_call_prepare fails the I/O again, without end. The existing NFS_CONTEXT_BAD check does not loop, since the open state is then invalid and pnfs_update_layout() fails the reset I/O, but it still forgets the device ID.
So when an RPC that was never sent fails and the open context is bad, the open state is invalid, or the lock is lost, complete it with -EIO without error handling. An RPC that was sent and failed is handled as before, so a real data server error is still reported to the MDS.
--- fs/nfs/flexfilelayout/flexfilelayout.c | 25 +++++++++++++++-- fs/nfs/nfs4_fs.h | 2 ++ fs/nfs/nfs4state.c | 38 +++++++++++++++++++++++--- 3 files changed, 59 insertions(+), 6 deletions(-)
fs/nfs/flexfilelayout/flexfilelayout.c +23 -2
@@ -1370,12 +1370,27 @@ static void ff_layout_io_track_ds_error(struct pnfs_layout_segment *lseg,dprintk ("%s: err %d op %d status %u\n" , __func__, err, opnum, status); } +static bool ff_layout_io_state_lost (const struct nfs_pgio_header *hdr) +{ +struct nfs_open_context *ctx = hdr->args.context; + +return test_bit (NFS_CONTEXT_BAD , &ctx->flags) || + !nfs4_valid_open_stateid (ctx->state) || +nfs4_lock_context_lost (ctx->state, hdr->args.lock_context); +} +/* NFS_PROTO call done callback routines */ static int ff_layout_read_done_cb (struct rpc_task *task,struct nfs_pgio_header *hdr) {int err; +if (task->tk_status <0 && !RPC_WAS_SENT (task) && +ff_layout_io_state_lost (hdr)) { + task->tk_status = -EIO ; +return 0 ; + } +if (task->tk_status <0 ) { ff_layout_io_track_ds_error(hdr->lseg, hdr->pgio_mirror_idx, hdr->args.offset, hdr->args.count,
@@ -1463,7 +1478,7 @@ static void ff_layout_read_record_layoutstats_done(struct rpc_task *task,static int ff_layout_read_prepare_common (struct rpc_task *task,struct nfs_pgio_header *hdr) { -if (unlikely (test_bit (NFS_CONTEXT_BAD , &hdr->args.context->flags))) { +if (unlikely (ff_layout_io_state_lost (hdr))) {rpc_exit (task, -EIO );return -EIO ; }
@@ -1542,6 +1557,12 @@ static int ff_layout_write_done_cb(struct rpc_task *task,loff_t end_offs =0 ;int err; +if (task->tk_status <0 && !RPC_WAS_SENT (task) && +ff_layout_io_state_lost (hdr)) { + task->tk_status = -EIO ; +return 0 ; + } +if (task->tk_status <0 ) { ff_layout_io_track_ds_error(hdr->lseg, hdr->pgio_mirror_idx, hdr->args.offset, hdr->args.count,
@@ -1645,7 +1666,7 @@ static void ff_layout_write_record_layoutstats_done(struct rpc_task *task,static int ff_layout_write_prepare_common (struct rpc_task *task,struct nfs_pgio_header *hdr) { -if (unlikely (test_bit (NFS_CONTEXT_BAD , &hdr->args.context->flags))) { +if (unlikely (ff_layout_io_state_lost (hdr))) {rpc_exit (task, -EIO );return -EIO ; }
fs/nfs/nfs4_fs.h +2 -0
@@ -516,6 +516,8 @@ extern int nfs4_select_rw_stateid(struct nfs4_state *, fmode_t, const struct cred **); extern bool nfs4_copy_open_stateid(nfs4_stateid *dst,struct nfs4_state *state); +extern bool nfs4_lock_context_lost (struct nfs4_state *state, +const struct nfs_lock_context *l_ctx);extern struct nfs_seqid *nfs_alloc_seqid (struct nfs_seqid_counter *counter,gfp_t gfp_mask);extern int nfs_wait_on_sequence (struct nfs_seqid *seqid,struct rpc_task *task);
fs/nfs/nfs4state.c +34 -4
@@ -845,10 +845,13 @@ void nfs4_close_sync(struct nfs4_state *state, fmode_t fmode)* be made. Failing that, a "consistent" choice is preferable. The * consistent choice we make is to prefer the first owner, that of a * Posix lock. +* +* Called with state->state_lock held. No reference is taken: a lock +* state is freed only after it is unlinked under state->state_lock. */ static struct nfs4_lock_state * -__nfs4_find_lock_state (struct nfs4_state *state, -fl_owner_t fl_owner,fl_owner_t fl_owner2) +__nfs4_lookup_lock_state (struct nfs4_state *state, +fl_owner_t fl_owner,fl_owner_t fl_owner2) {struct nfs4_lock_state *pos, *ret =NULL ;list_for_each_entry (pos, &state->lock_states, ls_locks) {
@@ -859,6 +862,16 @@ __nfs4_find_lock_state(struct nfs4_state *state,if (pos->ls_owner == fl_owner2) ret = pos; } +return ret; +} + +static struct nfs4_lock_state * +__nfs4_find_lock_state (struct nfs4_state *state, +fl_owner_t owner,fl_owner_t owner2) +{ +struct nfs4_lock_state *ret; + + ret =__nfs4_lookup_lock_state (state, owner, owner2);if (ret)refcount_inc (&ret->ls_count);return ret;
@@ -1007,7 +1020,7 @@ static int nfs4_copy_lock_stateid(nfs4_stateid *dst, fl_flock_owner = l_ctx->open_context->flock_owner;spin_lock (&state->state_lock); - lsp =__nfs4_find_lock_state (state, fl_owner, fl_flock_owner); + lsp =__nfs4_lookup_lock_state (state, fl_owner, fl_flock_owner);if (lsp &&test_bit (NFS_LOCK_LOST , &lsp->ls_flags)) ret = -EIO ;else if (lsp !=NULL &&test_bit (NFS_LOCK_INITIALIZED , &lsp->ls_flags) !=0 ) {
@@ -1015,11 +1028,28 @@ static int nfs4_copy_lock_stateid(nfs4_stateid *dst, ret =0 ; }spin_unlock (&state->state_lock); -nfs4_put_lock_state (lsp); out:return ret; } +bool nfs4_lock_context_lost (struct nfs4_state *state, +const struct nfs_lock_context *l_ctx) +{ +struct nfs4_lock_state *lsp; +bool ret; + +if (!test_bit (LK_STATE_IN_USE , &state->flags)) +return false; + +spin_lock (&state->state_lock); + lsp =__nfs4_lookup_lock_state (state, l_ctx->lockowner, + l_ctx->open_context->flock_owner); + ret = lsp &&test_bit (NFS_LOCK_LOST , &lsp->ls_flags); +spin_unlock (&state->state_lock); +return ret; +} +EXPORT_SYMBOL_GPL (nfs4_lock_context_lost); +bool nfs4_copy_open_stateid (nfs4_stateid *dst,struct nfs4_state *state) {bool ret;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 630/1848 nfsd: dont offer flexfiles layouts when NFSv3 isnt being served
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jeff Layton <[email protected]>
[ Upstream commit 5d28b2c920d9d9d3c45b41769342ad785eb372a7 ]
The flexfiles layout driver hands out a deviceinfo that names this server as an NFSv3 DS (flexfilelayout.c hardcodes da->version = 3). With v3 disabled, the client can't talk to the DS: it loops on v3 NULL calls that the server answers with PROG_MISMATCH, and I/O hangs in D state.
Skip LAYOUT_FLEX_FILES in nfsd4_setup_layout_type() unless v3 is enabled.
--- fs/nfsd/nfs4layouts.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
fs/nfsd/nfs4layouts.c +4 -3
@@ -125,6 +125,7 @@ nfsd4_set_deviceid(struct nfsd4_deviceid *id, const struct svc_fh *fhp,void nfsd4_setup_layout_type (struct svc_export *exp) { +struct nfsd_net *nn =net_generic (exp->cd->net, nfsd_net_id);#if defined(CONFIG_NFSD_BLOCKLAYOUT ) || defined(CONFIG_NFSD_SCSILAYOUT )struct super_block *sb = exp->ex_path.mnt->mnt_sb;#endif
@@ -132,9 +133,9 @@ void nfsd4_setup_layout_type(struct svc_export *exp)if (!(exp->ex_flags &NFSEXP_PNFS ))return ; -#ifdef CONFIG_NFSD_FLEXFILELAYOUT - exp->ex_layout_types |=1 <<LAYOUT_FLEX_FILES ; -#endif +if (IS_ENABLED (CONFIG_NFSD_FLEXFILELAYOUT ) && +nfsd_vers (nn,3 ,NFSD_TEST )) + exp->ex_layout_types |=1 <<LAYOUT_FLEX_FILES ;#ifdef CONFIG_NFSD_BLOCKLAYOUT if (sb->s_export_op->get_uuid && sb->s_export_op->map_blocks &&
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 631/1848 NFSD: Move the cld upcall message out of the callers stack frame
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
[ Upstream commit c559b05610557fa3c6c30259261f6dae523b3f23 ]
__cld_pipe_upcall() builds its struct rpc_pipe_msg on the stack and hands it to rpc_queue_upcall(), which links it into a list the pipe owns until the message is released. Only the completion rules keep that frame alive for as long as the pipe refers to it, and the peer that drives those rules is an untrusted userspace daemon. The gss and idmap upcalls do not take that on: each keeps the message in the object it already allocates.
Do the same here and put the message in struct cld_upcall, beside the reply buffer it carries. cld_pipe_destroy_msg() then reaches the upcall from the message directly rather than through msg->data.
Stable-dep-of: 2a83fcb50f3c ("NFSD: Complete a cld upcall when the daemon closes the pipe")
--- fs/nfsd/nfs4recover.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
fs/nfsd/nfs4recover.c +10 -10
@@ -720,6 +720,7 @@ struct cld_upcall {struct completion cu_done;/* daemon has read the whole upcall; protected by cn_lock */ bool cu_inflight; +struct rpc_pipe_msg cu_pipe_msg;union {struct cld_msg_hdr cu_hdr;struct cld_msg cu_msg;
@@ -731,22 +732,22 @@ static int __cld_pipe_upcall(struct rpc_pipe *pipe, void *cmsg, struct nfsd_net *nn) { int ret; -struct rpc_pipe_msg msg; struct cld_upcall *cup = container_of(cmsg, struct cld_upcall, cu_u); +struct rpc_pipe_msg *msg = &cup->cu_pipe_msg; -memset (&msg,0 ,sizeof (msg)); - msg.data = cmsg; - msg.len = nn->client_tracking_ops->msglen; +memset (msg,0 ,sizeof (*msg)); + msg->data = cmsg; + msg->len = nn->client_tracking_ops->msglen; - ret =rpc_queue_upcall (pipe, &msg); + ret =rpc_queue_upcall (pipe, msg);if (ret <0 ) { goto out; }wait_for_completion (&cup->cu_done); -if (msg.errno <0 ) - ret = msg.errno; +if (msg->errno <0 ) + ret = msg->errno; out:return ret; }
@@ -918,9 +919,8 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)static void cld_pipe_destroy_msg (struct rpc_pipe_msg *msg) { -struct cld_msg *cmsg = msg->data; - struct cld_upcall *cup = container_of(cmsg, struct cld_upcall, - cu_u.cu_msg); + struct cld_upcall *cup = container_of(msg, struct cld_upcall, + cu_pipe_msg);struct cld_net *cn = cup->cu_net;/*
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 632/1848 NFSD: Complete a cld upcall when the daemon closes the pipe
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
[ Upstream commit 2a83fcb50f3c25c493cc4389619340fefe9d6ac4 ]
Once nfsdcld has read a whole upcall, rpc_pipe_read() unlinks the message from every pipe list, so the purges in rpc_pipe_release() and rpc_close_pipes() no longer reach it. cld_upcall_ops supplies no .release_pipe callback, and cld_pipe_destroy_msg() returns without completing the upcall because a downcall is expected to follow. A daemon that exits between the read and the write therefore strands its waiter: the nfsd thread sleeps in TASK_UNINTERRUPTIBLE in __cld_pipe_upcall() and never returns, hung task warnings follow, and the server cannot be shut down.
Add a .release_pipe that completes every upcall the daemon has consumed. cu_inflight distinguishes those from upcalls still queued on the pipe, which the framework purges before it calls this callback; cld_pipe_downcall() removes an upcall it accepts from cn_list under the same lock. Neither can be completed twice.
Fail the stranded upcall with -EPIPE rather than the -EAGAIN that makes cld_pipe_upcall() retry. The daemon consumed the request, so whether it acted on it before exiting is unknown.
--- fs/nfsd/nfs4recover.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
fs/nfsd/nfs4recover.c +24 -0
@@ -937,10 +937,34 @@ cld_pipe_destroy_msg(struct rpc_pipe_msg *msg)complete (&cup->cu_done); } +/* +* An upcall the daemon has consumed is off every pipe list, so the +* purge in rpc_pipe_release() and rpc_close_pipes() cannot reach it. +* Release its waiter here instead; no downcall can arrive now. +*/ +static void +cld_release_pipe (struct inode *inode) +{ +struct nfsd_net *nn =net_generic (inode->i_sb->s_fs_info, nfsd_net_id); +struct cld_net *cn = nn->cld_net; +struct cld_upcall *cup; + +spin_lock (&cn->cn_lock); +list_for_each_entry (cup, &cn->cn_list, cu_list) { +if (!cup->cu_inflight) +continue ; + cup->cu_inflight = false; + cup->cu_pipe_msg.errno = -EPIPE ; +complete (&cup->cu_done); + } +spin_unlock (&cn->cn_lock); +} +static const struct rpc_pipe_ops cld_upcall_ops = { .upcall = rpc_pipe_generic_upcall, .downcall = cld_pipe_downcall, .destroy_msg = cld_pipe_destroy_msg, + .release_pipe = cld_release_pipe, }; static struct dentry *
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 633/1848 NFSD: Complete a cld upcall when copying its reply fails
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
[ Upstream commit 8cef2b0a01d28647facc57501a3df7ccd8d13ccd ]
cld_pipe_downcall() removes the matching upcall from cn_list before copying the daemon's reply. When that copy_from_user() faults, the downcall returns -EFAULT without completing the upcall, and a retried write cannot reach it because its xid is no longer on the list. __cld_pipe_upcall() waits on cu_done uninterruptibly, so the nfsd thread that sent the upcall is stuck, and nfsd shutdown hangs behind it. The pipe is mode 0600, so only a broken or hostile nfsdcld can trigger the fault.
Record the fault in the upcall's pipe message and complete it, so the waiter returns the error to its client tracking operation.
--- fs/nfsd/nfs4recover.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/nfsd/nfs4recover.c +4 -1
@@ -909,8 +909,11 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)if (status == -EINPROGRESS )return __cld_pipe_inprogress_downcall (cmsg, nn); -if (copy_from_user (&cup->cu_u.cu_msg_v2, src, mlen) !=0 ) +if (copy_from_user (&cup->cu_u.cu_msg_v2, src, mlen) !=0 ) { + cup->cu_pipe_msg.errno = -EFAULT ; +complete (&cup->cu_done);return -EFAULT ; + }complete (&cup->cu_done);return mlen;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 634/1848 NFSD: Map flex file layout IDs through the requests user namespace
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
[ Upstream commit f913d5d2130a584d1a027ffe3dfd88b6be2e0540 ]
nfsd4_ff_proc_layoutget() and nfsd4_ff_encode_layoutget() translate the file's owner and group with init_user_ns, but every other identity nfsd places on the wire goes through nfsd_user_namespace(). When the transport carries a credential from a non-initial user namespace, the flex file layout reports host-global IDs. The client copies those IDs into the AUTH_SYS credential it presents to the data server, and svcauth_unix_accept() resolves that credential in the transport's namespace, so data server I/O runs under an identity unrelated to the file's owner.
Switching to the request's namespace introduces a second hazard. from_kuid() returns (uid_t)-1 when the target namespace has no mapping for the owner, and the IOMODE_READ arm adds one to that result to derive an identity for which the data server denies writes. The addition would wrap to zero, handing the client uid 0 instead of an identity distinct from the owner.
Translate both IDs in nfsd4_ff_proc_layoutget(), which has the svc_rqst, and carry the wire values in struct pnfs_ff_layout. from_kuid_munged() substitutes overflowuid for an unmapped owner and thus never returns (uid_t)-1, so the increment cannot wrap to zero.
--- fs/nfsd/blocklayout.c | 4 ++-- fs/nfsd/flexfilelayout.c | 24 ++++++++++++++---------- fs/nfsd/flexfilelayoutxdr.c | 4 ++-- fs/nfsd/flexfilelayoutxdr.h | 5 +++-- fs/nfsd/nfs4proc.c | 2 +- fs/nfsd/pnfs.h | 4 ++-- 6 files changed, 24 insertions(+), 19 deletions(-)
fs/nfsd/blocklayout.c +2 -2
@@ -22,8 +22,8 @@static __be32 -nfsd4_block_proc_layoutget (struct inode *inode,const struct svc_fh *fhp, -struct nfsd4_layoutget *args) +nfsd4_block_proc_layoutget (struct svc_rqst *rqstp,struct inode *inode, +const struct svc_fh *fhp,struct nfsd4_layoutget *args) {struct nfsd4_layout_seg *seg = &args->lg_seg;struct super_block *sb = inode->i_sb;
fs/nfsd/flexfilelayout.c +14 -10
@@ -14,19 +14,20 @@#include <linux/sunrpc/addr.h> #include "flexfilelayoutxdr.h" +#include "auth.h" #include "pnfs.h" #include "vfs.h" #define NFSDDBG_FACILITY NFSDDBG_PNFSstatic __be32 -nfsd4_ff_proc_layoutget (struct inode *inode,const struct svc_fh *fhp, -struct nfsd4_layoutget *args) +nfsd4_ff_proc_layoutget (struct svc_rqst *rqstp,struct inode *inode, +const struct svc_fh *fhp,struct nfsd4_layoutget *args) { +struct user_namespace *userns =nfsd_user_namespace (rqstp);struct nfsd4_layout_seg *seg = &args->lg_seg;u32 device_generation =0 ;int error; -uid_t u;struct pnfs_ff_layout *fl;
@@ -49,13 +50,16 @@ nfsd4_ff_proc_layoutget(struct inode *inode, const struct svc_fh *fhp, fl->flags =FF_FLAGS_NO_LAYOUTCOMMIT |FF_FLAGS_NO_IO_THRU_MDS |FF_FLAGS_NO_READ_IO ; -/* Do not allow a IOMODE_READ segment to have write pemissions */ -if (seg->iomode ==IOMODE_READ ) { - u =from_kuid (&init_user_ns, inode->i_uid) +1 ; - fl->uid =make_kuid (&init_user_ns, u); - }else - fl->uid = inode->i_uid; - fl->gid = inode->i_gid; + fl->uid =from_kuid_munged (userns, inode->i_uid); + fl->gid =from_kgid_munged (userns, inode->i_gid); + +/* +* Do not allow an IOMODE_READ segment to have write permissions. +* The group is left intact so group-readable files stay readable; +* nfsd_setuser() squashes an unmapped uid to the export's anon ID. +*/ +if (seg->iomode ==IOMODE_READ ) + fl->uid++; error =nfsd4_set_deviceid (&fl->deviceid, fhp, device_generation);if (error)
fs/nfsd/flexfilelayoutxdr.c +2 -2
@@ -32,8 +32,8 @@ nfsd4_ff_encode_layoutget(struct xdr_stream *xdr, fh_len =4 +xdr_align_size (fl->fh.size); - uid.len =sprintf (uid.buf,"%u" ,from_kuid (&init_user_ns, fl->uid)); - gid.len =sprintf (gid.buf,"%u" ,from_kgid (&init_user_ns, fl->gid)); + uid.len =sprintf (uid.buf,"%u" , fl->uid); + gid.len =sprintf (gid.buf,"%u" , fl->gid);/* data server entry: deviceid + efficiency + stateid + fh list + * user + group + flags + stats_collect_hint
fs/nfsd/flexfilelayoutxdr.h +3 -2
@@ -35,8 +35,9 @@ struct pnfs_ff_device_addr {struct pnfs_ff_layout {u32 flags;u32 stats_collect_hint; -kuid_t uid; -kgid_t gid; +/* Values to encode; nfsd4_ff_proc_layoutget() has mapped these */ +u32 uid; +u32 gid;struct nfsd4_deviceid deviceid;stateid_t stateid;struct nfs_fh fh;
fs/nfsd/nfs4proc.c +1 -1
@@ -2258,7 +2258,7 @@ nfsd4_layoutget(struct svc_rqst *rqstp,if (atomic_read (&ls->ls_stid.sc_file->fi_lo_recalls)) goto out_put_stid; - nfserr = ops->proc_layoutget (d_inode (current_fh->fh_dentry), + nfserr = ops->proc_layoutget (rqstp,d_inode (current_fh->fh_dentry), current_fh, lgp);if (nfserr) goto out_put_stid;
fs/nfsd/pnfs.h +2 -2
@@ -29,8 +29,8 @@ struct nfsd4_layout_ops {__be32 (*encode_getdeviceinfo)(struct xdr_stream *xdr,struct nfsd4_getdeviceinfo *gdevp); -__be32 (*proc_layoutget)(struct inode *,const struct svc_fh *fhp, -struct nfsd4_layoutget *lgp); +__be32 (*proc_layoutget)(struct svc_rqst *rqstp,struct inode *inode, +const struct svc_fh *fhp,struct nfsd4_layoutget *lgp);__be32 (*encode_layoutget)(struct xdr_stream *,struct nfsd4_layoutget *lgp);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 635/1848 SUNRPC: trace an accepted transport before publishing it
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Zhiling Zou <[email protected]>
[ Upstream commit 06f90cf104fc21ee01e7ef1eb80e092173089b9f ]
svc_handle_xprt() publishes a newly accepted transport before tracing it. svc_add_new_temp_xprt() places the transport on sv_tempsocks and clears XPT_BUSY, so another nfsd thread can dequeue it at once. If the peer has already closed the connection, that thread runs svc_delete_xprt(), which drops the list reference, the only reference the new transport holds. trace_svc_xprt_accept() then reads the transport's addresses and network namespace from freed memory.
Before publication the accepting thread owns the transport
exclusively: XPT_BUSY is still set from svc_xprt_init() and the transport is on no list. Emit the tracepoint there.
--- net/sunrpc/svc_xprt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/svc_xprt.c +1 -1
@@ -811,8 +811,8 @@ static int svc_handle_xprt(struct svc_rqst *rqstp, struct svc_xprt *xprt) newxpt = xprt->xpt_ops->xpo_accept (xprt);if (newxpt) { newxpt->xpt_cred =get_cred (xprt->xpt_cred); -svc_add_new_temp_xprt (serv, newxpt);trace_svc_xprt_accept (newxpt, serv->sv_name); +svc_add_new_temp_xprt (serv, newxpt); }else module_put (xprt->xpt_class->xcl_owner); }else if (svc_xprt_reserve_slot (rqstp, xprt)) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 636/1848 afs: Fix afs to abort the rxrpc call on send error
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Howells <[email protected]>
[ Upstream commit 3e6af08a571fe2943a006acf3e890f36322602bc ]
Fix afs_send_empty_reply() and afs_send_simple_reply() to always try to abort the rxrpc call rather than just aborting on -ENOMEM and otherwise abandoning it. If the call is already complete due to network failure or a received abort, this will do nothing.
Also make afs_make_call() always abort on send error; again, it does nothing if the rxrpc call is already dead.
--- fs/afs/rxrpc.c | 34 ++++++++++++---------------------- 1 file changed, 12 insertions(+), 22 deletions(-)
fs/afs/rxrpc.c +12 -22
@@ -469,10 +469,9 @@ void afs_make_call(struct afs_addr_cursor *ac, struct afs_call *call, gfp_t gfp)return ; error_do_abort: -if (ret != -ECONNABORTED ) { -rxrpc_kernel_abort_call (call->net->socket, rxcall, -RX_USER_ABORT , ret,"KSD" ); - }else { +rxrpc_kernel_abort_call (call->net->socket, rxcall, +RX_USER_ABORT , ret,"KSD" ); +if (ret == -ECONNABORTED ) {iov_iter_kvec (&msg.msg_iter,ITER_DEST ,NULL ,0 ,0 ); rxrpc_kernel_recv_data(call->net->socket, rxcall, &msg.msg_iter, false,
@@ -854,6 +853,7 @@ void afs_send_empty_reply(struct afs_call *call) {struct afs_net *net = call->net;struct msghdr msg; +int ret;_enter ("" );
@@ -866,20 +866,12 @@ void afs_send_empty_reply(struct afs_call *call) msg.msg_controllen =0 ; msg.msg_flags =0 ; -switch (rxrpc_kernel_send_data (net->socket, call->rxcall, &msg,0 , - afs_notify_end_reply_tx)) { -case 0 : -_leave (" [replied]" ); -return ; - -case -ENOMEM : -_debug ("oom" ); + ret =rxrpc_kernel_send_data (net->socket, call->rxcall, &msg,0 , + afs_notify_end_reply_tx); +if (ret <0 ) {rxrpc_kernel_abort_call (net->socket, call->rxcall, -RXGEN_SS_MARSHAL , -ENOMEM ,"KOO" ); - fallthrough; -default : -_leave (" [error]" ); -return ; +RXGEN_SS_MARSHAL , ret,"KSE" ); +afs_set_call_complete (call, ret,RXGEN_SS_MARSHAL ); } }
@@ -914,11 +906,9 @@ void afs_send_simple_reply(struct afs_call *call, const void *buf, size_t len)return ; } -if (n == -ENOMEM ) { -_debug ("oom" ); -rxrpc_kernel_abort_call (net->socket, call->rxcall, -RXGEN_SS_MARSHAL , -ENOMEM ,"KOO" ); - } +rxrpc_kernel_abort_call (net->socket, call->rxcall, +RXGEN_SS_MARSHAL , n,"KSE" ); +afs_set_call_complete (call, n,RXGEN_SS_MARSHAL );_leave (" [error]" ); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 637/1848 KVM: nSVM: Reject KVM_SET_NESTED_STATE if L1 has EFER.LMA=1 && EFER.LME=0
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sean Christopherson <[email protected]>
[ Upstream commit 5dc500a354cc8e109df678076ae3488094649468 ]
Reject KVM_SET_NESTED_STATE if the incoming L1 host state has what is effectively an impossible EFER combination of LMA=1 but LME=0, i.e. if the state says long mode is active but not enabled. Unlike VMX, SVM doesn't have an explicit consistent check for the illegal combination; presumably hardware simply ignores EFER.LMA if EFER.LME=0.
Unfortunately, KVM doesn't ignore EFER.LMA in this case and consumes the illegal state when constructing the shadow MMU for L2. E.g. if userspace also clears CR4.PAE, then kvm_calc_cpu_role() will compute a role with 4 or 5 levels of paging, but shadow_mmu_init_context() will wire up the MMU to use the paging32 template, which maxes out its levels at 2.
Note, the "real badness" is effectively the same as what happened with the nVMX bug fixed by commit 112e66017bff ("KVM: nVMX: add missing consistency checks for CR0 and CR4"). Unfortunately, the sanity check added by commit 72e2fb24a0b0 ("KVM: x86/mmu: Bug the VM if a vCPU ends up in long mode without PAE enabled") doesn't work for this case, since L2 state is active at the time of the page fault, but it's L1 that has the bad state.
--- arch/x86/kvm/svm/nested.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kvm/svm/nested.c +2 -1
@@ -1232,7 +1232,8 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu,* nested_svm_check_permissions). * TODO: validate reserved bits for all saved state. */ -if (!(save->cr0 &X86_CR0_PG )) +if (!(save->cr0 &X86_CR0_PG ) || + ((save->efer &EFER_LMA ) && !(save->efer &EFER_LME ))) goto out_free;if (!(save->efer &EFER_SVME )) goto out_free;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 638/1848 KVM: x86: Clear hardware HLT state when userspace makes a vCPU not-halted
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Keqiang Duan <[email protected]>
[ Upstream commit 883719f57f5d3898637b130d6db4742471cad618 ]
Force a vCPU out of its hardware-tracked halted state when userspace puts the vCPU into any state other than HALTED via KVM_SET_MP_STATE, i.e. clear VMCS.GUEST_ACTIVITY_STATE if it says the vCPU is halted. Add an optional kvm_x86_ops hook to do the clearing, as SVM has no equivalent VMCB field.
When HLT-exiting is disabled for a VM (KVM_CAP_X86_DISABLE_EXITS with KVM_X86_DISABLE_EXITS_HLT, e.g. QEMU's "-overcommit cpu-pm=on"), a guest HLT halts the physical CPU instead of exiting to KVM, and hardware saves GUEST_ACTIVITY_STATE=HLT into the VMCS on the next VM-Exit. That field is
sticky: it survives VM-Exit/VM-Enter and is only cleared by vmx_clear_hlt() on event injection, or by vmx_vcpu_reset() on INIT / vCPU creation.
Nothing clears it on a userspace-driven state change. KVM_SET_REGS only writes the software register cache and KVM_SET_MP_STATE only writes vcpu->arch.mp_state; kvm_vcpu_running() likewise consults software state only. A VMM that emulates a machine reset therefore ends up with a vCPU that KVM happily VM-Enters while hardware refuses to fetch instructions.
Reproduce with a Linux guest by triggering a panic/kdump on a non-boot
vCPU: nmi_shootdown_cpus() parks the other vCPUs -- including vCPU0 -- in crash_nmi_callback(), which does local_irq_disable() followed by a bare HLT. The capture kernel then resets the machine via port 0xCF9. QEMU rewrites RIP to 0xfff0 and sets mp_state to RUNNABLE, but vCPU0's GUEST_ACTIVITY_STATE is still HLT, so the BSP never executes the reset vector, never sends SIPIs, and the entire VM hangs at "reboot: machine restart" forever. Only destroying and recreating the VM recovers it.
Key off "not HALTED" rather than "is RUNNABLE" as HALTED is the only target state for which retaining the hardware halted state is meaningful; every other transition either can't be reached on VMX, e.g. AP_RESET_HOLD, or goes through vmx_vcpu_reset(), which stuffs GUEST_ACTIVITY_ACTIVE anyways. This also captures the intent more directly: KVM only ever drops the hardware halted state, it never installs it.
Hook KVM_SET_MP_STATE rather than the VM-Enter path so that the clearing is driven by an explicit userspace declaration, and so that no work is added to vmx_vcpu_run(). Gate the call on kvm_hlt_in_guest() even though vmx_clear_hlt() checks it as well, as the check is cheap and makes it obvious in common code when the hardware state can exist at all.
Do nothing for TDX vCPUs as TDX doesn't support disabling HLT-exiting and KVM cannot access a TD's VMCS, i.e. the VMCS used to run the vCPU can't in HALTED state, and even if it were, KVM can't change it.
--- arch/x86/include/asm/kvm_host.h | 7 +++++++ arch/x86/kvm/vmx/vmx.c | 1 + arch/x86/kvm/x86.c | 13 +++++++++++++ 3 files changed, 21 insertions(+)
arch/x86/include/asm/kvm_host.h +7 -0
@@ -1171,6 +1171,13 @@ struct kvm_x86_ops {int (*nmi_allowed)(struct kvm_vcpu *vcpu,bool for_injection);bool (*get_nmi_mask)(struct kvm_vcpu *vcpu);void (*set_nmi_mask)(struct kvm_vcpu *vcpu,bool masked); +/* +* Force the vCPU out of any hardware-tracked halted/inactive state so +* that it will fetch and execute instructions on the next VM-Enter. +* Only needed by VMX, where VMCS.GUEST_ACTIVITY_STATE persists across +* VM-Exit/VM-Enter; SVM has no equivalent VMCB field. +*/ +void (*clear_hlt)(struct kvm_vcpu *vcpu);void (*enable_nmi_window)(struct kvm_vcpu *vcpu);void (*enable_irq_window)(struct kvm_vcpu *vcpu);void (*update_cr8_intercept)(struct kvm_vcpu *vcpu,int tpr,int irr);
arch/x86/kvm/vmx/vmx.c +1 -0
@@ -7862,6 +7862,7 @@ static struct kvm_x86_ops vmx_x86_ops __initdata = { .nmi_allowed = vmx_nmi_allowed, .get_nmi_mask = vmx_get_nmi_mask, .set_nmi_mask = vmx_set_nmi_mask, + .clear_hlt = vmx_clear_hlt, .enable_nmi_window = enable_nmi_window, .enable_irq_window = enable_irq_window, .update_cr8_intercept = update_cr8_intercept,
arch/x86/kvm/x86.c +13 -0
@@ -9893,6 +9893,19 @@ int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu,set_bit (KVM_APIC_SIPI , &vcpu->arch.apic->pending_events); }else vcpu->arch.mp_state = mp_state->mp_state; + +/* +* Force the vCPU out of any hardware-tracked halted state, e.g. VMX's +* GUEST_ACTIVITY_STATE=HLT, when userspace puts the vCPU into a state +* other than HALTED. The hardware state is sticky across VM-Exit and +* VM-Enter and is not touched by any other ioctl, so a vCPU that halted +* with HLT-exiting disabled stays wedged even after userspace rewrites +* its registers, e.g. when a VMM emulates a machine reset. +*/ +if (kvm_hlt_in_guest (vcpu->kvm) && + mp_state->mp_state !=KVM_MP_STATE_HALTED && kvm_x86_ops.clear_hlt) + kvm_x86_ops.clear_hlt (vcpu); +kvm_make_request (KVM_REQ_EVENT , vcpu); ret =0 ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 639/1848 HID: hid-prodikeys: remove struct pk_device
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jiri Slaby (SUSE) <[email protected]>
[ Upstream commit 16d0e1d469cc16aefa8ef745e926eda473a9b221 ]
First, quirks was unused in struct pk_device.
And I see no reason for this additional level of indirection. struct pcmidi_snd is far enough for the driver. Unless I am missing something?
So drop struct pk_device and convert all the users to use struct pcmidi_snd directly. No need for doubled kmalloc+kfrees now.
Found by https://github.com/jirislaby/clang-struct.
Stable-dep-of: 0ff37294c41b ("HID: prodikeys: validate fixed-format MIDI reports")
--- drivers/hid/hid-prodikeys.c | 113 +++++++++++++----------------------- 1 file changed, 40 insertions(+), 73 deletions(-)
drivers/hid/hid-prodikeys.c +40 -73
@@ -32,13 +32,6 @@struct pcmidi_snd ; -struct pk_device { -unsigned long quirks; - -struct hid_device *hdev; -struct pcmidi_snd *pm;/* pcmidi device context */ -}; -struct pcmidi_sustain {unsigned long in_use;struct pcmidi_snd *pm;
@@ -50,7 +43,7 @@ struct pcmidi_sustain {#define PCMIDI_SUSTAINED_MAX 32struct pcmidi_snd { -struct pk_device *pk; +struct hid_device *hdev;unsigned short ifnum;struct hid_report *pcmidi_report6;struct input_dev *input_ep82;
@@ -100,11 +93,11 @@ static ssize_t show_channel(struct device *dev, struct device_attribute *attr, char *buf) { struct hid_device *hdev = to_hid_device(dev); -struct pk_device *pk =hid_get_drvdata (hdev); +struct pcmidi_snd *pm =hid_get_drvdata (hdev); -dbg_hid ("pcmidi sysfs read channel=%u\n" , pk->pm->midi_channel); +dbg_hid ("pcmidi sysfs read channel=%u\n" , pm->midi_channel); -return sprintf (buf,"%u (min:%u, max:%u)\n" , pk->pm->midi_channel, +return sprintf (buf,"%u (min:%u, max:%u)\n" , pm->midi_channel,PCMIDI_CHANNEL_MIN ,PCMIDI_CHANNEL_MAX ); }
@@ -113,13 +106,13 @@ static ssize_t store_channel(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { struct hid_device *hdev = to_hid_device(dev); -struct pk_device *pk =hid_get_drvdata (hdev); +struct pcmidi_snd *pm =hid_get_drvdata (hdev);unsigned channel =0 ;if (sscanf (buf,"%u" , &channel) >0 && channel <=PCMIDI_CHANNEL_MAX ) {dbg_hid ("pcmidi sysfs write channel=%u\n" , channel); - pk->pm->midi_channel = channel; + pm->midi_channel = channel;return strlen (buf); }return -EINVAL ;
@@ -137,11 +130,11 @@ static ssize_t show_sustain(struct device *dev, struct device_attribute *attr, char *buf) { struct hid_device *hdev = to_hid_device(dev); -struct pk_device *pk =hid_get_drvdata (hdev); +struct pcmidi_snd *pm =hid_get_drvdata (hdev); -dbg_hid ("pcmidi sysfs read sustain=%u\n" , pk->pm->midi_sustain); +dbg_hid ("pcmidi sysfs read sustain=%u\n" , pm->midi_sustain); -return sprintf (buf,"%u (off:%u, max:%u (ms))\n" , pk->pm->midi_sustain, +return sprintf (buf,"%u (off:%u, max:%u (ms))\n" , pm->midi_sustain,PCMIDI_SUSTAIN_MIN ,PCMIDI_SUSTAIN_MAX ); }
@@ -150,15 +143,14 @@ static ssize_t store_sustain(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { struct hid_device *hdev = to_hid_device(dev); -struct pk_device *pk =hid_get_drvdata (hdev); +struct pcmidi_snd *pm =hid_get_drvdata (hdev);unsigned sustain =0 ;if (sscanf (buf,"%u" , &sustain) >0 && sustain <=PCMIDI_SUSTAIN_MAX ) {dbg_hid ("pcmidi sysfs write sustain=%u\n" , sustain); - pk->pm->midi_sustain = sustain; - pk->pm->midi_sustain_mode = - (0 == sustain || !pk->pm->midi_mode) ?0 :1 ; + pm->midi_sustain = sustain; + pm->midi_sustain_mode = (0 == sustain || !pm->midi_mode) ?0 :1 ;return strlen (buf); }return -EINVAL ;
@@ -176,11 +168,11 @@ static ssize_t show_octave(struct device *dev, struct device_attribute *attr, char *buf) { struct hid_device *hdev = to_hid_device(dev); -struct pk_device *pk =hid_get_drvdata (hdev); +struct pcmidi_snd *pm =hid_get_drvdata (hdev); -dbg_hid ("pcmidi sysfs read octave=%d\n" , pk->pm->midi_octave); +dbg_hid ("pcmidi sysfs read octave=%d\n" , pm->midi_octave); -return sprintf (buf,"%d (min:%d, max:%d)\n" , pk->pm->midi_octave, +return sprintf (buf,"%d (min:%d, max:%d)\n" , pm->midi_octave,PCMIDI_OCTAVE_MIN ,PCMIDI_OCTAVE_MAX ); }
@@ -189,14 +181,14 @@ static ssize_t store_octave(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { struct hid_device *hdev = to_hid_device(dev); -struct pk_device *pk =hid_get_drvdata (hdev); +struct pcmidi_snd *pm =hid_get_drvdata (hdev);int octave =0 ;if (sscanf (buf,"%d" , &octave) >0 && octave >=PCMIDI_OCTAVE_MIN && octave <=PCMIDI_OCTAVE_MAX ) {dbg_hid ("pcmidi sysfs write octave=%d\n" , octave); - pk->pm->midi_octave = octave; + pm->midi_octave = octave;return strlen (buf); }return -EINVAL ;
@@ -270,7 +262,7 @@ static void stop_sustain_timers(struct pcmidi_snd *pm)static int pcmidi_get_output_report (struct pcmidi_snd *pm) { -struct hid_device *hdev = pm->pk->hdev; +struct hid_device *hdev = pm->hdev;struct hid_report *report; list_for_each_entry(report,
@@ -295,7 +287,7 @@ static int pcmidi_get_output_report(struct pcmidi_snd *pm)static void pcmidi_submit_output_report (struct pcmidi_snd *pm,int state) { -struct hid_device *hdev = pm->pk->hdev; +struct hid_device *hdev = pm->hdev;struct hid_report *report = pm->pcmidi_report6; report->field[0 ]->value[0 ] =0x01 ; report->field[0 ]->value[1 ] = state;
@@ -626,7 +618,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm)/* Setup sound card */ - err =snd_card_new (&pm->pk->hdev->dev, index[dev], id[dev], + err =snd_card_new (&pm->hdev->dev, index[dev], id[dev],THIS_MODULE ,0 , &card);if (err <0 ) {pk_error ("failed to create pc-midi sound card\n" );
@@ -664,7 +656,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm) &pcmidi_in_ops);/* create sysfs variables */ - err =device_create_file (&pm->pk->hdev->dev, + err =device_create_file (&pm->hdev->dev, sysfs_device_attr_channel);if (err <0 ) { pk_error("failed to create sysfs attribute channel: error %d\n",
@@ -672,7 +664,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm) goto fail; } - err =device_create_file (&pm->pk->hdev->dev, + err =device_create_file (&pm->hdev->dev, sysfs_device_attr_sustain);if (err <0 ) { pk_error("failed to create sysfs attribute sustain: error %d\n",
@@ -680,7 +672,7 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm) goto fail_attr_sustain; } - err =device_create_file (&pm->pk->hdev->dev, + err =device_create_file (&pm->hdev->dev, sysfs_device_attr_octave);if (err <0 ) { pk_error("failed to create sysfs attribute octave: error %d\n",
@@ -710,11 +702,11 @@ static int pcmidi_snd_initialise(struct pcmidi_snd *pm) fail_register:stop_sustain_timers (pm); -device_remove_file (&pm->pk->hdev->dev, sysfs_device_attr_octave); +device_remove_file (&pm->hdev->dev, sysfs_device_attr_octave); fail_attr_octave: -device_remove_file (&pm->pk->hdev->dev, sysfs_device_attr_sustain); +device_remove_file (&pm->hdev->dev, sysfs_device_attr_sustain); fail_attr_sustain: -device_remove_file (&pm->pk->hdev->dev, sysfs_device_attr_channel); +device_remove_file (&pm->hdev->dev, sysfs_device_attr_channel); fail:if (pm->card) {snd_card_free (pm->card);
@@ -728,12 +720,9 @@ static int pcmidi_snd_terminate(struct pcmidi_snd *pm)if (pm->card) {stop_sustain_timers (pm); -device_remove_file (&pm->pk->hdev->dev, - sysfs_device_attr_channel); -device_remove_file (&pm->pk->hdev->dev, - sysfs_device_attr_sustain); -device_remove_file (&pm->pk->hdev->dev, - sysfs_device_attr_octave); +device_remove_file (&pm->hdev->dev, sysfs_device_attr_channel); +device_remove_file (&pm->hdev->dev, sysfs_device_attr_sustain); +device_remove_file (&pm->hdev->dev, sysfs_device_attr_octave);snd_card_disconnect (pm->card);snd_card_free_when_closed (pm->card);
@@ -763,10 +752,7 @@ static int pk_input_mapping(struct hid_device *hdev, struct hid_input *hi, struct hid_field *field, struct hid_usage *usage, unsigned long **bit, int *max) { - struct pk_device *pk = hid_get_drvdata(hdev); -struct pcmidi_snd *pm; - - pm = pk->pm; + struct pcmidi_snd *pm = hid_get_drvdata(hdev);if (HID_UP_MSVENDOR == (usage->hid &HID_USAGE_PAGE ) &&1 == pm->ifnum) {
@@ -781,16 +767,16 @@ static int pk_input_mapping(struct hid_device *hdev, struct hid_input *hi,static int pk_raw_event (struct hid_device *hdev,struct hid_report *report,u8 *data,int size) { -struct pk_device *pk =hid_get_drvdata (hdev); +struct pcmidi_snd *pm =hid_get_drvdata (hdev);int ret =0 ; -if (1 == pk->pm->ifnum) { +if (1 == pm->ifnum) {if (report->id == data[0 ])switch (report->id) {case 0x01 :/* midi keys (qwerty)*/ case 0x03 :/* midi keyboard (musical)*/ case 0x04 :/* extra/midi keys (qwerty)*/ - ret =pcmidi_handle_report (pk->pm, + ret =pcmidi_handle_report (pm, report->id, data, size);break ; }
@@ -805,8 +791,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)struct usb_interface *intf;unsigned short ifnum;unsigned long quirks = id->driver_data; -struct pk_device *pk; -struct pcmidi_snd *pm =NULL ; +struct pcmidi_snd *pm;if (!hid_is_usb (hdev))return -EINVAL ;
@@ -814,26 +799,16 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) intf =to_usb_interface (hdev->dev.parent); ifnum = intf->cur_altsetting->desc.bInterfaceNumber; - pk =kzalloc (sizeof (*pk),GFP_KERNEL ); -if (pk ==NULL ) { -hid_err (hdev,"can't alloc descriptor\n" ); -return -ENOMEM ; - } - - pk->hdev = hdev; - pm =kzalloc (sizeof (*pm),GFP_KERNEL );if (pm ==NULL ) {hid_err (hdev,"can't alloc descriptor\n" ); - ret = -ENOMEM ; - goto err_free_pk; +return -ENOMEM ; } - pm->pk = pk; - pk->pm = pm; + pm->hdev = hdev; pm->ifnum = ifnum; -hid_set_drvdata (hdev, pk); +hid_set_drvdata (hdev, pm); ret =hid_parse (hdev);if (ret) {
@@ -860,26 +835,18 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)hid_hw_stop (hdev); err_free:kfree (pm); -err_free_pk: -kfree (pk);return ret; }static void pk_remove (struct hid_device *hdev) { -struct pk_device *pk =hid_get_drvdata (hdev); -struct pcmidi_snd *pm; - - pm = pk->pm; -if (pm) { -pcmidi_snd_terminate (pm); -kfree (pm); - } +struct pcmidi_snd *pm =hid_get_drvdata (hdev); +pcmidi_snd_terminate (pm);hid_hw_stop (hdev); -kfree (pk); +kfree (pm); }static const struct hid_device_id pk_devices[] = {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 640/1848 HID: prodikeys: validate fixed-format MIDI reports
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jiale Yao <[email protected]>
[ Upstream commit 0ff37294c41bd925258893310398bc2b45fcd4a7 ]
The HID core invokes raw_event callbacks before validating the report length. Prodikeys reports 0x01 and 0x04 are passed to handlers that always read bytes one through three, regardless of the supplied size. A truncated report can therefore cause an out-of-bounds read.
Require four bytes for the two fixed-format reports. Keep report 0x03 on its existing variable-length path, which derives the number of note pairs from size and only accesses complete pairs.
Commit 47669bec44fe ("HID: asus: refactor the two workqueues and init sequence") added the same kind of raw_event length validation to hid-asus.
--- drivers/hid/hid-prodikeys.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/hid/hid-prodikeys.c +6 -1
@@ -774,8 +774,13 @@ static int pk_raw_event(struct hid_device *hdev, struct hid_report *report,if (report->id == data[0 ])switch (report->id) {case 0x01 :/* midi keys (qwerty)*/ -case 0x03 :/* midi keyboard (musical)*/ case 0x04 :/* extra/midi keys (qwerty)*/ +if (size <4 ) +break ; + ret =pcmidi_handle_report (pm, report->id, + data, size); +break ; +case 0x03 :/* midi keyboard (musical)*/ ret =pcmidi_handle_report (pm, report->id, data, size);break ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 641/1848 mlxsw: Initialize register query payloads
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Til Kaiser <[email protected]>
[ Upstream commit 15b7a86a8888dc6a8fd19e181757e32389de9064 ]
MFGD register queries can exhaust EMAD retries and leave Mellanox Spectrum switches stuck during boot or shutdown when running OpenWrt built with GCC 15.
An example failure is shown below with the second line wrapped:
EMAD retries (5/5) (tid=9b544fc100001f35)
EMAD reg access failed (tid=9b544fc100001f35,reg_id=90f0(mfgd),
type=query,status=0(operation performed))
On an SN2100, the failure occurs during driver teardown on reboot. On an SN3420, it occurs while probing mlxsw_spectrum during boot.
The register query API transmits the supplied payload to the device before replacing it with the response. Both MFGD callers pass an uninitialized stack buffer, so the request contains arbitrary register field values and reserved bits. This makes the request depend on stack contents and compiler code generation.
Initialize both MFGD query buffers in the firmware fatal event configuration and reporter test paths. The initialization has been confirmed to eliminate the boot and shutdown hangs on both switches. The subsequent read-modify-write still preserves the other fields returned by the device.
Also initialize the FORE fan fault query and the MOGCR mirroring policer base query, which pass entirely uninitialized payloads.
This follows commit 5b0907407e7f ("mlxsw: core: Zero payload buffers for couple of registers"), which initialized other query payloads after a firmware field length bug caused firmware to consume uninitialized data.
Tested with firmware 2020.1148 and with 2016.3900 from linux-firmware.
--- drivers/net/ethernet/mellanox/mlxsw/core.c | 4 ++-- drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c | 2 +- drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/core.c +2 -2
@@ -1781,7 +1781,7 @@ mlxsw_core_health_fw_fatal_test(struct devlink_health_reporter *reporter, struct netlink_ext_ack *extack) {struct mlxsw_core *mlxsw_core =devlink_health_reporter_priv (reporter); -char mfgd_pl[MLXSW_REG_MFGD_LEN ]; +char mfgd_pl[MLXSW_REG_MFGD_LEN ] = {0 };int err;/* Read the register first to make sure no other bits are changed. */
@@ -1802,7 +1802,7 @@ mlxsw_core_health_fw_fatal_ops = {static int mlxsw_core_health_fw_fatal_config (struct mlxsw_core *mlxsw_core,bool enable) { -char mfgd_pl[MLXSW_REG_MFGD_LEN ]; +char mfgd_pl[MLXSW_REG_MFGD_LEN ] = {0 };int err;/* Read the register first to make sure no other bits are changed. */
drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c +1 -1
@@ -160,7 +160,7 @@ static ssize_t mlxsw_hwmon_fan_fault_show(struct device *dev,struct mlxsw_hwmon_attr *mlwsw_hwmon_attr = container_of(attr, struct mlxsw_hwmon_attr, dev_attr);struct mlxsw_hwmon *mlxsw_hwmon = mlwsw_hwmon_attr->hwmon; -char fore_pl[MLXSW_REG_FORE_LEN ]; +char fore_pl[MLXSW_REG_FORE_LEN ] = {0 };bool fault;int err;
drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c +1 -1
@@ -1690,7 +1690,7 @@ static int mlxsw_sp2_span_init(struct mlxsw_sp *mlxsw_sp)static int mlxsw_sp2_span_policer_id_base_set (struct mlxsw_sp *mlxsw_sp,u16 policer_id_base) { -char mogcr_pl[MLXSW_REG_MOGCR_LEN ]; +char mogcr_pl[MLXSW_REG_MOGCR_LEN ] = {0 };int err; err =mlxsw_reg_query (mlxsw_sp->core,MLXSW_REG (mogcr), mogcr_pl);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 642/1848 fsverity: Explicitly require FMODE_READ to retrieve hashes
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit 1acb4fd2d011c4bd6cc961095ae17361c71ff61a upstream.
The comment in fsverity_ioctl_read_metadata(), which justifies not checking for FMODE_READ, doesn't consider that the nonstandard access mode 3 (ioctl-only) exists.
Opening an ioctl-only fd generally requires read (and write) permission. However, there are gaps with certain LSMs: an ioctl-only fd requests read (and write) permission via security_inode_permission, but not security_file_open. With certain LSMs relying on the latter, such as Landlock and AppArmor, an ioctl-only fd can be opened without the LSM granting read (and write) permission.
Since FS_IOC_READ_VERITY_METADATA returns hashes of file contents blocks, it should require read permission. This also applies to FS_IOC_MEASURE_VERITY, which returns a hash for the whole file.
Meanwhile, ioctl-only fds are a rarely-used feature, not known to be used with either ioctl.
Therefore, just disallow these ioctls on ioctl-only file descriptors, similar to what was already done with FS_IOC_ENABLE_VERITY.
More specifically, explicitly check for FMODE_READ. This also covers write-only fds to non-verity files which otherwise would have failed with ENODATA. This change in error code for write-only fds should be fine too, as these ioctls cannot be usefully used with write-only fds anyway, but it's worth noting as another technicality.
(5.10: dropped the FS_IOC_READ_VERITY_METADATA changes, since that ioctl
does not exist in this version)
--- Documentation/filesystems/fsverity.rst | 2 ++ fs/verity/measure.c | 10 ++++++++++ 2 files changed, 12 insertions(+)
Documentation/filesystems/fsverity.rst +2 -0
@@ -146,6 +146,7 @@ fatal signal), no changes are made to the file. FS_IOC_ENABLE_VERITY can fail with the following errors: - ``EACCES``: the process does not have write access to the file +- ``EBADF``: the file descriptor is not open for reading - ``EBADMSG``: the signature is malformed - ``EBUSY``: this ioctl is already running on the file - ``EEXIST``: the file already has verity enabled
@@ -207,6 +208,7 @@ regardless of the size of the file. FS_IOC_MEASURE_VERITY can fail with the following errors: +- ``EBADF``: the file descriptor is not open for reading - ``EFAULT``: the caller provided inaccessible memory - ``ENODATA``: the file is not a verity file - ``ENOTTY``: this type of filesystem does not implement fs-verity
fs/verity/measure.c +10 -0
@@ -28,6 +28,16 @@ int fsverity_ioctl_measure(struct file *filp, void __user *_uarg)const struct fsverity_hash_alg *hash_alg;struct fsverity_digest arg; +/* +* This ioctl returns a hash of the file contents, so it should require +* read permission. Disallow it on ioctl-only (i.e., nonstandard access +* mode 3) fds, which can in some cases be acquired without passing all +* LSM read-permission checks. Also disallow write-only fds, which can +* refer only to non-verity files which would fail with ENODATA anyway. +*/ +if (!(filp->f_mode &FMODE_READ )) +return -EBADF ; + vi =fsverity_get_info (inode);if (!vi)return -ENODATA ;/* not a verity file */
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 643/1848 fs-verity: factor out fsverity_get_descriptor()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit c2c8261151b32f1956fc4ecd71c9a3e7972084b6 upstream.
The FS_IOC_READ_VERITY_METADATA ioctl will need to return the fs-verity descriptor (and signature) to userspace.
There are a few ways we could implement this:
- Save a copy of the descriptor (and signature) in the fsverity_info struct that hangs off of the in-memory inode. However, this would waste memory since most of the time it wouldn't be needed.
- Regenerate the descriptor from the merkle_tree_params in the fsverity_info. However, this wouldn't work for the signature, nor for the salt which the merkle_tree_params only contains indirectly as part of the 'hashstate'. It would also be error-prone.
- Just get them from the filesystem again. The disadvantage is that in general we can't trust that they haven't been maliciously changed since the file has opened. However, the use cases for FS_IOC_READ_VERITY_METADATA don't require that it verifies the chain of trust. So this is okay as long as we do some basic validation.
In preparation for implementing the third option, factor out a helper function fsverity_get_descriptor() which gets the descriptor (and appended signature) from the filesystem and does some basic validation.
As part of this, start checking the sig_size field for overflow. Currently fsverity_verify_signature() does this. But the new ioctl will need this too, so do it earlier.
--- fs/verity/fsverity_private.h | 7 +- fs/verity/open.c | 130 +++++++++++++++++++++++------------ 2 files changed, 91 insertions(+), 46 deletions(-)
fs/verity/fsverity_private.h +6 -1
@@ -152,12 +152,17 @@ int fsverity_init_merkle_tree_params(struct merkle_tree_params *params, const u8 *salt, size_t salt_size);struct fsverity_info *fsverity_create_info (const struct inode *inode, -void *desc,size_t desc_size); +struct fsverity_descriptor *desc, +size_t desc_size);void fsverity_set_info (struct inode *inode,struct fsverity_info *vi);void fsverity_free_info (struct fsverity_info *vi); +int fsverity_get_descriptor (struct inode *inode, +struct fsverity_descriptor **desc_ret, +size_t *desc_size_ret); +int __init fsverity_init_info_cache (void );void __init fsverity_exit_info_cache (void );
fs/verity/open.c +85 -45
165 lines not on this page · raw message
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 644/1848 fsverity: Be more careful with return value of ->get_verity_descriptor()
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit 8f8faec82aa902b1997ae578c46bcc84afbad811 upstream.
If fsverity_operations::get_verity_descriptor() returns that the verity descriptor has 0 size, then a zero-size buffer is allocated to hold it, and it's called again with bufsize=0.
But bufsize=0 is a special case that says to return the actual size. If in the meantime the filesystem has decided that the size is some actually valid size, it will return that size, and then validate_fsverity_descriptor() will read from ZERO_SIZE_PTR and crash.
Of course, for the filesystem to misbehave in that strange way, it generally would require direct writes to the block device.
Regardless, fsverity_get_descriptor() might as well guard against it. Make it do so. Specifically, validate that the first call to ->get_verity_descriptor() returns at least the minimum descriptor size, and validate that the second call returns the same size as the first.
--- fs/verity/open.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-)
fs/verity/open.c +19 -19
@@ -221,12 +221,6 @@ static bool validate_fsverity_descriptor(struct inode *inode,const struct fsverity_descriptor *desc, size_t desc_size) { - if (desc_size < sizeof(*desc)) { - fsverity_err(inode, "Unrecognized descriptor size: %zu bytes", - desc_size); -return false; - } - if (desc->version != 1) { fsverity_err(inode, "Unrecognized descriptor version: %u", desc->version);
@@ -266,31 +260,37 @@ int fsverity_get_descriptor(struct inode *inode,struct fsverity_descriptor **desc_ret, size_t *desc_size_ret) { - int res; + int size, res;struct fsverity_descriptor *desc; - res = inode->i_sb->s_vop->get_verity_descriptor (inode,NULL ,0 ); -if (res <0 ) { -fsverity_err (inode, -"Error %d getting verity descriptor size" , res); -return res; + size = inode->i_sb->s_vop->get_verity_descriptor (inode,NULL ,0 ); +if (size <0 ) { +fsverity_err (inode,"Error %d getting verity descriptor size" , + size); +return size; } -if (res >FS_VERITY_MAX_DESCRIPTOR_SIZE ) { -fsverity_err (inode,"Verity descriptor is too large (%d bytes)" , - res); +if (size <sizeof (*desc) || size >FS_VERITY_MAX_DESCRIPTOR_SIZE ) { +fsverity_err (inode, +"Verity descriptor has invalid size (%d bytes)" , + size);return -EMSGSIZE ; } - desc =kmalloc (res,GFP_KERNEL ); + desc =kmalloc (size,GFP_KERNEL );if (!desc)return -ENOMEM ; - res = inode->i_sb->s_vop->get_verity_descriptor (inode, desc, res); + res = inode->i_sb->s_vop->get_verity_descriptor (inode, desc, size);if (res <0 ) {fsverity_err (inode,"Error %d reading verity descriptor" , res);kfree (desc);return res; } - -if (!validate_fsverity_descriptor (inode, desc, res)) { +if (res != size) { +fsverity_err (inode,"Verity descriptor size changed (%d => %d)" , + size, res); +kfree (desc); +return -EINVAL ; + } +if (!validate_fsverity_descriptor (inode, desc, size)) {kfree (desc);return -EINVAL ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 645/1848 xor: add missing vzeroupper to AVX code
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit 7b8fc26c40d6cf4c6751a045c9e42bbb7e78d81b upstream.
Since the AVX optimized XOR code uses YMM registers, execute vzeroupper before returning from it. This is needed to avoid degrading the performance of any later SSE code that may happen to be executed.
(Backported to the old organization of the XOR code.)
--- arch/x86/include/asm/xor_avx.h | 4 ++++ 1 file changed, 4 insertions(+)
arch/x86/include/asm/xor_avx.h +4 -0
@@ -49,6 +49,7 @@ do { \ p1 = (unsigned long *)((uintptr_t )p1 +512 ); } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -79,6 +80,7 @@ do { \ p2 = (unsigned long *)((uintptr_t )p2 +512 ); } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -112,6 +114,7 @@ do { \ p3 = (unsigned long *)((uintptr_t )p3 +512 ); } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -148,6 +151,7 @@ do { \ p4 = (unsigned long *)((uintptr_t )p4 +512 ); } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 646/1848 raid6: add missing vzeroupper to AVX-512 code
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit b82cf9e49c1be7cf1fd8e1bd806b0cdd25ab8127 upstream.
Since the AVX-512 optimized RAID6 code uses ZMM registers, execute vzeroupper before returning from it. This is needed to avoid degrading the performance of any later SSE code that may happen to be executed.
--- lib/raid6/avx512.c | 6 ++++++ lib/raid6/recov_avx512.c | 2 ++ 2 files changed, 8 insertions(+)
lib/raid6/avx512.c +6 -0
@@ -95,6 +95,7 @@ static void raid6_avx5121_gen_syndrome(int disks, size_t bytes, void **ptrs) } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -154,6 +155,7 @@ static void raid6_avx5121_xor_syndrome(int disks, int start, int stop, } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -227,6 +229,7 @@ static void raid6_avx5122_gen_syndrome(int disks, size_t bytes, void **ptrs) } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -311,6 +314,7 @@ static void raid6_avx5122_xor_syndrome(int disks, int start, int stop, } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -417,6 +421,7 @@ static void raid6_avx5124_gen_syndrome(int disks, size_t bytes, void **ptrs) } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -550,6 +555,7 @@ static void raid6_avx5124_xor_syndrome(int disks, int start, int stop, "m" (q[d+128]), "m" (q[d+192])); } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }const struct raid6_calls raid6_avx512x4 = {
lib/raid6/recov_avx512.c +2 -0
@@ -221,6 +221,7 @@ static void raid6_2data_recov_avx512(int disks, size_t bytes, int faila,#endif } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -363,6 +364,7 @@ static void raid6_datap_recov_avx512(int disks, size_t bytes, int faila,#endif } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 647/1848 ACPI: CPPC: Validate FFH register fields before hardware access
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian Loehle <[email protected]>
commit 6b016c5c96448c0a5f09328d37f66562d154a5e5 upstream.
The x86 CPPC FFH accessors construct masks and shift values using the firmware's Bit Width and Bit Offset without checking that the field fits in an MSR. A zero-width field or a field extending beyond bit 63 can therefore cause an invalid shift. The safe MSR accessors only handle an access fault, not invalid field arithmetic after a successful read.
Also, the 64-bit GAS address is implicitly narrowed to the 32-bit MSR number. A descriptor with nonzero upper address bits can access a different MSR from the one described by firmware.
The arm64 AMU counter readers have the same unchecked field arithmetic. Validate the field bounds before reading a counter, including both descriptors in the paired counter path.
Dispatch FFH accesses before decoding the GAS Access Size in the common read and write paths. Otherwise, a large access_width can trigger an invalid shift in GET_BIT_WIDTH() before the architecture validates its register. That field has architecture-specific FFH semantics and is not needed by the generic memory/port accessor on this path.
Validate x86 MSR addresses and share the field-bounds checks between related accessors within each architecture.
--- arch/x86/kernel/acpi/cppc_msr.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
arch/x86/kernel/acpi/cppc_msr.c +15 -0
@@ -4,6 +4,8 @@* Copyright (c) 2016, Intel Corporation. */ +#include <linux/limits.h> +#include <acpi/cppc_acpi.h> #include <asm/msr.h>
@@ -14,10 +16,20 @@ bool cpc_ffh_supported(void)return true; } +static bool cpc_ffh_reg_valid (const struct cpc_reg *reg) +{ +return reg->address <=U32_MAX && reg->bit_width && + reg->bit_width <=64 && + reg->bit_offset <=64 - reg->bit_width; +} +int cpc_read_ffh (int cpunum,struct cpc_reg *reg,u64 *val) {int err; +if (!cpc_ffh_reg_valid (reg)) +return -EINVAL ; + err =rdmsrl_safe_on_cpu (cpunum, reg->address, val);if (!err) { u64 mask = GENMASK_ULL(reg->bit_offset + reg->bit_width - 1,
@@ -34,6 +46,9 @@ int cpc_write_ffh(int cpunum, struct cpc_reg *reg, u64 val)u64 rd_val;int err; +if (!cpc_ffh_reg_valid (reg)) +return -EINVAL ; + err =rdmsrl_safe_on_cpu (cpunum, reg->address, &rd_val);if (!err) { u64 mask = GENMASK_ULL(reg->bit_offset + reg->bit_width - 1,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 648/1848 pppoe: delete session hash entries by pointer match
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Qingfang Deng <[email protected]>
[ Upstream commit b5b8c81836e2bec7b444dfa2b14fd14e912e9d63 ]
pppoe_connect() copies the requested PPPoE address to a socket before attempting to insert the socket into the session hash table. If the tuple already exists, __set_item() returns -EALREADY, but the copied address and ifindex remain set on the failed socket.
Closing that socket then deletes the existing socket's hash entry through pppoe_release(), preventing it from receiving further session traffic. An unprivileged process in the same network namespace can trigger this through a duplicate connection attempt.
To avoid the accidental delete, pass the pppox_sock to __delete_item(), and unlink only an entry whose pointer matches the requested socket.
[ Resolve conflict, and remove const qualifier of pppox_sock to match
hash_item(). ]
--- drivers/net/ppp/pppoe.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)
drivers/net/ppp/pppoe.c +8 -14
@@ -194,18 +194,16 @@ static int __set_item(struct pppoe_net *pn, struct pppox_sock *po)return 0 ; } -static void __delete_item (struct pppoe_net *pn,__be16 sid, -char *addr,int ifindex) +static void __delete_item (struct pppoe_net *pn,struct pppox_sock *po) { -int hash =hash_item (sid, addr); +int hash =hash_item (po->pppoe_pa.sid, po->pppoe_pa.remote);struct pppox_sock *ret, **src; ret = pn->hash_table[hash]; src = &pn->hash_table[hash];while (ret) { -if (cmp_addr (&ret->pppoe_pa, sid, addr) && - ret->pppoe_ifindex == ifindex) { +if (ret == po) { *src = ret->next;break ; }
@@ -255,11 +253,10 @@ static inline struct pppox_sock *get_item_by_addr(struct net *net,return pppox_sock; } -static inline void delete_item (struct pppoe_net *pn,__be16 sid, -char *addr,int ifindex) +static void delete_item (struct pppoe_net *pn,struct pppox_sock *po) {write_lock_bh (&pn->hash_lock); -__delete_item (pn, sid, addr, ifindex); +__delete_item (pn, po);write_unlock_bh (&pn->hash_lock); }
@@ -599,8 +596,7 @@ static int pppoe_release(struct socket *sock)* protect "po" from concurrent updates * on pppoe_flush_dev */ -delete_item (pn, po->pppoe_pa.sid, po->pppoe_pa.remote, - po->pppoe_ifindex); +delete_item (pn, po);sock_orphan (sk); sock->sk =NULL ;
@@ -651,8 +647,7 @@ static int pppoe_connect(struct socket *sock, struct sockaddr *uservaddr,if (stage_session (po->pppoe_pa.sid)) {pppox_unbind_sock (sk); pn =pppoe_pernet (sock_net (sk)); -delete_item (pn, po->pppoe_pa.sid, - po->pppoe_pa.remote, po->pppoe_ifindex); +delete_item (pn, po);if (po->pppoe_dev) {dev_put (po->pppoe_dev); po->pppoe_dev =NULL ;
@@ -702,8 +697,7 @@ static int pppoe_connect(struct socket *sock, struct sockaddr *uservaddr, error =ppp_register_net_channel (dev_net (dev), &po->chan);if (error) { -delete_item (pn, po->pppoe_pa.sid, - po->pppoe_pa.remote, po->pppoe_ifindex); +delete_item (pn, po); goto err_put; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 649/1848 xfs: allow softlimit with no hardlimit in quota scrub
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Darrick J. Wong <[email protected]>
[ Upstream commit 342c2e00b3a99099a7088f7b8c8f075670c603a9 ]
LOLLM observes that the sysadmin can set a user's soft limit to a nonzero value and the hard limit to zero, so those aren't corruptions.
--- fs/xfs/scrub/quota.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
fs/xfs/scrub/quota.c +4 -4
@@ -103,21 +103,21 @@ xchk_quota_item(* suspect, which is why we flag it for review. * * Complain about corruption if the soft limit is greater than -* the hard limit. +* the hard limit and there's a hard limit set. */ if (dq->q_blk.hardlimit > mp->m_sb.sb_dblocks)xchk_fblock_set_warning (sc,XFS_DATA_FORK , offset); -if (dq->q_blk.softlimit > dq->q_blk.hardlimit) +if (dq->q_blk.hardlimit && dq->q_blk.softlimit > dq->q_blk.hardlimit)xchk_fblock_set_corrupt (sc,XFS_DATA_FORK , offset);if (dq->q_ino.hardlimit >M_IGEO (mp)->maxicount)xchk_fblock_set_warning (sc,XFS_DATA_FORK , offset); -if (dq->q_ino.softlimit > dq->q_ino.hardlimit) +if (dq->q_ino.hardlimit && dq->q_ino.softlimit > dq->q_ino.hardlimit)xchk_fblock_set_corrupt (sc,XFS_DATA_FORK , offset);if (dq->q_rtb.hardlimit > mp->m_sb.sb_rblocks)xchk_fblock_set_warning (sc,XFS_DATA_FORK , offset); -if (dq->q_rtb.softlimit > dq->q_rtb.hardlimit) +if (dq->q_rtb.hardlimit && dq->q_rtb.softlimit > dq->q_rtb.hardlimit)xchk_fblock_set_corrupt (sc,XFS_DATA_FORK , offset);/* Check the resource counts. */
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 650/1848 xfs: rescan the AGs if incore delalloc counter is negative
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Darrick J. Wong <[email protected]>
[ Upstream commit 47b1e941bb55f735d82ba2649412260da78b98f8 ]
LOLLM complains that percpu_counter_sum can return a negative number but we instead misinterpret that into a huge unsigned value and do bad things to fdblocks. It shouldn't do that, so let's add a retry loop and an attempt to freeze the filesystem to (hopefully) zero out the incore delalloc counter. It probably won't work, but at least failing the repair beats doing the wrong thing.
--- fs/xfs/scrub/fscounters.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
fs/xfs/scrub/fscounters.c +6 -1
@@ -157,7 +157,7 @@ xchk_fscount_aggregate_agcounts( {struct xfs_mount *mp = sc->mp;struct xfs_perag *pag; -uint64_t delayed; +int64_t delayed;xfs_agnumber_t agno;int tries =8 ;int error =0 ;
@@ -213,6 +213,11 @@ xchk_fscount_aggregate_agcounts(* of the computation. */ delayed =percpu_counter_sum (&mp->m_delalloc_blks); +if (delayed <0 ) { +ASSERT (delayed >=0 ); +xchk_set_incomplete (sc); +return -EFSCORRUPTED ; + } fsc->fdblocks -= delayed; trace_xchk_fscounters_calc(mp, fsc->icount, fsc->ifree, fsc->fdblocks,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 651/1848 xfs: reject absurdly large xattr value lengths in xchk_xattr_actor
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Darrick J. Wong <[email protected]>
[ Upstream commit fd012955641881169a9f01a00f656f6ca73842ec ]
LOLLM suggests that we shouldn't try to allocate absurdly large buffers for xattr value checks because that will push reclaim very hard, never succeed, and is pointless because nobody can create xattrs that large. Since the xattr repair code ignores values larger than XATTR_SIZE_MAX, we can flag the corruption and return early.
--- fs/xfs/scrub/attr.c | 6 ++++++ 1 file changed, 6 insertions(+)
fs/xfs/scrub/attr.c +6 -0
@@ -134,6 +134,12 @@ xchk_xattr_listent(return ; } +/* Don't even try to handle a bizarrely large xattr. */ +if (valuelen >XATTR_SIZE_MAX ) { +xchk_fblock_set_corrupt (sx->sc,XFS_ATTR_FORK , args.blkno); + goto fail_xref; + } +/* * Try to allocate enough memory to extrat the attr value. If that * doesn't work, we overload the seen_enough variable to convey
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 652/1848 xfs: bound da-node entry count against the correct geometry
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Aldo Ariel Panzardo <[email protected]>
[ Upstream commit 3df5e5aaa3bc0913236c48ab29b7df3a785aa29f ]
xfs_da3_node_verify() bounds the node entry count against the larger of the directory and attribute geometries because, as a buffer verifier, it cannot tell whether the block belongs to the directory or the attribute tree. When the directory block size exceeds the fs block size (e.g. mkfs.xfs -n size=64k -b size=4k), an attribute node buffer is a single fs block that holds only m_attr_geo->node_ents entries, yet a crafted attr node may claim a count up to m_dir_geo->node_ents and still pass the verifier.
xfs_da3_node_lookup_int() then indexes btree[] up to that count during its binary search -- an out-of-bounds read via getxattr/listxattr on a mounted crafted image.
The buffer verifier is the wrong place to tighten this: it has no fork context, and the transaction-less read path used by getxattr does not run xfs_da3_node_set_type() either. xfs_da3_node_lookup_int(), on the other hand, always runs on that path and holds args->geo, the geometry of the fork actually being searched. Bound the entry count against args->geo->node_ents there, before walking the entries.
--- fs/xfs/libxfs/xfs_da_btree.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
fs/xfs/libxfs/xfs_da_btree.c +13 -0
@@ -1658,6 +1658,19 @@ xfs_da3_node_lookup_int( }else expected_level--; +/* +* The node verifier cannot tell whether this block belongs to +* the directory or the attribute tree, so it only bounds the +* entry count against the larger of the two geometries. Here +* args->geo is the geometry of the fork we are actually +* searching, so reject a count that would walk btree[] off the +* end of this node buffer. +*/ +if (nodehdr.count > args->geo->node_ents) { +xfs_buf_mark_corrupt (blk->bp); +return -EFSCORRUPTED ; + } + max = nodehdr.count; blk->hashval =be32_to_cpu (btree[max -1 ].hashval);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 653/1848 raid6: add missing vzeroupper to AVX2 code
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit 24f1241cdb056fd630e6710a916e0f7c8c910a70 upstream.
Since the AVX2 optimized RAID6 code uses YMM registers, execute vzeroupper before returning from it. This is needed to avoid degrading the performance of any later SSE code that may happen to be executed.
--- lib/raid6/avx2.c | 6 ++++++ lib/raid6/recov_avx2.c | 2 ++ 2 files changed, 8 insertions(+)
lib/raid6/avx2.c +6 -0
@@ -76,6 +76,7 @@ static void raid6_avx21_gen_syndrome(int disks, size_t bytes, void **ptrs) } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -124,6 +125,7 @@ static void raid6_avx21_xor_syndrome(int disks, int start, int stop, } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -186,6 +188,7 @@ static void raid6_avx22_gen_syndrome(int disks, size_t bytes, void **ptrs) } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -254,6 +257,7 @@ static void raid6_avx22_xor_syndrome(int disks, int start, int stop, } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -347,6 +351,7 @@ static void raid6_avx24_gen_syndrome(int disks, size_t bytes, void **ptrs) } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -457,6 +462,7 @@ static void raid6_avx24_xor_syndrome(int disks, int start, int stop, asmvolatile ("vmovntdq %%ymm14,%0" :"=m" (q[d+96 ])); } asmvolatile ("sfence" : : :"memory" ); + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
lib/raid6/recov_avx2.c +2 -0
@@ -180,6 +180,7 @@ static void raid6_2data_recov_avx2(int disks, size_t bytes, int faila,#endif } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
@@ -297,6 +298,7 @@ static void raid6_datap_recov_avx2(int disks, size_t bytes, int faila,#endif } + asmvolatile ("vzeroupper" );kernel_fpu_end (); }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 654/1848 xfs: jump out of xchk_bmap_check_rmap if fatal signals
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Darrick J. Wong <[email protected]>
[ Upstream commit 49d300a51442bd64b627645b7b0b1cd66e492905 ]
LOLLM observes that we never check for fatal signals inside the loop that checks file fork mappings against the rmapbt. This can lead to lengthy delays in responding to a ^C, so add some bailout checks.
--- fs/xfs/scrub/bmap.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/xfs/scrub/bmap.c +7 -0
@@ -487,6 +487,10 @@ xchk_bmap_check_rmap(struct xfs_ifork *ifp;struct xfs_scrub *sc = sbcri->sc;bool have_map; +int error =0 ; + +if (xchk_should_terminate (sc, &error)) +return error;/* Is this even the right fork? */ if (rec->rm_owner != sc->ip->i_ino)
@@ -517,6 +521,9 @@ xchk_bmap_check_rmap(* entire rmap is covered by bmbt records. */ while (have_map) { +if (xchk_should_terminate (sc, &error)) +return error; +if (irec.br_startoff != rec->rm_offset)xchk_fblock_set_corrupt (sc, sbcri->whichfork, rec->rm_offset);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 655/1848 xfs: always report scrub errors in tracepoints
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Darrick J. Wong <[email protected]>
[ Upstream commit 1ccc8f553d885d49c1bfe141ea1f331511940b3a ]
LOLLM complains that the error processing functions in scrub will sometimes zero out *error before recording a tracepoint. This makes diagnosing problems harder, so let's fix that.
--- fs/xfs/scrub/btree.c | 8 +++++++- fs/xfs/scrub/common.c | 7 +++++-- fs/xfs/scrub/dabtree.c | 6 +++++- 3 files changed, 17 insertions(+), 4 deletions(-)
fs/xfs/scrub/btree.c +7 -1
@@ -44,8 +44,14 @@ __xchk_btree_process_error(case -ENODATA :/* Note the badness but don't abort. */ sc->sm->sm_flags |= errflag; +if (cur->bc_flags &XFS_BTREE_ROOT_IN_INODE ) +trace_xchk_ifork_btree_op_error (sc, cur, level, + *error, ret_ip); +else +trace_xchk_btree_op_error (sc, cur, level, + *error, ret_ip); *error =0 ; -/* fall through */ +break ;default :if (cur->bc_flags &XFS_BTREE_ROOT_IN_INODE ) trace_xchk_ifork_btree_op_error(sc, cur, level,
fs/xfs/scrub/common.c +5 -2
@@ -82,8 +82,9 @@ __xchk_process_error(case -ENODATA :/* Note the badness but don't abort. */ sc->sm->sm_flags |= errflag; +trace_xchk_op_error (sc, agno, bno, *error, ret_ip); *error =0 ; -/* fall through */ +break ;default :trace_xchk_op_error (sc, agno, bno, *error, ret_ip);
@@ -137,8 +138,10 @@ __xchk_fblock_process_error(case -ENODATA :/* Note the badness but don't abort. */ sc->sm->sm_flags |= errflag; +trace_xchk_file_op_error (sc, whichfork, offset, *error, + ret_ip); *error =0 ; -/* fall through */ +break ;default :trace_xchk_file_op_error (sc, whichfork, offset, *error, ret_ip);
fs/xfs/scrub/dabtree.c +5 -1
@@ -48,8 +48,12 @@ xchk_da_process_error(case -ENODATA :/* Note the badness but don't abort. */ sc->sm->sm_flags |=XFS_SCRUB_OFLAG_CORRUPT ; +trace_xchk_file_op_error (sc, ds->dargs.whichfork, +xfs_dir2_da_to_db (ds->dargs.geo, + ds->state->path.blk[level].blkno), + *error, __return_address); *error =0 ; -/* fall through */ +break ;default : trace_xchk_file_op_error(sc, ds->dargs.whichfork, xfs_dir2_da_to_db(ds->dargs.geo,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 656/1848 net: bgmac: enable interrupts only after NAPI is ready
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rosen Penev <[email protected]>
[ Upstream commit ac1f6e58cb77bb66b8811f7d98703e0f076a8f65 ]
bgmac_open() calls bgmac_chip_init(), which unmasks the interrupts and enables the MAC receiver, before request_irq() and napi_enable(). bgmac_enet_resume() also enables NAPI only after bgmac_chip_init().
When frames arrive in that window, the first RX interrupt masks all interrupts in bgmac_interrupt() and calls napi_schedule() on a NAPI instance that is still disabled, so nothing is scheduled. Nothing unmasks the interrupts again, the RX ring fills up and the interface stays deaf until it is brought down and up without traffic.
On an Asus RT-N16 (BCM4716) a single "ip link set eth0 down/up" while a host sends UDP to the router left INT_MASK at 0, INT_STATUS with RX pending and the RX DMA idle on a full ring, with the RX packet and interrupt counters no longer moving. With this change, 10 of 10 such cycles recovered on their own.
Request the IRQ and enable NAPI before the chip is initialized.
--- drivers/net/ethernet/broadcom/bgmac.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/ethernet/broadcom/bgmac.c +5 -5
@@ -1183,9 +1183,6 @@ static int bgmac_open(struct net_device *net_dev)if (err)return err; -/* Specs say about reclaiming rings here, but we do that in DMA init */ -bgmac_chip_init (bgmac); - err =request_irq (bgmac->irq, bgmac_interrupt,IRQF_SHARED , net_dev->name, net_dev);if (err <0 ) {
@@ -1195,6 +1192,9 @@ static int bgmac_open(struct net_device *net_dev) }napi_enable (&bgmac->napi); +/* Specs say about reclaiming rings here, but we do that in DMA init */ +bgmac_chip_init (bgmac); +phy_start (net_dev->phydev);netif_start_queue (net_dev);
@@ -1609,10 +1609,10 @@ int bgmac_enet_resume(struct bgmac *bgmac)if (rc)return rc; -bgmac_chip_init (bgmac); -napi_enable (&bgmac->napi); +bgmac_chip_init (bgmac); +netif_tx_lock (bgmac->net_dev);netif_device_attach (bgmac->net_dev);netif_tx_unlock (bgmac->net_dev);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 657/1848 spi: zynq-qspi: fix address buffer corruption and support 4-byte address
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pufan Jin <[email protected]>
[ Upstream commit dc5ca34f5e8dc10c566ef39aa3b1a201a17ca734 ]
In zynq_qspi_exec_mem_op(), when transmitting address bytes, the driver iterates over op->addr.nbytes and populates xqspi->txbuf[i]. However, xqspi->txbuf is never re-assigned before populating the address, meaning it still points to (u8 *)&op->cmd.opcode from the command phase.
This causes two severe issues:
1. Memory corruption: Writing into xqspi->txbuf writes past the opcode buffer on the stack (which was passed as const struct spi_mem_op *). If opcode is zero, xqspi->txbuf is uninitialized.
2. In zynq_qspi_supports_op(), operations with op->addr.nbytes > 3 are rejected. When paired with SPI NOR flashes larger than 16MB (such as Winbond W25Q256), spi_nor_spimem_check_read_pp_op() tests 4-byte address support, which fails and causes spi_nor_select_read() to drop all read capabilities, failing probe with -EINVAL (-22).
The Zynq-7000 QSPI controller hardware in manual I/O mode natively supports transmitting 1 to 4 address bytes via its TXD FIFO registers (ZYNQ_QSPI_TXD_00_00_OFFSET).
Fix this by introducing a local opaddr[4] buffer in zynq_qspi_exec_mem_op() and explicitly setting xqspi->txbuf = opaddr before populating address bytes. Also allow up to 4 address bytes in zynq_qspi_supports_op().
--- drivers/spi/spi-zynq-qspi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/spi/spi-zynq-qspi.c +4 -2
@@ -231,7 +231,7 @@ static bool zynq_qspi_supports_op(struct spi_mem *mem,/* * The number of address bytes should be equal to or less than 3 bytes. */ -if (op->addr.nbytes >3 ) +if (op->addr.nbytes >4 )return false;return true;
@@ -535,6 +535,7 @@ static int zynq_qspi_exec_mem_op(struct spi_mem *mem, const struct spi_mem_op *op) {struct zynq_qspi *xqspi =spi_controller_get_devdata (mem->spi->master); +u8 opaddr[4 ]__aligned(4) ;int err =0 , i;u8 *tmpbuf;
@@ -561,11 +562,12 @@ static int zynq_qspi_exec_mem_op(struct spi_mem *mem,if (op->addr.nbytes) {for (i =0 ; i < op->addr.nbytes; i++) { - xqspi->txbuf[i] = op->addr.val >> + opaddr[i] = op->addr.val >> (8 * (op->addr.nbytes - i -1 )); }reinit_completion (&xqspi->data_completion); + xqspi->txbuf = opaddr; xqspi->rxbuf =NULL ; xqspi->tx_bytes = op->addr.nbytes; xqspi->rx_bytes = op->addr.nbytes;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 658/1848 s390/vmcp: Initialize full session info to zero
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian Borntraeger <[email protected]>
[ Upstream commit f63eb4ee4a30fc5d8de07a229d92310e3c8d560c ]
The cma_alloc bit as well as the response can contain old data. cma_release will not free the kmalloced memory in that case and the response code might leak kernel stack data to CAP_SYS_ADMIN users.
--- drivers/s390/char/vmcp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/s390/char/vmcp.c +1 -3
@@ -105,13 +105,11 @@ static int vmcp_open(struct inode *inode, struct file *file)if (!capable (CAP_SYS_ADMIN ))return -EPERM ; - session =kmalloc (sizeof (*session),GFP_KERNEL ); + session =kzalloc (sizeof (*session),GFP_KERNEL );if (!session)return -ENOMEM ; session->bufsize =PAGE_SIZE ; - session->response =NULL ; - session->resp_size =0 ;mutex_init (&session->mutex); file->private_data = session;return nonseekable_open (inode, file);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 659/1848 arm64: kprobes: Remove redundant kprobe_step_ctx
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Masami Hiramatsu <[email protected]>
commit ba090f9cafd53dbabe0f0a8c4ccae44203d3731b upstream.
The kprobe_step_ctx (kcb->ss_ctx) has ss_pending and match_addr, but those are redundant because those can be replaced by KPROBE_HIT_SS and &cur_kprobe->ainsn.api.insn[1] respectively.
To simplify the code, remove the kprobe_step_ctx.
--- arch/arm64/include/asm/kprobes.h | 7 ---- arch/arm64/kernel/probes/kprobes.c | 53 +++++++----------------------- 2 files changed, 12 insertions(+), 48 deletions(-)
arch/arm64/include/asm/kprobes.h +0 -7
@@ -34,18 +34,11 @@ struct prev_kprobe {unsigned long saved_irqflag; }; -/* Single step context for kprobe */ -struct kprobe_step_ctx { -unsigned long ss_pending; -unsigned long match_addr; -}; -/* per-cpu kprobe control block */ struct kprobe_ctlblk {unsigned int kprobe_status;unsigned long saved_irqflag;struct prev_kprobe prev_kprobe; -struct kprobe_step_ctx ss_ctx; };void arch_remove_kprobe (struct kprobe *);
arch/arm64/kernel/probes/kprobes.c +12 -41
98 lines not on this page · raw message
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 660/1848 arm64: kprobes: Fix Uexpected kernel BRK exception at EL1
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Qais Yousef <[email protected]>
commit 75bd4bff300b3c5252d4a0e7a959569c62d1dbae upstream.
I was hitting the below panic continuously when attaching kprobes to scheduler functions
[ 159.045212] Unexpected kernel BRK exception at EL1 [ 159.053753] Internal error: BRK handler: f2000006 [#1] PREEMPT SMP [ 159.059954] Modules linked in: [ 159.063025] CPU: 2 PID: 0 Comm: swapper/2 Not tainted 5.11.0-rc4-00008-g1e2a199f6ccd #56 [rt-app] <notice> [1] Exiting.[ 159.071166] Hardware name: ARM Juno development board (r2) (DT) [ 159.079689] pstate: 600003c5 (nZCv DAIF -PAN -UAO -TCO BTYPE=--)
[ 159.085723] pc : 0xffff80001624501c [ 159.089377] lr : attach_entity_load_avg+0x2ac/0x350 [ 159.094271] sp : ffff80001622b640 [rt-app] <notice> [0] Exiting.[ 159.097591] x29: ffff80001622b640 x28: 0000000000000001 [ 159.105515] x27: 0000000000000049 x26: ffff000800b79980
[ 159.110847] x25: ffff00097ef37840 x24: 0000000000000000 [ 159.116331] x23: 00000024eacec1ec x22: ffff00097ef12b90 [ 159.121663] x21: ffff00097ef37700 x20: ffff800010119170 [rt-app] <notice> [11] Exiting.[ 159.126995] x19: ffff00097ef37840 x18: 000000000000000e [ 159.135003] x17: 0000000000000001 x16: 0000000000000019 [ 159.140335] x15: 0000000000000000 x14: 0000000000000000 [ 159.145666] x13: 0000000000000002 x12: 0000000000000002 [ 159.150996] x11: ffff80001592f9f0 x10: 0000000000000060 [ 159.156327] x9 : ffff8000100f6f9c x8 : be618290de0999a1 [ 159.161659] x7 : ffff80096a4b1000 x6 : 0000000000000000 [ 159.166990] x5 : ffff00097ef37840 x4 : 0000000000000000 [ 159.172321] x3 : ffff000800328948 x2 : 0000000000000000 [ 159.177652] x1 : 0000002507d52fec x0 : ffff00097ef12b90 [ 159.182983] Call trace: [ 159.185433] 0xffff80001624501c [ 159.188581] update_load_avg+0x2d0/0x778 [ 159.192516] enqueue_task_fair+0x134/0xe20 [ 159.196625] enqueue_task+0x4c/0x2c8 [ 159.200211] ttwu_do_activate+0x70/0x138 [ 159.204147] sched_ttwu_pending+0xbc/0x160 [ 159.208253] flush_smp_call_function_queue+0x16c/0x320 [ 159.213408] generic_smp_call_function_single_interrupt+0x1c/0x28 [ 159.219521] ipi_handler+0x1e8/0x3c8 [ 159.223106] handle_percpu_devid_irq+0xd8/0x460 [ 159.227650] generic_handle_irq+0x38/0x50 [ 159.231672] __handle_domain_irq+0x6c/0xc8 [ 159.235781] gic_handle_irq+0xcc/0xf0 [ 159.239452] el1_irq+0xb4/0x180 [ 159.242600] rcu_is_watching+0x28/0x70 [ 159.246359] rcu_read_lock_held_common+0x44/0x88 [ 159.250991] rcu_read_lock_any_held+0x30/0xc0 [ 159.255360] kretprobe_dispatcher+0xc4/0xf0 [ 159.259555] __kretprobe_trampoline_handler+0xc0/0x150 [ 159.264710] trampoline_probe_handler+0x38/0x58 [ 159.269255] kretprobe_trampoline+0x70/0xc4 [ 159.273450] run_rebalance_domains+0x54/0x80 [ 159.277734] __do_softirq+0x164/0x684 [ 159.281406] irq_exit+0x198/0x1b8 [ 159.284731] __handle_domain_irq+0x70/0xc8 [ 159.288840] gic_handle_irq+0xb0/0xf0 [ 159.292510] el1_irq+0xb4/0x180 [ 159.295658] arch_cpu_idle+0x18/0x28 [ 159.299245] default_idle_call+0x9c/0x3e8 [ 159.303265] do_idle+0x25c/0x2a8 [ 159.306502] cpu_startup_entry+0x2c/0x78 [ 159.310436] secondary_start_kernel+0x160/0x198 [ 159.314984] Code: d42000c0 aa1e03e9 d42000c0 aa1e03e9 (d42000c0)
After a bit of head scratching and debugging it turned out that it is due to kprobe handler being interrupted by a tick that causes us to go into (I think another) kprobe handler.
The culprit was kprobe_breakpoint_ss_handler() returning DBG_HOOK_ERROR which leads to the Unexpected kernel BRK exception.
Reverting commit ba090f9cafd5 ("arm64: kprobes: Remove redundant kprobe_step_ctx") seemed to fix the problem for me.
Further analysis showed that kcb->kprobe_status is set to KPROBE_REENTER when the error occurs. By teaching kprobe_breakpoint_ss_handler() to handle this status I can no longer reproduce the problem.
--- arch/arm64/kernel/probes/kprobes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/kernel/probes/kprobes.c +2 -2
@@ -375,8 +375,8 @@ kprobe_breakpoint_ss_handler(struct pt_regs *regs, unsigned int esr)unsigned long addr =instruction_pointer (regs);struct kprobe *cur =kprobe_running (); -if (cur && (kcb->kprobe_status ==KPROBE_HIT_SS ) - && ((unsigned long )&cur->ainsn.api.insn[1 ] == addr)) { +if (cur && (kcb->kprobe_status & (KPROBE_HIT_SS |KPROBE_REENTER )) && + ((unsigned long )&cur->ainsn.api.insn[1 ] == addr)) {kprobes_restore_local_irqflag (kcb, regs);post_kprobe_handler (cur, kcb, regs);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 661/1848 jbd2: dont advance j_fc_off before the buffer is recorded
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daejun Park <[email protected]>
commit 9f359c031885bb50add7d23c7a5a0e9755b134c9 upstream.
jbd2_fc_get_buf() increments journal->j_fc_off before jbd2_journal_bmap() and __getblk() have had a chance to fail. When either does, the slot j_fc_wbuf[fc_off] is never assigned, but j_fc_off already counts it.
ext4 then fails the fast commit and falls back, and the fallback path reaches jbd2_fc_release_bufs() via ext4_fc_commit -> jbd2_fc_end_commit_fallback -> __jbd2_fc_end_commit -> ext4_fc_cleanup. That walks down from j_fc_off - 1 and put_bh()es every slot until it sees NULL, so it also touches the slot that was never written. j_fc_wbuf comes from a plain kmalloc() and is never zeroed, so a slot used for the first time holds uninitialised heap data.
Advance j_fc_off only after the buffer head has been stored. That restores the invariant that j_fc_off covers exactly the filled slots, which is what jbd2_fc_release_bufs() relies on: the live buffers of the current fast commit sit above the NULLs the previous one released, so stopping at the first NULL is correct.
Reproduced on a KASAN kernel with an ext4 fast_commit filesystem on a loop device, truncating the backing file under the live mount so that only the journal's fast-commit region falls past the end of the device. __getblk() then fails for the first fast-commit block while the rest of the journal is still addressable, so the journal is not aborted and the fast commit reaches the fallback path. j_fc_wbuf was poisoned to make the read of the never-written slot visible:
BUG: KASAN: wild-memory-access in jbd2_fc_release_bufs+0x6b/0xd0 Write of size 4 at addr 5a5a5a5a5a5a5ab2 by task sync/961 jbd2_fc_release_bufs+0x6b/0xd0 ext4_fc_cleanup+0x97/0x830 __jbd2_fc_end_commit+0x37/0xc0 ext4_fc_commit+0x524/0x560 ext4_sync_file+0x3c4/0x4b0 __x64_sys_fsync+0x20/0x30
With this patch the same run leaves j_fc_off at 0 across repeated __getblk() failures and completes cleanly.
[ Context: in 5.10.y, jbd2_fc_get_buf() still advances j_fc_off inside
the if/else bounds check, so the increment is removed from there. The change is otherwise the same as upstream. ]
--- fs/jbd2/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jbd2/journal.c +1 -1
@@ -884,7 +884,6 @@ int jbd2_fc_get_buf(journal_t *journal, struct buffer_head **bh_out)if (journal->j_fc_off + journal->j_fc_first < journal->j_fc_last) { fc_off = journal->j_fc_off; blocknr = journal->j_fc_first + fc_off; - journal->j_fc_off++; }else { ret = -EINVAL ; }
@@ -902,6 +901,7 @@ int jbd2_fc_get_buf(journal_t *journal, struct buffer_head **bh_out) journal->j_fc_wbuf[fc_off] = bh; + journal->j_fc_off++; *bh_out = bh;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 662/1848 spi: bcm-qspi: reject oversized dummy bytes in mspi exec_mem_op
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Weibin Liu <[email protected]>
[ Upstream commit 9e44f0df3fff215d9033089e85980048c3ac132a ]
bcm_qspi_mspi_exec_mem_op() builds a local command buffer cmd[6] holding one opcode byte, up to four address bytes and one spare byte, and sets t[0].len = op->addr.nbytes + op->dummy.nbytes + 1. bcm_qspi_exec_mem_op() only validates op->addr.nbytes <= 4 and never bounds op->dummy.nbytes, which spi_mem_check_op() also leaves unrestricted. With addr.nbytes = 4 and dummy.nbytes >= 2 the length becomes 7 or more, so write_to_hw() reads past cmd[] on the kernel stack and pushes the leaked bytes into the hardware TXRAM.
Reject operations whose dummy phase does not fit the remaining byte of cmd[] by requiring op->dummy.nbytes <= 1, so such transfers fall back to the generic SPI path instead of overrunning the buffer.
--- drivers/spi/spi-bcm-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spi/spi-bcm-qspi.c +2 -1
@@ -1024,8 +1024,9 @@ static int bcm_qspi_exec_mem_op(struct spi_mem *mem,u32 addr =0 , len;u_char *buf; +/* cmd[] holds 1 opcode + 4 address + 1 dummy byte at most */ if (!op->data.nbytes || !op->addr.nbytes || op->addr.nbytes >4 || - op->data.dir !=SPI_MEM_DATA_IN ) + op->dummy.nbytes >1 || op->data.dir !=SPI_MEM_DATA_IN )return -ENOTSUPP ; buf = op->data.buf.in;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 663/1848 pwm: tiehrpwm: Clear period on disable to allow reconfiguration
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alexander Sverdlin <[email protected]>
[ Upstream commit e74b9a7ee50071aad25d3989bf985292f90b0c6e ]
Both channels share one period register, so ehrpwm_pwm_config() rejects a period differing from the sibling's period_cycles[]. That value was cleared only in .free(), not in .disable(), so a stopped channel kept blocking the sibling from switching to a new frequency. Clear it in .disable() too.
Testcase:
cd /sys/class/pwm/pwmchip0; echo 0 > export; echo 1 > export for p in pwm0 pwm1; do
echo 1000000 > $p/period; echo 500000 > $p/duty_cycle
echo 1 > $p/enable; echo 0 > $p/enable; echo 2000000 > $p/period done
echo 1 > pwm0/enable # before: -EINVAL, after: succeeds
--- drivers/pwm/pwm-tiehrpwm.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pwm/pwm-tiehrpwm.c +3 -0
@@ -386,6 +386,9 @@ static void ehrpwm_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)/* Disable clock on PWM disable */ pm_runtime_put_sync (chip->dev); + +/* A disabled channel must not constrain the sibling's period */ + pc->period_cycles[pwm->hwpwm] =0 ; }static void ehrpwm_pwm_free (struct pwm_chip *chip,struct pwm_device *pwm)
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 664/1848 media: require two-byte Cypress type 04 records
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pengpeng Hou <[email protected]>
[ Upstream commit e22872703386c3885d8c6bd595124587bc4e5081 ]
Both Cypress Intel HEX parsers read two address bytes from type 04 records. Generic record framing permits any record length, so a short record can make the parser consume the checksum or bytes beyond the firmware record. A longer record also violates the Intel HEX type 04 layout.
Require the type 04 payload length to be exactly two bytes in both implementations.
--- drivers/media/common/cypress_firmware.c | 2 ++ drivers/media/usb/dvb-usb/dvb-usb-firmware.c | 2 ++ 2 files changed, 4 insertions(+)
drivers/media/common/cypress_firmware.c +2 -0
@@ -59,6 +59,8 @@ static int cypress_get_hexline(const struct firmware *fw,if (hx->type ==0x04 ) {/* b[4] and b[5] are the Extended linear address record data * field */ +if (hx->len !=2 ) +return -EINVAL ; hx->addr |= (b[4 ] <<24 ) | (b[5 ] <<16 ); }
drivers/media/usb/dvb-usb/dvb-usb-firmware.c +2 -0
@@ -141,6 +141,8 @@ int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx,if (hx->type ==0x04 ) {/* b[4] and b[5] are the Extended linear address record data field */ +if (hx->len !=2 ) +return -EINVAL ; hx->addr |= (b[4 ] <<24 ) | (b[5 ] <<16 );/* hx->len -= 2; data_offs += 2; */
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 665/1848 media: adv748x: Fix endpoint reference leaks on probe failure
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ruoyu Wang <[email protected]>
[ Upstream commit 359db09cf055497075a668b192f4578a0ed00955 ]
adv748x_parse_dt() takes an extra reference for every endpoint saved in state->endpoints. If parsing later fails, adv748x_probe() skips adv748x_dt_cleanup(), so the saved references remain held. A CSI-2 lane parsing error also returns from for_each_endpoint_of_node() without dropping the iterator's reference.
Save the endpoint reference only after lane parsing succeeds. Drop the iterator reference before returning a lane parsing error and route all parse failures through the endpoint cleanup path to release any saved references. This retains the endpoints only for a successful probe.
This issue was found by a static analysis checker and confirmed by manual source review.
--- drivers/media/i2c/adv748x/adv748x-core.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
drivers/media/i2c/adv748x/adv748x-core.c +7 -6
@@ -656,9 +656,6 @@ static int adv748x_parse_dt(struct adv748x_state *state)continue ; } -of_node_get (ep_np); - state->endpoints[ep.port] = ep_np; -/* * At least one input endpoint and one output endpoint shall * be defined.
@@ -670,8 +667,13 @@ static int adv748x_parse_dt(struct adv748x_state *state)/* Store number of CSI-2 lanes used for TXA and TXB. */ ret =adv748x_parse_csi2_lanes (state, ep.port, ep_np); -if (ret) +if (ret) { +of_node_put (ep_np);return ret; + } + +of_node_get (ep_np); + state->endpoints[ep.port] = ep_np; }return in_found && out_found ?0 : -ENODEV ;
@@ -720,7 +722,7 @@ static int adv748x_probe(struct i2c_client *client) ret =adv748x_parse_dt (state);if (ret) {adv_err (state,"Failed to parse device tree" ); - goto err_free_mutex; + goto err_cleanup_dt; }/* Configure IO Regmap region */
@@ -790,7 +792,6 @@ static int adv748x_probe(struct i2c_client *client)adv748x_unregister_clients (state); err_cleanup_dt:adv748x_dt_cleanup (state); -err_free_mutex:mutex_destroy (&state->mutex);return ret;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 666/1848 iio: pressure: dps310: fix CFG_REG bit definitions
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rupesh Majhi <[email protected]>
[ Upstream commit 4334dc4092c271e6cd010c2ee70b7f4415c4c199 ]
Driver defines them as BIT(4), BIT(5) and BIT(6). Per datasheet P_SHIFT is bit 2, FIFO_EN is bit 1 and SPI_MODE is bit 0.
Only P_SHIFT has a user. dps310_set_pres_precision() sets it at oversampling 16 or above, so with wrong bit the result register is never shifted and stops matching the scale factor compensation divides by. in_pressure_input returns -ERANGE at oversampling 16, 32 and 64.
FIFO_EN needed by FIFO support later in this series.
--- drivers/iio/pressure/dps310.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/pressure/dps310.c +3 -3
@@ -50,9 +50,9 @@#define DPS310_CFG_REG 0x09#define DPS310_INT_HL BIT(7)#define DPS310_TMP_SHIFT_EN BIT(3) -#define DPS310_PRS_SHIFT_EN BIT(4) -#define DPS310_FIFO_EN BIT(5) -#define DPS310_SPI_EN BIT(6) +#define DPS310_PRS_SHIFT_EN BIT(2) +#define DPS310_FIFO_EN BIT(1) +#define DPS310_SPI_EN BIT(0)#define DPS310_RESET 0x0c#define DPS310_RESET_MAGIC 0x09#define DPS310_COEF_BASE 0x10
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 667/1848 media: mediatek: jpeg: Avoid context access after job finish
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kazuki Hanai <[email protected]>
[ Upstream commit 7c7f31405b76acd95a628c834ee8a2d6da439782 ]
v4l2_m2m_job_finish() publishes job completion and wakes waiters before it returns. A concurrent file release can therefore finish v4l2_m2m_ctx_release() and free the context while the single-core IRQ handler continues with its tail.
Both handlers only need the device for the matching runtime PM put. Use the IRQ-owned jpeg pointer instead of dereferencing ctx after completion has been published. This preserves the get/put pairing and removes the post-completion context access.
--- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c +2 -2
@@ -1096,7 +1096,7 @@ static irqreturn_t mtk_jpeg_enc_done(struct mtk_jpeg_dev *jpeg)v4l2_m2m_buf_done (src_buf, buf_state);v4l2_m2m_buf_done (dst_buf, buf_state);v4l2_m2m_job_finish (jpeg->m2m_dev, ctx->fh.m2m_ctx); -pm_runtime_put (ctx->jpeg->dev); +pm_runtime_put (jpeg->dev);return IRQ_HANDLED ; }
@@ -1163,7 +1163,7 @@ static irqreturn_t mtk_jpeg_dec_irq(int irq, void *priv)v4l2_m2m_buf_done (src_buf, buf_state);v4l2_m2m_buf_done (dst_buf, buf_state);v4l2_m2m_job_finish (jpeg->m2m_dev, ctx->fh.m2m_ctx); -pm_runtime_put (ctx->jpeg->dev); +pm_runtime_put (jpeg->dev);return IRQ_HANDLED ; }
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 668/1848 Bluetooth: selftest: Pin module for selftest debugfs file operations
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bui Viet Dung <[email protected]>
[ Upstream commit 64aabf94ecccb1120a63b4ee5a6761871a181a41 ]
An open debugfs file retains its file_operations pointer in the debugfs proxy state. However, test_smp_fops in net/bluetooth/smp.c and test_ecdh_fops in net/bluetooth/selftest.c have no .owner set to THIS_MODULE.
As a result, full_proxy_open_regular() calls fops_get() which succeeds without taking a reference to the bluetooth module. When CONFIG_BT=m and selftests are enabled, a userspace process can open either /sys/kernel/debug/bluetooth/selftest_smp or /sys/kernel/debug/bluetooth/selftest_ecdh and keep the file descriptor open while the module is unloaded (rmmod bluetooth).
When the userspace process subsequently closes the descriptor, full_proxy_release() accesses the already unmapped file_operations structure, triggering a kernel oops in full_proxy_release():
BUG: unable to handle page fault for address: fffffbfff8056f03 #PF: supervisor read access in kernel mode Oops: 0000 [#1] SMP KASAN NOPTI RIP: 0010:full_proxy_release+0x8e/0x140 Call Trace: <TASK> __fput+0x39f/0xa60 fput_close_sync+0xff/0x200 __x64_sys_close+0x8c/0xf0 do_syscall_64+0x115/0x6a0 entry_SYSCALL_64_after_hwframe+0x77/0x7f </TASK>
The issue was discovered via manual code audit of net/bluetooth/smp.c and net/bluetooth/selftest.c.
Set .owner = THIS_MODULE on test_smp_fops and test_ecdh_fops so that debugfs keeps the module pinned until the file descriptors are closed.
--- net/bluetooth/selftest.c | 1 + net/bluetooth/smp.c | 1 + 2 files changed, 2 insertions(+)
net/bluetooth/selftest.c +1 -0
@@ -191,6 +191,7 @@ static ssize_t test_ecdh_read(struct file *file, char __user *user_buf, }static const struct file_operations test_ecdh_fops = { + .owner =THIS_MODULE , .open = simple_open, .read = test_ecdh_read, .llseek = default_llseek,
net/bluetooth/smp.c +1 -0
@@ -3783,6 +3783,7 @@ static ssize_t test_smp_read(struct file *file, char __user *user_buf, }static const struct file_operations test_smp_fops = { + .owner =THIS_MODULE , .open = simple_open, .read = test_smp_read, .llseek = default_llseek,
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 669/1848 genirq: Move interrupt thread exit_work object to irqaction
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Richard Patel <[email protected]>
[ Upstream commit 89a9e003a2ef73f67dff03dfd59e0a5474b56b0b ]
irq_thread() registers irq_thread_dtor() as exit task_work using a stack-allocated callback_head. On normal interrupt thread exit, this work gets cancelled and never runs.
On x86, an abnormal interrupt thread exit (e.g. handler oops) discards the stack, including the callback_head, while that callback_head is still pending. By the time exit_task_work() runs, the stack memory formerly backing callback_head is already clobbered.
irq_thread() <-- on_exit_work allocated
** IRQ handler faults **
oops_end()
rewind_stack_and_make_dead() <-- on_exit_work freed
make_task_dead()
do_exit(SIGSEGV)
...
exit_shm() <-- on_exit_work clobbered
...
exit_task_work() <-- stack use-after-free
exit_shm()+0x30 <-- wild jump to return addrThus, a benign threaded IRQ oops (e.g. a NULL pointer deref) is turned into a wild jump. This is caught by kernel IBT:
** first fault **
Oops: general protection fault, kernel NULL pointer dereference 0x3c0: 0000 [#1] SMP NOPTI ... ** second fault ** Missing ENDBR: exit_shm+0x30/0x1c0 kernel BUG at arch/x86/kernel/cet.c:133! ... ? task_work_run+0x5c/0x90 ? do_exit+0x209/0x460 ? rewind_stack_and_make_dead+0x16/0x20 ... note: irq/165-AudioDS[1427] exited with irqs disabled Fixing recursive fault but reboot is needed!
Fix this by storing the callback_head in struct irqaction. The irqaction is only freed once irq_thread_dtor() finishes.
--- include/linux/interrupt.h | 2 ++ kernel/irq/manage.c | 9 ++++----- 2 files changed, 6 insertions(+), 5 deletions(-)
include/linux/interrupt.h +2 -0
@@ -110,6 +110,7 @@ typedef irqreturn_t (*irq_handler_t)(int, void *);* @thread_flags: flags related to @thread * @thread_mask: bitmask for keeping track of @thread activity * @dir: pointer to the proc/irq/NN/name entry +* @thread_dtor: task_work for @thread irregular exit cleanup */ struct irqaction {irq_handler_t handler;
@@ -125,6 +126,7 @@ struct irqaction {unsigned long thread_mask;const char *name;struct proc_dir_entry *dir; +struct callback_head thread_dtor; }____cacheline_internodealigned_in_smp ;extern irqreturn_t no_action (int cpl,void *dev_id);
kernel/irq/manage.c +4 -5
@@ -1250,9 +1250,9 @@ static void __irq_thread_dtor(struct irqaction *action)irq_finalize_oneshot (desc, action); } -static void irq_thread_dtor (struct callback_head *unused) +static void irq_thread_dtor (struct callback_head *work) { -struct irqaction *action =kthread_data (current); + struct irqaction *action = container_of(work, struct irqaction, thread_dtor);__irq_thread_dtor (action);clear_and_wake_up_bit (IRQTF_EXIT_WORK , &action->thread_flags);
@@ -1300,7 +1300,6 @@ static void wake_up_and_wait_for_irq_thread_ready(struct irq_desc *desc,*/ static int irq_thread (void *data) { -struct callback_head on_exit_work;struct irqaction *action = data;struct irq_desc *desc =irq_to_desc (action->irq); irqreturn_t (*handler_fn)(struct irq_desc *desc,
@@ -1315,8 +1314,8 @@ static int irq_thread(void *data) handler_fn = irq_thread_fn;set_bit (IRQTF_EXIT_WORK , &action->thread_flags); -init_task_work (&on_exit_work, irq_thread_dtor); -task_work_add (current, &on_exit_work,TWA_NONE ); +init_task_work (&action->thread_dtor, irq_thread_dtor); +task_work_add (current, &action->thread_dtor,TWA_NONE );irq_thread_check_affinity (desc, action);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 670/1848 rds: fix out-of-bounds conn_path walks via handshake exthdrs
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Henry Martin <[email protected]>
[ Upstream commit 50f2103fce43922b6e562937b2d2fc62089ff7ec ]
Both the lane and the connection-generation negotiation are driven by extension headers in handshake packets, and both are processed unconditionally, even on transports that are not multipath capable. A non-MP connection (t_mp_capable unset) owns exactly one rds_conn_path slot, so a peer claiming up to RDS_MPATH_WORKERS lanes makes every subsequent fan-out walk conn->c_path[0..7] at 504-byte strides past the single allocated slot (KASAN: "Read of size 8 in rds_conn_path_connect_if_down"); the generation negotiation opens a similar out-of-bounds walk on the same array.
Only process handshake extension headers when the connection's transport is multipath capable, so a peer can never make us walk lanes that do not exist. Both call sites in rds_recv_incoming() are gated.
This is a port of the Oracle UEK fix for the same issue, picked up where Paula's series of the same change left off.
This issue was discovered by Tencent CodeBuddy Security.
--- net/rds/recv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
net/rds/recv.c +4 -2
@@ -342,7 +342,8 @@ void rds_recv_incoming(struct rds_connection *conn, struct in6_addr *saddr,rds_stats_inc (s_recv_ping);rds_send_pong (cp, inc->i_hdr.h_sport);/* if this is a handshake ping, start multipath if necessary */ -if (RDS_HS_PROBE (be16_to_cpu (inc->i_hdr.h_sport), +if (conn->c_trans->t_mp_capable && +RDS_HS_PROBE (be16_to_cpu (inc->i_hdr.h_sport),be16_to_cpu (inc->i_hdr.h_dport))) {rds_recv_hs_exthdrs (&inc->i_hdr, cp->cp_conn);rds_start_mprds (cp->cp_conn);
@@ -350,7 +351,8 @@ void rds_recv_incoming(struct rds_connection *conn, struct in6_addr *saddr, goto out; } -if (be16_to_cpu (inc->i_hdr.h_dport) ==RDS_FLAG_PROBE_PORT && +if (conn->c_trans->t_mp_capable && +be16_to_cpu (inc->i_hdr.h_dport) ==RDS_FLAG_PROBE_PORT && inc->i_hdr.h_sport ==0 ) {rds_recv_hs_exthdrs (&inc->i_hdr, cp->cp_conn);/* if this is a handshake pong, start multipath if necessary */
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 671/1848 gpio: pca953x: Preserve wakeup accounting on parent IRQ failure
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sahaj Chaudhari <[email protected]>
[ Upstream commit a38bf551726a21c9bcc001b02164f30378b64b64 ]
pca953x_irq_set_wake() updates wakeup_path before asking the parent IRQ controller to change its wake state. If irq_set_irq_wake() fails, the IRQ core rolls back its wake state but the driver's counter remains changed.
A failed enable can therefore leave the expander marked as part of the wakeup path when no child IRQ has successfully enabled wakeup. A failed disable can make the driver stop retaining power even though wakeup is still enabled. The suspend and resume paths use this counter to decide whether to disable or enable the regulator.
Update wakeup_path only after the parent operation succeeds, leaving it unchanged on error.
--- drivers/gpio/gpio-pca953x.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpio/gpio-pca953x.c +6 -1
@@ -645,13 +645,18 @@ static int pca953x_irq_set_wake(struct irq_data *d, unsigned int on) {struct gpio_chip *gc =irq_data_get_irq_chip_data (d);struct pca953x_chip *chip =gpiochip_get_data (gc); +int ret; + + ret =irq_set_irq_wake (chip->client->irq, on); +if (ret) +return ret;if (on)atomic_inc (&chip->wakeup_path);else atomic_dec (&chip->wakeup_path); -return irq_set_irq_wake (chip->client->irq, on); +return 0 ; }static void pca953x_irq_bus_lock (struct irq_data *d)
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 672/1848 posix-timers: Accept NULL clock_getres() output in stubs
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hungyu Lin <[email protected]>
[ Upstream commit 5b819071e4346256c4edbae5cc2095dff25694fc ]
With CONFIG_POSIX_TIMERS disabled, clock_getres() returns -EFAULT for a supported clock when the result pointer is NULL. POSIX permits a NULL result pointer to suppress returning the clock resolution.
Only copy the result when a destination is provided, in both the native and time32 stubs. This matches the full POSIX timer implementation and preserves clock ID validation.
--- kernel/time/posix-stubs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/time/posix-stubs.c +2 -2
@@ -116,7 +116,7 @@ SYSCALL_DEFINE2(clock_getres, const clockid_t, which_clock, struct __kernel_timecase CLOCK_REALTIME :case CLOCK_MONOTONIC :case CLOCK_BOOTTIME : -if (put_timespec64 (&rtn_tp, tp)) +if (tp &&put_timespec64 (&rtn_tp, tp))return -EFAULT ;return 0 ;default :
@@ -210,7 +210,7 @@ SYSCALL_DEFINE2(clock_getres_time32, clockid_t, which_clock,case CLOCK_REALTIME :case CLOCK_MONOTONIC :case CLOCK_BOOTTIME : -if (put_old_timespec32 (&rtn_tp, tp)) +if (tp &&put_old_timespec32 (&rtn_tp, tp))return -EFAULT ;return 0 ;default :
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 673/1848 tg3: Invert restart quirk logic to restrict SNP power-down bypass
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Noam D. Eliyahu <[email protected]>
[ Upstream commit d7314b51341c037973ce022f12c6009fd07b021e ]
Commit 9fc3bc764334 ("tg3: power down device only on SYSTEM_POWER_OFF") bypassed tg3_power_down() on system restarts to prevent reboot hangs and NMIs on servers where NICs were initialized via SNP (such as Dell PowerEdge R650 and R750).
However, skipping the power-down flow globally causes the ACPI _PTS method to trigger fatal PCIe AER events and hangs on other models. Commit e0efe83ed325 ("tg3: Disable tg3 PCIe AER on system reboot") attempted to mitigate this by adding an AER-disable DMI quirk table. Maintaining a growing list of models for a secondary symptom misses the root cause, leaving systems like the PowerEdge T440 (sharing the BCM5720 NIC) exposed.
Fix this by inverting the quirk logic:
1. Restrict SNP power-down avoidance strictly to tg3_restart_snp_quirk_table for the specific systems requiring it (Dell PowerEdge R650 and R750).
2. Restore standard power-down behavior for all other systems, eliminating the separate AER-disable quirk table.
For systems affected by the original SNP restart issue, their shutdown flow remains completely untouched.
--- drivers/net/ethernet/broadcom/tg3.c | 42 ++++++++--------------------- 1 file changed, 11 insertions(+), 31 deletions(-)
drivers/net/ethernet/broadcom/tg3.c +11 -31
@@ -18186,41 +18186,17 @@ static int tg3_resume(struct device *device) static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume); -/* Systems where ACPI _PTS (Prepare To Sleep) S5 will result in a fatal -* PCIe AER event on the tg3 device if the tg3 device is not, or cannot -* be, powered down. +/* Systems where powering down a tg3 device on restarts triggers +* NMIs and fatal hangs during reboot if the network adapters were +* initialized under SNP. */ -static const struct dmi_system_id tg3_restart_aer_quirk_table[] = { - { - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), -DMI_MATCH (DMI_PRODUCT_NAME ,"PowerEdge R440" ), - }, - }, - { - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), -DMI_MATCH (DMI_PRODUCT_NAME ,"PowerEdge R540" ), - }, - }, - { - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), -DMI_MATCH (DMI_PRODUCT_NAME ,"PowerEdge R640" ), - }, - }, +static const struct dmi_system_id tg3_restart_snp_quirk_table[] = { { .matches = {DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ),DMI_MATCH (DMI_PRODUCT_NAME ,"PowerEdge R650" ), }, }, - { - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), -DMI_MATCH (DMI_PRODUCT_NAME ,"PowerEdge R740" ), - }, - }, { .matches = {DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ),
@@ -18244,14 +18220,18 @@ static void tg3_shutdown(struct pci_dev *pdev)if (netif_running (dev))dev_close (dev); -if (system_state ==SYSTEM_POWER_OFF ) +if (!dmi_first_match (tg3_restart_snp_quirk_table) || + system_state ==SYSTEM_POWER_OFF ) {tg3_power_down (tp); -else if (system_state ==SYSTEM_RESTART && -dmi_first_match (tg3_restart_aer_quirk_table) && + }else if (system_state ==SYSTEM_RESTART && pdev->current_state != PCI_D3cold && pdev->current_state !=PCI_UNKNOWN ) {/* Disable PCIe AER on the tg3 to avoid a fatal * error during this system restart. +* Needed since on restarts for systems in +* tg3_restart_snp_quirk_table skipping on powering down the +* tg3 device causes a fatal AER error during ACPI _PTS +* (Prepare To Sleep). */ pcie_capability_clear_word(pdev, PCI_EXP_DEVCTL, PCI_EXP_DEVCTL_CERE |
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 674/1848 9p/trans_virtio: reject mount tags longer than NAME_MAX at probe
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Bommarito <[email protected]>
[ Upstream commit 5bfef2b6dafe83fe2d8d210d54093a8f48cfc97e ]
p9_virtio_probe() reads a 16-bit mount tag length (tag_len) from the device config and kzalloc()s tag_len + 1 bytes for chan->tag with no upper bound. A malicious or compromised host can present a tag of up to 65535 bytes; that tag is later copied into the single-page sysfs buffer by p9_mount_tag_show() (memcpy(buf, chan->tag, tag_len + 1)), a host-controlled out-of-bounds write of up to ~64 KiB past the PAGE_SIZE attribute buffer.
Reject an overlong tag at probe time. A 9p mount tag is a name-like identifier, so bound it by NAME_MAX (255): that limit is independent of the sysfs/seq_file page size and is far above any legitimate mount tag, which keeps p9_mount_tag_show() safe at the root without hard-coding a seq_file implementation detail.
Message-ID: <[email protected]>
--- net/9p/trans_virtio.c | 5 +++++ 1 file changed, 5 insertions(+)
net/9p/trans_virtio.c +5 -0
@@ -589,6 +589,11 @@ static int p9_virtio_probe(struct virtio_device *vdev) err = -EINVAL ; goto out_free_vq; } +if (tag_len >NAME_MAX ) { +dev_err (&vdev->dev,"mount tag too long (%u bytes)\n" , tag_len); + err = -EINVAL ; + goto out_free_vq; + } tag =kzalloc (tag_len +1 ,GFP_KERNEL );if (!tag) { err = -ENOMEM ;
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 675/1848 9p: fix caches_show() out-of-bounds write
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Zhao Zhang <[email protected]>
[ Upstream commit 2acd800de8827b7cdce8cb5c2c63b8e8608ec8e3 ]
The sysfs show handler for /sys/fs/9p/caches appends cache tags with snprintf(buf + count, limit, ...) and then advances count and limit by the return value. This is incorrect for truncation because snprintf() returns the full would-have-been length, not the number of bytes stored.
Once the accumulated output exceeds PAGE_SIZE, count can advance past the sysfs buffer and limit can become negative. A later iteration then passes an out-of-bounds destination pointer and an oversized size_t into snprintf(), leading to an out-of-bounds write.
Use sysfs_emit_at() for the append instead. It follows the sysfs buffer contract and returns the number of bytes actually stored, so the offset remains bounded even when the output is truncated.
Message-ID: <abfb65f4800634dafb08238bba20cb48797e796f.1781908090.git.zzhan461@ucr.edu>
--- fs/9p/v9fs.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-)
fs/9p/v9fs.c +5 -11
@@ -19,6 +19,7 @@#include <linux/idr.h> #include <linux/slab.h> #include <linux/seq_file.h> +#include <linux/sysfs.h> #include <net/9p/9p.h> #include <net/9p/client.h> #include <net/9p/transport.h>
@@ -552,21 +553,14 @@ static ssize_t caches_show(struct kobject *kobj,struct kobj_attribute *attr, char *buf) { - ssize_t n = 0, count = 0, limit = PAGE_SIZE; + ssize_t count = 0;struct v9fs_session_info *v9ses;spin_lock (&v9fs_sessionlist_lock);list_for_each_entry (v9ses, &v9fs_sessionlist, slist) { -if (v9ses->cachetag) { - n =snprintf (buf + count, limit,"%s\n" , v9ses->cachetag); -if (n <0 ) { - count = n; -break ; - } - - count += n; - limit -= n; - } +if (v9ses->cachetag) + count +=sysfs_emit_at (buf, count,"%s\n" , + v9ses->cachetag); }spin_unlock (&v9fs_sessionlist_lock);
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 676/1848 xfrm: interface: validate the IP header on xmit
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Qihang <[email protected]>
[ Upstream commit 86de3a1118a16dbbbe5fabe9aa20ffb93c072ed5 ]
Packets injected into an xfrm interface (e.g. AF_PACKET on an xfrmi device) reach the xfrm output path without IP header validation, but xfrm4_transport_output() uses iph->ihl for __skb_pull() and memmove() and expects the header to be valid.
vti_tunnel_xmit() already calls pskb_inet_may_pull() before handing packets to the xfrm output path. Do the same in xfrmi_xmit() and perform the header checks ip_rcv_core()/ip6_rcv_core() do on entry to the IP stack: reject wrong IP versions and malformed IPv4 header lengths.
--- net/xfrm/xfrm_interface_core.c | 8 ++++++++ 1 file changed, 8 insertions(+)
net/xfrm/xfrm_interface_core.c +8 -0
@@ -399,8 +399,13 @@ static netdev_tx_t xfrmi_xmit(struct sk_buff *skb, struct net_device *dev)memset (&fl,0 ,sizeof (fl)); +if (!pskb_inet_may_pull (skb)) + goto tx_err; +switch (skb->protocol) {case htons (ETH_P_IPV6 ): +if (ipv6_hdr (skb)->version !=6 ) + goto tx_err;memset (IP6CB (skb),0 ,sizeof (*IP6CB (skb)));xfrm_decode_session (skb, &fl,AF_INET6 );if (!dst) {
@@ -416,6 +421,9 @@ static netdev_tx_t xfrmi_xmit(struct sk_buff *skb, struct net_device *dev) }break ;case htons (ETH_P_IP ): +if (ip_hdr (skb)->version !=4 ||ip_hdr (skb)->ihl <5 || + !pskb_network_may_pull (skb,ip_hdr (skb)->ihl *4 )) + goto tx_err;memset (IPCB (skb),0 ,sizeof (*IPCB (skb)));xfrm_decode_session (skb, &fl,AF_INET );if (!dst) {
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 677/1848 xfrm: espintcp: reorder operations within espintcp_init_sk
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sabrina Dubroca <[email protected]>
[ Upstream commit f9a11716c8445b496e9fafeec7e8412d384d02e2 ]
When enabled on a socket, espintcp sets the socket callbacks to its own before it has finished setting up its context and published it as icsk_ulp_data. Any one of those callbacks that gets called before will dereference a NULL icsk_ulp_data.
Fix this by reording the operations, and add memory barriers to ensure callers will have a struct espintcp_ctx available. Add a few WRITE_ONCE/READ_ONCE too while we're there.
--- include/net/espintcp.h | 5 +++-- net/xfrm/espintcp.c | 41 +++++++++++++++++++++++++---------------- 2 files changed, 28 insertions(+), 18 deletions(-)
include/net/espintcp.h +3 -2
@@ -34,7 +34,8 @@ static inline struct espintcp_ctx *espintcp_getctx(const struct sock *sk) {struct inet_connection_sock *icsk =inet_csk (sk); -/* RCU is only needed for diag */ -return (__force void *)icsk->icsk_ulp_data; +/* pairs with smp_wmb() in espintcp_init_sk() */ +smp_rmb (); +return (__force void *)READ_ONCE (icsk->icsk_ulp_data); }#endif
net/xfrm/espintcp.c +25 -16
65 lines not on this page · raw message
Signature · 1 line
2.53.0
Greg Kroah-Hartman
maintainerPATCH 678/1848 drm/drm_crtc: ensure dma_fence_ops remain valid during device unbind
In reply to Greg Kroah-Hartman5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: André Draszik <[email protected]>
[ Upstream commit 3be436cbd3d265fe4fcfbb5b650edad7b2108443 ]
In [1], sashiko reported the following issue:
=== snip ===
Looking at how these fences are managed, drm_crtc_create_fence() creates a dma_fence without taking a reference to the drm_device or drm_crtc. Because the sync_file framework exposes this fence to userspace, the fence can outlive the CRTC.
The dma_fence contract requires that data accessed by dma_fence_ops (like get_driver_name) must remain valid for an RCU grace period after the fence is signaled. However, drm_crtc_cleanup() and the subsequent freeing of the device do not wait for an RCU grace period via synchronize_rcu().
If userspace calls ioctl(SYNC_IOC_FILE_INFO) concurrently with a device hot-unplug:
CPU1 (Userspace)sync_file_get_name()
ops = rcu_dereference(fence->ops);
if (!dma_fence_test_signaled_flag())
// Preempted or delayed here
CPU2 (Driver Teardown)
Signals the fence (setting fence->ops = NULL)
Destroys and frees the CRTC without waiting for an RCU grace period
CPU1 (Resumes)
ops->get_driver_name(fence) -> drm_crtc_fence_get_driver_name() crtc = fence_to_crtc(fence); // Casts to the freed CRTC return crtc->dev->driver->name; // Use-after-free
...
Does the CRTC or DRM device need to be kept alive for the RCU grace period, or should the fence hold a proper reference to prevent the use-after-free when get_driver_name() and get_timeline_name() access the freed CRTC structure?
=== snap ===
I believe this to be a correct observation and this patch implements the suggestion of waiting for an RCU grace period before proceeding with destruction of the drm_crtc, so that get_driver_name() and get_timeline_name() can still work.
--- drivers/gpu/drm/drm_crtc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_crtc.c +12 -3
@@ -336,14 +336,23 @@ EXPORT_SYMBOL(drm_crtc_init_with_planes);* drm_crtc_cleanup - Clean up the core crtc usage * @crtc: CRTC to cleanup * -* This function cleans up @crtc and removes it from the DRM mode setting -* core. Note that the function does *not* free the crtc structure itself, -* this is the responsibility of the caller. +* This function cleans up @crtc and removes it from the DRM mode setting core, +* after first waiting an RCU grace period to ensure @crtc->dev can safely be +* dereferenced by our dma_fence_ops. +* +* Note that the function does *not* free the crtc structure itself, this is the +* responsibility of the caller. */ void drm_crtc_cleanup (struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev; +/* Ensure our dma_fence_ops remain valid for an RCU grace period after +* the fence is signaled. This is necessary because our dma_fence_ops +* dereference crtc->dev. +*/ +synchronize_rcu (); +/* Note that the crtc_list is considered to be static; should we * remove the drm_crtc at runtime we would have to decrement all * the indices on the drm_crtc after us in the crtc_list.
Signature · 1 line
2.53.0