net/mlx4: Fix fall-through warnings for Clang
Subsystems (4)
PATCH RESEND 1/1 net/mlx4: Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case.
--- drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +1 -0
@@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,case RES_XRCD : err =xrcdn_free_res (dev, slave, vhcr->op_modifier, alop, vhcr->in_param, &vhcr->out_param); +break ;default :break ;
Signature · 1 line
2.27.0
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
Quoted 24 lines · Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case.
Reviewed-by Tariq Toukan <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +1
-0@@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,case RES_XRCD : err =xrcdn_free_res (dev, slave, vhcr->op_modifier, alop, vhcr->in_param, &vhcr->out_param); +break ;default :break ;
Quoted 3 lines · Gustavo A. R. Silva
Hi all,
Friendly ping: who can take this, please?
Why don't you fix Clang instead?
Why do we have this churn for something that correct?
Quoted 30 lines
Thanks
--
GustavoQuoted 24 lines · Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case.
Reviewed-by Tariq Toukan <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +1
-0@@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,case RES_XRCD : err =xrcdn_free_res (dev, slave, vhcr->op_modifier, alop, vhcr->in_param, &vhcr->out_param); +break ;default :break ;